Merge pull request #74 from github/event_prevent_deafult_apply

keithamus · web-flow · commit 432d70d9707c · 2023-09-22T17:19:36.000+01:00
Move preventDefault into apply functions
diff --git a/src/index.ts b/src/index.ts
@@ -62,7 +62,6 @@ function getButtons(toolbar: Element): HTMLElement[] {
 function keydown(fn: (event: KeyboardEvent) => void): (event: KeyboardEvent) => void {
   return function (event: KeyboardEvent) {
     if (event.key === ' ' || event.key === 'Enter') {
-      event.preventDefault()
       fn(event)
     }
   }
@@ -121,9 +120,10 @@ const manualStyles = {
 class MarkdownButtonElement extends HTMLElement {
   constructor() {
     super()
-    const apply = () => {
+    const apply = (event: Event) => {
       const style = styles.get(this)
       if (!style) return
+      event.preventDefault()
       applyStyle(this, style)
     }
     this.addEventListener('keydown', keydown(apply))
@@ -316,6 +316,7 @@ function applyFromToolbar(event: Event) {
   const mdButtonStyle = target.getAttribute('data-md-button')
   const style = manualStyles[mdButtonStyle as keyof typeof manualStyles]
   if (!style) return
+  event.preventDefault()
   applyStyle(target, style)
 }
 
