Merge pull request #141 from github/hash_splats

bensheldon · web-flow · commit 5affebaa56b8 · 2023-07-19T09:37:14.000-07:00
Improve check for hash literals
diff --git a/lib/rubocop/cop/github/render_literal_helpers.rb b/lib/rubocop/cop/github/render_literal_helpers.rb
@@ -41,7 +41,8 @@ module RenderLiteralHelpers
         PATTERN
 
         def hash_with_literal_keys?(hash)
-          hash.pairs.all? { |pair| literal?(pair.key) }
+          hash.children.all? { |child| child.pair_type? } &&
+            hash.pairs.all? { |pair| literal?(pair.key) }
         end
 
         def render_view_component?(node)
diff --git a/test/test_rails_controller_render_literal.rb b/test/test_rails_controller_render_literal.rb
@@ -442,6 +442,17 @@ def index
     assert_equal 1, offenses.count
   end
 
+  def test_render_literal_splat_locals_offense
+    offenses = investigate cop, <<-RUBY, "app/controllers/products_controller.rb"
+      class ProductsController < ActionController::Base
+        def index
+          render "products/product", locals: { **locals }
+        end
+      end
+    RUBY
+
+    assert_equal 1, offenses.count
+  end
 
   def test_render_literal_dynamic_local_key_offense
     offenses = investigate cop, <<-RUBY, "app/controllers/products_controller.rb"
diff --git a/test/test_rails_view_render_literal.rb b/test/test_rails_view_render_literal.rb
@@ -145,6 +145,14 @@ def test_render_literal_dynamic_local_key_offense
     assert_equal 1, offenses.count
   end
 
+  def test_render_literal_splat_locals_offense
+    offenses = erb_investigate cop, <<-ERB, "app/views/products/index.html.erb"
+      <%= render "products/product", { **locals } %>
+    ERB
+
+    assert_equal 1, offenses.count
+  end
+
   def test_render_options_static_locals_no_offense
     offenses = erb_investigate cop, <<-ERB, "app/views/products/index.html.erb"
       <%= render partial: "products/product", locals: { product: product } %>
@@ -168,4 +176,12 @@ def test_render_options_dynamic_local_key_offense
 
     assert_equal 1, offenses.count
   end
+
+  def test_render_options_local_splat_offense
+    offenses = erb_investigate cop, <<-ERB, "app/views/products/index.html.erb"
+      <%= render partial: "products/product", locals: { **locals } %>
+    ERB
+
+    assert_equal 1, offenses.count
+  end
 end
