Lint :render_to_string the same as :render

jhawthorn · jhawthorn · commit d19eda5f3e99 · 2020-11-16T16:22:48.000-08:00
diff --git a/lib/rubocop/cop/github/rails_controller_render_action_symbol.rb b/lib/rubocop/cop/github/rails_controller_render_action_symbol.rb
@@ -9,11 +9,11 @@ class RailsControllerRenderActionSymbol < Cop
         MSG = "Prefer `render` with string instead of symbol"
 
         def_node_matcher :render_sym?, <<-PATTERN
-          (send nil? :render $(sym _))
+          (send nil? {:render :render_to_string} $(sym _))
         PATTERN
 
         def_node_matcher :render_with_options?, <<-PATTERN
-          (send nil? :render (hash $...))
+          (send nil? {:render :render_to_string} (hash $...))
         PATTERN
 
         def_node_matcher :action_key?, <<-PATTERN
diff --git a/lib/rubocop/cop/github/rails_controller_render_literal.rb b/lib/rubocop/cop/github/rails_controller_render_literal.rb
@@ -13,23 +13,23 @@ class RailsControllerRenderLiteral < Cop
         PATTERN
 
         def_node_matcher :render?, <<-PATTERN
-          (send nil? :render ...)
+          (send nil? {:render :render_to_string} ...)
         PATTERN
 
         def_node_matcher :render_literal?, <<-PATTERN
-          (send nil? :render ({str sym} $_) $...)
+          (send nil? {:render :render_to_string} ({str sym} $_) $...)
         PATTERN
 
         def_node_matcher :render_const?, <<-PATTERN
-          (send nil? :render (const _ _) ...)
+          (send nil? {:render :render_to_string} (const _ _) ...)
         PATTERN
 
         def_node_matcher :render_inst?, <<-PATTERN
-          (send nil? :render (send _ :new ...) ...)
+          (send nil? {:render :render_to_string} (send _ :new ...) ...)
         PATTERN
 
         def_node_matcher :render_with_options?, <<-PATTERN
-          (send nil? :render (hash $...))
+          (send nil? {:render :render_to_string} (hash $...))
         PATTERN
 
         def_node_matcher :ignore_key?, <<-PATTERN
diff --git a/lib/rubocop/cop/github/rails_controller_render_paths_exist.rb b/lib/rubocop/cop/github/rails_controller_render_paths_exist.rb
@@ -7,15 +7,15 @@ module Cop
     module GitHub
       class RailsControllerRenderPathsExist < Cop
         def_node_matcher :render?, <<-PATTERN
-          (send nil? :render $...)
+          (send nil? {:render :render_to_string} $...)
         PATTERN
 
         def_node_matcher :render_str?, <<-PATTERN
-          (send nil? :render $({str sym} $_) ...)
+          (send nil? {:render :render_to_string} $({str sym} $_) ...)
         PATTERN
 
         def_node_matcher :render_options?, <<-PATTERN
-          (send nil? :render (hash $...))
+          (send nil? {:render :render_to_string} (hash $...))
         PATTERN
 
         def_node_matcher :render_key?, <<-PATTERN
diff --git a/lib/rubocop/cop/github/rails_controller_render_shorthand.rb b/lib/rubocop/cop/github/rails_controller_render_shorthand.rb
@@ -9,7 +9,7 @@ class RailsControllerRenderShorthand < Cop
         MSG = "Prefer `render` template shorthand"
 
         def_node_matcher :render_with_options?, <<-PATTERN
-          (send nil? :render (hash $...))
+          (send nil? {:render :render_to_string} (hash $...))
         PATTERN
 
         def_node_matcher :action_key?, <<-PATTERN
diff --git a/lib/rubocop/cop/github/rails_render_inline.rb b/lib/rubocop/cop/github/rails_render_inline.rb
@@ -9,7 +9,7 @@ class RailsRenderInline < Cop
         MSG = "Avoid `render inline:`"
 
         def_node_matcher :render_with_options?, <<-PATTERN
-          (send nil? :render (hash $...))
+          (send nil? {:render :render_to_string} (hash $...))
         PATTERN
 
         def_node_matcher :inline_key?, <<-PATTERN
diff --git a/lib/rubocop/cop/github/rails_render_object_collection.rb b/lib/rubocop/cop/github/rails_render_object_collection.rb
@@ -9,7 +9,7 @@ class RailsRenderObjectCollection < Cop
         MSG = "Avoid `render object:`"
 
         def_node_matcher :render_with_options?, <<-PATTERN
-          (send nil? :render (hash $...) ...)
+          (send nil? {:render :render_to_string} (hash $...) ...)
         PATTERN
 
         def_node_matcher :partial_key?, <<-PATTERN
diff --git a/lib/rubocop/cop/github/rails_view_render_literal.rb b/lib/rubocop/cop/github/rails_view_render_literal.rb
@@ -13,23 +13,23 @@ class RailsViewRenderLiteral < Cop
         PATTERN
 
         def_node_matcher :render?, <<-PATTERN
-          (send nil? :render $...)
+          (send nil? {:render :render_to_string} $...)
         PATTERN
 
         def_node_matcher :render_literal?, <<-PATTERN
-          (send nil? :render ({str sym} $_) $...)
+          (send nil? {:render :render_to_string} ({str sym} $_) $...)
         PATTERN
 
         def_node_matcher :render_inst?, <<-PATTERN
-          (send nil? :render (send _ :new ...) ...)
+          (send nil? {:render :render_to_string} (send _ :new ...) ...)
         PATTERN
 
         def_node_matcher :render_collection?, <<-PATTERN
-          (send nil? :render (send _ :with_collection ...) ...)
+          (send nil? {:render :render_to_string} (send _ :with_collection ...) ...)
         PATTERN
 
         def_node_matcher :render_with_options?, <<-PATTERN
-          (send nil? :render (hash $...) ...)
+          (send nil? {:render :render_to_string} (hash $...) ...)
         PATTERN
 
         def_node_matcher :ignore_key?, <<-PATTERN
diff --git a/lib/rubocop/cop/github/rails_view_render_paths_exist.rb b/lib/rubocop/cop/github/rails_view_render_paths_exist.rb
@@ -7,15 +7,15 @@ module Cop
     module GitHub
       class RailsViewRenderPathsExist < Cop
         def_node_matcher :render?, <<-PATTERN
-          (send nil? :render $...)
+          (send nil? {:render :render_to_string} $...)
         PATTERN
 
         def_node_matcher :render_str?, <<-PATTERN
-          (send nil? :render $(str $_) ...)
+          (send nil? {:render :render_to_string} $(str $_) ...)
         PATTERN
 
         def_node_matcher :render_options?, <<-PATTERN
-          (send nil? :render (hash $...))
+          (send nil? {:render :render_to_string} (hash $...))
         PATTERN
 
         def_node_matcher :partial_key?, <<-PATTERN
diff --git a/lib/rubocop/cop/github/rails_view_render_shorthand.rb b/lib/rubocop/cop/github/rails_view_render_shorthand.rb
@@ -9,7 +9,7 @@ class RailsViewRenderShorthand < Cop
         MSG = "Prefer `render` partial shorthand"
 
         def_node_matcher :render_with_options?, <<-PATTERN
-          (send nil? :render (hash $...))
+          (send nil? {:render :render_to_string} (hash $...))
         PATTERN
 
         def_node_matcher :partial_key?, <<-PATTERN
diff --git a/test/test_rails_controller_render_literal.rb b/test/test_rails_controller_render_literal.rb
@@ -316,6 +316,19 @@ def index
     assert_equal "render must be used with a string literal or an instance of a Class", cop.offenses[0].message
   end
 
+  def test_render_to_string_variable_offense
+    investigate cop, <<-RUBY, "app/controllers/products_controller.rb"
+      class ProductsController < ActionController::Base
+        def index
+          render_to_string(magic_string)
+        end
+      end
+    RUBY
+
+    assert_equal 1, cop.offenses.count
+    assert_equal "render must be used with a string literal or an instance of a Class", cop.offenses[0].message
+  end
+
   def test_render_action_variable_offense
     investigate cop, <<-RUBY, "app/controllers/products_controller.rb"
       class ProductsController < ActionController::Base
