Skip to content

Commit e4db9ad

Browse files
spraintsspraints
committed
Use predominant style
1 parent 8de2f84 commit e4db9ad

File tree

2 files changed

+23
-18
lines changed

2 files changed

+23
-18
lines changed

‎lib/rubocop/cop/github/insecure_hash_algorithm.rb

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,15 @@ module RuboCop
66
module Cop
77
module GitHub
88
class InsecureHashAlgorithm < Cop
9-
MESSAGE = "This hash algorithm is old and insecure and should not be used. Please use SHA256 instead."
9+
MSG = "This hash algorithm is old and insecure, use SHA-256 instead"
1010

11-
def_node_matcher :insecure_const?, "(const (const _ :Digest) #insecure_algorithm?)"
12-
def_node_matcher :insecure_call?, "(send (const _ {:Digest :HMAC}) _ (str #insecure_algorithm?) ...)"
11+
def_node_matcher :insecure_const?, <<-PATTERN
12+
(const (const _ :Digest) #insecure_algorithm?)
13+
PATTERN
14+
15+
def_node_matcher :insecure_call?, <<-PATTERN
16+
(send (const _ {:Digest :HMAC}) _ (str #insecure_algorithm?) ...)
17+
PATTERN
1318

1419
def insecure_algorithm?(val)
1520
case val.to_s.downcase
@@ -22,13 +27,13 @@ def insecure_algorithm?(val)
2227

2328
def on_const(const_node)
2429
if insecure_const?(const_node)
25-
add_offense(const_node, message: MESSAGE)
30+
add_offense(const_node, message: MSG)
2631
end
2732
end
2833

2934
def on_send(send_node)
3035
if insecure_call?(send_node)
31-
add_offense(send_node, message: MESSAGE)
36+
add_offense(send_node, message: MSG)
3237
end
3338
end
3439
end

‎test/test_insecure_hash_algorithm.rb

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ class Something
1717
RUBY
1818

1919
assert_equal 1, cop.offenses.count
20-
assert_equal cop_class::MESSAGE, cop.offenses.first.message
20+
assert_equal cop_class::MSG, cop.offenses.first.message
2121
end
2222

2323
def test_alias_for_openssl_digest_md5
@@ -28,7 +28,7 @@ class Something
2828
RUBY
2929

3030
assert_equal 1, cop.offenses.count
31-
assert_equal cop_class::MESSAGE, cop.offenses.first.message
31+
assert_equal cop_class::MSG, cop.offenses.first.message
3232
end
3333

3434
def test_alias_for_digest_sha1
@@ -39,7 +39,7 @@ class Something
3939
RUBY
4040

4141
assert_equal 1, cop.offenses.count
42-
assert_equal cop_class::MESSAGE, cop.offenses.first.message
42+
assert_equal cop_class::MSG, cop.offenses.first.message
4343
end
4444

4545
def test_alias_for_openssl_digest_sha1
@@ -50,7 +50,7 @@ class Something
5050
RUBY
5151

5252
assert_equal 1, cop.offenses.count
53-
assert_equal cop_class::MESSAGE, cop.offenses.first.message
53+
assert_equal cop_class::MSG, cop.offenses.first.message
5454
end
5555

5656
def test_alias_for_digest_sha256
@@ -95,7 +95,7 @@ def something(str)
9595
RUBY
9696

9797
assert_equal 1, cop.offenses.count
98-
assert_equal cop_class::MESSAGE, cop.offenses.first.message
98+
assert_equal cop_class::MSG, cop.offenses.first.message
9999
end
100100

101101
def test_openssl_md5_hexdigest
@@ -108,7 +108,7 @@ def something(str)
108108
RUBY
109109

110110
assert_equal 1, cop.offenses.count
111-
assert_equal cop_class::MESSAGE, cop.offenses.first.message
111+
assert_equal cop_class::MSG, cop.offenses.first.message
112112
end
113113

114114
def test_openssl_md5_digest_by_name
@@ -121,7 +121,7 @@ def something(str)
121121
RUBY
122122

123123
assert_equal 1, cop.offenses.count
124-
assert_equal cop_class::MESSAGE, cop.offenses.first.message
124+
assert_equal cop_class::MSG, cop.offenses.first.message
125125
end
126126

127127
def test_openssl_sha1_digest_by_name
@@ -134,7 +134,7 @@ def something(str)
134134
RUBY
135135

136136
assert_equal 1, cop.offenses.count
137-
assert_equal cop_class::MESSAGE, cop.offenses.first.message
137+
assert_equal cop_class::MSG, cop.offenses.first.message
138138
end
139139

140140
def test_openssl_sha1_hexdigest_by_name_mixed_case
@@ -147,7 +147,7 @@ def something(str)
147147
RUBY
148148

149149
assert_equal 1, cop.offenses.count
150-
assert_equal cop_class::MESSAGE, cop.offenses.first.message
150+
assert_equal cop_class::MSG, cop.offenses.first.message
151151
end
152152

153153
def test_openssl_sha256_digest_by_name
@@ -172,7 +172,7 @@ def something(str)
172172
RUBY
173173

174174
assert_equal 1, cop.offenses.count
175-
assert_equal cop_class::MESSAGE, cop.offenses.first.message
175+
assert_equal cop_class::MSG, cop.offenses.first.message
176176
end
177177

178178
def test_openssl_sha1_hmac_by_name
@@ -185,7 +185,7 @@ def something(str)
185185
RUBY
186186

187187
assert_equal 1, cop.offenses.count
188-
assert_equal cop_class::MESSAGE, cop.offenses.first.message
188+
assert_equal cop_class::MSG, cop.offenses.first.message
189189
end
190190

191191
def test_openssl_sha256_hmac_by_name
@@ -210,7 +210,7 @@ def something(str)
210210
RUBY
211211

212212
assert_equal 1, cop.offenses.count
213-
assert_equal cop_class::MESSAGE, cop.offenses.first.message
213+
assert_equal cop_class::MSG, cop.offenses.first.message
214214
end
215215

216216
def test_openssl_sha1_digest_instance_by_name
@@ -223,7 +223,7 @@ def something(str)
223223
RUBY
224224

225225
assert_equal 1, cop.offenses.count
226-
assert_equal cop_class::MESSAGE, cop.offenses.first.message
226+
assert_equal cop_class::MSG, cop.offenses.first.message
227227
end
228228

229229
def test_openssl_sha256_digest_instance_by_name

0 commit comments

Comments
 (0)
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy