From 5daf4bc263937015547c2a5dfc1edd8082594ff3 Mon Sep 17 00:00:00 2001
From: Orhan Toy <orhantoy@github.com>
Date: Tue, 28 Jun 2022 12:50:45 +0200
Subject: [PATCH 01/47] Fix .rubocop.yml example

---
 README.md | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/README.md b/README.md
index 328ed2ba..5d664e17 100644
--- a/README.md
+++ b/README.md
@@ -17,8 +17,8 @@ gem "rubocop-rails", require: false
 ``` yaml
 inherit_gem:
   rubocop-github:
-    - config/default_edge.yml
-    - config/rails_edge.yml
+    - config/default.yml
+    - config/rails.yml
 ```
 
 ### Legacy usage

From 36c807b3c497263393895b0494c455237f633c43 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Adri=C3=A1n=20Bolonio?= <bolonio@github.com>
Date: Thu, 28 Jul 2022 13:28:19 +0000
Subject: [PATCH 02/47] Add new a11y rubocop rule: ImageHasAlt

---
 lib/rubocop/cop/github/rails_image_has_alt.rb | 26 +++++++++++++++++
 test/test_rails_image_has_alt.rb              | 28 +++++++++++++++++++
 2 files changed, 54 insertions(+)
 create mode 100644 lib/rubocop/cop/github/rails_image_has_alt.rb
 create mode 100644 test/test_rails_image_has_alt.rb

diff --git a/lib/rubocop/cop/github/rails_image_has_alt.rb b/lib/rubocop/cop/github/rails_image_has_alt.rb
new file mode 100644
index 00000000..698d9224
--- /dev/null
+++ b/lib/rubocop/cop/github/rails_image_has_alt.rb
@@ -0,0 +1,26 @@
+# frozen_string_literal: true
+
+require "rubocop"
+
+module RuboCop
+  module Cop
+    module GitHub
+      module Accessibility
+        class ImageHasAlt < Base
+          MSG = "Images should have an alt prop with meaningful text or an empty string for decorative images"
+
+          def_node_search :has_alt_attribute?, "(sym :alt)"
+
+          def on_send(node)
+            receiver, method_name, _= *node
+
+            if receiver.nil? && method_name == :image_tag
+              alt = has_alt_attribute?(node)
+              add_offense(node.loc.selector) if alt.nil?
+            end
+          end
+        end
+      end
+    end
+  end
+end
diff --git a/test/test_rails_image_has_alt.rb b/test/test_rails_image_has_alt.rb
new file mode 100644
index 00000000..e241c9eb
--- /dev/null
+++ b/test/test_rails_image_has_alt.rb
@@ -0,0 +1,28 @@
+# frozen_string_literal: true
+
+require_relative "./cop_test"
+require "minitest/autorun"
+require "rubocop/cop/github/rails_image_has_alt"
+
+class TestImageHasAlt < CopTest
+  def cop_class
+    RuboCop::Cop::GitHub::Accessibility::ImageHasAlt
+  end
+
+  def test_image_has_alt_offense
+    offenses = erb_investigate cop, <<-ERB, "app/views/products/index.html.erb"
+      <%= image_tag "spinners/octocat-spinner-16px.gif", size: "12x12" %>
+    ERB
+
+    assert_equal 1, offenses.count
+    assert_equal "Images should have an alt prop with meaningful text or an empty string for decorative images", offenses[0].message
+  end
+
+  def test_image_has_alt_no_offense
+    offenses = erb_investigate cop, <<-ERB, "app/views/products/index.html.erb"
+      <%= image_tag "spinners/octocat-spinner-16px.gif", size: "12x12", alt: "GitHub Logo spinner" %>
+    ERB
+
+    assert_equal 0, offenses.count
+  end
+end

From 19eb191a0ab31f82d41c9dd418d2caad3745bdcf Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Adri=C3=A1n=20Bolonio?= <bolonio@github.com>
Date: Thu, 28 Jul 2022 13:45:50 +0000
Subject: [PATCH 03/47] Add new a11y rubocop rule: NoRedundantImageAlt

---
 .../github/rails_no_redundant_image_alt.rb    | 38 +++++++++++++++++++
 test/test_rails_no_redundant_image_alt.rb     | 28 ++++++++++++++
 2 files changed, 66 insertions(+)
 create mode 100644 lib/rubocop/cop/github/rails_no_redundant_image_alt.rb
 create mode 100644 test/test_rails_no_redundant_image_alt.rb

diff --git a/lib/rubocop/cop/github/rails_no_redundant_image_alt.rb b/lib/rubocop/cop/github/rails_no_redundant_image_alt.rb
new file mode 100644
index 00000000..0f84a872
--- /dev/null
+++ b/lib/rubocop/cop/github/rails_no_redundant_image_alt.rb
@@ -0,0 +1,38 @@
+# frozen_string_literal: true
+
+require "rubocop"
+
+module RuboCop
+  module Cop
+    module GitHub
+      module Accessibility
+        class NoRedundantImageAlt < Base
+          MSG = "Alt prop should not contain `image` or `picture` as screen readers already announce the element as an image"
+          REDUNDANT_ALT_WORDS = %w(image picture)
+
+          def_node_search :redundant_alt?, "(pair (sym :alt) (str #contains_redundant_alt_text?))"
+
+          def on_send(node)
+            receiver, method_name, _= *node
+
+            if receiver.nil? && method_name == :image_tag
+              if redundant_alt?(node)
+                add_offense(node.loc.selector)
+              end
+            end
+          end
+
+          private
+
+          def contains_redundant_alt_text?(string)
+            return false if string.empty?
+
+            if (string.downcase.split & REDUNDANT_ALT_WORDS).any?
+              return true
+            end
+          end
+        end
+      end
+    end
+  end
+end
diff --git a/test/test_rails_no_redundant_image_alt.rb b/test/test_rails_no_redundant_image_alt.rb
new file mode 100644
index 00000000..43101bb6
--- /dev/null
+++ b/test/test_rails_no_redundant_image_alt.rb
@@ -0,0 +1,28 @@
+# frozen_string_literal: true
+
+require_relative "./cop_test"
+require "minitest/autorun"
+require "rubocop/cop/github/rails_no_redundant_image_alt"
+
+class NoRedundantImageAlt < CopTest
+  def cop_class
+    RuboCop::Cop::GitHub::Accessibility::NoRedundantImageAlt
+  end
+
+  def test_no_redundant_image_alt_offense
+    offenses = erb_investigate cop, <<-ERB, "app/views/products/index.html.erb"
+      <%= image_tag "cat.gif", size: "12x12", alt: "Picture of a cat" %>
+    ERB
+
+    assert_equal 1, offenses.count
+    assert_equal "Alt prop should not contain `image` or `picture` as screen readers already announce the element as an image", offenses[0].message
+  end
+
+  def test_no_redundant_image_alt_no_offense
+    offenses = erb_investigate cop, <<-ERB, "app/views/products/index.html.erb"
+       <%= image_tag "cat.gif", size: "12x12", alt: "A black cat" %>
+    ERB
+
+    assert_equal 0, offenses.count
+  end
+end

From ca3930a258b4225a745495d51852db8508eeb2e8 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Adri=C3=A1n=20Bolonio?= <bolonio@github.com>
Date: Thu, 28 Jul 2022 14:20:58 +0000
Subject: [PATCH 04/47] Add new a11y rubocop rule: NoPositiveTabindex

---
 .../cop/github/rails_no_positive_tabindex.rb  | 32 +++++++++++++++++++
 test/test_rails_no_positive_tabindex.rb       | 28 ++++++++++++++++
 2 files changed, 60 insertions(+)
 create mode 100644 lib/rubocop/cop/github/rails_no_positive_tabindex.rb
 create mode 100644 test/test_rails_no_positive_tabindex.rb

diff --git a/lib/rubocop/cop/github/rails_no_positive_tabindex.rb b/lib/rubocop/cop/github/rails_no_positive_tabindex.rb
new file mode 100644
index 00000000..2a63fbe1
--- /dev/null
+++ b/lib/rubocop/cop/github/rails_no_positive_tabindex.rb
@@ -0,0 +1,32 @@
+# frozen_string_literal: true
+
+require "rubocop"
+
+module RuboCop
+  module Cop
+    module GitHub
+      module Accessibility
+        class NoPositiveTabindex < Base
+          MSG = "Positive tabindex is error-prone and often inaccessible."
+
+          def on_send(node)
+            receiver, method_name, *args = *node
+            if receiver.nil?
+              args.select do |arg|
+                arg.type == :hash
+              end.each do |hash|
+                hash.each_pair do |key, value|
+                  next if key.type == :dsym
+                  next unless key.respond_to?(:value)
+                  if key.value == :tabindex && value.source.to_i > 0
+                    add_offense(hash)
+                  end
+                end
+              end
+            end
+          end
+        end
+      end
+    end
+  end
+end
diff --git a/test/test_rails_no_positive_tabindex.rb b/test/test_rails_no_positive_tabindex.rb
new file mode 100644
index 00000000..db174acf
--- /dev/null
+++ b/test/test_rails_no_positive_tabindex.rb
@@ -0,0 +1,28 @@
+# frozen_string_literal: true
+
+require_relative "./cop_test"
+require "minitest/autorun"
+require "rubocop/cop/github/rails_no_positive_tabindex"
+
+class NoPositiveTabindex < CopTest
+  def cop_class
+    RuboCop::Cop::GitHub::Accessibility::NoPositiveTabindex
+  end
+
+  def test_no_positive_tabindex_alt_offense
+    offenses = erb_investigate cop, <<-ERB, "app/views/products/index.html.erb"
+      <%= button_tag "Continue", :tabindex => 3 %>
+    ERB
+
+    assert_equal 1, offenses.count
+    assert_equal "Positive tabindex is error-prone and often inaccessible.", offenses[0].message
+  end
+
+  def test_no_positive_tabindex_alt_no_offense
+    offenses = erb_investigate cop, <<-ERB, "app/views/products/index.html.erb"
+       <%= button_tag "Continue", :tabindex => -1 %>
+    ERB
+
+    assert_equal 0, offenses.count
+  end
+end

From fb79321412edd95913cf2a55be900c0978c0b98a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Adri=C3=A1n=20Bolonio?= <bolonio@github.com>
Date: Thu, 28 Jul 2022 14:54:39 +0000
Subject: [PATCH 05/47] Add new a11y rubocop rule: LinkHref

---
 lib/rubocop/cop/github/rails_link_href.rb | 25 ++++++++++++++++++++
 test/test_rails_link_href.rb              | 28 +++++++++++++++++++++++
 2 files changed, 53 insertions(+)
 create mode 100644 lib/rubocop/cop/github/rails_link_href.rb
 create mode 100644 test/test_rails_link_href.rb

diff --git a/lib/rubocop/cop/github/rails_link_href.rb b/lib/rubocop/cop/github/rails_link_href.rb
new file mode 100644
index 00000000..f2165f7b
--- /dev/null
+++ b/lib/rubocop/cop/github/rails_link_href.rb
@@ -0,0 +1,25 @@
+# frozen_string_literal: true
+
+require "rubocop"
+
+module RuboCop
+  module Cop
+    module GitHub
+      module Accessibility
+        class LinkHref < Base
+          MSG = "Links should go somewhere, you probably want to use a `<button>` instead.".freeze
+
+          def on_send(node)
+            receiver, method_name, *args = *node
+
+            if receiver.nil? && method_name == :link_to
+              if args.first.type == :str && args.first.children.first == "#"
+                add_offense(node.loc.selector)
+              end
+            end
+          end
+        end
+      end
+    end
+  end
+end
diff --git a/test/test_rails_link_href.rb b/test/test_rails_link_href.rb
new file mode 100644
index 00000000..cc961c8f
--- /dev/null
+++ b/test/test_rails_link_href.rb
@@ -0,0 +1,28 @@
+# frozen_string_literal: true
+
+require_relative "./cop_test"
+require "minitest/autorun"
+require "rubocop/cop/github/rails_link_href"
+
+class LinkHref < CopTest
+  def cop_class
+    RuboCop::Cop::GitHub::Accessibility::LinkHref
+  end
+
+  def test_link_href_offense
+    offenses = erb_investigate cop, <<-ERB, "app/views/products/index.html.erb"
+      <%= link_to 'Go to GitHub' %>
+    ERB
+
+    assert_equal 1, offenses.count
+    assert_equal "Links should go somewhere, you probably want to use a `<button>` instead.", offenses[0].message
+  end
+
+  def test_link_href_no_offense
+    offenses = erb_investigate cop, <<-ERB, "app/views/products/index.html.erb"
+      <%= link_to 'Go to GitHub', 'https://github.com/' %>
+    ERB
+    
+    assert_equal 0, offenses.count
+  end
+end

From 7aa3f0cae446c2fb930b4077eba129b3d6693a84 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Adri=C3=A1n=20Bolonio?= <bolonio@github.com>
Date: Fri, 29 Jul 2022 09:45:09 +0000
Subject: [PATCH 06/47] Renamed and move rubocop rule

---
 .../{rails_image_has_alt.rb => accessibility/image_has_alt.rb}  | 0
 test/{test_rails_image_has_alt.rb => test_image_has_alt.rb}     | 2 +-
 2 files changed, 1 insertion(+), 1 deletion(-)
 rename lib/rubocop/cop/github/{rails_image_has_alt.rb => accessibility/image_has_alt.rb} (100%)
 rename test/{test_rails_image_has_alt.rb => test_image_has_alt.rb} (93%)

diff --git a/lib/rubocop/cop/github/rails_image_has_alt.rb b/lib/rubocop/cop/github/accessibility/image_has_alt.rb
similarity index 100%
rename from lib/rubocop/cop/github/rails_image_has_alt.rb
rename to lib/rubocop/cop/github/accessibility/image_has_alt.rb
diff --git a/test/test_rails_image_has_alt.rb b/test/test_image_has_alt.rb
similarity index 93%
rename from test/test_rails_image_has_alt.rb
rename to test/test_image_has_alt.rb
index e241c9eb..e4fb08a8 100644
--- a/test/test_rails_image_has_alt.rb
+++ b/test/test_image_has_alt.rb
@@ -2,7 +2,7 @@
 
 require_relative "./cop_test"
 require "minitest/autorun"
-require "rubocop/cop/github/rails_image_has_alt"
+require "rubocop/cop/github/accessibility/image_has_alt"
 
 class TestImageHasAlt < CopTest
   def cop_class

From 6825ecb78e8dbd049f919fcb0f2f5aaac0e5a88f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Adri=C3=A1n=20Bolonio?= <bolonio@github.com>
Date: Fri, 29 Jul 2022 09:45:53 +0000
Subject: [PATCH 07/47] Add documentation about rubocop rule. Add config file

---
 README.md                |  3 ++-
 config/accessibility.yml |  6 ++++++
 guides/image-has-alt.md  | 29 +++++++++++++++++++++++++++++
 3 files changed, 37 insertions(+), 1 deletion(-)
 create mode 100644 config/accessibility.yml
 create mode 100644 guides/image-has-alt.md

diff --git a/README.md b/README.md
index 5d664e17..b8af92a1 100644
--- a/README.md
+++ b/README.md
@@ -19,6 +19,7 @@ inherit_gem:
   rubocop-github:
     - config/default.yml
     - config/rails.yml
+    - config/accessibility.yml
 ```
 
 ### Legacy usage
@@ -33,4 +34,4 @@ If you are using a rubocop version < 1.0.0, you can use rubocop-github version
 
 ## The Cops
 
-All cops are located under [`lib/rubocop/cop/github`](lib/rubocop/cop/github), and contain examples/documentation.
+All cops are located under [`lib/rubocop/cop/github`](lib/rubocop/cop/github) and [`lib/rubocop/cop/github/accessibility`](lib/rubocop/cop/github/accessibility), and contain examples/documentation.
diff --git a/config/accessibility.yml b/config/accessibility.yml
new file mode 100644
index 00000000..00f871c6
--- /dev/null
+++ b/config/accessibility.yml
@@ -0,0 +1,6 @@
+require:
+  - rubocop/cop/github/accessibility
+
+GitHub/Accessibility/ImageHasAlt:
+  Enabled: true
+  StyleGuide: https://github.com/github/rubocop-github/blob/master/guides/image-has-alt.md
\ No newline at end of file
diff --git a/guides/image-has-alt.md b/guides/image-has-alt.md
new file mode 100644
index 00000000..a761dba6
--- /dev/null
+++ b/guides/image-has-alt.md
@@ -0,0 +1,29 @@
+# GitHub/Accessibility/ImageHasAlt
+
+## Rule Details
+
+Images should have an alt prop with meaningful text or an empty string for decorative images.
+
+## Resources
+
+- [W3C WAI Images Tutorial](https://www.w3.org/WAI/tutorials/images/)
+- [Primer: Alternative text for images](https://primer.style/design/accessibility/alternative-text-for-images)
+
+## Examples
+### **Incorrect** code for this rule 👎
+
+```erb
+<%= image_tag "spinners/octocat-spinner-16px.gif", size: "12x12" %>
+```
+
+### **Correct** code for this rule  👍
+
+```erb
+<!-- good -->
+<%= image_tag "spinners/octocat-spinner-16px.gif", size: "12x12", alt: "GitHub Logo spinner" %>
+```
+
+```erb
+<!-- also good -->
+<%= image_tag "spinners/octocat-spinner-16px.gif", size: "12x12", alt: "" %>
+```
\ No newline at end of file

From 14837ff4e1b5ad94dd4b460761ac7945ab4f0c4a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Adri=C3=A1n=20Bolonio?= <bolonio@github.com>
Date: Fri, 29 Jul 2022 15:10:14 +0000
Subject: [PATCH 08/47] Move test to accessibility folder

---
 test/{ => accessibility}/test_image_has_alt.rb | 0
 1 file changed, 0 insertions(+), 0 deletions(-)
 rename test/{ => accessibility}/test_image_has_alt.rb (100%)

diff --git a/test/test_image_has_alt.rb b/test/accessibility/test_image_has_alt.rb
similarity index 100%
rename from test/test_image_has_alt.rb
rename to test/accessibility/test_image_has_alt.rb

From fd729fafefdd120f9763f432b3410cd64e8d405a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Adri=C3=A1n=20Bolonio?= <bolonio@github.com>
Date: Mon, 1 Aug 2022 09:10:09 +0000
Subject: [PATCH 09/47] Add documentation, Move to accessibility folder, Add
 config

---
 config/accessibility.yml                      |  5 +++-
 guides/no-redundant-image-alt.md              | 24 +++++++++++++++++++
 .../no_redundant_image_alt.rb}                |  0
 .../test_no_redundant_image_alt.rb}           |  2 +-
 4 files changed, 29 insertions(+), 2 deletions(-)
 create mode 100644 guides/no-redundant-image-alt.md
 rename lib/rubocop/cop/github/{rails_no_redundant_image_alt.rb => accessibility/no_redundant_image_alt.rb} (100%)
 rename test/{test_rails_no_redundant_image_alt.rb => accessibility/test_no_redundant_image_alt.rb} (92%)

diff --git a/config/accessibility.yml b/config/accessibility.yml
index 00f871c6..0b140de7 100644
--- a/config/accessibility.yml
+++ b/config/accessibility.yml
@@ -3,4 +3,7 @@ require:
 
 GitHub/Accessibility/ImageHasAlt:
   Enabled: true
-  StyleGuide: https://github.com/github/rubocop-github/blob/master/guides/image-has-alt.md
\ No newline at end of file
+  StyleGuide: https://github.com/github/rubocop-github/blob/master/guides/image-has-alt.md
+GitHub/Accessibility/NoRedundantImageAlt:
+  Enabled: true
+  StyleGuide: https://github.com/github/rubocop-github/blob/master/guides/no-redundant-image-alt.md
\ No newline at end of file
diff --git a/guides/no-redundant-image-alt.md b/guides/no-redundant-image-alt.md
new file mode 100644
index 00000000..2e4fad7f
--- /dev/null
+++ b/guides/no-redundant-image-alt.md
@@ -0,0 +1,24 @@
+# GitHub/Accessibility/NoRedundantImageAlt
+
+## Rule Details
+
+Alt prop should not contain `image` or `picture` as screen readers already announce the element as an image
+
+## Resources
+
+- [W3C WAI Images Tutorial](https://www.w3.org/WAI/tutorials/images/)
+- [Primer: Alternative text for images](https://primer.style/design/accessibility/alternative-text-for-images)
+
+## Examples
+### **Incorrect** code for this rule 👎
+
+```erb
+<%= image_tag "cat.gif", size: "12x12", alt: "Picture of a cat" %>
+```
+
+### **Correct** code for this rule  👍
+
+```erb
+<!-- good -->
+<%= image_tag "cat.gif", size: "12x12", alt: "A black cat" %>
+```
diff --git a/lib/rubocop/cop/github/rails_no_redundant_image_alt.rb b/lib/rubocop/cop/github/accessibility/no_redundant_image_alt.rb
similarity index 100%
rename from lib/rubocop/cop/github/rails_no_redundant_image_alt.rb
rename to lib/rubocop/cop/github/accessibility/no_redundant_image_alt.rb
diff --git a/test/test_rails_no_redundant_image_alt.rb b/test/accessibility/test_no_redundant_image_alt.rb
similarity index 92%
rename from test/test_rails_no_redundant_image_alt.rb
rename to test/accessibility/test_no_redundant_image_alt.rb
index 43101bb6..c8e91641 100644
--- a/test/test_rails_no_redundant_image_alt.rb
+++ b/test/accessibility/test_no_redundant_image_alt.rb
@@ -2,7 +2,7 @@
 
 require_relative "./cop_test"
 require "minitest/autorun"
-require "rubocop/cop/github/rails_no_redundant_image_alt"
+require "rubocop/cop/github/accessibility/no_redundant_image_alt"
 
 class NoRedundantImageAlt < CopTest
   def cop_class

From 41721c30eeda4f8eeadee35ced822cd541dc28a8 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Adri=C3=A1n=20Bolonio?= <bolonio@github.com>
Date: Mon, 1 Aug 2022 09:18:22 +0000
Subject: [PATCH 10/47] Add documentation, Move to accessibility folder, Add
 config

---
 config/accessibility.yml                      |  5 ++-
 guides/no-positive-tabindex.md                | 24 ++++++++++++++
 .../accessibility/no_positive_tabindex.rb     | 32 +++++++++++++++++++
 .../test_no_positive_tabindex.rb              | 28 ++++++++++++++++
 4 files changed, 88 insertions(+), 1 deletion(-)
 create mode 100644 guides/no-positive-tabindex.md
 create mode 100644 lib/rubocop/cop/github/accessibility/no_positive_tabindex.rb
 create mode 100644 test/accessibility/test_no_positive_tabindex.rb

diff --git a/config/accessibility.yml b/config/accessibility.yml
index 00f871c6..69a1e5b1 100644
--- a/config/accessibility.yml
+++ b/config/accessibility.yml
@@ -3,4 +3,7 @@ require:
 
 GitHub/Accessibility/ImageHasAlt:
   Enabled: true
-  StyleGuide: https://github.com/github/rubocop-github/blob/master/guides/image-has-alt.md
\ No newline at end of file
+  StyleGuide: https://github.com/github/rubocop-github/blob/master/guides/image-has-alt.md
+GitHub/Accessibility/NoPositiveTabindex:
+  Enabled: true
+  StyleGuide: https://github.com/github/rubocop-github/blob/master/guides/no-positive-tabindex.md
\ No newline at end of file
diff --git a/guides/no-positive-tabindex.md b/guides/no-positive-tabindex.md
new file mode 100644
index 00000000..e51af7d8
--- /dev/null
+++ b/guides/no-positive-tabindex.md
@@ -0,0 +1,24 @@
+# GitHub/Accessibility/NoPositiveTabindex
+
+## Rule Details
+
+Positive tabindex is error-prone and often inaccessible.
+
+## Resources
+
+- [F44: Failure of Success Criterion 2.4.3 due to using tabindex to create a tab order that does not preserve meaning and operability](https://www.w3.org/TR/WCAG20-TECHS/F44.html)
+- [Deque University: Avoid Using Tabindex with Positive Numbers](https://dequeuniversity.com/tips/tabindex-positive-numbers)
+
+## Examples
+### **Incorrect** code for this rule 👎
+
+```erb
+<%= button_tag "Continue", :tabindex => 3 %>
+```
+
+### **Correct** code for this rule  👍
+
+```erb
+<!-- good -->
+<%= button_tag "Continue", :tabindex => -1 %>
+```
diff --git a/lib/rubocop/cop/github/accessibility/no_positive_tabindex.rb b/lib/rubocop/cop/github/accessibility/no_positive_tabindex.rb
new file mode 100644
index 00000000..2a63fbe1
--- /dev/null
+++ b/lib/rubocop/cop/github/accessibility/no_positive_tabindex.rb
@@ -0,0 +1,32 @@
+# frozen_string_literal: true
+
+require "rubocop"
+
+module RuboCop
+  module Cop
+    module GitHub
+      module Accessibility
+        class NoPositiveTabindex < Base
+          MSG = "Positive tabindex is error-prone and often inaccessible."
+
+          def on_send(node)
+            receiver, method_name, *args = *node
+            if receiver.nil?
+              args.select do |arg|
+                arg.type == :hash
+              end.each do |hash|
+                hash.each_pair do |key, value|
+                  next if key.type == :dsym
+                  next unless key.respond_to?(:value)
+                  if key.value == :tabindex && value.source.to_i > 0
+                    add_offense(hash)
+                  end
+                end
+              end
+            end
+          end
+        end
+      end
+    end
+  end
+end
diff --git a/test/accessibility/test_no_positive_tabindex.rb b/test/accessibility/test_no_positive_tabindex.rb
new file mode 100644
index 00000000..482c9c42
--- /dev/null
+++ b/test/accessibility/test_no_positive_tabindex.rb
@@ -0,0 +1,28 @@
+# frozen_string_literal: true
+
+require_relative "./cop_test"
+require "minitest/autorun"
+require "rubocop/cop/github/accessibility/no_positive_tabindex"
+
+class NoPositiveTabindex < CopTest
+  def cop_class
+    RuboCop::Cop::GitHub::Accessibility::NoPositiveTabindex
+  end
+
+  def test_no_positive_tabindex_alt_offense
+    offenses = erb_investigate cop, <<-ERB, "app/views/products/index.html.erb"
+      <%= button_tag "Continue", :tabindex => 3 %>
+    ERB
+
+    assert_equal 1, offenses.count
+    assert_equal "Positive tabindex is error-prone and often inaccessible.", offenses[0].message
+  end
+
+  def test_no_positive_tabindex_alt_no_offense
+    offenses = erb_investigate cop, <<-ERB, "app/views/products/index.html.erb"
+       <%= button_tag "Continue", :tabindex => -1 %>
+    ERB
+
+    assert_equal 0, offenses.count
+  end
+end

From b6645c249a3050ce450fdd95bd73d65bec0a7ced Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Adri=C3=A1n=20Bolonio?= <bolonio@github.com>
Date: Mon, 1 Aug 2022 09:35:22 +0000
Subject: [PATCH 11/47] Add documentation, Move to accessibility folder, Add
 config

---
 config/accessibility.yml                      |  5 +++-
 guides/link-has-href.md                       | 27 +++++++++++++++++++
 .../link_has_href.rb}                         |  4 +--
 ...ils_link_href.rb => test_link_has_href.rb} | 19 ++++++++-----
 4 files changed, 46 insertions(+), 9 deletions(-)
 create mode 100644 guides/link-has-href.md
 rename lib/rubocop/cop/github/{rails_link_href.rb => accessibility/link_has_href.rb} (77%)
 rename test/{test_rails_link_href.rb => test_link_has_href.rb} (54%)

diff --git a/config/accessibility.yml b/config/accessibility.yml
index 00f871c6..44839317 100644
--- a/config/accessibility.yml
+++ b/config/accessibility.yml
@@ -3,4 +3,7 @@ require:
 
 GitHub/Accessibility/ImageHasAlt:
   Enabled: true
-  StyleGuide: https://github.com/github/rubocop-github/blob/master/guides/image-has-alt.md
\ No newline at end of file
+  StyleGuide: https://github.com/github/rubocop-github/blob/master/guides/image-has-alt.md
+GitHub/Accessibility/LinkHasHref:
+  Enabled: true
+  StyleGuide: https://github.com/github/rubocop-github/blob/master/guides/link-has-href.md
\ No newline at end of file
diff --git a/guides/link-has-href.md b/guides/link-has-href.md
new file mode 100644
index 00000000..7a8d4efa
--- /dev/null
+++ b/guides/link-has-href.md
@@ -0,0 +1,27 @@
+# GitHub/Accessibility/LinkHasHref
+
+## Rule Details
+
+Links should go somewhere, you probably want to use a `<button>` instead.
+
+## Resources
+
+- TBD
+
+## Examples
+### **Incorrect** code for this rule 👎
+
+```erb
+<%= link_to 'Go to GitHub' %>
+```
+
+```erb
+<%= link_to 'Go to GitHub', '#' %>
+```
+
+### **Correct** code for this rule  👍
+
+```erb
+<!-- good -->
+<%= link_to 'Go to GitHub', 'https://github.com/' %>
+```
diff --git a/lib/rubocop/cop/github/rails_link_href.rb b/lib/rubocop/cop/github/accessibility/link_has_href.rb
similarity index 77%
rename from lib/rubocop/cop/github/rails_link_href.rb
rename to lib/rubocop/cop/github/accessibility/link_has_href.rb
index f2165f7b..751c564c 100644
--- a/lib/rubocop/cop/github/rails_link_href.rb
+++ b/lib/rubocop/cop/github/accessibility/link_has_href.rb
@@ -6,14 +6,14 @@ module RuboCop
   module Cop
     module GitHub
       module Accessibility
-        class LinkHref < Base
+        class LinkHasHref < Base
           MSG = "Links should go somewhere, you probably want to use a `<button>` instead.".freeze
 
           def on_send(node)
             receiver, method_name, *args = *node
 
             if receiver.nil? && method_name == :link_to
-              if args.first.type == :str && args.first.children.first == "#"
+              if args.length == 1 || (args.length > 1 && args[1].type == :str && args[1].children.first == "#")
                 add_offense(node.loc.selector)
               end
             end
diff --git a/test/test_rails_link_href.rb b/test/test_link_has_href.rb
similarity index 54%
rename from test/test_rails_link_href.rb
rename to test/test_link_has_href.rb
index cc961c8f..b68dc92e 100644
--- a/test/test_rails_link_href.rb
+++ b/test/test_link_has_href.rb
@@ -2,27 +2,34 @@
 
 require_relative "./cop_test"
 require "minitest/autorun"
-require "rubocop/cop/github/rails_link_href"
+require "rubocop/cop/github/accessibility/link_has_href"
 
-class LinkHref < CopTest
+class LinkHasHref < CopTest
   def cop_class
-    RuboCop::Cop::GitHub::Accessibility::LinkHref
+    RuboCop::Cop::GitHub::Accessibility::LinkHasHref
   end
 
-  def test_link_href_offense
+  def test_link_has_href_offense
     offenses = erb_investigate cop, <<-ERB, "app/views/products/index.html.erb"
       <%= link_to 'Go to GitHub' %>
     ERB
 
     assert_equal 1, offenses.count
     assert_equal "Links should go somewhere, you probably want to use a `<button>` instead.", offenses[0].message
+
+    offenses = erb_investigate cop, <<-ERB, "app/views/products/index.html.erb"
+      <%= link_to 'Go to GitHub', '#' %>
+    ERB
+
+    assert_equal 1, offenses.count
+    assert_equal "Links should go somewhere, you probably want to use a `<button>` instead.", offenses[0].message
   end
 
-  def test_link_href_no_offense
+  def test_link_has_href_no_offense
     offenses = erb_investigate cop, <<-ERB, "app/views/products/index.html.erb"
       <%= link_to 'Go to GitHub', 'https://github.com/' %>
     ERB
-    
+
     assert_equal 0, offenses.count
   end
 end

From 4054a2f273d4596b9ce84c32eb384f776230379b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Adri=C3=A1n=20Bolonio?= <bolonio@github.com>
Date: Mon, 1 Aug 2022 09:38:07 +0000
Subject: [PATCH 12/47] Move tests

---
 .../no_positive_tabindex.rb                   |  0
 .../cop/github/rails_no_positive_tabindex.rb  | 32 -------------------
 .../test_no_positive_tabindex.rb              |  0
 test/test_rails_no_positive_tabindex.rb       | 28 ----------------
 4 files changed, 60 deletions(-)
 rename lib/rubocop/cop/github/{accessibility => }/no_positive_tabindex.rb (100%)
 delete mode 100644 lib/rubocop/cop/github/rails_no_positive_tabindex.rb
 rename test/{accessibility => }/test_no_positive_tabindex.rb (100%)
 delete mode 100644 test/test_rails_no_positive_tabindex.rb

diff --git a/lib/rubocop/cop/github/accessibility/no_positive_tabindex.rb b/lib/rubocop/cop/github/no_positive_tabindex.rb
similarity index 100%
rename from lib/rubocop/cop/github/accessibility/no_positive_tabindex.rb
rename to lib/rubocop/cop/github/no_positive_tabindex.rb
diff --git a/lib/rubocop/cop/github/rails_no_positive_tabindex.rb b/lib/rubocop/cop/github/rails_no_positive_tabindex.rb
deleted file mode 100644
index 2a63fbe1..00000000
--- a/lib/rubocop/cop/github/rails_no_positive_tabindex.rb
+++ /dev/null
@@ -1,32 +0,0 @@
-# frozen_string_literal: true
-
-require "rubocop"
-
-module RuboCop
-  module Cop
-    module GitHub
-      module Accessibility
-        class NoPositiveTabindex < Base
-          MSG = "Positive tabindex is error-prone and often inaccessible."
-
-          def on_send(node)
-            receiver, method_name, *args = *node
-            if receiver.nil?
-              args.select do |arg|
-                arg.type == :hash
-              end.each do |hash|
-                hash.each_pair do |key, value|
-                  next if key.type == :dsym
-                  next unless key.respond_to?(:value)
-                  if key.value == :tabindex && value.source.to_i > 0
-                    add_offense(hash)
-                  end
-                end
-              end
-            end
-          end
-        end
-      end
-    end
-  end
-end
diff --git a/test/accessibility/test_no_positive_tabindex.rb b/test/test_no_positive_tabindex.rb
similarity index 100%
rename from test/accessibility/test_no_positive_tabindex.rb
rename to test/test_no_positive_tabindex.rb
diff --git a/test/test_rails_no_positive_tabindex.rb b/test/test_rails_no_positive_tabindex.rb
deleted file mode 100644
index db174acf..00000000
--- a/test/test_rails_no_positive_tabindex.rb
+++ /dev/null
@@ -1,28 +0,0 @@
-# frozen_string_literal: true
-
-require_relative "./cop_test"
-require "minitest/autorun"
-require "rubocop/cop/github/rails_no_positive_tabindex"
-
-class NoPositiveTabindex < CopTest
-  def cop_class
-    RuboCop::Cop::GitHub::Accessibility::NoPositiveTabindex
-  end
-
-  def test_no_positive_tabindex_alt_offense
-    offenses = erb_investigate cop, <<-ERB, "app/views/products/index.html.erb"
-      <%= button_tag "Continue", :tabindex => 3 %>
-    ERB
-
-    assert_equal 1, offenses.count
-    assert_equal "Positive tabindex is error-prone and often inaccessible.", offenses[0].message
-  end
-
-  def test_no_positive_tabindex_alt_no_offense
-    offenses = erb_investigate cop, <<-ERB, "app/views/products/index.html.erb"
-       <%= button_tag "Continue", :tabindex => -1 %>
-    ERB
-
-    assert_equal 0, offenses.count
-  end
-end

From db3bad5487c79821ae4a5b6ea83f1cb5be6c2d19 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Adri=C3=A1n=20Bolonio?= <bolonio@github.com>
Date: Mon, 1 Aug 2022 09:38:51 +0000
Subject: [PATCH 13/47] Move rule

---
 .../cop/github/{ => accessibility}/no_positive_tabindex.rb        | 0
 1 file changed, 0 insertions(+), 0 deletions(-)
 rename lib/rubocop/cop/github/{ => accessibility}/no_positive_tabindex.rb (100%)

diff --git a/lib/rubocop/cop/github/no_positive_tabindex.rb b/lib/rubocop/cop/github/accessibility/no_positive_tabindex.rb
similarity index 100%
rename from lib/rubocop/cop/github/no_positive_tabindex.rb
rename to lib/rubocop/cop/github/accessibility/no_positive_tabindex.rb

From 039822b9bc527c686a70c67380322dbd9b2ee50d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Adri=C3=A1n=20Bolonio?= <bolonio@github.com>
Date: Mon, 1 Aug 2022 09:39:43 +0000
Subject: [PATCH 14/47] Move tests

---
 test/{accessibility => }/test_image_has_alt.rb          | 0
 test/{accessibility => }/test_no_redundant_image_alt.rb | 0
 2 files changed, 0 insertions(+), 0 deletions(-)
 rename test/{accessibility => }/test_image_has_alt.rb (100%)
 rename test/{accessibility => }/test_no_redundant_image_alt.rb (100%)

diff --git a/test/accessibility/test_image_has_alt.rb b/test/test_image_has_alt.rb
similarity index 100%
rename from test/accessibility/test_image_has_alt.rb
rename to test/test_image_has_alt.rb
diff --git a/test/accessibility/test_no_redundant_image_alt.rb b/test/test_no_redundant_image_alt.rb
similarity index 100%
rename from test/accessibility/test_no_redundant_image_alt.rb
rename to test/test_no_redundant_image_alt.rb

From 295968ef0fa211f8deb7269b347b2e64714703e3 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Adri=C3=A1n=20Bolonio?= <bolonio@github.com>
Date: Mon, 1 Aug 2022 12:10:02 +0000
Subject: [PATCH 15/47] Update docs

---
 guides/link-has-href.md | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/guides/link-has-href.md b/guides/link-has-href.md
index 7a8d4efa..8a574c94 100644
--- a/guides/link-has-href.md
+++ b/guides/link-has-href.md
@@ -6,7 +6,9 @@ Links should go somewhere, you probably want to use a `<button>` instead.
 
 ## Resources
 
-- TBD
+- [`<a>`: The Anchor element](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/a)
+- [Primer: Links](https://primer.style/design/accessibility/links)
+- [HTML Spec: The a element](https://html.spec.whatwg.org/multipage/text-level-semantics.html#the-a-element)
 
 ## Examples
 ### **Incorrect** code for this rule 👎

From 9e4d47875612ce2b8b92cc038f099e20c082e00a Mon Sep 17 00:00:00 2001
From: Elena Tanasoiu <elenatanasoiu@github.com>
Date: Sun, 28 Aug 2022 18:39:05 +0100
Subject: [PATCH 16/47] Display testing commands on separate lines

At the moment they're displayed on a single line.
---
 README.md | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/README.md b/README.md
index b8af92a1..ab466b18 100644
--- a/README.md
+++ b/README.md
@@ -29,8 +29,10 @@ If you are using a rubocop version < 1.0.0, you can use rubocop-github version
 
 ## Testing
 
-`bundle install`
-`bundle exec rake test`
+``` bash
+bundle install
+bundle exec rake test
+```
 
 ## The Cops
 

From 5622c35630e2f354101bee707424d316fd198abb Mon Sep 17 00:00:00 2001
From: Elena Tanasoiu <elenatanasoiu@github.com>
Date: Sun, 28 Aug 2022 19:02:44 +0100
Subject: [PATCH 17/47] Add table of contents

---
 STYLEGUIDE.md | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/STYLEGUIDE.md b/STYLEGUIDE.md
index 829f4b2c..cfaf3c6b 100644
--- a/STYLEGUIDE.md
+++ b/STYLEGUIDE.md
@@ -1,5 +1,23 @@
 # Ruby Style Guide
 
+## Table of Contents
+1. [Coding Style](#coding-style)
+2. [Classes](#classes)
+3. [Collections](#collections)
+4. [Documentation](#documentation)
+5. [Dynamic Dispatch](#dynamic-dispatch)
+6. [Exceptions](#exceptions)
+7. [Hashes](#hashes)
+8. [Keyword Arguments](#keyword-arguments)
+9. [Naming](#naming)
+10. [Percent Literals](#percent-literals)
+11. [Regular Expressions](#regular-expressions)
+12. [Requires](#requires)
+13. [Strings](#strings)
+14. [Syntax](#syntax)
+
+## Coding Style
+
 * Use soft-tabs with a two space indent.
 
 * Keep each line of code to a readable length. Unless you have a reason to, keep lines to a maximum of 118 characters. Why 118? That's the width at which the pull request diff UI needs horizontal scrolling (making pull requests harder to review).

From 50f9b94a25edad0dc6de9d3265de38451f7d724f Mon Sep 17 00:00:00 2001
From: Elena Tanasoiu <elenatanasoiu@github.com>
Date: Sun, 28 Aug 2022 19:03:23 +0100
Subject: [PATCH 18/47] Point to Rubocop guide

The old styleguide page [1] points to the Rubocop styleguide as a source
of inspiration. Let's add it here as well.

[1]: https://web.archive.org/web/20160410033955/https://github.com/styleguide/ruby
---
 STYLEGUIDE.md | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/STYLEGUIDE.md b/STYLEGUIDE.md
index cfaf3c6b..1893ca69 100644
--- a/STYLEGUIDE.md
+++ b/STYLEGUIDE.md
@@ -1,5 +1,7 @@
 # Ruby Style Guide
 
+This is GitHub's Ruby Style Guide, inspired by [RuboCop's guide][rubocop-guide].
+
 ## Table of Contents
 1. [Coding Style](#coding-style)
 2. [Classes](#classes)
@@ -795,3 +797,5 @@ result = hash.map { |_, v| v + 1 }
   Instead, use `is_a?` or `kind_of?` if you must.
 
   Refactoring is even better. It's worth looking hard at any code that explicitly checks types.
+
+[rubocop-guide]: https://github.com/rubocop-hq/ruby-style-guide
\ No newline at end of file

From 2bda235972a35ee44c4484559a49503df44c4a70 Mon Sep 17 00:00:00 2001
From: Elena Tanasoiu <elenatanasoiu@github.com>
Date: Sun, 28 Aug 2022 19:19:02 +0100
Subject: [PATCH 19/47] Re-organise "Coding Style" section

This doesn't add or remove any rules, it just groups them together under:

Layout
 - Indentation
 - Inline
 - Newlines
Maximum Line Length

Inspired by the RuboCop [1] and AirBnb [2] styleguides.

[1]: https://github.com/rubocop/ruby-style-guide/blob/master/README.adoc
[2]: https://github.com/airbnb/ruby/blob/master/README.md
---
 STYLEGUIDE.md | 102 ++++++++++++++++++++++++++++----------------------
 1 file changed, 57 insertions(+), 45 deletions(-)

diff --git a/STYLEGUIDE.md b/STYLEGUIDE.md
index 1893ca69..d7237672 100644
--- a/STYLEGUIDE.md
+++ b/STYLEGUIDE.md
@@ -3,54 +3,31 @@
 This is GitHub's Ruby Style Guide, inspired by [RuboCop's guide][rubocop-guide].
 
 ## Table of Contents
-1. [Coding Style](#coding-style)
-2. [Classes](#classes)
-3. [Collections](#collections)
-4. [Documentation](#documentation)
-5. [Dynamic Dispatch](#dynamic-dispatch)
-6. [Exceptions](#exceptions)
-7. [Hashes](#hashes)
-8. [Keyword Arguments](#keyword-arguments)
-9. [Naming](#naming)
-10. [Percent Literals](#percent-literals)
-11. [Regular Expressions](#regular-expressions)
-12. [Requires](#requires)
-13. [Strings](#strings)
-14. [Syntax](#syntax)
-
-## Coding Style
+1. [Layout](#layout)
+   1. [Indentation](#indentation)
+   2. [Inline](#inline)
+   3. [Newlines](#newlines)
+2. [Maximum Line Length](#line-length)
+3. [Classes](#classes)
+4. [Collections](#collections)
+5. [Documentation](#documentation)
+6. [Dynamic Dispatch](#dynamic-dispatch)
+7. [Exceptions](#exceptions)
+8. [Hashes](#hashes)
+9. [Keyword Arguments](#keyword-arguments)
+10. [Naming](#naming)
+11. [Percent Literals](#percent-literals)
+12. [Regular Expressions](#regular-expressions)
+13. [Requires](#requires)
+14. [Strings](#strings)
+15. [Syntax](#syntax)
+
+## Layout
+
+### Indentation
 
 * Use soft-tabs with a two space indent.
 
-* Keep each line of code to a readable length. Unless you have a reason to, keep lines to a maximum of 118 characters. Why 118? That's the width at which the pull request diff UI needs horizontal scrolling (making pull requests harder to review).
-
-* Never leave trailing whitespace.
-
-* End each file with a [newline](https://github.com/bbatsov/ruby-style-guide#newline-eof).
-
-* Use spaces around operators, after commas, colons and semicolons, around `{`
-  and before `}`.
-
-``` ruby
-sum = 1 + 2
-a, b = 1, 2
-1 > 2 ? true : false; puts "Hi"
-[1, 2, 3].each { |e| puts e }
-```
-
-* No spaces after `(`, `[` or before `]`, `)`.
-
-``` ruby
-some(arg).other
-[1, 2, 3].length
-```
-
-* No spaces after `!`.
-
-``` ruby
-!array.include?(element)
-```
-
 * Indent `when` with the start of the `case` expression.
 
 ``` ruby
@@ -91,6 +68,37 @@ else
 end
 ```
 
+### Inline
+
+* Never leave trailing whitespace.
+
+* Use spaces around operators, after commas, colons and semicolons, around `{`
+  and before `}`.
+
+``` ruby
+sum = 1 + 2
+a, b = 1, 2
+1 > 2 ? true : false; puts "Hi"
+[1, 2, 3].each { |e| puts e }
+```
+
+* No spaces after `(`, `[` or before `]`, `)`.
+
+``` ruby
+some(arg).other
+[1, 2, 3].length
+```
+
+* No spaces after `!`.
+
+``` ruby
+!array.include?(element)
+```
+
+### Newlines
+
+* End each file with a [newline](https://github.com/bbatsov/ruby-style-guide#newline-eof).
+
 * Use empty lines between `def`s and to break up a method into logical
   paragraphs.
 
@@ -108,6 +116,10 @@ def some_method
 end
 ```
 
+## Maximum Line Length
+
+* Keep each line of code to a readable length. Unless you have a reason to, keep lines to a maximum of 118 characters. Why 118? That's the width at which the pull request diff UI needs horizontal scrolling (making pull requests harder to review).
+
 ## Classes
 
 * Avoid the usage of class (`@@`) variables due to their unusual behavior

From fe295a73dd0fb14964fd54daef78f3d29127522b Mon Sep 17 00:00:00 2001
From: Elena Tanasoiu <elenatanasoiu@github.com>
Date: Sun, 28 Aug 2022 19:35:05 +0100
Subject: [PATCH 20/47] Extract method-related rules into own section

---
 STYLEGUIDE.md | 42 ++++++++++++++++++++++++++----------------
 1 file changed, 26 insertions(+), 16 deletions(-)

diff --git a/STYLEGUIDE.md b/STYLEGUIDE.md
index d7237672..be4774cd 100644
--- a/STYLEGUIDE.md
+++ b/STYLEGUIDE.md
@@ -20,7 +20,11 @@ This is GitHub's Ruby Style Guide, inspired by [RuboCop's guide][rubocop-guide].
 12. [Regular Expressions](#regular-expressions)
 13. [Requires](#requires)
 14. [Strings](#strings)
-15. [Syntax](#syntax)
+15. [Methods](#methods)
+    1. [Method definitions](#method-definitions)
+    2. [Method calls](#method-calls)
+
+16. [Syntax](#syntax)
 
 ## Layout
 
@@ -558,7 +562,9 @@ paragraphs.each do |paragraph|
 end
 ```
 
-## Syntax
+## Methods
+
+### Method definitions
 
 * Use `def` with parentheses when there are arguments. Omit the
   parentheses when the method doesn't accept any arguments.
@@ -573,6 +579,24 @@ end
  end
  ```
 
+### Method calls
+
+* If the first argument to a method begins with an open parenthesis,
+  always use parentheses in the method invocation. For example, write
+  `f((3 + 2) + 1)`.
+
+* Never put a space between a method name and the opening parenthesis.
+
+``` ruby
+# bad
+f (3 + 2) + 1
+
+# good
+f(3 + 2) + 1
+```
+
+## Syntax
+
 * Never use `for`, unless you know exactly why. Most of the time iterators
   should be used instead. `for` is implemented in terms of `each` (so
   you're adding a level of indirection), but with a twist - `for`
@@ -779,20 +803,6 @@ enabled = true if enabled.nil?
   one-liner scripts is discouraged. Prefer long form versions such as
   `$PROGRAM_NAME`.
 
-* Never put a space between a method name and the opening parenthesis.
-
-``` ruby
-# bad
-f (3 + 2) + 1
-
-# good
-f(3 + 2) + 1
-```
-
-* If the first argument to a method begins with an open parenthesis,
-  always use parentheses in the method invocation. For example, write
-`f((3 + 2) + 1)`.
-
 * Use `_` for unused block parameters.
 
 ``` ruby

From 839223d9b3e4241b56744fafba3af46a423e4cf6 Mon Sep 17 00:00:00 2001
From: Elena Tanasoiu <elenatanasoiu@github.com>
Date: Sun, 28 Aug 2022 19:45:33 +0100
Subject: [PATCH 21/47] Extract "Conditional Expressions" section

---
 STYLEGUIDE.md | 108 +++++++++++++++++++++++++++-----------------------
 1 file changed, 58 insertions(+), 50 deletions(-)

diff --git a/STYLEGUIDE.md b/STYLEGUIDE.md
index be4774cd..365f68d5 100644
--- a/STYLEGUIDE.md
+++ b/STYLEGUIDE.md
@@ -23,8 +23,10 @@ This is GitHub's Ruby Style Guide, inspired by [RuboCop's guide][rubocop-guide].
 15. [Methods](#methods)
     1. [Method definitions](#method-definitions)
     2. [Method calls](#method-calls)
-
-16. [Syntax](#syntax)
+16. [Conditional Expressions](#conditional-expressions)
+    1. [Conditional keywords](#conditional-keywords)
+    2. [Ternary operator](#ternary-operator)
+17. [Syntax](#syntax)
 
 ## Layout
 
@@ -595,25 +597,9 @@ f (3 + 2) + 1
 f(3 + 2) + 1
 ```
 
-## Syntax
+## Conditional Expressions
 
-* Never use `for`, unless you know exactly why. Most of the time iterators
-  should be used instead. `for` is implemented in terms of `each` (so
-  you're adding a level of indirection), but with a twist - `for`
-  doesn't introduce a new scope (unlike `each`) and variables defined
-  in its block will be visible outside it.
-
-``` ruby
-arr = [1, 2, 3]
-
-# bad
-for elem in arr do
-  puts elem
-end
-
-# good
-arr.each { |elem| puts elem }
-```
+### Conditional keywords
 
 * Never use `then` for multi-line `if/unless`.
 
@@ -629,38 +615,8 @@ if some_condition
 end
 ```
 
-* Avoid the ternary operator (`?:`) except in cases where all expressions are extremely
-  trivial. However, do use the ternary operator(`?:`) over `if/then/else/end` constructs
-  for single line conditionals.
-
-``` ruby
-# bad
-result = if some_condition then something else something_else end
-
-# good
-result = some_condition ? something : something_else
-```
-
-* Use one expression per branch in a ternary operator. This
-  also means that ternary operators must not be nested. Prefer
-  `if/else` constructs in these cases.
-
-``` ruby
-# bad
-some_condition ? (nested_condition ? nested_something : nested_something_else) : something_else
-
-# good
-if some_condition
-  nested_condition ? nested_something : nested_something_else
-else
-  something_else
-end
-```
-
 * The `and` and `or` keywords are banned. It's just not worth it. Always use `&&` and `||` instead.
 
-* Avoid multi-line `?:` (the ternary operator), use `if/unless` instead.
-
 * Favor modifier `if/unless` usage when you have a single-line
   body.
 
@@ -706,6 +662,58 @@ if x > 10
 end
 ```
 
+### Ternary operator
+
+* Avoid the ternary operator (`?:`) except in cases where all expressions are extremely
+  trivial. However, do use the ternary operator(`?:`) over `if/then/else/end` constructs
+  for single line conditionals.
+
+``` ruby
+# bad
+result = if some_condition then something else something_else end
+
+# good
+result = some_condition ? something : something_else
+```
+
+* Avoid multi-line `?:` (the ternary operator), use `if/unless` instead.
+
+* Use one expression per branch in a ternary operator. This
+  also means that ternary operators must not be nested. Prefer
+  `if/else` constructs in these cases.
+
+``` ruby
+# bad
+some_condition ? (nested_condition ? nested_something : nested_something_else) : something_else
+
+# good
+if some_condition
+  nested_condition ? nested_something : nested_something_else
+else
+  something_else
+end
+```
+
+## Syntax
+
+* Never use `for`, unless you know exactly why. Most of the time iterators
+  should be used instead. `for` is implemented in terms of `each` (so
+  you're adding a level of indirection), but with a twist - `for`
+  doesn't introduce a new scope (unlike `each`) and variables defined
+  in its block will be visible outside it.
+
+``` ruby
+arr = [1, 2, 3]
+
+# bad
+for elem in arr do
+  puts elem
+end
+
+# good
+arr.each { |elem| puts elem }
+```
+
 * Prefer `{...}` over `do...end` for single-line blocks.  Avoid using
   `{...}` for multi-line blocks (multiline chaining is always
   ugly). Always use `do...end` for "control flow" and "method

From 653e004ea17481b290105650a912af24a56701ab Mon Sep 17 00:00:00 2001
From: Elena Tanasoiu <elenatanasoiu@github.com>
Date: Sun, 28 Aug 2022 20:34:09 +0100
Subject: [PATCH 22/47] Add handy anchor links to items in styleguide

I've noticed people point at the styleguide when doing reviews.

Let's make their life easier by adding a link to each rule.

Spoiler: I am one of those people.
---
 STYLEGUIDE.md | 65 +++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 65 insertions(+)

diff --git a/STYLEGUIDE.md b/STYLEGUIDE.md
index 365f68d5..b10d59c3 100644
--- a/STYLEGUIDE.md
+++ b/STYLEGUIDE.md
@@ -33,8 +33,10 @@ This is GitHub's Ruby Style Guide, inspired by [RuboCop's guide][rubocop-guide].
 ### Indentation
 
 * Use soft-tabs with a two space indent.
+  <a name="default-indentation"></a><sup>[[link](#default-indentation)]</sup>
 
 * Indent `when` with the start of the `case` expression.
+  <a name="indent-when-as-start-of-case"></a><sup>[[link](#indent-when-as-start-of-case)]</sup>
 
 ``` ruby
 # bad
@@ -77,9 +79,11 @@ end
 ### Inline
 
 * Never leave trailing whitespace.
+  <a name="trailing-whitespace"></a><sup>[[link](#trailing-whitespace)]</sup>
 
 * Use spaces around operators, after commas, colons and semicolons, around `{`
   and before `}`.
+  <a name="spaces-operators"></a><sup>[[link](#spaces-operators)]</sup>
 
 ``` ruby
 sum = 1 + 2
@@ -89,6 +93,7 @@ a, b = 1, 2
 ```
 
 * No spaces after `(`, `[` or before `]`, `)`.
+  <a name="no-spaces-braces"></a><sup>[[link](#no-spaces-braces)]</sup>
 
 ``` ruby
 some(arg).other
@@ -96,6 +101,7 @@ some(arg).other
 ```
 
 * No spaces after `!`.
+  <a name="no-spaces-bang"></a><sup>[[link](#no-spaces-bang)]</sup>
 
 ``` ruby
 !array.include?(element)
@@ -104,9 +110,11 @@ some(arg).other
 ### Newlines
 
 * End each file with a [newline](https://github.com/bbatsov/ruby-style-guide#newline-eof).
+  <a name="newline-eof"></a><sup>[[link](#newline-eof)]</sup>
 
 * Use empty lines between `def`s and to break up a method into logical
   paragraphs.
+  <a name="empty-lines-def"></a><sup>[[link](#empty-lines-def)]</sup>
 
 ``` ruby
 def some_method
@@ -125,11 +133,13 @@ end
 ## Maximum Line Length
 
 * Keep each line of code to a readable length. Unless you have a reason to, keep lines to a maximum of 118 characters. Why 118? That's the width at which the pull request diff UI needs horizontal scrolling (making pull requests harder to review).
+  <a name="line-length"></a><sup>[[link](#line-length)]</sup>
 
 ## Classes
 
 * Avoid the usage of class (`@@`) variables due to their unusual behavior
 in inheritance.
+  <a name="class-variables"></a><sup>[[link](#class-variables)]</sup>
 
 ``` ruby
 class Parent
@@ -153,6 +163,7 @@ Parent.print_class_var # => will print "child"
 
 * Use `def self.method` to define singleton methods. This makes the methods
   more resistant to refactoring changes.
+  <a name="singleton-methods"></a><sup>[[link](#singleton-methods)]</sup>
 
 ``` ruby
 class TestClass
@@ -169,6 +180,7 @@ class TestClass
 
 * Avoid `class << self` except when necessary, e.g. single accessors and aliased
   attributes.
+  <a name="class-method-definitions"></a><sup>[[link](#class-method-definitions)]</sup>
 
 ``` ruby
 class TestClass
@@ -201,6 +213,7 @@ end
 
 * Indent the `public`, `protected`, and `private` methods as much the
   method definitions they apply to. Leave one blank line above them.
+  <a name="access-modifier-identation"></a><sup>[[link](#access-modifier-identation)]</sup>
 
 ``` ruby
 class SomeClass
@@ -217,6 +230,7 @@ end
 
 * Avoid explicit use of `self` as the recipient of internal class or instance
   messages unless to specify a method shadowed by a variable.
+  <a name="self-messages"></a><sup>[[link](#self-messages)]</sup>
 
 ``` ruby
 class SomeClass
@@ -233,6 +247,7 @@ end
 
 * Prefer `%w` to the literal array syntax when you need an array of
 strings.
+  <a name="percent-w"></a><sup>[[link](#percent-w)]</sup>
 
 ``` ruby
 # bad
@@ -246,8 +261,10 @@ STATES = %w(draft open closed)
   implements a collection of unordered values with no duplicates. This
   is a hybrid of `Array`'s intuitive inter-operation facilities and
   `Hash`'s fast lookup.
+  <a name="prefer-set"></a><sup>[[link](#prefer-set)]</sup>
 
 * Use symbols instead of strings as hash keys.
+  <a name="symbols-as-keys"></a><sup>[[link](#symbols-as-keys)]</sup>
 
 ``` ruby
 # bad
@@ -260,6 +277,7 @@ hash = { one: 1, two: 2, three: 3 }
 ## Documentation
 
 Use [TomDoc](http://tomdoc.org) to the best of your ability. It's pretty sweet:
+<a name="tomdoc"></a><sup>[[link](#tomdoc)]</sup>
 
 ``` ruby
 # Public: Duplicate some text an arbitrary number of times.
@@ -281,6 +299,7 @@ end
 ## Dynamic Dispatch
 
 Avoid calling `send` and its cousins unless you really need it. Metaprogramming can be extremely powerful, but in most cases you can write code that captures your meaning by being explicit:
+<a name="avoid-send"></a><sup>[[link](#avoid-send)]</sup>
 
 ``` ruby
 # avoid 
@@ -306,6 +325,7 @@ end
 ## Exceptions
 
 * Don't use exceptions for flow of control.
+  <a name="exceptions-flow-control"></a><sup>[[link](#exceptions-flow-control)]</sup>
 
 ``` ruby
 # bad
@@ -324,6 +344,7 @@ end
 ```
 
 * Rescue specific exceptions, not `StandardError` or its superclasses.
+  <a name="specific-exceptions"></a><sup>[[link](#specific-exceptions)]</sup>
 
 ``` ruby
 # bad
@@ -344,6 +365,7 @@ end
 ## Hashes
 
 Use the Ruby 1.9 syntax for hash literals when all the keys are symbols:
+<a name="symbols-as-hash-keys"></a><sup>[[link](#symbols-as-hash-keys)]</sup>
 
 ``` ruby
 # bad
@@ -360,6 +382,7 @@ user = {
 ```
 
 Use the 1.9 syntax when calling a method with Hash options arguments or named arguments:
+<a name="symbols-as-hash-method-arguments"></a><sup>[[link](#symbols-as-hash-method-arguments)]</sup>
 
 ``` ruby
 # bad
@@ -372,6 +395,9 @@ link_to("Account", controller: "users", action: "show", id: user)
 ```
 
 If you have a hash with mixed key types, use the legacy hashrocket style to avoid mixing styles within the same hash:
+<a name="consistent-hash-syntax"></a><sup>[[link](#consistent-hash-syntax)]</sup>
+
+``` ruby
 
 ``` ruby
 # bad
@@ -390,6 +416,9 @@ hsh = {
 ## Keyword Arguments
 
 [Keyword arguments](http://magazine.rubyist.net/?Ruby200SpecialEn-kwarg) are recommended but not required when a method's arguments may otherwise be opaque or non-obvious when called. Additionally, prefer them over the old "Hash as pseudo-named args" style from pre-2.0 ruby.
+<a name="keyword-arguments"></a><sup>[[link](#keyword-arguments)]</sup>
+
+``` ruby
 
 So instead of this:
 ``` ruby
@@ -414,23 +443,29 @@ remove_member(user, skip_membership_check: true)
 ## Naming
 
 * Use `snake_case` for methods and variables.
+  <a name="snake-case-methods-vars"></a><sup>[[link](#snake-case-methods-vars)]</sup>
 
 * Use `CamelCase` for classes and modules.  (Keep acronyms like HTTP,
   RFC, XML uppercase.)
+  <a name="camelcase-classes-modules"></a><sup>[[link](#camelcase-classes-modules)]</sup>
 
 * Use `SCREAMING_SNAKE_CASE` for other constants.
+  <a name="screaming-snake-case-constants"></a><sup>[[link](#screaming-snake-case-constants)]</sup>
 
 * The names of predicate methods (methods that return a boolean value)
   should end in a question mark. (i.e. `Array#empty?`).
+  <a name="bool-methods-qmark"></a><sup>[[link](#bool-methods-qmark)]</sup>
 
 * The names of potentially "dangerous" methods (i.e. methods that modify `self` or the
   arguments, `exit!`, etc.) should end with an exclamation mark. Bang methods
   should only exist if a non-bang counterpart (method name which does NOT end with !) 
   also exists.
+  <a name="dangerous-method-bang"></a><sup>[[link](#dangerous-method-bang)]</sup>
 
 ## Percent Literals
 
 * Use `%w` freely.
+  <a name="use-percent-w-freely"></a><sup>[[link](#use-percent-w-freely)]</sup>
 
 ``` ruby
 STATES = %w(draft open closed)
@@ -438,6 +473,7 @@ STATES = %w(draft open closed)
 
 * Use `%()` for single-line strings which require both interpolation
   and embedded double-quotes. For multi-line strings, prefer heredocs.
+  <a name="percent-parens-single-line"></a><sup>[[link](#percent-parens-single-line)]</sup>
 
 ``` ruby
 # bad (no interpolation needed)
@@ -457,6 +493,7 @@ STATES = %w(draft open closed)
 ```
 
 * Use `%r` only for regular expressions matching *more than* one '/' character.
+  <a name="percent-r-regular-expressions"></a><sup>[[link](#percent-r-regular-expressions)]</sup>
 
 ``` ruby
 # bad
@@ -474,6 +511,7 @@ STATES = %w(draft open closed)
 
 * Avoid using $1-9 as it can be hard to track what they contain. Named groups
   can be used instead.
+  <a name="capture-with-named-groups"></a><sup>[[link](#capture-with-named-groups)]</sup>
 
 ``` ruby
 # bad
@@ -489,6 +527,7 @@ process meaningful_var
 
 * Be careful with `^` and `$` as they match start/end of line, not string endings.
   If you want to match the whole string use: `\A` and `\z`.
+  <a name="regex-begin-end-markers"></a><sup>[[link](#regex-begin-end-markers)]</sup>
 
 ``` ruby
 string = "some injection\nusername"
@@ -498,6 +537,7 @@ string[/\Ausername\z/] # don't match
 
 * Use `x` modifier for complex regexps. This makes them more readable and you
   can add some useful comments. Just be careful as spaces are ignored.
+  <a name="x-modifier-complex-regex"></a><sup>[[link](#x-modifier-complex-regex)]</sup>
 
 ``` ruby
 regexp = %r{
@@ -514,6 +554,7 @@ regexp = %r{
 Always `require` dependencies used directly in a script at the start of the same file.
 Resources that will get autoloaded on first use—such as Rails models, controllers, or
 helpers—don't need to be required.
+<a name="require-dependencies-directly"></a><sup>[[link](#require-dependencies-directly)]</sup>
 
 ``` ruby
 require "set"
@@ -529,6 +570,7 @@ documentation about the libraries that the current file uses.
 ## Strings
 
 * Prefer string interpolation instead of string concatenation:
+  <a name="string-interpolation"></a><sup>[[link](#string-interpolation)]</sup>
 
 ``` ruby
 # bad
@@ -541,6 +583,7 @@ email_with_name = "#{user.name} <#{user.email}>"
 * Use double-quoted strings. Interpolation and escaped characters
   will always work without a delimiter change, and `'` is a lot more
   common than `"` in string literals.
+  <a name="double-quotes"></a><sup>[[link](#double-quotes)]</sup>
 
 ``` ruby
 # bad
@@ -553,6 +596,7 @@ name = "Bozhidar"
 * Avoid using `String#+` when you need to construct large data chunks.
   Instead, use `String#<<`. Concatenation mutates the string instance in-place
   and is always faster than `String#+`, which creates a bunch of new string objects.
+  <a name="string-concatenation"></a><sup>[[link](#string-concatenation)]</sup>
 
 ``` ruby
 # good and also fast
@@ -570,6 +614,7 @@ end
 
 * Use `def` with parentheses when there are arguments. Omit the
   parentheses when the method doesn't accept any arguments.
+  <a name="method-parens-when-arguments"></a><sup>[[link](#method-parens-when-arguments)]</sup>
 
  ``` ruby
  def some_method
@@ -586,8 +631,10 @@ end
 * If the first argument to a method begins with an open parenthesis,
   always use parentheses in the method invocation. For example, write
   `f((3 + 2) + 1)`.
+  <a name="parens-no-spaces"></a><sup>[[link](#parens-no-spaces)]</sup>
 
 * Never put a space between a method name and the opening parenthesis.
+  <a name="no-spaces-method-parens"></a><sup>[[link](#no-spaces-method-parens)]</sup>
 
 ``` ruby
 # bad
@@ -602,6 +649,7 @@ f(3 + 2) + 1
 ### Conditional keywords
 
 * Never use `then` for multi-line `if/unless`.
+  <a name="no-then-for-multi-line-if-unless"></a><sup>[[link](#no-then-for-multi-line-if-unless)]</sup>
 
 ``` ruby
 # bad
@@ -616,9 +664,11 @@ end
 ```
 
 * The `and` and `or` keywords are banned. It's just not worth it. Always use `&&` and `||` instead.
+  <a name="no-and-or-or"></a><sup>[[link](#no-and-or-or)]</sup>
 
 * Favor modifier `if/unless` usage when you have a single-line
   body.
+  <a name="favor-modifier-if-unless"></a><sup>[[link](#favor-modifier-if-unless)]</sup>
 
 ``` ruby
 # bad
@@ -631,6 +681,7 @@ do_something if some_condition
 ```
 
 * Never use `unless` with `else`. Rewrite these with the positive case first.
+  <a name="no-else-with-unless"></a><sup>[[link](#no-else-with-unless)]</sup>
 
 ``` ruby
 # bad
@@ -649,6 +700,7 @@ end
 ```
 
 * Don't use parentheses around the condition of an `if/unless/while`.
+  <a name="no-parens-if-unless-while"></a><sup>[[link](#no-parens-if-unless-while)]</sup>
 
 ``` ruby
 # bad
@@ -667,6 +719,7 @@ end
 * Avoid the ternary operator (`?:`) except in cases where all expressions are extremely
   trivial. However, do use the ternary operator(`?:`) over `if/then/else/end` constructs
   for single line conditionals.
+  <a name="trivial-ternary"></a><sup>[[link](#trivial-ternary)]</sup>
 
 ``` ruby
 # bad
@@ -677,10 +730,12 @@ result = some_condition ? something : something_else
 ```
 
 * Avoid multi-line `?:` (the ternary operator), use `if/unless` instead.
+  <a name="no-multiline-ternary"></a><sup>[[link](#no-multiline-ternary)]</sup>
 
 * Use one expression per branch in a ternary operator. This
   also means that ternary operators must not be nested. Prefer
   `if/else` constructs in these cases.
+  <a name="one-expression-per-branch"></a><sup>[[link](#one-expression-per-branch)]</sup>
 
 ``` ruby
 # bad
@@ -701,6 +756,7 @@ end
   you're adding a level of indirection), but with a twist - `for`
   doesn't introduce a new scope (unlike `each`) and variables defined
   in its block will be visible outside it.
+  <a name="avoid-for"></a><sup>[[link](#avoid-for)]</sup>
 
 ``` ruby
 arr = [1, 2, 3]
@@ -719,6 +775,7 @@ arr.each { |elem| puts elem }
   ugly). Always use `do...end` for "control flow" and "method
   definitions" (e.g. in Rakefiles and certain DSLs).  Avoid `do...end`
   when chaining.
+  <a name="squiggly-braces"></a><sup>[[link](#squiggly-braces)]</sup>
 
 ``` ruby
 names = ["Bozhidar", "Steve", "Sarah"]
@@ -745,6 +802,7 @@ end.map { |name| name.upcase }
     nifty methods?
 
 * Avoid `return` where not required.
+  <a name="avoid-return"></a><sup>[[link](#avoid-return)]</sup>
 
 ``` ruby
 # bad
@@ -759,6 +817,7 @@ end
 ```
 
 * Use spaces around the `=` operator when assigning default values to method parameters:
+  <a name="spaces-around-equals"></a><sup>[[link](#spaces-around-equals)]</sup>
 
 ``` ruby
 # bad
@@ -776,6 +835,7 @@ While several Ruby books suggest the first style, the second is much more promin
 in practice (and arguably a bit more readable).
 
 * Using the return value of `=` (an assignment) is ok.
+  <a name="use-return-value-of-assignment"></a><sup>[[link](#use-return-value-of-assignment)]</sup>
 
 ``` ruby
 # bad
@@ -789,6 +849,7 @@ if (v = next_value) == "hello" ...
 ```
 
 * Use `||=` freely to initialize variables.
+  <a name="memoization-for-initialization"></a><sup>[[link](#memoize-away)]</sup>
 
 ``` ruby
 # set name to Bozhidar, only if it's nil or false
@@ -797,6 +858,7 @@ name ||= "Bozhidar"
 
 * Don't use `||=` to initialize boolean variables. (Consider what
   would happen if the current value happened to be `false`.)
+  <a name="no-memoization-for-boolean"></a><sup>[[link](#no-memoization-for-boolean)]</sup>
 
 ``` ruby
 # bad - would set enabled to true even if it was false
@@ -810,8 +872,10 @@ enabled = true if enabled.nil?
   etc. ). They are quite cryptic and their use in anything but
   one-liner scripts is discouraged. Prefer long form versions such as
   `$PROGRAM_NAME`.
+  <a name="no-cryptic-vars"></a><sup>[[link](#no-cryptic-vars)]</sup>
 
 * Use `_` for unused block parameters.
+  <a name="underscore-unused-vars"></a><sup>[[link](#underscore-unused-vars)]</sup>
 
 ``` ruby
 # bad
@@ -825,6 +889,7 @@ result = hash.map { |_, v| v + 1 }
   implementation detail to support Ruby features like `case`, and it's not commutative.
   For example, `String === "hi"` is true and `"hi" === String` is false.
   Instead, use `is_a?` or `kind_of?` if you must.
+  <a name="type-checking-is-a-kind-of"></a><sup>[[link](#type-checking-is-a-kind-of)]</sup>
 
   Refactoring is even better. It's worth looking hard at any code that explicitly checks types.
 

From 2c20cd6d62de70faf093009997c3fecf1d50f6d6 Mon Sep 17 00:00:00 2001
From: Francis <francisfuzz@github.com>
Date: Wed, 5 Oct 2022 14:17:07 -0700
Subject: [PATCH 23/47] fix(STYLEGUIDE.md): remove extra opening code block

In the `Keyword Arguments` section, there's an example that presents two code blocks. This change removes a lone opening code block without its matching end and adjusts the accompanying prose for readability.
---
 STYLEGUIDE.md | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/STYLEGUIDE.md b/STYLEGUIDE.md
index b10d59c3..c32650c4 100644
--- a/STYLEGUIDE.md
+++ b/STYLEGUIDE.md
@@ -418,9 +418,8 @@ hsh = {
 [Keyword arguments](http://magazine.rubyist.net/?Ruby200SpecialEn-kwarg) are recommended but not required when a method's arguments may otherwise be opaque or non-obvious when called. Additionally, prefer them over the old "Hash as pseudo-named args" style from pre-2.0 ruby.
 <a name="keyword-arguments"></a><sup>[[link](#keyword-arguments)]</sup>
 
-``` ruby
-
 So instead of this:
+
 ``` ruby
 def remove_member(user, skip_membership_check=false)
   # ...
@@ -430,7 +429,8 @@ end
 remove_member(user, true)
 ```
 
-Do this, which is much clearer.
+Do this, which is much clearer:
+
 ``` ruby
 def remove_member(user, skip_membership_check: false)
   # ...
@@ -893,4 +893,4 @@ result = hash.map { |_, v| v + 1 }
 
   Refactoring is even better. It's worth looking hard at any code that explicitly checks types.
 
-[rubocop-guide]: https://github.com/rubocop-hq/ruby-style-guide
\ No newline at end of file
+[rubocop-guide]: https://github.com/rubocop-hq/ruby-style-guide

From a33679fcd8f5118d4e70369e432e5a4d25d952e7 Mon Sep 17 00:00:00 2001
From: Francis <francisfuzz@github.com>
Date: Wed, 5 Oct 2022 14:28:51 -0700
Subject: [PATCH 24/47] fix(STYLEGUIDE.md): use list item instead of codeblock

This change updates the `Syntax` section's statement from it being in a codeblock (via indentation) to it being another list item (to stay consistent with the other style notes in the document).
---
 STYLEGUIDE.md | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/STYLEGUIDE.md b/STYLEGUIDE.md
index b10d59c3..4418ad9f 100644
--- a/STYLEGUIDE.md
+++ b/STYLEGUIDE.md
@@ -797,9 +797,9 @@ names.select do |name|
 end.map { |name| name.upcase }
 ```
 
-    Some will argue that multiline chaining would look OK with the use of {...}, but they should
-    ask themselves - is this code really readable and can't the block's contents be extracted into
-    nifty methods?
+* Some will argue that multiline chaining would look OK with the use of `{...}`,
+ but they should ask themselves: is this code really readable and can't the block's 
+ contents be extracted into nifty methods?
 
 * Avoid `return` where not required.
   <a name="avoid-return"></a><sup>[[link](#avoid-return)]</sup>
@@ -893,4 +893,4 @@ result = hash.map { |_, v| v + 1 }
 
   Refactoring is even better. It's worth looking hard at any code that explicitly checks types.
 
-[rubocop-guide]: https://github.com/rubocop-hq/ruby-style-guide
\ No newline at end of file
+[rubocop-guide]: https://github.com/rubocop-hq/ruby-style-guide

From 417fc0146090f286e9462e1699f2166d60520349 Mon Sep 17 00:00:00 2001
From: Issy Long <issyl0@github.com>
Date: Mon, 10 Oct 2022 13:54:17 +0000
Subject: [PATCH 25/47] Delete GitHub/Accessibility cops; point to
 `rubocop-rails-accessibility`

- Accessibility rules used to live in this gem, but
  https://github.com/github/rubocop-rails-accessibility now exists with
  the rules that were here and more. The monolith uses the new gem.
- For projects that haven't moved over yet, signpost in the README (and
  the eventual new gem version release notes, please) that accessibility
  cops have moved.
- Fixes https://github.com/github/code-scanning/issues/7337.
---
 README.md                                     |  3 +-
 config/accessibility.yml                      | 15 --------
 .../cop/github/accessibility/image_has_alt.rb | 26 -------------
 .../cop/github/accessibility/link_has_href.rb | 25 ------------
 .../accessibility/no_positive_tabindex.rb     | 32 ----------------
 .../accessibility/no_redundant_image_alt.rb   | 38 -------------------
 test/test_image_has_alt.rb                    | 28 --------------
 test/test_link_has_href.rb                    | 35 -----------------
 test/test_no_positive_tabindex.rb             | 28 --------------
 test/test_no_redundant_image_alt.rb           | 28 --------------
 10 files changed, 2 insertions(+), 256 deletions(-)
 delete mode 100644 config/accessibility.yml
 delete mode 100644 lib/rubocop/cop/github/accessibility/image_has_alt.rb
 delete mode 100644 lib/rubocop/cop/github/accessibility/link_has_href.rb
 delete mode 100644 lib/rubocop/cop/github/accessibility/no_positive_tabindex.rb
 delete mode 100644 lib/rubocop/cop/github/accessibility/no_redundant_image_alt.rb
 delete mode 100644 test/test_image_has_alt.rb
 delete mode 100644 test/test_link_has_href.rb
 delete mode 100644 test/test_no_positive_tabindex.rb
 delete mode 100644 test/test_no_redundant_image_alt.rb

diff --git a/README.md b/README.md
index ab466b18..cdca4068 100644
--- a/README.md
+++ b/README.md
@@ -19,9 +19,10 @@ inherit_gem:
   rubocop-github:
     - config/default.yml
     - config/rails.yml
-    - config/accessibility.yml
 ```
 
+💭 Looking for `config/accessibility.yml` and the `GitHub/Accessibility` configs? [They have moved](https://github.com/github/rubocop-rails-accessibility) to a new gem.
+
 ### Legacy usage
 
 If you are using a rubocop version < 1.0.0, you can use rubocop-github version
diff --git a/config/accessibility.yml b/config/accessibility.yml
deleted file mode 100644
index 1908cad4..00000000
--- a/config/accessibility.yml
+++ /dev/null
@@ -1,15 +0,0 @@
-require:
-  - rubocop/cop/github/accessibility
-
-GitHub/Accessibility/ImageHasAlt:
-  Enabled: true
-  StyleGuide: https://github.com/github/rubocop-github/blob/master/guides/image-has-alt.md
-GitHub/Accessibility/LinkHasHref:
-  Enabled: true
-  StyleGuide: https://github.com/github/rubocop-github/blob/master/guides/link-has-href.md
-GitHub/Accessibility/NoPositiveTabindex:
-  Enabled: true
-  StyleGuide: https://github.com/github/rubocop-github/blob/master/guides/no-positive-tabindex.md
-GitHub/Accessibility/NoRedundantImageAlt:
-  Enabled: true
-  StyleGuide: https://github.com/github/rubocop-github/blob/master/guides/no-redundant-image-alt.md
diff --git a/lib/rubocop/cop/github/accessibility/image_has_alt.rb b/lib/rubocop/cop/github/accessibility/image_has_alt.rb
deleted file mode 100644
index 698d9224..00000000
--- a/lib/rubocop/cop/github/accessibility/image_has_alt.rb
+++ /dev/null
@@ -1,26 +0,0 @@
-# frozen_string_literal: true
-
-require "rubocop"
-
-module RuboCop
-  module Cop
-    module GitHub
-      module Accessibility
-        class ImageHasAlt < Base
-          MSG = "Images should have an alt prop with meaningful text or an empty string for decorative images"
-
-          def_node_search :has_alt_attribute?, "(sym :alt)"
-
-          def on_send(node)
-            receiver, method_name, _= *node
-
-            if receiver.nil? && method_name == :image_tag
-              alt = has_alt_attribute?(node)
-              add_offense(node.loc.selector) if alt.nil?
-            end
-          end
-        end
-      end
-    end
-  end
-end
diff --git a/lib/rubocop/cop/github/accessibility/link_has_href.rb b/lib/rubocop/cop/github/accessibility/link_has_href.rb
deleted file mode 100644
index 751c564c..00000000
--- a/lib/rubocop/cop/github/accessibility/link_has_href.rb
+++ /dev/null
@@ -1,25 +0,0 @@
-# frozen_string_literal: true
-
-require "rubocop"
-
-module RuboCop
-  module Cop
-    module GitHub
-      module Accessibility
-        class LinkHasHref < Base
-          MSG = "Links should go somewhere, you probably want to use a `<button>` instead.".freeze
-
-          def on_send(node)
-            receiver, method_name, *args = *node
-
-            if receiver.nil? && method_name == :link_to
-              if args.length == 1 || (args.length > 1 && args[1].type == :str && args[1].children.first == "#")
-                add_offense(node.loc.selector)
-              end
-            end
-          end
-        end
-      end
-    end
-  end
-end
diff --git a/lib/rubocop/cop/github/accessibility/no_positive_tabindex.rb b/lib/rubocop/cop/github/accessibility/no_positive_tabindex.rb
deleted file mode 100644
index 2a63fbe1..00000000
--- a/lib/rubocop/cop/github/accessibility/no_positive_tabindex.rb
+++ /dev/null
@@ -1,32 +0,0 @@
-# frozen_string_literal: true
-
-require "rubocop"
-
-module RuboCop
-  module Cop
-    module GitHub
-      module Accessibility
-        class NoPositiveTabindex < Base
-          MSG = "Positive tabindex is error-prone and often inaccessible."
-
-          def on_send(node)
-            receiver, method_name, *args = *node
-            if receiver.nil?
-              args.select do |arg|
-                arg.type == :hash
-              end.each do |hash|
-                hash.each_pair do |key, value|
-                  next if key.type == :dsym
-                  next unless key.respond_to?(:value)
-                  if key.value == :tabindex && value.source.to_i > 0
-                    add_offense(hash)
-                  end
-                end
-              end
-            end
-          end
-        end
-      end
-    end
-  end
-end
diff --git a/lib/rubocop/cop/github/accessibility/no_redundant_image_alt.rb b/lib/rubocop/cop/github/accessibility/no_redundant_image_alt.rb
deleted file mode 100644
index 0f84a872..00000000
--- a/lib/rubocop/cop/github/accessibility/no_redundant_image_alt.rb
+++ /dev/null
@@ -1,38 +0,0 @@
-# frozen_string_literal: true
-
-require "rubocop"
-
-module RuboCop
-  module Cop
-    module GitHub
-      module Accessibility
-        class NoRedundantImageAlt < Base
-          MSG = "Alt prop should not contain `image` or `picture` as screen readers already announce the element as an image"
-          REDUNDANT_ALT_WORDS = %w(image picture)
-
-          def_node_search :redundant_alt?, "(pair (sym :alt) (str #contains_redundant_alt_text?))"
-
-          def on_send(node)
-            receiver, method_name, _= *node
-
-            if receiver.nil? && method_name == :image_tag
-              if redundant_alt?(node)
-                add_offense(node.loc.selector)
-              end
-            end
-          end
-
-          private
-
-          def contains_redundant_alt_text?(string)
-            return false if string.empty?
-
-            if (string.downcase.split & REDUNDANT_ALT_WORDS).any?
-              return true
-            end
-          end
-        end
-      end
-    end
-  end
-end
diff --git a/test/test_image_has_alt.rb b/test/test_image_has_alt.rb
deleted file mode 100644
index e4fb08a8..00000000
--- a/test/test_image_has_alt.rb
+++ /dev/null
@@ -1,28 +0,0 @@
-# frozen_string_literal: true
-
-require_relative "./cop_test"
-require "minitest/autorun"
-require "rubocop/cop/github/accessibility/image_has_alt"
-
-class TestImageHasAlt < CopTest
-  def cop_class
-    RuboCop::Cop::GitHub::Accessibility::ImageHasAlt
-  end
-
-  def test_image_has_alt_offense
-    offenses = erb_investigate cop, <<-ERB, "app/views/products/index.html.erb"
-      <%= image_tag "spinners/octocat-spinner-16px.gif", size: "12x12" %>
-    ERB
-
-    assert_equal 1, offenses.count
-    assert_equal "Images should have an alt prop with meaningful text or an empty string for decorative images", offenses[0].message
-  end
-
-  def test_image_has_alt_no_offense
-    offenses = erb_investigate cop, <<-ERB, "app/views/products/index.html.erb"
-      <%= image_tag "spinners/octocat-spinner-16px.gif", size: "12x12", alt: "GitHub Logo spinner" %>
-    ERB
-
-    assert_equal 0, offenses.count
-  end
-end
diff --git a/test/test_link_has_href.rb b/test/test_link_has_href.rb
deleted file mode 100644
index b68dc92e..00000000
--- a/test/test_link_has_href.rb
+++ /dev/null
@@ -1,35 +0,0 @@
-# frozen_string_literal: true
-
-require_relative "./cop_test"
-require "minitest/autorun"
-require "rubocop/cop/github/accessibility/link_has_href"
-
-class LinkHasHref < CopTest
-  def cop_class
-    RuboCop::Cop::GitHub::Accessibility::LinkHasHref
-  end
-
-  def test_link_has_href_offense
-    offenses = erb_investigate cop, <<-ERB, "app/views/products/index.html.erb"
-      <%= link_to 'Go to GitHub' %>
-    ERB
-
-    assert_equal 1, offenses.count
-    assert_equal "Links should go somewhere, you probably want to use a `<button>` instead.", offenses[0].message
-
-    offenses = erb_investigate cop, <<-ERB, "app/views/products/index.html.erb"
-      <%= link_to 'Go to GitHub', '#' %>
-    ERB
-
-    assert_equal 1, offenses.count
-    assert_equal "Links should go somewhere, you probably want to use a `<button>` instead.", offenses[0].message
-  end
-
-  def test_link_has_href_no_offense
-    offenses = erb_investigate cop, <<-ERB, "app/views/products/index.html.erb"
-      <%= link_to 'Go to GitHub', 'https://github.com/' %>
-    ERB
-
-    assert_equal 0, offenses.count
-  end
-end
diff --git a/test/test_no_positive_tabindex.rb b/test/test_no_positive_tabindex.rb
deleted file mode 100644
index 482c9c42..00000000
--- a/test/test_no_positive_tabindex.rb
+++ /dev/null
@@ -1,28 +0,0 @@
-# frozen_string_literal: true
-
-require_relative "./cop_test"
-require "minitest/autorun"
-require "rubocop/cop/github/accessibility/no_positive_tabindex"
-
-class NoPositiveTabindex < CopTest
-  def cop_class
-    RuboCop::Cop::GitHub::Accessibility::NoPositiveTabindex
-  end
-
-  def test_no_positive_tabindex_alt_offense
-    offenses = erb_investigate cop, <<-ERB, "app/views/products/index.html.erb"
-      <%= button_tag "Continue", :tabindex => 3 %>
-    ERB
-
-    assert_equal 1, offenses.count
-    assert_equal "Positive tabindex is error-prone and often inaccessible.", offenses[0].message
-  end
-
-  def test_no_positive_tabindex_alt_no_offense
-    offenses = erb_investigate cop, <<-ERB, "app/views/products/index.html.erb"
-       <%= button_tag "Continue", :tabindex => -1 %>
-    ERB
-
-    assert_equal 0, offenses.count
-  end
-end
diff --git a/test/test_no_redundant_image_alt.rb b/test/test_no_redundant_image_alt.rb
deleted file mode 100644
index c8e91641..00000000
--- a/test/test_no_redundant_image_alt.rb
+++ /dev/null
@@ -1,28 +0,0 @@
-# frozen_string_literal: true
-
-require_relative "./cop_test"
-require "minitest/autorun"
-require "rubocop/cop/github/accessibility/no_redundant_image_alt"
-
-class NoRedundantImageAlt < CopTest
-  def cop_class
-    RuboCop::Cop::GitHub::Accessibility::NoRedundantImageAlt
-  end
-
-  def test_no_redundant_image_alt_offense
-    offenses = erb_investigate cop, <<-ERB, "app/views/products/index.html.erb"
-      <%= image_tag "cat.gif", size: "12x12", alt: "Picture of a cat" %>
-    ERB
-
-    assert_equal 1, offenses.count
-    assert_equal "Alt prop should not contain `image` or `picture` as screen readers already announce the element as an image", offenses[0].message
-  end
-
-  def test_no_redundant_image_alt_no_offense
-    offenses = erb_investigate cop, <<-ERB, "app/views/products/index.html.erb"
-       <%= image_tag "cat.gif", size: "12x12", alt: "A black cat" %>
-    ERB
-
-    assert_equal 0, offenses.count
-  end
-end

From 7a083dae1e7df78047a34269109e33821d9c7492 Mon Sep 17 00:00:00 2001
From: Issy Long <issyl0@github.com>
Date: Mon, 10 Oct 2022 15:11:19 +0100
Subject: [PATCH 26/47] README: Language tweak.
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Co-authored-by: Adrián Bolonio <bolonio@github.com>
---
 README.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/README.md b/README.md
index cdca4068..5cad859c 100644
--- a/README.md
+++ b/README.md
@@ -21,7 +21,7 @@ inherit_gem:
     - config/rails.yml
 ```
 
-💭 Looking for `config/accessibility.yml` and the `GitHub/Accessibility` configs? [They have moved](https://github.com/github/rubocop-rails-accessibility) to a new gem.
+💭 Looking for `config/accessibility.yml` and the `GitHub/Accessibility` configs? [They have been moved](https://github.com/github/rubocop-rails-accessibility) to a new gem.
 
 ### Legacy usage
 

From e408daea3a5dcf34a9c4d0f6e39c56a1104501b2 Mon Sep 17 00:00:00 2001
From: Issy Long <issyl0@github.com>
Date: Mon, 10 Oct 2022 15:14:59 +0100
Subject: [PATCH 27/47] README: (nit) Move link text over slightly

Co-authored-by: Sam Partington <sampart@github.com>
---
 README.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/README.md b/README.md
index 5cad859c..b5fb2ad4 100644
--- a/README.md
+++ b/README.md
@@ -21,7 +21,7 @@ inherit_gem:
     - config/rails.yml
 ```
 
-💭 Looking for `config/accessibility.yml` and the `GitHub/Accessibility` configs? [They have been moved](https://github.com/github/rubocop-rails-accessibility) to a new gem.
+💭 Looking for `config/accessibility.yml` and the `GitHub/Accessibility` configs? They have been moved to [a new gem](https://github.com/github/rubocop-rails-accessibility).
 
 ### Legacy usage
 

From 1b549a305087169c3f730511c42093c4c67571bd Mon Sep 17 00:00:00 2001
From: Issy Long <issyl0@github.com>
Date: Mon, 10 Oct 2022 18:54:28 +0000
Subject: [PATCH 28/47] config/default: Unset `DisabledByDefault: true`

- The `DisabledByDefault` config option made it so that "all cops in the
  default configuration are disabled, and only cops in user configuration
  are enabled", which makes cops "opt-in rather than opt-out"
  (source: https://github.com/rubocop/rubocop/blob/d1270c468cdb9a211229e36aef8d568ae3bfe607/config/default.yml#L91-L102).

- It's not immediately obvious that this gem has this config option,
  and it's used in a lot of GitHub Ruby projects. This means that
  people may write new, custom cops in downstream projects, with no
  configuration in `.rubocop.yml`, and then they never run because all
  cops are disabled unless explicitly enabled or otherwise configured
  with `Include`/`Exclude`.

- This change is a follow-up to the great conversations had in
  https://github.com/github/rubocop-github/pull/117, and makes this gem
  take a more neutral stance to match whatever RuboCop's defaults are
  for enabling (or not) cops. Then it's up to the maintainers of this
  gem and the deciders of our styleguide to pick the settings for the
  rules to include, and/or it's up to the downstream consumers of this
  gem to decide whether they want all the rules or just some of the rules
  as they are defined in here.
---
 config/default.yml | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/config/default.yml b/config/default.yml
index 67af72a5..f04a02b8 100644
--- a/config/default.yml
+++ b/config/default.yml
@@ -2,9 +2,6 @@ require:
   - rubocop/cop/github
   - rubocop-performance
 
-AllCops:
-  DisabledByDefault: true
-
 Bundler/DuplicatedGem:
   Enabled: true
 

From 7df97a71204a8bf09eb97f87818b5fc90de09e4f Mon Sep 17 00:00:00 2001
From: Issy Long <issyl0@github.com>
Date: Mon, 10 Oct 2022 19:32:03 +0000
Subject: [PATCH 29/47] rubocop.yml: Disable some cops locally that aren't in
 the styleguide

- This config applies only to this repo, it's not the global config.
---
 .rubocop.yml | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/.rubocop.yml b/.rubocop.yml
index 802a6e67..593983b7 100644
--- a/.rubocop.yml
+++ b/.rubocop.yml
@@ -1,6 +1,33 @@
 inherit_from: ./config/default.yml
 
+AllCops:
+  SuggestExtensions: false
+
+Gemspec/RequiredRubyVersion:
+  Enabled: false
+
+Lint/AssignmentInCondition:
+  Enabled: false
+
+Lint/EmptyConditionalBody:
+  Enabled: false
+
+Lint/UselessAssignment:
+  Enabled: false
+
 Naming/FileName:
   Enabled: true
   Exclude:
     - "rubocop-github.gemspec"
+
+Style/Documentation:
+  Enabled: false
+
+Style/GuardClause:
+  Enabled: false
+
+Style/Next:
+  Enabled: false
+
+Style/SoleNestedConditional:
+  Enabled: false

From 53a0a37784c3d95c05edbc3f57023072b00ef607 Mon Sep 17 00:00:00 2001
From: Issy Long <issyl0@github.com>
Date: Mon, 10 Oct 2022 19:32:38 +0000
Subject: [PATCH 30/47] Run `bundle exec rubocop -a` (or `-A`) on all the code
 in this repo

- These rules seemed to make sense and were all autocorrectable:
  - Style/SymbolArray
  - Layout/EmptyLineAfterGuardClause
  - Style/MultipleComparison
  - Style/IfUnlessModifier (since we don't have line length limitations)
  - Style/EmptyCaseCondition
  - Style/TrailingUnderscoreVariable
  - Style/RedundantParentheses
  - Lint/UnusedBlockArgument
  - Style/NegatedIf
  - Style/StringConcatenation
  - Style/SafeNavigation
  - Layout/MultilineMethodCallIndentation
  - Layout/EmptyLineAfterMagicComment
  - Layout/SpaceInsideHashLiteralBraces
  - Layout/EmptyLines
  - Layout/EmptyLineBetweenDefs
---
 Rakefile                                      |  2 +-
 .../cop/github/insecure_hash_algorithm.rb     | 31 +++++++------------
 .../cop/github/rails_application_record.rb    |  6 ++--
 .../rails_controller_render_action_symbol.rb  |  2 +-
 .../github/rails_controller_render_literal.rb | 14 +++------
 .../rails_controller_render_paths_exist.rb    | 14 +++------
 .../rails_controller_render_shorthand.rb      |  4 +--
 lib/rubocop/cop/github/rails_render_inline.rb |  4 +--
 .../github/rails_render_object_collection.rb  |  4 +--
 .../cop/github/rails_view_render_literal.rb   | 10 ++----
 .../github/rails_view_render_paths_exist.rb   | 10 ++----
 .../cop/github/render_literal_helpers.rb      |  2 +-
 test/test_insecure_hash_algorithm.rb          |  2 +-
 test/test_rails_controller_render_literal.rb  |  1 -
 14 files changed, 37 insertions(+), 69 deletions(-)

diff --git a/Rakefile b/Rakefile
index 25e3326b..66dceb34 100644
--- a/Rakefile
+++ b/Rakefile
@@ -4,7 +4,7 @@ require "bundler/gem_tasks"
 require "rake/testtask"
 require "rubocop/rake_task"
 
-task default: [:test, :rubocop]
+task default: %i[test rubocop]
 
 Rake::TestTask.new
 RuboCop::RakeTask.new
diff --git a/lib/rubocop/cop/github/insecure_hash_algorithm.rb b/lib/rubocop/cop/github/insecure_hash_algorithm.rb
index de1b321d..032bc12b 100644
--- a/lib/rubocop/cop/github/insecure_hash_algorithm.rb
+++ b/lib/rubocop/cop/github/insecure_hash_algorithm.rb
@@ -64,6 +64,7 @@ class InsecureHashAlgorithm < Base
 
         def insecure_algorithm?(val)
           return false if val == :Digest # Don't match "Digest::Digest".
+
           case alg_name(val)
           when *allowed_hash_functions
             false
@@ -80,7 +81,7 @@ def not_just_encoding?(val)
         end
 
         def just_encoding?(val)
-          val == :hexencode || val == :bubblebabble
+          %i[hexencode bubblebabble].include?(val)
         end
 
         # Built-in hash functions are listed in these docs:
@@ -99,6 +100,7 @@ def allowed_hash_functions
         def alg_name(val)
           return :nil if val.nil?
           return val.to_s.downcase unless val.is_a?(RuboCop::AST::Node)
+
           case val.type
           when :sym, :str
             val.children.first.to_s.downcase
@@ -108,28 +110,19 @@ def alg_name(val)
         end
 
         def on_const(const_node)
-          if insecure_const?(const_node) && !digest_uuid?(const_node)
-            add_offense(const_node, message: MSG)
-          end
+          add_offense(const_node, message: MSG) if insecure_const?(const_node) && !digest_uuid?(const_node)
         end
 
         def on_send(send_node)
-          case
-          when uuid_v3?(send_node)
-            unless allowed_hash_functions.include?("md5")
-              add_offense(send_node, message: UUID_V3_MSG)
-            end
-          when uuid_v5?(send_node)
-            unless allowed_hash_functions.include?("sha1")
-              add_offense(send_node, message: UUID_V5_MSG)
-            end
-          when openssl_hmac_new?(send_node)
-            if openssl_hmac_new_insecure?(send_node)
-              add_offense(send_node, message: MSG)
-            end
-          when insecure_digest?(send_node)
+          if uuid_v3?(send_node)
+            add_offense(send_node, message: UUID_V3_MSG) unless allowed_hash_functions.include?("md5")
+          elsif uuid_v5?(send_node)
+            add_offense(send_node, message: UUID_V5_MSG) unless allowed_hash_functions.include?("sha1")
+          elsif openssl_hmac_new?(send_node)
+            add_offense(send_node, message: MSG) if openssl_hmac_new_insecure?(send_node)
+          elsif insecure_digest?(send_node)
             add_offense(send_node, message: MSG)
-          when insecure_hash_lookup?(send_node)
+          elsif insecure_hash_lookup?(send_node)
             add_offense(send_node, message: MSG)
           end
         end
diff --git a/lib/rubocop/cop/github/rails_application_record.rb b/lib/rubocop/cop/github/rails_application_record.rb
index 1ec30cf9..cfb19743 100644
--- a/lib/rubocop/cop/github/rails_application_record.rb
+++ b/lib/rubocop/cop/github/rails_application_record.rb
@@ -17,11 +17,9 @@ class RailsApplicationRecord < Base
         PATTERN
 
         def on_class(node)
-          klass, superclass, _ = *node
+          klass, superclass, = *node
 
-          if active_record_base_const?(superclass) && !(application_record_const?(klass))
-            add_offense(superclass)
-          end
+          add_offense(superclass) if active_record_base_const?(superclass) && !application_record_const?(klass)
         end
       end
     end
diff --git a/lib/rubocop/cop/github/rails_controller_render_action_symbol.rb b/lib/rubocop/cop/github/rails_controller_render_action_symbol.rb
index e3d6eca7..86618331 100644
--- a/lib/rubocop/cop/github/rails_controller_render_action_symbol.rb
+++ b/lib/rubocop/cop/github/rails_controller_render_action_symbol.rb
@@ -24,7 +24,7 @@ class RailsControllerRenderActionSymbol < Base
 
         def on_send(node)
           if sym_node = render_sym?(node)
-            add_offense(sym_node) do |corrector|
+            add_offense(sym_node) do |_corrector|
               register_offense(sym_node, node)
             end
           elsif option_pairs = render_with_options?(node)
diff --git a/lib/rubocop/cop/github/rails_controller_render_literal.rb b/lib/rubocop/cop/github/rails_controller_render_literal.rb
index 0f2efd39..edda84d6 100644
--- a/lib/rubocop/cop/github/rails_controller_render_literal.rb
+++ b/lib/rubocop/cop/github/rails_controller_render_literal.rb
@@ -60,12 +60,10 @@ def on_send(node)
           elsif option_pairs = render_with_options?(node)
             option_pairs = option_pairs.reject { |pair| options_key?(pair) }
 
-            if option_pairs.any? { |pair| ignore_key?(pair) }
-              return
-            end
+            return if option_pairs.any? { |pair| ignore_key?(pair) }
 
             if template_node = option_pairs.map { |pair| template_key?(pair) }.compact.first
-              if !literal?(template_node)
+              unless literal?(template_node)
                 add_offense(node)
                 return
               end
@@ -75,7 +73,7 @@ def on_send(node)
             end
 
             if layout_node = option_pairs.map { |pair| layout_key?(pair) }.compact.first
-              if !literal?(layout_node)
+              unless literal?(layout_node)
                 add_offense(node)
                 return
               end
@@ -91,16 +89,14 @@ def on_send(node)
               add_offense(node)
               return
             end
-            option_pairs = option_hash && option_hash.pairs
+            option_pairs = option_hash&.pairs
           else
             option_pairs = node.arguments[0].pairs
           end
 
           if option_pairs
             locals = option_pairs.map { |pair| locals_key?(pair) }.compact.first
-            if locals && (!locals.hash_type? || !hash_with_literal_keys?(locals))
-              add_offense(node)
-            end
+            add_offense(node) if locals && (!locals.hash_type? || !hash_with_literal_keys?(locals))
           end
         end
       end
diff --git a/lib/rubocop/cop/github/rails_controller_render_paths_exist.rb b/lib/rubocop/cop/github/rails_controller_render_paths_exist.rb
index 126738a0..3f84ce2f 100644
--- a/lib/rubocop/cop/github/rails_controller_render_paths_exist.rb
+++ b/lib/rubocop/cop/github/rails_controller_render_paths_exist.rb
@@ -27,22 +27,16 @@ def on_send(node)
 
           if args = render_str?(node)
             node, path = args
-            unless resolve_template(path.to_s)
-              add_offense(node, message: "Template could not be found")
-            end
+            add_offense(node, message: "Template could not be found") unless resolve_template(path.to_s)
           elsif pairs = render_options?(node)
             if pair = pairs.detect { |p| render_key?(p) }
               key, node, path = render_key?(pair)
 
               case key
               when :action, :template
-                unless resolve_template(path.to_s)
-                  add_offense(node, message: "Template could not be found")
-                end
+                add_offense(node, message: "Template could not be found") unless resolve_template(path.to_s)
               when :partial
-                unless resolve_partial(path.to_s)
-                  add_offense(node, message: "Partial template could not be found")
-                end
+                add_offense(node, message: "Partial template could not be found") unless resolve_partial(path.to_s)
               end
             end
           end
@@ -50,7 +44,7 @@ def on_send(node)
 
         def resolve_template(path)
           cop_config["ViewPath"].each do |view_path|
-            if m = Dir[File.join(config.path_relative_to_config(view_path), path) + "*"].first
+            if m = Dir["#{File.join(config.path_relative_to_config(view_path), path)}*"].first
               return m
             end
           end
diff --git a/lib/rubocop/cop/github/rails_controller_render_shorthand.rb b/lib/rubocop/cop/github/rails_controller_render_shorthand.rb
index 58069e10..ae62f71b 100644
--- a/lib/rubocop/cop/github/rails_controller_render_shorthand.rb
+++ b/lib/rubocop/cop/github/rails_controller_render_shorthand.rb
@@ -28,8 +28,8 @@ def on_send(node)
               if value_node = action_key?(pair)
                 comma = option_pairs.length > 1 ? ", " : ""
                 corrected_source = node.source
-                  .sub(/#{pair.source}(,\s*)?/, "")
-                  .sub("render ", "render \"#{str(value_node)}\"#{comma}")
+                                       .sub(/#{pair.source}(,\s*)?/, "")
+                                       .sub("render ", "render \"#{str(value_node)}\"#{comma}")
 
                 add_offense(node, message: "Use `#{corrected_source}` instead") do |corrector|
                   corrector.replace(node.source_range, corrected_source)
diff --git a/lib/rubocop/cop/github/rails_render_inline.rb b/lib/rubocop/cop/github/rails_render_inline.rb
index 8f76fb2f..65c8fb5e 100644
--- a/lib/rubocop/cop/github/rails_render_inline.rb
+++ b/lib/rubocop/cop/github/rails_render_inline.rb
@@ -18,9 +18,7 @@ class RailsRenderInline < Base
 
         def on_send(node)
           if option_pairs = render_with_options?(node)
-            if option_pairs.detect { |pair| inline_key?(pair) }
-              add_offense(node)
-            end
+            add_offense(node) if option_pairs.detect { |pair| inline_key?(pair) }
           end
         end
       end
diff --git a/lib/rubocop/cop/github/rails_render_object_collection.rb b/lib/rubocop/cop/github/rails_render_object_collection.rb
index 38a27fa5..b5a13b53 100644
--- a/lib/rubocop/cop/github/rails_render_object_collection.rb
+++ b/lib/rubocop/cop/github/rails_render_object_collection.rb
@@ -31,9 +31,7 @@ def on_send(node)
 
               case object_sym
               when :object
-                if partial_name.children[0].is_a?(String)
-                  suggestion = ", instead `render partial: #{partial_name.source}, locals: { #{File.basename(partial_name.children[0], '.html.erb')}: #{object_node.source} }`"
-                end
+                suggestion = ", instead `render partial: #{partial_name.source}, locals: { #{File.basename(partial_name.children[0], '.html.erb')}: #{object_node.source} }`" if partial_name.children[0].is_a?(String)
                 add_offense(node, message: "Avoid `render object:`#{suggestion}")
               when :collection, :spacer_template
                 add_offense(node, message: "Avoid `render collection:`")
diff --git a/lib/rubocop/cop/github/rails_view_render_literal.rb b/lib/rubocop/cop/github/rails_view_render_literal.rb
index c8563868..d3070d39 100644
--- a/lib/rubocop/cop/github/rails_view_render_literal.rb
+++ b/lib/rubocop/cop/github/rails_view_render_literal.rb
@@ -34,12 +34,10 @@ def on_send(node)
 
           if render_literal?(node)
           elsif option_pairs = render_with_options?(node)
-            if option_pairs.any? { |pair| ignore_key?(pair) }
-              return
-            end
+            return if option_pairs.any? { |pair| ignore_key?(pair) }
 
             if partial_node = option_pairs.map { |pair| partial_key?(pair) }.compact.first
-              if !literal?(partial_node)
+              unless literal?(partial_node)
                 add_offense(node)
                 return
               end
@@ -60,9 +58,7 @@ def on_send(node)
 
           if locals
             if locals.hash_type?
-              if !hash_with_literal_keys?(locals)
-                add_offense(node)
-              end
+              add_offense(node) unless hash_with_literal_keys?(locals)
             else
               add_offense(node)
             end
diff --git a/lib/rubocop/cop/github/rails_view_render_paths_exist.rb b/lib/rubocop/cop/github/rails_view_render_paths_exist.rb
index 49a40f2c..64234167 100644
--- a/lib/rubocop/cop/github/rails_view_render_paths_exist.rb
+++ b/lib/rubocop/cop/github/rails_view_render_paths_exist.rb
@@ -27,16 +27,12 @@ def on_send(node)
 
           if args = render_str?(node)
             node, path = args
-            unless resolve_partial(path.to_s)
-              add_offense(node, message: "Partial template could not be found")
-            end
+            add_offense(node, message: "Partial template could not be found") unless resolve_partial(path.to_s)
           elsif pairs = render_options?(node)
             if pair = pairs.detect { |p| partial_key?(p) }
               node, path = partial_key?(pair)
 
-              unless resolve_partial(path.to_s)
-                add_offense(node, message: "Partial template could not be found")
-              end
+              add_offense(node, message: "Partial template could not be found") unless resolve_partial(path.to_s)
             end
           end
         end
@@ -47,7 +43,7 @@ def resolve_partial(path)
           path = parts.join(File::SEPARATOR)
 
           cop_config["ViewPath"].each do |view_path|
-            if m = Dir[File.join(config.path_relative_to_config(view_path), path) + "*"].first
+            if m = Dir["#{File.join(config.path_relative_to_config(view_path), path)}*"].first
               return m
             end
           end
diff --git a/lib/rubocop/cop/github/render_literal_helpers.rb b/lib/rubocop/cop/github/render_literal_helpers.rb
index 67417a54..6994fb79 100644
--- a/lib/rubocop/cop/github/render_literal_helpers.rb
+++ b/lib/rubocop/cop/github/render_literal_helpers.rb
@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-#
+
 require "rubocop"
 
 module RuboCop
diff --git a/test/test_insecure_hash_algorithm.rb b/test/test_insecure_hash_algorithm.rb
index 597450b8..3e48aa90 100644
--- a/test/test_insecure_hash_algorithm.rb
+++ b/test/test_insecure_hash_algorithm.rb
@@ -10,7 +10,7 @@ def cop_class
   end
 
   def make_cop(allowed:)
-    config = RuboCop::Config.new({"GitHub/InsecureHashAlgorithm" => {"Allowed" => allowed}})
+    config = RuboCop::Config.new({ "GitHub/InsecureHashAlgorithm" => { "Allowed" => allowed } })
     cop_class.new(config)
   end
 
diff --git a/test/test_rails_controller_render_literal.rb b/test/test_rails_controller_render_literal.rb
index 9da2f16c..bd52c7f1 100644
--- a/test/test_rails_controller_render_literal.rb
+++ b/test/test_rails_controller_render_literal.rb
@@ -442,7 +442,6 @@ def index
     assert_equal 1, offenses.count
   end
 
-
   def test_render_literal_dynamic_local_key_offense
     offenses = investigate cop, <<-RUBY, "app/controllers/products_controller.rb"
       class ProductsController < ActionController::Base

From e36d683f6b85e7394775a02d9f6321f2cf34b4b5 Mon Sep 17 00:00:00 2001
From: Issy Long <issyl0@github.com>
Date: Mon, 10 Oct 2022 19:41:45 +0000
Subject: [PATCH 31/47] Fix `Naming/MemoizedInstanceVariableName` offenses

---
 lib/rubocop/cop/github/insecure_hash_algorithm.rb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/rubocop/cop/github/insecure_hash_algorithm.rb b/lib/rubocop/cop/github/insecure_hash_algorithm.rb
index 032bc12b..e9fb3309 100644
--- a/lib/rubocop/cop/github/insecure_hash_algorithm.rb
+++ b/lib/rubocop/cop/github/insecure_hash_algorithm.rb
@@ -94,7 +94,7 @@ def just_encoding?(val)
         ].freeze
 
         def allowed_hash_functions
-          @allowed_algorithms ||= cop_config.fetch("Allowed", DEFAULT_ALLOWED).map(&:downcase)
+          @allowed_hash_functions ||= cop_config.fetch("Allowed", DEFAULT_ALLOWED).map(&:downcase)
         end
 
         def alg_name(val)

From a899fa276edf38e3ce20c5c59a61002b697d82f5 Mon Sep 17 00:00:00 2001
From: Issy Long <issyl0@github.com>
Date: Tue, 11 Oct 2022 16:04:26 +0000
Subject: [PATCH 32/47] README, guides: Clean up leftover
 `GitHub/Accessibility` cop references

- My changes in https://github.com/github/rubocop-github/pull/118 didn't
  quite go far enough.
---
 README.md                        |  2 +-
 guides/image-has-alt.md          | 29 -----------------------------
 guides/link-has-href.md          | 29 -----------------------------
 guides/no-positive-tabindex.md   | 24 ------------------------
 guides/no-redundant-image-alt.md | 24 ------------------------
 5 files changed, 1 insertion(+), 107 deletions(-)
 delete mode 100644 guides/image-has-alt.md
 delete mode 100644 guides/link-has-href.md
 delete mode 100644 guides/no-positive-tabindex.md
 delete mode 100644 guides/no-redundant-image-alt.md

diff --git a/README.md b/README.md
index b5fb2ad4..da686741 100644
--- a/README.md
+++ b/README.md
@@ -37,4 +37,4 @@ bundle exec rake test
 
 ## The Cops
 
-All cops are located under [`lib/rubocop/cop/github`](lib/rubocop/cop/github) and [`lib/rubocop/cop/github/accessibility`](lib/rubocop/cop/github/accessibility), and contain examples/documentation.
+All cops are located under [`lib/rubocop/cop/github`](lib/rubocop/cop/github).
diff --git a/guides/image-has-alt.md b/guides/image-has-alt.md
deleted file mode 100644
index a761dba6..00000000
--- a/guides/image-has-alt.md
+++ /dev/null
@@ -1,29 +0,0 @@
-# GitHub/Accessibility/ImageHasAlt
-
-## Rule Details
-
-Images should have an alt prop with meaningful text or an empty string for decorative images.
-
-## Resources
-
-- [W3C WAI Images Tutorial](https://www.w3.org/WAI/tutorials/images/)
-- [Primer: Alternative text for images](https://primer.style/design/accessibility/alternative-text-for-images)
-
-## Examples
-### **Incorrect** code for this rule 👎
-
-```erb
-<%= image_tag "spinners/octocat-spinner-16px.gif", size: "12x12" %>
-```
-
-### **Correct** code for this rule  👍
-
-```erb
-<!-- good -->
-<%= image_tag "spinners/octocat-spinner-16px.gif", size: "12x12", alt: "GitHub Logo spinner" %>
-```
-
-```erb
-<!-- also good -->
-<%= image_tag "spinners/octocat-spinner-16px.gif", size: "12x12", alt: "" %>
-```
\ No newline at end of file
diff --git a/guides/link-has-href.md b/guides/link-has-href.md
deleted file mode 100644
index 8a574c94..00000000
--- a/guides/link-has-href.md
+++ /dev/null
@@ -1,29 +0,0 @@
-# GitHub/Accessibility/LinkHasHref
-
-## Rule Details
-
-Links should go somewhere, you probably want to use a `<button>` instead.
-
-## Resources
-
-- [`<a>`: The Anchor element](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/a)
-- [Primer: Links](https://primer.style/design/accessibility/links)
-- [HTML Spec: The a element](https://html.spec.whatwg.org/multipage/text-level-semantics.html#the-a-element)
-
-## Examples
-### **Incorrect** code for this rule 👎
-
-```erb
-<%= link_to 'Go to GitHub' %>
-```
-
-```erb
-<%= link_to 'Go to GitHub', '#' %>
-```
-
-### **Correct** code for this rule  👍
-
-```erb
-<!-- good -->
-<%= link_to 'Go to GitHub', 'https://github.com/' %>
-```
diff --git a/guides/no-positive-tabindex.md b/guides/no-positive-tabindex.md
deleted file mode 100644
index e51af7d8..00000000
--- a/guides/no-positive-tabindex.md
+++ /dev/null
@@ -1,24 +0,0 @@
-# GitHub/Accessibility/NoPositiveTabindex
-
-## Rule Details
-
-Positive tabindex is error-prone and often inaccessible.
-
-## Resources
-
-- [F44: Failure of Success Criterion 2.4.3 due to using tabindex to create a tab order that does not preserve meaning and operability](https://www.w3.org/TR/WCAG20-TECHS/F44.html)
-- [Deque University: Avoid Using Tabindex with Positive Numbers](https://dequeuniversity.com/tips/tabindex-positive-numbers)
-
-## Examples
-### **Incorrect** code for this rule 👎
-
-```erb
-<%= button_tag "Continue", :tabindex => 3 %>
-```
-
-### **Correct** code for this rule  👍
-
-```erb
-<!-- good -->
-<%= button_tag "Continue", :tabindex => -1 %>
-```
diff --git a/guides/no-redundant-image-alt.md b/guides/no-redundant-image-alt.md
deleted file mode 100644
index 2e4fad7f..00000000
--- a/guides/no-redundant-image-alt.md
+++ /dev/null
@@ -1,24 +0,0 @@
-# GitHub/Accessibility/NoRedundantImageAlt
-
-## Rule Details
-
-Alt prop should not contain `image` or `picture` as screen readers already announce the element as an image
-
-## Resources
-
-- [W3C WAI Images Tutorial](https://www.w3.org/WAI/tutorials/images/)
-- [Primer: Alternative text for images](https://primer.style/design/accessibility/alternative-text-for-images)
-
-## Examples
-### **Incorrect** code for this rule 👎
-
-```erb
-<%= image_tag "cat.gif", size: "12x12", alt: "Picture of a cat" %>
-```
-
-### **Correct** code for this rule  👍
-
-```erb
-<!-- good -->
-<%= image_tag "cat.gif", size: "12x12", alt: "A black cat" %>
-```

From ee3cac872c022eb36fdb603d0a0139c5e594f09f Mon Sep 17 00:00:00 2001
From: Issy Long <issyl0@github.com>
Date: Tue, 11 Oct 2022 16:18:48 +0000
Subject: [PATCH 33/47] README: Note that `DisabledByDefault: true` is useful
 for granularity

- Now that this behaviour has changed in `rubocop-github`, our users
  might want to have finer-grained control of which cops they enable
  since they can't rely on this gem to include that option now (if they
  even noticed).
---
 README.md | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/README.md b/README.md
index b5fb2ad4..800d0b0a 100644
--- a/README.md
+++ b/README.md
@@ -23,6 +23,8 @@ inherit_gem:
 
 💭 Looking for `config/accessibility.yml` and the `GitHub/Accessibility` configs? They have been moved to [a new gem](https://github.com/github/rubocop-rails-accessibility).
 
+For more granular control over which of RuboCop's rules are enabled for your project, both from this gem and your own configs, consider using the `DisabledByDefault: true` option under `AllCops` in your project's `.rubocop.yml` file. This will disable all cops by default, and you can then explicitly enable the ones you want by setting `Enabled: true`. See [the RuboCop docs](https://docs.rubocop.org/rubocop/configuration.html#enabled) for more information.
+
 ### Legacy usage
 
 If you are using a rubocop version < 1.0.0, you can use rubocop-github version

From db3b3380e26a90ba8f22194dd62861bcdfcef433 Mon Sep 17 00:00:00 2001
From: Issy Long <issyl0@github.com>
Date: Tue, 11 Oct 2022 16:26:19 +0000
Subject: [PATCH 34/47] CHANGELOG: Add an 'unreleased' section

- Should probably write about the recent accessibility gem changes here, too, but that's not in this PR. Hence a generic 'unreleased' section.
---
 CHANGELOG.md | 5 +++++
 1 file changed, 5 insertions(+)
 create mode 100644 CHANGELOG.md

diff --git a/CHANGELOG.md b/CHANGELOG.md
new file mode 100644
index 00000000..c42df4d3
--- /dev/null
+++ b/CHANGELOG.md
@@ -0,0 +1,5 @@
+# rubocop-github
+
+## Unreleased
+
+- Unset `DisabledByDefault: true` in `config/default.yml`. This will use RuboCop's choice of default cops to enable, plus our existing augmentations in `config/default.yml`. Prevents confusing behaviour where downstream consumers didn't realise that RuboCop's default cops weren't being applied. (https://github.com/github/rubocop-github/pull/119)

From f40758f26ce54c86bc4d7588383f7a514d3be7b4 Mon Sep 17 00:00:00 2001
From: Issy Long <issyl0@github.com>
Date: Tue, 11 Oct 2022 17:31:04 +0000
Subject: [PATCH 35/47] config/default: Explicitly set `Enabled: false` for a
 bunch of rules

- These rules come directly from RuboCop. They're configured `Enabled: false`
  upstream, but it's worth being explicit in this gem since this guards
  against RuboCop changing underneath us and causing linting changes that
  either don't match our styleguide or we don't want to propagate to
  users of this gem.
- This was generated by the following script (thanks to `@matthewd`),
  where `show-cops.yml` is the output of
  `bundle exec rubocop --show-cops`:

```ruby
require "yaml"
y = YAML.unsafe_load_file("show-cops.yml")
cfg = YAML.unsafe_load_file(".rubocop.yml")
off = y.keys.select { |k| y[k]["Enabled"] == false }
(off - cfg.keys).sort.each { |k| puts "#{k}:\n  Enabled: false\n\n" }
```

- Next I'll do the same for `Enabled: true`, then in a follow-up commit
  or PR (probably PR, at this point) I'll go through and link the
  `Enabled: true` ones to their styleguide items in the GitHub styleguide.
---
 config/default.yml | 147 +++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 147 insertions(+)

diff --git a/config/default.yml b/config/default.yml
index f04a02b8..603e1815 100644
--- a/config/default.yml
+++ b/config/default.yml
@@ -5,9 +5,18 @@ require:
 Bundler/DuplicatedGem:
   Enabled: true
 
+Bundler/GemComment:
+  Enabled: false
+
+Bundler/GemVersion:
+  Enabled: false
+
 Bundler/OrderedGems:
   Enabled: true
 
+Gemspec/DependencyVersion:
+  Enabled: false
+
 GitHub/InsecureHashAlgorithm:
   Enabled: true
 
@@ -17,18 +26,39 @@ Layout/BlockAlignment:
 Layout/BlockEndNewline:
   Enabled: true
 
+Layout/ClassStructure:
+  Enabled: false
+
 Layout/ConditionPosition:
   Enabled: true
 
 Layout/DefEndAlignment:
   Enabled: true
 
+Layout/EmptyLineAfterMultilineCondition:
+  Enabled: false
+
 Layout/EndAlignment:
   Enabled: false
 
 Layout/EndOfLine:
   Enabled: true
 
+Layout/FirstArrayElementLineBreak:
+  Enabled: false
+
+Layout/FirstHashElementLineBreak:
+  Enabled: false
+
+Layout/FirstMethodArgumentLineBreak:
+  Enabled: false
+
+Layout/FirstMethodParameterLineBreak:
+  Enabled: false
+
+Layout/HeredocArgumentClosingParenthesis:
+  Enabled: false
+
 Layout/IndentationStyle:
   Enabled: true
   EnforcedStyle: spaces
@@ -44,6 +74,24 @@ Layout/InitialIndentation:
 Layout/LineLength:
   Enabled: false
 
+Layout/MultilineArrayLineBreaks:
+  Enabled: false
+
+Layout/MultilineAssignmentLayout:
+  Enabled: false
+
+Layout/MultilineHashKeyLineBreaks:
+  Enabled: false
+
+Layout/MultilineMethodArgumentLineBreaks:
+  Enabled: false
+
+Layout/RedundantLineBreak:
+  Enabled: false
+
+Layout/SingleLineBlockChain:
+  Enabled: false
+
 Layout/SpaceAfterColon:
   Enabled: true
 
@@ -96,6 +144,9 @@ Layout/TrailingWhitespace:
 Lint/CircularArgumentReference:
   Enabled: true
 
+Lint/ConstantResolution:
+  Enabled: false
+
 Lint/Debugger:
   Enabled: true
 
@@ -132,6 +183,9 @@ Lint/FloatOutOfRange:
 Lint/FormatParameterMismatch:
   Enabled: true
 
+Lint/HeredocMethodCallPosition:
+  Enabled: false
+
 Lint/LiteralAsCondition:
   Enabled: true
 
@@ -144,6 +198,9 @@ Lint/Loop:
 Lint/NextWithoutAccumulator:
   Enabled: true
 
+Lint/NumberConversion:
+  Enabled: false
+
 Lint/RandOne:
   Enabled: true
 
@@ -213,12 +270,21 @@ Naming/ClassAndModuleCamelCase:
 Naming/FileName:
   Enabled: true
 
+Naming/InclusiveLanguage:
+  Enabled: false
+
 Naming/MethodName:
   Enabled: true
 
+Performance/ArraySemiInfiniteRangeSlice:
+  Enabled: false
+
 Performance/CaseWhenSplat:
   Enabled: false
 
+Performance/ChainArrayAllocation:
+  Enabled: false
+
 Performance/Count:
   Enabled: true
 
@@ -234,6 +300,9 @@ Performance/EndWith:
 Performance/FlatMap:
   Enabled: true
 
+Performance/OpenStruct:
+  Enabled: false
+
 Performance/RangeInclude:
   Enabled: false
 
@@ -247,6 +316,9 @@ Performance/RedundantMerge:
 Performance/ReverseEach:
   Enabled: true
 
+Performance/SelectMap:
+  Enabled: false
+
 Performance/Size:
   Enabled: true
 
@@ -256,9 +328,18 @@ Performance/StartWith:
 Security/Eval:
   Enabled: true
 
+Style/ArrayCoercion:
+  Enabled: false
+
 Style/ArrayJoin:
   Enabled: true
 
+Style/AsciiComments:
+  Enabled: false
+
+Style/AutoResourceCleanup:
+  Enabled: false
+
 Style/BeginBlock:
   Enabled: true
 
@@ -274,12 +355,33 @@ Style/CharacterLiteral:
 Style/ClassMethods:
   Enabled: true
 
+Style/ClassMethodsDefinitions:
+  Enabled: false
+
+Style/CollectionMethods:
+  Enabled: false
+
+Style/ConstantVisibility:
+  Enabled: false
+
 Style/Copyright:
   Enabled: false
 
+Style/DateTime:
+  Enabled: false
+
 Style/DefWithParentheses:
   Enabled: true
 
+Style/DisableCopsWithinSourceCodeDirective:
+  Enabled: false
+
+Style/Documentation:
+  Enabled: false
+
+Style/DocumentationMethod:
+  Enabled: false
+
 Style/EndBlock:
   Enabled: true
 
@@ -289,6 +391,15 @@ Style/For:
 Style/FrozenStringLiteralComment:
   Enabled: true
 
+Style/ImplicitRuntimeError:
+  Enabled: false
+
+Style/InlineComment:
+  Enabled: false
+
+Style/IpAddresses:
+  Enabled: false
+
 Style/HashSyntax:
   Enabled: true
   EnforcedStyle: ruby19_no_mixed_keys
@@ -296,15 +407,24 @@ Style/HashSyntax:
 Style/LambdaCall:
   Enabled: true
 
+Style/MethodCalledOnDoEndBlock:
+  Enabled: false
+
 Style/MethodCallWithoutArgsParentheses:
   Enabled: true
 
 Style/MethodDefParentheses:
   Enabled: true
 
+Style/MissingElse:
+  Enabled: false
+
 Style/MultilineIfThen:
   Enabled: true
 
+Style/MultilineMethodSignature:
+  Enabled: false
+
 Style/NilComparison:
   Enabled: true
 
@@ -314,18 +434,45 @@ Style/Not:
 Style/OneLineConditional:
   Enabled: true
 
+Style/OptionHash:
+  Enabled: false
+
 Style/RedundantSortBy:
   Enabled: true
 
+Style/ReturnNil:
+  Enabled: false
+
 Style/Sample:
   Enabled: true
 
+Style/SingleLineBlockParams:
+  Enabled: false
+
 Style/StabbyLambdaParentheses:
   Enabled: true
 
+Style/StaticClass:
+  Enabled: false
+
 Style/Strip:
   Enabled: true
 
+Style/StringHashKeys:
+  Enabled: false
+
 Style/StringLiterals:
   Enabled: true
   EnforcedStyle: double_quotes
+
+Style/StringMethods:
+  Enabled: false
+
+Style/TopLevelMethodDefinition:
+  Enabled: false
+
+Style/TrailingCommaInBlockArgs:
+  Enabled: false
+
+Style/UnlessLogicalOperators:
+  Enabled: false

From 05e82768e5bff3380276d5b2cb7d59a85ddfd6ca Mon Sep 17 00:00:00 2001
From: Issy Long <issyl0@github.com>
Date: Tue, 11 Oct 2022 17:44:17 +0000
Subject: [PATCH 36/47] config/default: Add `Enabled: true` cops now configured
 by default

- Previously these were disabled because of `DisableByDefault: true`.
  Since we removed that config, all of these become enabled. That's
  somewhat undesirable since when we ship the new version, downstream
  consumers of this gem will have to make decisions to enable or disable
  the cops. We should do this for them and make this gem the source of
  truth matching the styleguide as far as possible. Of course, downstream
  projects are free to tweak in their own `.rubocop.yml` for what matches
  their project style, but we should attempt to set a central standard
  according to the styleguide that we publish, to make writing Ruby at
  GitHub easier.

- I left some TODOs to audit these (before we ship the new gem version!)
  for whether or not they:
  - a) already exist in the file in either enabled/disabled state;
  - b) checking if the GitHub Ruby styleguide has opinions on them and enabling/disabling accordingly.

- This list was (as in the previous commit) generated by:

```ruby
require "yaml"
y = YAML.unsafe_load_file("show-cops.yml")
cfg = YAML.unsafe_load_file(".rubocop.yml")
on = y.keys.select { |k| y[k]["Enabled"] == true }
(on - cfg.keys).sort.each { |k| puts "#{k}:\n  Enabled: true\n\n" }
```
---
 config/default.yml | 1230 ++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 1230 insertions(+)

diff --git a/config/default.yml b/config/default.yml
index 603e1815..8cc171b5 100644
--- a/config/default.yml
+++ b/config/default.yml
@@ -476,3 +476,1233 @@ Style/TrailingCommaInBlockArgs:
 
 Style/UnlessLogicalOperators:
   Enabled: false
+
+# TODO: Check if the following cops are in the GitHub Ruby styleguide; disable them if not.
+# TODO: Add `StyleGuide` links for cops that are in the GitHub Ruby styleguide.
+# TODO: It would be good to run an alphabetization script over these, to put them
+# in the right places in this file. Also there are probably duplicates for rules
+# that we already had enabled/disabled previously.
+
+Bundler/DuplicatedGem:
+  Enabled: true
+
+Bundler/GemFilename:
+  Enabled: true
+
+Bundler/InsecureProtocolSource:
+  Enabled: true
+
+Bundler/OrderedGems:
+  Enabled: true
+
+Gemspec/DuplicatedAssignment:
+  Enabled: true
+
+Gemspec/OrderedDependencies:
+  Enabled: true
+
+Gemspec/RubyVersionGlobalsUsage:
+  Enabled: true
+
+GitHub/InsecureHashAlgorithm:
+  Enabled: true
+
+GitHub/RailsApplicationRecord:
+  Enabled: true
+
+GitHub/RailsControllerRenderActionSymbol:
+  Enabled: true
+
+GitHub/RailsControllerRenderLiteral:
+  Enabled: true
+
+GitHub/RailsControllerRenderPathsExist:
+  Enabled: true
+
+GitHub/RailsControllerRenderShorthand:
+  Enabled: true
+
+GitHub/RailsRenderInline:
+  Enabled: true
+
+GitHub/RailsRenderObjectCollection:
+  Enabled: true
+
+GitHub/RailsViewRenderLiteral:
+  Enabled: true
+
+GitHub/RailsViewRenderPathsExist:
+  Enabled: true
+
+GitHub/RailsViewRenderShorthand:
+  Enabled: true
+
+Layout/AccessModifierIndentation:
+  Enabled: true
+
+Layout/ArgumentAlignment:
+  Enabled: true
+
+Layout/ArrayAlignment:
+  Enabled: true
+
+Layout/AssignmentIndentation:
+  Enabled: true
+
+Layout/BeginEndAlignment:
+  Enabled: true
+
+Layout/BlockAlignment:
+  Enabled: true
+
+Layout/BlockEndNewline:
+  Enabled: true
+
+Layout/CaseIndentation:
+  Enabled: true
+
+Layout/ClosingHeredocIndentation:
+  Enabled: true
+
+Layout/ClosingParenthesisIndentation:
+  Enabled: true
+
+Layout/CommentIndentation:
+  Enabled: true
+
+Layout/ConditionPosition:
+  Enabled: true
+
+Layout/DefEndAlignment:
+  Enabled: true
+
+Layout/DotPosition:
+  Enabled: true
+
+Layout/ElseAlignment:
+  Enabled: true
+
+Layout/EmptyComment:
+  Enabled: true
+
+Layout/EmptyLineAfterGuardClause:
+  Enabled: true
+
+Layout/EmptyLineAfterMagicComment:
+  Enabled: true
+
+Layout/EmptyLineBetweenDefs:
+  Enabled: true
+
+Layout/EmptyLines:
+  Enabled: true
+
+Layout/EmptyLinesAroundAccessModifier:
+  Enabled: true
+
+Layout/EmptyLinesAroundArguments:
+  Enabled: true
+
+Layout/EmptyLinesAroundAttributeAccessor:
+  Enabled: true
+
+Layout/EmptyLinesAroundBeginBody:
+  Enabled: true
+
+Layout/EmptyLinesAroundBlockBody:
+  Enabled: true
+
+Layout/EmptyLinesAroundClassBody:
+  Enabled: true
+
+Layout/EmptyLinesAroundExceptionHandlingKeywords:
+  Enabled: true
+
+Layout/EmptyLinesAroundMethodBody:
+  Enabled: true
+
+Layout/EmptyLinesAroundModuleBody:
+  Enabled: true
+
+Layout/EndOfLine:
+  Enabled: true
+
+Layout/ExtraSpacing:
+  Enabled: true
+
+Layout/FirstArgumentIndentation:
+  Enabled: true
+
+Layout/FirstArrayElementIndentation:
+  Enabled: true
+
+Layout/FirstHashElementIndentation:
+  Enabled: true
+
+Layout/FirstParameterIndentation:
+  Enabled: true
+
+Layout/HashAlignment:
+  Enabled: true
+
+Layout/HeredocIndentation:
+  Enabled: true
+
+Layout/IndentationConsistency:
+  Enabled: true
+
+Layout/IndentationStyle:
+  Enabled: true
+
+Layout/IndentationWidth:
+  Enabled: true
+
+Layout/InitialIndentation:
+  Enabled: true
+
+Layout/LeadingCommentSpace:
+  Enabled: true
+
+Layout/LeadingEmptyLines:
+  Enabled: true
+
+Layout/MultilineArrayBraceLayout:
+  Enabled: true
+
+Layout/MultilineBlockLayout:
+  Enabled: true
+
+Layout/MultilineHashBraceLayout:
+  Enabled: true
+
+Layout/MultilineMethodCallBraceLayout:
+  Enabled: true
+
+Layout/MultilineMethodCallIndentation:
+  Enabled: true
+
+Layout/MultilineMethodDefinitionBraceLayout:
+  Enabled: true
+
+Layout/MultilineOperationIndentation:
+  Enabled: true
+
+Layout/ParameterAlignment:
+  Enabled: true
+
+Layout/RescueEnsureAlignment:
+  Enabled: true
+
+Layout/SpaceAfterColon:
+  Enabled: true
+
+Layout/SpaceAfterComma:
+  Enabled: true
+
+Layout/SpaceAfterMethodName:
+  Enabled: true
+
+Layout/SpaceAfterNot:
+  Enabled: true
+
+Layout/SpaceAfterSemicolon:
+  Enabled: true
+
+Layout/SpaceAroundBlockParameters:
+  Enabled: true
+
+Layout/SpaceAroundEqualsInParameterDefault:
+  Enabled: true
+
+Layout/SpaceAroundKeyword:
+  Enabled: true
+
+Layout/SpaceAroundMethodCallOperator:
+  Enabled: true
+
+Layout/SpaceAroundOperators:
+  Enabled: true
+
+Layout/SpaceBeforeBlockBraces:
+  Enabled: true
+
+Layout/SpaceBeforeComma:
+  Enabled: true
+
+Layout/SpaceBeforeComment:
+  Enabled: true
+
+Layout/SpaceBeforeFirstArg:
+  Enabled: true
+
+Layout/SpaceBeforeSemicolon:
+  Enabled: true
+
+Layout/SpaceInLambdaLiteral:
+  Enabled: true
+
+Layout/SpaceInsideArrayLiteralBrackets:
+  Enabled: true
+
+Layout/SpaceInsideArrayPercentLiteral:
+  Enabled: true
+
+Layout/SpaceInsideBlockBraces:
+  Enabled: true
+
+Layout/SpaceInsideHashLiteralBraces:
+  Enabled: true
+
+Layout/SpaceInsideParens:
+  Enabled: true
+
+Layout/SpaceInsidePercentLiteralDelimiters:
+  Enabled: true
+
+Layout/SpaceInsideRangeLiteral:
+  Enabled: true
+
+Layout/SpaceInsideReferenceBrackets:
+  Enabled: true
+
+Layout/SpaceInsideStringInterpolation:
+  Enabled: true
+
+Layout/TrailingEmptyLines:
+  Enabled: true
+
+Layout/TrailingWhitespace:
+  Enabled: true
+
+Lint/AmbiguousBlockAssociation:
+  Enabled: true
+
+Lint/AmbiguousOperator:
+  Enabled: true
+
+Lint/AmbiguousRegexpLiteral:
+  Enabled: true
+
+Lint/BigDecimalNew:
+  Enabled: true
+
+Lint/BinaryOperatorWithIdenticalOperands:
+  Enabled: true
+
+Lint/BooleanSymbol:
+  Enabled: true
+
+Lint/CircularArgumentReference:
+  Enabled: true
+
+Lint/ConstantDefinitionInBlock:
+  Enabled: true
+
+Lint/Debugger:
+  Enabled: true
+
+Lint/DeprecatedClassMethods:
+  Enabled: true
+
+Lint/DeprecatedOpenSSLConstant:
+  Enabled: true
+
+Lint/DisjunctiveAssignmentInConstructor:
+  Enabled: true
+
+Lint/DuplicateCaseCondition:
+  Enabled: true
+
+Lint/DuplicateElsifCondition:
+  Enabled: true
+
+Lint/DuplicateHashKey:
+  Enabled: true
+
+Lint/DuplicateMethods:
+  Enabled: true
+
+Lint/DuplicateRequire:
+  Enabled: true
+
+Lint/DuplicateRescueException:
+  Enabled: true
+
+Lint/EachWithObjectArgument:
+  Enabled: true
+
+Lint/ElseLayout:
+  Enabled: true
+
+Lint/EmptyEnsure:
+  Enabled: true
+
+Lint/EmptyExpression:
+  Enabled: true
+
+Lint/EmptyFile:
+  Enabled: true
+
+Lint/EmptyInterpolation:
+  Enabled: true
+
+Lint/EmptyWhen:
+  Enabled: true
+
+Lint/EnsureReturn:
+  Enabled: true
+
+Lint/ErbNewArguments:
+  Enabled: true
+
+Lint/FlipFlop:
+  Enabled: true
+
+Lint/FloatComparison:
+  Enabled: true
+
+Lint/FloatOutOfRange:
+  Enabled: true
+
+Lint/FormatParameterMismatch:
+  Enabled: true
+
+Lint/HashCompareByIdentity:
+  Enabled: true
+
+Lint/IdentityComparison:
+  Enabled: true
+
+Lint/ImplicitStringConcatenation:
+  Enabled: true
+
+Lint/IneffectiveAccessModifier:
+  Enabled: true
+
+Lint/InheritException:
+  Enabled: true
+
+Lint/InterpolationCheck:
+  Enabled: true
+
+Lint/LiteralAsCondition:
+  Enabled: true
+
+Lint/LiteralInInterpolation:
+  Enabled: true
+
+Lint/Loop:
+  Enabled: true
+
+Lint/MissingCopEnableDirective:
+  Enabled: true
+
+Lint/MissingSuper:
+  Enabled: true
+
+Lint/MixedRegexpCaptureTypes:
+  Enabled: true
+
+Lint/MultipleComparison:
+  Enabled: true
+
+Lint/NestedMethodDefinition:
+  Enabled: true
+
+Lint/NestedPercentLiteral:
+  Enabled: true
+
+Lint/NextWithoutAccumulator:
+  Enabled: true
+
+Lint/NonDeterministicRequireOrder:
+  Enabled: true
+
+Lint/NonLocalExitFromIterator:
+  Enabled: true
+
+Lint/OrderedMagicComments:
+  Enabled: true
+
+Lint/OutOfRangeRegexpRef:
+  Enabled: true
+
+Lint/ParenthesesAsGroupedExpression:
+  Enabled: true
+
+Lint/PercentStringArray:
+  Enabled: true
+
+Lint/PercentSymbolArray:
+  Enabled: true
+
+Lint/RaiseException:
+  Enabled: true
+
+Lint/RandOne:
+  Enabled: true
+
+Lint/RedundantCopDisableDirective:
+  Enabled: true
+
+Lint/RedundantCopEnableDirective:
+  Enabled: true
+
+Lint/RedundantRequireStatement:
+  Enabled: true
+
+Lint/RedundantSafeNavigation:
+  Enabled: true
+
+Lint/RedundantSplatExpansion:
+  Enabled: true
+
+Lint/RedundantStringCoercion:
+  Enabled: true
+
+Lint/RedundantWithIndex:
+  Enabled: true
+
+Lint/RedundantWithObject:
+  Enabled: true
+
+Lint/RegexpAsCondition:
+  Enabled: true
+
+Lint/RequireParentheses:
+  Enabled: true
+
+Lint/RescueException:
+  Enabled: true
+
+Lint/RescueType:
+  Enabled: true
+
+Lint/ReturnInVoidContext:
+  Enabled: true
+
+Lint/SafeNavigationChain:
+  Enabled: true
+
+Lint/SafeNavigationConsistency:
+  Enabled: true
+
+Lint/SafeNavigationWithEmpty:
+  Enabled: true
+
+Lint/ScriptPermission:
+  Enabled: true
+
+Lint/SelfAssignment:
+  Enabled: true
+
+Lint/SendWithMixinArgument:
+  Enabled: true
+
+Lint/ShadowedArgument:
+  Enabled: true
+
+Lint/ShadowedException:
+  Enabled: true
+
+Lint/ShadowingOuterLocalVariable:
+  Enabled: true
+
+Lint/StructNewOverride:
+  Enabled: true
+
+Lint/SuppressedException:
+  Enabled: true
+
+Lint/Syntax:
+  Enabled: true
+
+Lint/ToJSON:
+  Enabled: true
+
+Lint/TopLevelReturnWithArgument:
+  Enabled: true
+
+Lint/TrailingCommaInAttributeDeclaration:
+  Enabled: true
+
+Lint/UnderscorePrefixedVariableName:
+  Enabled: true
+
+Lint/UnifiedInteger:
+  Enabled: true
+
+Lint/UnreachableCode:
+  Enabled: true
+
+Lint/UnreachableLoop:
+  Enabled: true
+
+Lint/UnusedBlockArgument:
+  Enabled: true
+
+Lint/UnusedMethodArgument:
+  Enabled: true
+
+Lint/UriEscapeUnescape:
+  Enabled: true
+
+Lint/UriRegexp:
+  Enabled: true
+
+Lint/UselessAccessModifier:
+  Enabled: true
+
+Lint/UselessElseWithoutRescue:
+  Enabled: true
+
+Lint/UselessMethodDefinition:
+  Enabled: true
+
+Lint/UselessSetterCall:
+  Enabled: true
+
+Lint/UselessTimes:
+  Enabled: true
+
+Lint/Void:
+  Enabled: true
+
+Migration/DepartmentName:
+  Enabled: true
+
+Naming/AccessorMethodName:
+  Enabled: true
+
+Naming/AsciiIdentifiers:
+  Enabled: true
+
+Naming/BinaryOperatorParameterName:
+  Enabled: true
+
+Naming/BlockParameterName:
+  Enabled: true
+
+Naming/ClassAndModuleCamelCase:
+  Enabled: true
+
+Naming/ConstantName:
+  Enabled: true
+
+Naming/HeredocDelimiterCase:
+  Enabled: true
+
+Naming/HeredocDelimiterNaming:
+  Enabled: true
+
+Naming/MemoizedInstanceVariableName:
+  Enabled: true
+
+Naming/MethodName:
+  Enabled: true
+
+Naming/MethodParameterName:
+  Enabled: true
+
+Naming/PredicateName:
+  Enabled: true
+
+Naming/RescuedExceptionsVariableName:
+  Enabled: true
+
+Naming/VariableName:
+  Enabled: true
+
+Naming/VariableNumber:
+  Enabled: true
+
+Performance/BindCall:
+  Enabled: true
+
+Performance/Caller:
+  Enabled: true
+
+Performance/Casecmp:
+  Enabled: true
+
+Performance/CompareWithBlock:
+  Enabled: true
+
+Performance/Count:
+  Enabled: true
+
+Performance/DeletePrefix:
+  Enabled: true
+
+Performance/DeleteSuffix:
+  Enabled: true
+
+Performance/Detect:
+  Enabled: true
+
+Performance/DoubleStartEndWith:
+  Enabled: true
+
+Performance/EndWith:
+  Enabled: true
+
+Performance/FixedSize:
+  Enabled: true
+
+Performance/FlatMap:
+  Enabled: true
+
+Performance/InefficientHashSearch:
+  Enabled: true
+
+Performance/RedundantBlockCall:
+  Enabled: true
+
+Performance/RedundantMerge:
+  Enabled: true
+
+Performance/RegexpMatch:
+  Enabled: true
+
+Performance/ReverseEach:
+  Enabled: true
+
+Performance/Size:
+  Enabled: true
+
+Performance/StartWith:
+  Enabled: true
+
+Performance/StringReplacement:
+  Enabled: true
+
+Performance/TimesMap:
+  Enabled: true
+
+Performance/UnfreezeString:
+  Enabled: true
+
+Performance/UriDefaultParser:
+  Enabled: true
+
+Security/Eval:
+  Enabled: true
+
+Security/JSONLoad:
+  Enabled: true
+
+Security/MarshalLoad:
+  Enabled: true
+
+Security/Open:
+  Enabled: true
+
+Security/YAMLLoad:
+  Enabled: true
+
+Style/AccessModifierDeclarations:
+  Enabled: true
+
+Style/AccessorGrouping:
+  Enabled: true
+
+Style/Alias:
+  Enabled: true
+
+Style/AndOr:
+  Enabled: true
+
+Style/ArrayJoin:
+  Enabled: true
+
+Style/Attr:
+  Enabled: true
+
+Style/BarePercentLiterals:
+  Enabled: true
+
+Style/BeginBlock:
+  Enabled: true
+
+Style/BisectedAttrAccessor:
+  Enabled: true
+
+Style/BlockComments:
+  Enabled: true
+
+Style/BlockDelimiters:
+  Enabled: true
+
+Style/CaseEquality:
+  Enabled: true
+
+Style/CaseLikeIf:
+  Enabled: true
+
+Style/CharacterLiteral:
+  Enabled: true
+
+Style/ClassAndModuleChildren:
+  Enabled: true
+
+Style/ClassCheck:
+  Enabled: true
+
+Style/ClassEqualityComparison:
+  Enabled: true
+
+Style/ClassMethods:
+  Enabled: true
+
+Style/ClassVars:
+  Enabled: true
+
+Style/ColonMethodCall:
+  Enabled: true
+
+Style/ColonMethodDefinition:
+  Enabled: true
+
+Style/CombinableLoops:
+  Enabled: true
+
+Style/CommandLiteral:
+  Enabled: true
+
+Style/CommentAnnotation:
+  Enabled: true
+
+Style/CommentedKeyword:
+  Enabled: true
+
+Style/ConditionalAssignment:
+  Enabled: true
+
+Style/DefWithParentheses:
+  Enabled: true
+
+Style/Dir:
+  Enabled: true
+
+Style/DoubleCopDisableDirective:
+  Enabled: true
+
+Style/DoubleNegation:
+  Enabled: true
+
+Style/EachForSimpleLoop:
+  Enabled: true
+
+Style/EachWithObject:
+  Enabled: true
+
+Style/EmptyBlockParameter:
+  Enabled: true
+
+Style/EmptyCaseCondition:
+  Enabled: true
+
+Style/EmptyElse:
+  Enabled: true
+
+Style/EmptyLambdaParameter:
+  Enabled: true
+
+Style/EmptyLiteral:
+  Enabled: true
+
+Style/EmptyMethod:
+  Enabled: true
+
+Style/Encoding:
+  Enabled: true
+
+Style/EndBlock:
+  Enabled: true
+
+Style/EvalWithLocation:
+  Enabled: true
+
+Style/EvenOdd:
+  Enabled: true
+
+Style/ExpandPathArguments:
+  Enabled: true
+
+Style/ExplicitBlockArgument:
+  Enabled: true
+
+Style/ExponentialNotation:
+  Enabled: true
+
+Style/FloatDivision:
+  Enabled: true
+
+Style/For:
+  Enabled: true
+
+Style/FormatString:
+  Enabled: true
+
+Style/FormatStringToken:
+  Enabled: true
+
+Style/FrozenStringLiteralComment:
+  Enabled: true
+
+Style/GlobalStdStream:
+  Enabled: true
+
+Style/GlobalVars:
+  Enabled: true
+
+Style/HashAsLastArrayItem:
+  Enabled: true
+
+Style/HashEachMethods:
+  Enabled: true
+
+Style/HashLikeCase:
+  Enabled: true
+
+Style/HashSyntax:
+  Enabled: true
+
+Style/HashTransformKeys:
+  Enabled: true
+
+Style/HashTransformValues:
+  Enabled: true
+
+Style/IdenticalConditionalBranches:
+  Enabled: true
+
+Style/IfInsideElse:
+  Enabled: true
+
+Style/IfUnlessModifier:
+  Enabled: true
+
+Style/IfUnlessModifierOfIfUnless:
+  Enabled: true
+
+Style/IfWithSemicolon:
+  Enabled: true
+
+Style/InfiniteLoop:
+  Enabled: true
+
+Style/InverseMethods:
+  Enabled: true
+
+Style/KeywordParametersOrder:
+  Enabled: true
+
+Style/Lambda:
+  Enabled: true
+
+Style/LambdaCall:
+  Enabled: true
+
+Style/LineEndConcatenation:
+  Enabled: true
+
+Style/MethodCallWithoutArgsParentheses:
+  Enabled: true
+
+Style/MethodDefParentheses:
+  Enabled: true
+
+Style/MinMax:
+  Enabled: true
+
+Style/MissingRespondToMissing:
+  Enabled: true
+
+Style/MixinGrouping:
+  Enabled: true
+
+Style/MixinUsage:
+  Enabled: true
+
+Style/ModuleFunction:
+  Enabled: true
+
+Style/MultilineBlockChain:
+  Enabled: true
+
+Style/MultilineIfModifier:
+  Enabled: true
+
+Style/MultilineIfThen:
+  Enabled: true
+
+Style/MultilineMemoization:
+  Enabled: true
+
+Style/MultilineTernaryOperator:
+  Enabled: true
+
+Style/MultilineWhenThen:
+  Enabled: true
+
+Style/MultipleComparison:
+  Enabled: true
+
+Style/MutableConstant:
+  Enabled: true
+
+Style/NegatedIf:
+  Enabled: true
+
+Style/NegatedUnless:
+  Enabled: true
+
+Style/NegatedWhile:
+  Enabled: true
+
+Style/NestedModifier:
+  Enabled: true
+
+Style/NestedParenthesizedCalls:
+  Enabled: true
+
+Style/NestedTernaryOperator:
+  Enabled: true
+
+Style/NilComparison:
+  Enabled: true
+
+Style/NonNilCheck:
+  Enabled: true
+
+Style/Not:
+  Enabled: true
+
+Style/NumericLiteralPrefix:
+  Enabled: true
+
+Style/NumericLiterals:
+  Enabled: true
+
+Style/NumericPredicate:
+  Enabled: true
+
+Style/OneLineConditional:
+  Enabled: true
+
+Style/OptionalArguments:
+  Enabled: true
+
+Style/OptionalBooleanParameter:
+  Enabled: true
+
+Style/OrAssignment:
+  Enabled: true
+
+Style/ParallelAssignment:
+  Enabled: true
+
+Style/ParenthesesAroundCondition:
+  Enabled: true
+
+Style/PercentLiteralDelimiters:
+  Enabled: true
+
+Style/PercentQLiterals:
+  Enabled: true
+
+Style/PerlBackrefs:
+  Enabled: true
+
+Style/PreferredHashMethods:
+  Enabled: true
+
+Style/Proc:
+  Enabled: true
+
+Style/RaiseArgs:
+  Enabled: true
+
+Style/RandomWithOffset:
+  Enabled: true
+
+Style/RedundantAssignment:
+  Enabled: true
+
+Style/RedundantBegin:
+  Enabled: true
+
+Style/RedundantCapitalW:
+  Enabled: true
+
+Style/RedundantCondition:
+  Enabled: true
+
+Style/RedundantConditional:
+  Enabled: true
+
+Style/RedundantException:
+  Enabled: true
+
+Style/RedundantFetchBlock:
+  Enabled: true
+
+Style/RedundantFileExtensionInRequire:
+  Enabled: true
+
+Style/RedundantFreeze:
+  Enabled: true
+
+Style/RedundantInterpolation:
+  Enabled: true
+
+Style/RedundantParentheses:
+  Enabled: true
+
+Style/RedundantPercentQ:
+  Enabled: true
+
+Style/RedundantRegexpCharacterClass:
+  Enabled: true
+
+Style/RedundantRegexpEscape:
+  Enabled: true
+
+Style/RedundantReturn:
+  Enabled: true
+
+Style/RedundantSelf:
+  Enabled: true
+
+Style/RedundantSelfAssignment:
+  Enabled: true
+
+Style/RedundantSort:
+  Enabled: true
+
+Style/RedundantSortBy:
+  Enabled: true
+
+Style/RegexpLiteral:
+  Enabled: true
+
+Style/RescueModifier:
+  Enabled: true
+
+Style/RescueStandardError:
+  Enabled: true
+
+Style/SafeNavigation:
+  Enabled: true
+
+Style/Sample:
+  Enabled: true
+
+Style/SelfAssignment:
+  Enabled: true
+
+Style/Semicolon:
+  Enabled: true
+
+Style/SignalException:
+  Enabled: true
+
+Style/SingleArgumentDig:
+  Enabled: true
+
+Style/SingleLineMethods:
+  Enabled: true
+
+Style/SlicingWithRange:
+  Enabled: true
+
+Style/SpecialGlobalVars:
+  Enabled: true
+
+Style/StabbyLambdaParentheses:
+  Enabled: true
+
+Style/StderrPuts:
+  Enabled: true
+
+Style/StringConcatenation:
+  Enabled: true
+
+Style/StringLiterals:
+  Enabled: true
+
+Style/StringLiteralsInInterpolation:
+  Enabled: true
+
+Style/Strip:
+  Enabled: true
+
+Style/StructInheritance:
+  Enabled: true
+
+Style/SymbolArray:
+  Enabled: true
+
+Style/SymbolLiteral:
+  Enabled: true
+
+Style/SymbolProc:
+  Enabled: true
+
+Style/TernaryParentheses:
+  Enabled: true
+
+Style/TrailingBodyOnClass:
+  Enabled: true
+
+Style/TrailingBodyOnMethodDefinition:
+  Enabled: true
+
+Style/TrailingBodyOnModule:
+  Enabled: true
+
+Style/TrailingCommaInArguments:
+  Enabled: true
+
+Style/TrailingCommaInArrayLiteral:
+  Enabled: true
+
+Style/TrailingCommaInHashLiteral:
+  Enabled: true
+
+Style/TrailingMethodEndStatement:
+  Enabled: true
+
+Style/TrailingUnderscoreVariable:
+  Enabled: true
+
+Style/TrivialAccessors:
+  Enabled: true
+
+Style/UnlessElse:
+  Enabled: true
+
+Style/UnpackFirst:
+  Enabled: true
+
+Style/VariableInterpolation:
+  Enabled: true
+
+Style/WhenThen:
+  Enabled: true
+
+Style/WhileUntilDo:
+  Enabled: true
+
+Style/WhileUntilModifier:
+  Enabled: true
+
+Style/WordArray:
+  Enabled: true
+
+Style/YodaCondition:
+  Enabled: true
+
+Style/ZeroLengthPredicate:
+  Enabled: true

From e48f4521aed8730da99e85c9de56c7780d3f33e9 Mon Sep 17 00:00:00 2001
From: Issy Long <issyl0@github.com>
Date: Wed, 12 Oct 2022 09:59:30 +0000
Subject: [PATCH 37/47] config/default: Set `Enabled: false` on a bunch of
 rules

- This enumerates all of the currently defined rules that were
  implicitly disabled by `DisabledByDefault: true` and make them
  explicitly disabled so that there is no functional change to the
  RuboCop cops today e.g. if someone upgrades they won't experience a
  flood of newly enabled rules.
- This was achieved by briefly re-enabling `DisabledByDefault`, then
  running `bundle exec rubocop --show-cops`, and the script included
  with the previous commit.
- All of the TODOs from the previous commit about cross-checking newly
  enabled rules with the styleguide are gone, since there are no newly
  enabled rules, and this should be a better user experience for
  downstream consumers since they don't have to scramble to understand
  new RuboCop rules that fail in their project (over and above custom
  ones they have in their project which will now be enabled because we
  removed `DisabledByDefault` in this gem).
- In the future, we'll go through the list of rules here and cross-check
  them with the styleguide, potentially migrating some of them to
  `Enabled: true`. But this changeset as it is now should be good to ship.
---
 config/default.yml | 1554 +++++++++++++++++++++-----------------------
 1 file changed, 738 insertions(+), 816 deletions(-)

diff --git a/config/default.yml b/config/default.yml
index 8cc171b5..c34453de 100644
--- a/config/default.yml
+++ b/config/default.yml
@@ -8,549 +8,53 @@ Bundler/DuplicatedGem:
 Bundler/GemComment:
   Enabled: false
 
-Bundler/GemVersion:
-  Enabled: false
-
-Bundler/OrderedGems:
-  Enabled: true
-
-Gemspec/DependencyVersion:
-  Enabled: false
-
-GitHub/InsecureHashAlgorithm:
-  Enabled: true
-
-Layout/BlockAlignment:
-  Enabled: true
-
-Layout/BlockEndNewline:
-  Enabled: true
-
-Layout/ClassStructure:
-  Enabled: false
-
-Layout/ConditionPosition:
-  Enabled: true
-
-Layout/DefEndAlignment:
-  Enabled: true
-
-Layout/EmptyLineAfterMultilineCondition:
-  Enabled: false
-
-Layout/EndAlignment:
-  Enabled: false
-
-Layout/EndOfLine:
-  Enabled: true
-
-Layout/FirstArrayElementLineBreak:
-  Enabled: false
-
-Layout/FirstHashElementLineBreak:
-  Enabled: false
-
-Layout/FirstMethodArgumentLineBreak:
-  Enabled: false
-
-Layout/FirstMethodParameterLineBreak:
-  Enabled: false
-
-Layout/HeredocArgumentClosingParenthesis:
-  Enabled: false
-
-Layout/IndentationStyle:
-  Enabled: true
-  EnforcedStyle: spaces
-  IndentationWidth: 2
-
-Layout/IndentationWidth:
-  Enabled: true
-  Width: 2
-
-Layout/InitialIndentation:
-  Enabled: true
-
-Layout/LineLength:
-  Enabled: false
-
-Layout/MultilineArrayLineBreaks:
-  Enabled: false
-
-Layout/MultilineAssignmentLayout:
-  Enabled: false
-
-Layout/MultilineHashKeyLineBreaks:
-  Enabled: false
-
-Layout/MultilineMethodArgumentLineBreaks:
-  Enabled: false
-
-Layout/RedundantLineBreak:
-  Enabled: false
-
-Layout/SingleLineBlockChain:
-  Enabled: false
-
-Layout/SpaceAfterColon:
-  Enabled: true
-
-Layout/SpaceAfterComma:
-  Enabled: true
-
-Layout/SpaceAfterMethodName:
-  Enabled: true
-
-Layout/SpaceAfterNot:
-  Enabled: true
-
-Layout/SpaceAfterSemicolon:
-  Enabled: true
-
-Layout/SpaceAroundBlockParameters:
-  Enabled: true
-
-Layout/SpaceAroundEqualsInParameterDefault:
-  Enabled: true
-
-Layout/SpaceBeforeBlockBraces:
-  Enabled: true
-
-Layout/SpaceInsideArrayLiteralBrackets:
-  Enabled: true
-  EnforcedStyle: no_space
-
-Layout/SpaceInsideArrayPercentLiteral:
-  Enabled: true
-
-Layout/SpaceInsideBlockBraces:
-  Enabled: true
-
-Layout/SpaceInsideParens:
-  Enabled: true
-
-Layout/SpaceInsideRangeLiteral:
-  Enabled: true
-
-Layout/SpaceInsideReferenceBrackets:
-  Enabled: true
-
-Layout/TrailingEmptyLines:
-  Enabled: true
-
-Layout/TrailingWhitespace:
-  Enabled: true
-
-Lint/CircularArgumentReference:
-  Enabled: true
-
-Lint/ConstantResolution:
-  Enabled: false
-
-Lint/Debugger:
-  Enabled: true
-
-Lint/DeprecatedClassMethods:
-  Enabled: true
-
-Lint/DuplicateMethods:
-  Enabled: true
-
-Lint/DuplicateHashKey:
-  Enabled: true
-
-Lint/EachWithObjectArgument:
-  Enabled: true
-
-Lint/ElseLayout:
-  Enabled: true
-
-Lint/EmptyEnsure:
-  Enabled: true
-
-Lint/EmptyInterpolation:
-  Enabled: true
-
-Lint/EnsureReturn:
-  Enabled: true
-
-Lint/FlipFlop:
-  Enabled: true
-
-Lint/FloatOutOfRange:
-  Enabled: true
-
-Lint/FormatParameterMismatch:
-  Enabled: true
-
-Lint/HeredocMethodCallPosition:
-  Enabled: false
-
-Lint/LiteralAsCondition:
-  Enabled: true
-
-Lint/LiteralInInterpolation:
-  Enabled: true
-
-Lint/Loop:
-  Enabled: true
-
-Lint/NextWithoutAccumulator:
-  Enabled: true
-
-Lint/NumberConversion:
-  Enabled: false
-
-Lint/RandOne:
-  Enabled: true
-
-Lint/RequireParentheses:
-  Enabled: true
-
-Lint/RescueException:
-  Enabled: true
-
-Lint/RedundantStringCoercion:
-  Enabled: true
-
-Lint/UnderscorePrefixedVariableName:
-  Enabled: true
-
-Lint/RedundantCopDisableDirective:
-  Enabled: true
-
-Lint/RedundantSplatExpansion:
-  Enabled: true
-
-Lint/UnreachableCode:
-  Enabled: true
-
-Lint/BinaryOperatorWithIdenticalOperands:
-  Enabled: true
-
-Lint/UselessSetterCall:
-  Enabled: true
-
-Lint/Void:
-  Enabled: true
-
-Metrics/AbcSize:
-  Enabled: false
-
-Metrics/BlockLength:
-  Enabled: false
-
-Metrics/BlockNesting:
-  Enabled: false
-
-Metrics/ClassLength:
-  Enabled: false
-
-Metrics/CyclomaticComplexity:
-  Enabled: false
-
-Metrics/MethodLength:
-  Enabled: false
-
-Metrics/ModuleLength:
-  Enabled: false
-
-Metrics/ParameterLists:
-  Enabled: false
-
-Metrics/PerceivedComplexity:
-  Enabled: false
-
-Naming/AsciiIdentifiers:
-  Enabled: true
-
-Naming/ClassAndModuleCamelCase:
-  Enabled: true
-
-Naming/FileName:
-  Enabled: true
-
-Naming/InclusiveLanguage:
-  Enabled: false
-
-Naming/MethodName:
-  Enabled: true
-
-Performance/ArraySemiInfiniteRangeSlice:
-  Enabled: false
-
-Performance/CaseWhenSplat:
-  Enabled: false
-
-Performance/ChainArrayAllocation:
-  Enabled: false
-
-Performance/Count:
-  Enabled: true
-
-Performance/Detect:
-  Enabled: true
-
-Performance/DoubleStartEndWith:
-  Enabled: true
-
-Performance/EndWith:
-  Enabled: true
-
-Performance/FlatMap:
-  Enabled: true
-
-Performance/OpenStruct:
-  Enabled: false
-
-Performance/RangeInclude:
-  Enabled: false
-
-Performance/RedundantMatch:
-  Enabled: false
-
-Performance/RedundantMerge:
-  Enabled: true
-  MaxKeyValuePairs: 1
-
-Performance/ReverseEach:
-  Enabled: true
-
-Performance/SelectMap:
-  Enabled: false
-
-Performance/Size:
-  Enabled: true
-
-Performance/StartWith:
-  Enabled: true
-
-Security/Eval:
-  Enabled: true
-
-Style/ArrayCoercion:
-  Enabled: false
-
-Style/ArrayJoin:
-  Enabled: true
-
-Style/AsciiComments:
-  Enabled: false
-
-Style/AutoResourceCleanup:
-  Enabled: false
-
-Style/BeginBlock:
-  Enabled: true
-
-Style/BlockComments:
-  Enabled: true
-
-Style/CaseEquality:
-  Enabled: true
-
-Style/CharacterLiteral:
-  Enabled: true
-
-Style/ClassMethods:
-  Enabled: true
-
-Style/ClassMethodsDefinitions:
-  Enabled: false
-
-Style/CollectionMethods:
-  Enabled: false
-
-Style/ConstantVisibility:
-  Enabled: false
-
-Style/Copyright:
-  Enabled: false
-
-Style/DateTime:
-  Enabled: false
-
-Style/DefWithParentheses:
-  Enabled: true
-
-Style/DisableCopsWithinSourceCodeDirective:
-  Enabled: false
-
-Style/Documentation:
-  Enabled: false
-
-Style/DocumentationMethod:
-  Enabled: false
-
-Style/EndBlock:
-  Enabled: true
-
-Style/For:
-  Enabled: true
-
-Style/FrozenStringLiteralComment:
-  Enabled: true
-
-Style/ImplicitRuntimeError:
-  Enabled: false
-
-Style/InlineComment:
-  Enabled: false
-
-Style/IpAddresses:
-  Enabled: false
-
-Style/HashSyntax:
-  Enabled: true
-  EnforcedStyle: ruby19_no_mixed_keys
-
-Style/LambdaCall:
-  Enabled: true
-
-Style/MethodCalledOnDoEndBlock:
-  Enabled: false
-
-Style/MethodCallWithoutArgsParentheses:
-  Enabled: true
-
-Style/MethodDefParentheses:
-  Enabled: true
-
-Style/MissingElse:
-  Enabled: false
-
-Style/MultilineIfThen:
-  Enabled: true
-
-Style/MultilineMethodSignature:
-  Enabled: false
-
-Style/NilComparison:
-  Enabled: true
-
-Style/Not:
-  Enabled: true
-
-Style/OneLineConditional:
-  Enabled: true
-
-Style/OptionHash:
-  Enabled: false
-
-Style/RedundantSortBy:
-  Enabled: true
-
-Style/ReturnNil:
+Bundler/GemFilename:
   Enabled: false
 
-Style/Sample:
-  Enabled: true
-
-Style/SingleLineBlockParams:
+Bundler/GemVersion:
   Enabled: false
 
-Style/StabbyLambdaParentheses:
-  Enabled: true
-
-Style/StaticClass:
+Bundler/InsecureProtocolSource:
   Enabled: false
 
-Style/Strip:
+Bundler/OrderedGems:
   Enabled: true
 
-Style/StringHashKeys:
+Gemspec/DependencyVersion:
   Enabled: false
 
-Style/StringLiterals:
-  Enabled: true
-  EnforcedStyle: double_quotes
-
-Style/StringMethods:
+Gemspec/DeprecatedAttributeAssignment:
   Enabled: false
 
-Style/TopLevelMethodDefinition:
+Gemspec/DuplicatedAssignment:
   Enabled: false
 
-Style/TrailingCommaInBlockArgs:
+Gemspec/OrderedDependencies:
   Enabled: false
 
-Style/UnlessLogicalOperators:
+Gemspec/RequireMFA:
   Enabled: false
 
-# TODO: Check if the following cops are in the GitHub Ruby styleguide; disable them if not.
-# TODO: Add `StyleGuide` links for cops that are in the GitHub Ruby styleguide.
-# TODO: It would be good to run an alphabetization script over these, to put them
-# in the right places in this file. Also there are probably duplicates for rules
-# that we already had enabled/disabled previously.
-
-Bundler/DuplicatedGem:
-  Enabled: true
-
-Bundler/GemFilename:
-  Enabled: true
-
-Bundler/InsecureProtocolSource:
-  Enabled: true
-
-Bundler/OrderedGems:
-  Enabled: true
-
-Gemspec/DuplicatedAssignment:
-  Enabled: true
-
-Gemspec/OrderedDependencies:
-  Enabled: true
-
 Gemspec/RubyVersionGlobalsUsage:
-  Enabled: true
+  Enabled: false
 
 GitHub/InsecureHashAlgorithm:
   Enabled: true
 
-GitHub/RailsApplicationRecord:
-  Enabled: true
-
-GitHub/RailsControllerRenderActionSymbol:
-  Enabled: true
-
-GitHub/RailsControllerRenderLiteral:
-  Enabled: true
-
-GitHub/RailsControllerRenderPathsExist:
-  Enabled: true
-
-GitHub/RailsControllerRenderShorthand:
-  Enabled: true
-
-GitHub/RailsRenderInline:
-  Enabled: true
-
-GitHub/RailsRenderObjectCollection:
-  Enabled: true
-
-GitHub/RailsViewRenderLiteral:
-  Enabled: true
-
-GitHub/RailsViewRenderPathsExist:
-  Enabled: true
-
-GitHub/RailsViewRenderShorthand:
-  Enabled: true
-
 Layout/AccessModifierIndentation:
-  Enabled: true
+  Enabled: false
 
 Layout/ArgumentAlignment:
-  Enabled: true
+  Enabled: false
 
 Layout/ArrayAlignment:
-  Enabled: true
+  Enabled: false
 
 Layout/AssignmentIndentation:
-  Enabled: true
+  Enabled: false
 
 Layout/BeginEndAlignment:
-  Enabled: true
+  Enabled: false
 
 Layout/BlockAlignment:
   Enabled: true
@@ -559,16 +63,19 @@ Layout/BlockEndNewline:
   Enabled: true
 
 Layout/CaseIndentation:
-  Enabled: true
+  Enabled: false
+
+Layout/ClassStructure:
+  Enabled: false
 
 Layout/ClosingHeredocIndentation:
-  Enabled: true
+  Enabled: false
 
 Layout/ClosingParenthesisIndentation:
-  Enabled: true
+  Enabled: false
 
 Layout/CommentIndentation:
-  Enabled: true
+  Enabled: false
 
 Layout/ConditionPosition:
   Enabled: true
@@ -577,121 +84,175 @@ Layout/DefEndAlignment:
   Enabled: true
 
 Layout/DotPosition:
-  Enabled: true
+  Enabled: false
 
 Layout/ElseAlignment:
-  Enabled: true
+  Enabled: false
 
 Layout/EmptyComment:
-  Enabled: true
+  Enabled: false
 
 Layout/EmptyLineAfterGuardClause:
-  Enabled: true
+  Enabled: false
 
 Layout/EmptyLineAfterMagicComment:
-  Enabled: true
+  Enabled: false
+
+Layout/EmptyLineAfterMultilineCondition:
+  Enabled: false
 
 Layout/EmptyLineBetweenDefs:
-  Enabled: true
+  Enabled: false
 
 Layout/EmptyLines:
-  Enabled: true
+  Enabled: false
 
 Layout/EmptyLinesAroundAccessModifier:
-  Enabled: true
+  Enabled: false
 
 Layout/EmptyLinesAroundArguments:
-  Enabled: true
+  Enabled: false
 
 Layout/EmptyLinesAroundAttributeAccessor:
-  Enabled: true
+  Enabled: false
 
 Layout/EmptyLinesAroundBeginBody:
-  Enabled: true
+  Enabled: false
 
 Layout/EmptyLinesAroundBlockBody:
-  Enabled: true
+  Enabled: false
 
 Layout/EmptyLinesAroundClassBody:
-  Enabled: true
+  Enabled: false
 
 Layout/EmptyLinesAroundExceptionHandlingKeywords:
-  Enabled: true
+  Enabled: false
 
 Layout/EmptyLinesAroundMethodBody:
-  Enabled: true
+  Enabled: false
 
 Layout/EmptyLinesAroundModuleBody:
-  Enabled: true
+  Enabled: false
+
+Layout/EndAlignment:
+  Enabled: false
 
 Layout/EndOfLine:
   Enabled: true
 
 Layout/ExtraSpacing:
-  Enabled: true
+  Enabled: false
 
 Layout/FirstArgumentIndentation:
-  Enabled: true
+  Enabled: false
 
 Layout/FirstArrayElementIndentation:
-  Enabled: true
+  Enabled: false
+
+Layout/FirstArrayElementLineBreak:
+  Enabled: false
 
 Layout/FirstHashElementIndentation:
-  Enabled: true
+  Enabled: false
+
+Layout/FirstHashElementLineBreak:
+  Enabled: false
+
+Layout/FirstMethodArgumentLineBreak:
+  Enabled: false
+
+Layout/FirstMethodParameterLineBreak:
+  Enabled: false
 
 Layout/FirstParameterIndentation:
-  Enabled: true
+  Enabled: false
 
 Layout/HashAlignment:
-  Enabled: true
+  Enabled: false
+
+Layout/HeredocArgumentClosingParenthesis:
+  Enabled: false
 
 Layout/HeredocIndentation:
-  Enabled: true
+  Enabled: false
 
 Layout/IndentationConsistency:
   Enabled: true
+  EnforcedStyle: spaces
+  IndentationWidth: 2
 
 Layout/IndentationStyle:
-  Enabled: true
+  Enabled: false
 
 Layout/IndentationWidth:
   Enabled: true
+  Width: 2
 
 Layout/InitialIndentation:
   Enabled: true
 
 Layout/LeadingCommentSpace:
-  Enabled: true
+  Enabled: false
 
 Layout/LeadingEmptyLines:
-  Enabled: true
+  Enabled: false
+
+Layout/LineContinuationLeadingSpace:
+  Enabled: false
+
+Layout/LineContinuationSpacing:
+  Enabled: false
+
+Layout/LineEndStringConcatenationIndentation:
+  Enabled: false
+
+Layout/LineLength:
+  Enabled: false
 
 Layout/MultilineArrayBraceLayout:
-  Enabled: true
+  Enabled: false
+
+Layout/MultilineArrayLineBreaks:
+  Enabled: false
+
+Layout/MultilineAssignmentLayout:
+  Enabled: false
 
 Layout/MultilineBlockLayout:
-  Enabled: true
+  Enabled: false
 
 Layout/MultilineHashBraceLayout:
-  Enabled: true
+  Enabled: false
+
+Layout/MultilineHashKeyLineBreaks:
+  Enabled: false
+
+Layout/MultilineMethodArgumentLineBreaks:
+  Enabled: false
 
 Layout/MultilineMethodCallBraceLayout:
-  Enabled: true
+  Enabled: false
 
 Layout/MultilineMethodCallIndentation:
-  Enabled: true
+  Enabled: false
 
 Layout/MultilineMethodDefinitionBraceLayout:
-  Enabled: true
+  Enabled: false
 
 Layout/MultilineOperationIndentation:
-  Enabled: true
+  Enabled: false
 
 Layout/ParameterAlignment:
-  Enabled: true
+  Enabled: false
+
+Layout/RedundantLineBreak:
+  Enabled: false
 
 Layout/RescueEnsureAlignment:
-  Enabled: true
+  Enabled: false
+
+Layout/SingleLineBlockChain:
+  Enabled: false
 
 Layout/SpaceAfterColon:
   Enabled: true
@@ -715,34 +276,38 @@ Layout/SpaceAroundEqualsInParameterDefault:
   Enabled: true
 
 Layout/SpaceAroundKeyword:
-  Enabled: true
+  Enabled: false
 
 Layout/SpaceAroundMethodCallOperator:
-  Enabled: true
+  Enabled: false
 
 Layout/SpaceAroundOperators:
-  Enabled: true
+  Enabled: false
 
 Layout/SpaceBeforeBlockBraces:
   Enabled: true
 
+Layout/SpaceBeforeBrackets:
+  Enabled: false
+
 Layout/SpaceBeforeComma:
-  Enabled: true
+  Enabled: false
 
 Layout/SpaceBeforeComment:
-  Enabled: true
+  Enabled: false
 
 Layout/SpaceBeforeFirstArg:
-  Enabled: true
+  Enabled: false
 
 Layout/SpaceBeforeSemicolon:
-  Enabled: true
+  Enabled: false
 
 Layout/SpaceInLambdaLiteral:
-  Enabled: true
+  Enabled: false
 
 Layout/SpaceInsideArrayLiteralBrackets:
   Enabled: true
+  EnforcedStyle: no_space
 
 Layout/SpaceInsideArrayPercentLiteral:
   Enabled: true
@@ -751,13 +316,13 @@ Layout/SpaceInsideBlockBraces:
   Enabled: true
 
 Layout/SpaceInsideHashLiteralBraces:
-  Enabled: true
+  Enabled: false
 
 Layout/SpaceInsideParens:
   Enabled: true
 
 Layout/SpaceInsidePercentLiteralDelimiters:
-  Enabled: true
+  Enabled: false
 
 Layout/SpaceInsideRangeLiteral:
   Enabled: true
@@ -766,7 +331,7 @@ Layout/SpaceInsideReferenceBrackets:
   Enabled: true
 
 Layout/SpaceInsideStringInterpolation:
-  Enabled: true
+  Enabled: false
 
 Layout/TrailingEmptyLines:
   Enabled: true
@@ -774,29 +339,44 @@ Layout/TrailingEmptyLines:
 Layout/TrailingWhitespace:
   Enabled: true
 
+Lint/AmbiguousAssignment:
+  Enabled: false
+
 Lint/AmbiguousBlockAssociation:
-  Enabled: true
+  Enabled: false
 
 Lint/AmbiguousOperator:
-  Enabled: true
+  Enabled: false
+
+Lint/AmbiguousOperatorPrecedence:
+  Enabled: false
+
+Lint/AmbiguousRange:
+  Enabled: false
 
 Lint/AmbiguousRegexpLiteral:
-  Enabled: true
+  Enabled: false
 
 Lint/BigDecimalNew:
-  Enabled: true
+  Enabled: false
 
 Lint/BinaryOperatorWithIdenticalOperands:
   Enabled: true
 
 Lint/BooleanSymbol:
-  Enabled: true
+  Enabled: false
 
 Lint/CircularArgumentReference:
   Enabled: true
 
-Lint/ConstantDefinitionInBlock:
-  Enabled: true
+Lint/ConstantDefinitionInBlock:
+  Enabled: false
+
+Lint/ConstantOverwrittenInRescue:
+  Enabled: false
+
+Lint/ConstantResolution:
+  Enabled: false
 
 Lint/Debugger:
   Enabled: true
@@ -804,17 +384,23 @@ Lint/Debugger:
 Lint/DeprecatedClassMethods:
   Enabled: true
 
+Lint/DeprecatedConstants:
+  Enabled: false
+
 Lint/DeprecatedOpenSSLConstant:
-  Enabled: true
+  Enabled: false
 
 Lint/DisjunctiveAssignmentInConstructor:
-  Enabled: true
+  Enabled: false
+
+Lint/DuplicateBranch:
+  Enabled: false
 
 Lint/DuplicateCaseCondition:
-  Enabled: true
+  Enabled: false
 
 Lint/DuplicateElsifCondition:
-  Enabled: true
+  Enabled: false
 
 Lint/DuplicateHashKey:
   Enabled: true
@@ -822,11 +408,14 @@ Lint/DuplicateHashKey:
 Lint/DuplicateMethods:
   Enabled: true
 
+Lint/DuplicateRegexpCharacterClassElement:
+  Enabled: false
+
 Lint/DuplicateRequire:
-  Enabled: true
+  Enabled: false
 
 Lint/DuplicateRescueException:
-  Enabled: true
+  Enabled: false
 
 Lint/EachWithObjectArgument:
   Enabled: true
@@ -837,29 +426,17 @@ Lint/ElseLayout:
 Lint/EmptyEnsure:
   Enabled: true
 
-Lint/EmptyExpression:
-  Enabled: true
-
-Lint/EmptyFile:
-  Enabled: true
-
 Lint/EmptyInterpolation:
   Enabled: true
 
-Lint/EmptyWhen:
-  Enabled: true
-
 Lint/EnsureReturn:
   Enabled: true
 
-Lint/ErbNewArguments:
-  Enabled: true
-
 Lint/FlipFlop:
   Enabled: true
 
 Lint/FloatComparison:
-  Enabled: true
+  Enabled: false
 
 Lint/FloatOutOfRange:
   Enabled: true
@@ -868,22 +445,31 @@ Lint/FormatParameterMismatch:
   Enabled: true
 
 Lint/HashCompareByIdentity:
-  Enabled: true
+  Enabled: false
+
+Lint/HeredocMethodCallPosition:
+  Enabled: false
 
 Lint/IdentityComparison:
-  Enabled: true
+  Enabled: false
 
 Lint/ImplicitStringConcatenation:
-  Enabled: true
+  Enabled: false
+
+Lint/IncompatibleIoSelectWithFiberScheduler:
+  Enabled: false
 
 Lint/IneffectiveAccessModifier:
-  Enabled: true
+  Enabled: false
 
 Lint/InheritException:
-  Enabled: true
+  Enabled: false
 
 Lint/InterpolationCheck:
-  Enabled: true
+  Enabled: false
+
+Lint/LambdaWithoutLiteralBlock:
+  Enabled: false
 
 Lint/LiteralAsCondition:
   Enabled: true
@@ -895,49 +481,64 @@ Lint/Loop:
   Enabled: true
 
 Lint/MissingCopEnableDirective:
-  Enabled: true
+  Enabled: false
 
 Lint/MissingSuper:
-  Enabled: true
+  Enabled: false
 
 Lint/MixedRegexpCaptureTypes:
-  Enabled: true
+  Enabled: false
 
 Lint/MultipleComparison:
-  Enabled: true
+  Enabled: false
 
 Lint/NestedMethodDefinition:
-  Enabled: true
+  Enabled: false
 
 Lint/NestedPercentLiteral:
-  Enabled: true
+  Enabled: false
 
 Lint/NextWithoutAccumulator:
   Enabled: true
 
+Lint/NoReturnInBeginEndBlocks:
+  Enabled: false
+
+Lint/NonAtomicFileOperation:
+  Enabled: false
+
 Lint/NonDeterministicRequireOrder:
-  Enabled: true
+  Enabled: false
 
 Lint/NonLocalExitFromIterator:
-  Enabled: true
+  Enabled: false
+
+Lint/NumberConversion:
+  Enabled: false
+
+Lint/NumberedParameterAssignment:
+  Enabled: false
+
+Lint/OrAssignmentToConstant:
+  Enabled: false
 
 Lint/OrderedMagicComments:
-  Enabled: true
+  Enabled: false
 
 Lint/OutOfRangeRegexpRef:
-  Enabled: true
+  Enabled: false
 
 Lint/ParenthesesAsGroupedExpression:
-  Enabled: true
+  Enabled: false
 
 Lint/PercentStringArray:
-  Enabled: true
+  Enabled: false
 
 Lint/PercentSymbolArray:
-  Enabled: true
+  Enabled: false
 
 Lint/RaiseException:
-  Enabled: true
+  Enabled: false
 
 Lint/RandOne:
   Enabled: true
@@ -946,13 +547,16 @@ Lint/RedundantCopDisableDirective:
   Enabled: true
 
 Lint/RedundantCopEnableDirective:
-  Enabled: true
+  Enabled: false
+
+Lint/RedundantDirGlobSort:
+  Enabled: false
 
 Lint/RedundantRequireStatement:
-  Enabled: true
+  Enabled: false
 
 Lint/RedundantSafeNavigation:
-  Enabled: true
+  Enabled: false
 
 Lint/RedundantSplatExpansion:
   Enabled: true
@@ -961,181 +565,268 @@ Lint/RedundantStringCoercion:
   Enabled: true
 
 Lint/RedundantWithIndex:
-  Enabled: true
+  Enabled: false
 
 Lint/RedundantWithObject:
-  Enabled: true
+  Enabled: false
+
+Lint/RefinementImportMethods:
+  Enabled: false
 
 Lint/RegexpAsCondition:
-  Enabled: true
+  Enabled: false
 
 Lint/RequireParentheses:
   Enabled: true
 
+Lint/RequireRelativeSelfPath:
+  Enabled: false
+
 Lint/RescueException:
   Enabled: true
 
 Lint/RescueType:
-  Enabled: true
+  Enabled: false
 
 Lint/ReturnInVoidContext:
-  Enabled: true
+  Enabled: false
 
 Lint/SafeNavigationChain:
-  Enabled: true
+  Enabled: false
 
 Lint/SafeNavigationConsistency:
-  Enabled: true
+  Enabled: false
 
 Lint/SafeNavigationWithEmpty:
-  Enabled: true
+  Enabled: false
 
 Lint/ScriptPermission:
-  Enabled: true
+  Enabled: false
 
 Lint/SelfAssignment:
-  Enabled: true
+  Enabled: false
 
 Lint/SendWithMixinArgument:
-  Enabled: true
+  Enabled: false
 
 Lint/ShadowedArgument:
-  Enabled: true
+  Enabled: false
 
 Lint/ShadowedException:
-  Enabled: true
+  Enabled: false
 
 Lint/ShadowingOuterLocalVariable:
-  Enabled: true
+  Enabled: false
 
 Lint/StructNewOverride:
-  Enabled: true
+  Enabled: false
 
 Lint/SuppressedException:
-  Enabled: true
+  Enabled: false
+
+Lint/SymbolConversion:
+  Enabled: false
 
 Lint/Syntax:
-  Enabled: true
+  Enabled: false
+
+Lint/ToEnumArguments:
+  Enabled: false
 
 Lint/ToJSON:
-  Enabled: true
+  Enabled: false
 
 Lint/TopLevelReturnWithArgument:
-  Enabled: true
+  Enabled: false
 
 Lint/TrailingCommaInAttributeDeclaration:
-  Enabled: true
+  Enabled: false
+
+Lint/TripleQuotes:
+  Enabled: false
 
 Lint/UnderscorePrefixedVariableName:
   Enabled: true
 
+Lint/UnexpectedBlockArity:
+  Enabled: false
+
 Lint/UnifiedInteger:
-  Enabled: true
+  Enabled: false
+
+Lint/UnmodifiedReduceAccumulator:
+  Enabled: false
 
 Lint/UnreachableCode:
   Enabled: true
 
 Lint/UnreachableLoop:
-  Enabled: true
+  Enabled: false
 
 Lint/UnusedBlockArgument:
-  Enabled: true
+  Enabled: false
 
 Lint/UnusedMethodArgument:
-  Enabled: true
+  Enabled: false
 
 Lint/UriEscapeUnescape:
-  Enabled: true
+  Enabled: false
 
 Lint/UriRegexp:
-  Enabled: true
+  Enabled: false
 
 Lint/UselessAccessModifier:
-  Enabled: true
+  Enabled: false
 
 Lint/UselessElseWithoutRescue:
-  Enabled: true
+  Enabled: false
 
 Lint/UselessMethodDefinition:
-  Enabled: true
+  Enabled: false
+
+Lint/UselessRuby2Keywords:
+  Enabled: false
 
 Lint/UselessSetterCall:
   Enabled: true
 
 Lint/UselessTimes:
-  Enabled: true
+  Enabled: false
 
 Lint/Void:
   Enabled: true
 
+Metrics/AbcSize:
+  Enabled: false
+
+Metrics/BlockLength:
+  Enabled: false
+
+Metrics/BlockNesting:
+  Enabled: false
+
+Metrics/ClassLength:
+  Enabled: false
+
+Metrics/CyclomaticComplexity:
+  Enabled: false
+
+Metrics/MethodLength:
+  Enabled: false
+
+Metrics/ModuleLength:
+  Enabled: false
+
+Metrics/ParameterLists:
+  Enabled: false
+
+Metrics/PerceivedComplexity:
+  Enabled: false
+
 Migration/DepartmentName:
-  Enabled: true
+  Enabled: false
 
 Naming/AccessorMethodName:
-  Enabled: true
+  Enabled: false
 
 Naming/AsciiIdentifiers:
   Enabled: true
 
 Naming/BinaryOperatorParameterName:
-  Enabled: true
+  Enabled: false
+
+Naming/BlockForwarding:
+  Enabled: false
 
 Naming/BlockParameterName:
-  Enabled: true
+  Enabled: false
 
 Naming/ClassAndModuleCamelCase:
   Enabled: true
 
 Naming/ConstantName:
+  Enabled: false
+
+Naming/FileName:
   Enabled: true
 
 Naming/HeredocDelimiterCase:
-  Enabled: true
+  Enabled: false
 
 Naming/HeredocDelimiterNaming:
-  Enabled: true
+  Enabled: false
+
+Naming/InclusiveLanguage:
+  Enabled: false
 
 Naming/MemoizedInstanceVariableName:
-  Enabled: true
+  Enabled: false
 
 Naming/MethodName:
   Enabled: true
 
 Naming/MethodParameterName:
-  Enabled: true
+  Enabled: false
 
 Naming/PredicateName:
-  Enabled: true
+  Enabled: false
 
 Naming/RescuedExceptionsVariableName:
-  Enabled: true
+  Enabled: false
 
 Naming/VariableName:
-  Enabled: true
+  Enabled: false
 
 Naming/VariableNumber:
-  Enabled: true
+  Enabled: false
+
+Performance/AncestorsInclude:
+  Enabled: false
+
+Performance/ArraySemiInfiniteRangeSlice:
+  Enabled: false
+
+Performance/BigDecimalWithNumericArgument:
+  Enabled: false
 
 Performance/BindCall:
-  Enabled: true
+  Enabled: false
+
+Performance/BlockGivenWithExplicitBlock:
+  Enabled: false
 
 Performance/Caller:
-  Enabled: true
+  Enabled: false
+
+Performance/CaseWhenSplat:
+  Enabled: false
 
 Performance/Casecmp:
-  Enabled: true
+  Enabled: false
+
+Performance/ChainArrayAllocation:
+  Enabled: false
+
+Performance/CollectionLiteralInLoop:
+  Enabled: false
 
 Performance/CompareWithBlock:
-  Enabled: true
+  Enabled: false
+
+Performance/ConcurrentMonotonicTime:
+  Enabled: false
+
+Performance/ConstantRegexp:
+  Enabled: false
 
 Performance/Count:
   Enabled: true
 
 Performance/DeletePrefix:
-  Enabled: true
+  Enabled: false
 
 Performance/DeleteSuffix:
-  Enabled: true
+  Enabled: false
 
 Performance/Detect:
   Enabled: true
@@ -1147,562 +838,793 @@ Performance/EndWith:
   Enabled: true
 
 Performance/FixedSize:
-  Enabled: true
+  Enabled: false
 
 Performance/FlatMap:
   Enabled: true
 
 Performance/InefficientHashSearch:
-  Enabled: true
+  Enabled: false
+
+Performance/IoReadlines:
+  Enabled: false
+
+Performance/MapCompact:
+  Enabled: false
+
+Performance/MethodObjectAsBlock:
+  Enabled: false
+
+Performance/OpenStruct:
+  Enabled: false
+
+Performance/RangeInclude:
+  Enabled: false
 
 Performance/RedundantBlockCall:
-  Enabled: true
+  Enabled: false
+
+Performance/RedundantEqualityComparisonBlock:
+  Enabled: false
+
+Performance/RedundantMatch:
+  Enabled: false
 
 Performance/RedundantMerge:
   Enabled: true
+  MaxKeyValuePairs: 1
+
+Performance/RedundantSortBlock:
+  Enabled: false
+
+Performance/RedundantSplitRegexpArgument:
+  Enabled: false
+
+Performance/RedundantStringChars:
+  Enabled: false
 
 Performance/RegexpMatch:
-  Enabled: true
+  Enabled: false
 
 Performance/ReverseEach:
   Enabled: true
 
+Performance/ReverseFirst:
+  Enabled: false
+
+Performance/SelectMap:
+  Enabled: false
+
 Performance/Size:
   Enabled: true
 
+Performance/SortReverse:
+  Enabled: false
+
+Performance/Squeeze:
+  Enabled: false
+
 Performance/StartWith:
   Enabled: true
 
+Performance/StringIdentifierArgument:
+  Enabled: false
+
+Performance/StringInclude:
+  Enabled: false
+
 Performance/StringReplacement:
-  Enabled: true
+  Enabled: false
+
+Performance/Sum:
+  Enabled: false
 
 Performance/TimesMap:
-  Enabled: true
+  Enabled: false
 
 Performance/UnfreezeString:
-  Enabled: true
+  Enabled: false
 
 Performance/UriDefaultParser:
-  Enabled: true
+  Enabled: false
+
+Security/CompoundHash:
+  Enabled: false
 
 Security/Eval:
   Enabled: true
 
+Security/IoMethods:
+  Enabled: false
+
 Security/JSONLoad:
-  Enabled: true
+  Enabled: false
 
 Security/MarshalLoad:
-  Enabled: true
+  Enabled: false
 
 Security/Open:
-  Enabled: true
+  Enabled: false
 
 Security/YAMLLoad:
-  Enabled: true
+  Enabled: false
 
 Style/AccessModifierDeclarations:
-  Enabled: true
+  Enabled: false
 
 Style/AccessorGrouping:
-  Enabled: true
+  Enabled: false
 
 Style/Alias:
-  Enabled: true
+  Enabled: false
 
 Style/AndOr:
-  Enabled: true
+  Enabled: false
+
+Style/ArgumentsForwarding:
+  Enabled: false
+
+Style/ArrayCoercion:
+  Enabled: false
 
 Style/ArrayJoin:
   Enabled: true
 
+Style/AsciiComments:
+  Enabled: false
+
 Style/Attr:
-  Enabled: true
+  Enabled: false
+
+Style/AutoResourceCleanup:
+  Enabled: false
 
 Style/BarePercentLiterals:
-  Enabled: true
+  Enabled: false
 
 Style/BeginBlock:
   Enabled: true
 
 Style/BisectedAttrAccessor:
-  Enabled: true
+  Enabled: false
 
 Style/BlockComments:
   Enabled: true
 
 Style/BlockDelimiters:
-  Enabled: true
+  Enabled: false
 
 Style/CaseEquality:
   Enabled: true
 
 Style/CaseLikeIf:
-  Enabled: true
+  Enabled: false
 
 Style/CharacterLiteral:
   Enabled: true
 
 Style/ClassAndModuleChildren:
-  Enabled: true
+  Enabled: false
 
 Style/ClassCheck:
-  Enabled: true
+  Enabled: false
 
 Style/ClassEqualityComparison:
-  Enabled: true
+  Enabled: false
 
 Style/ClassMethods:
   Enabled: true
 
+Style/ClassMethodsDefinitions:
+  Enabled: false
+
 Style/ClassVars:
-  Enabled: true
+  Enabled: false
+
+Style/CollectionCompact:
+  Enabled: false
+
+Style/CollectionMethods:
+  Enabled: false
 
 Style/ColonMethodCall:
-  Enabled: true
+  Enabled: false
 
 Style/ColonMethodDefinition:
-  Enabled: true
+  Enabled: false
 
 Style/CombinableLoops:
-  Enabled: true
+  Enabled: false
 
 Style/CommandLiteral:
-  Enabled: true
+  Enabled: false
 
 Style/CommentAnnotation:
-  Enabled: true
+  Enabled: false
 
 Style/CommentedKeyword:
-  Enabled: true
+  Enabled: false
 
 Style/ConditionalAssignment:
-  Enabled: true
+  Enabled: false
+
+Style/ConstantVisibility:
+  Enabled: false
+
+Style/Copyright:
+  Enabled: false
+
+Style/DateTime:
+  Enabled: false
 
 Style/DefWithParentheses:
   Enabled: true
 
 Style/Dir:
-  Enabled: true
+  Enabled: false
+
+Style/DisableCopsWithinSourceCodeDirective:
+  Enabled: false
+
+Style/DocumentDynamicEvalDefinition:
+  Enabled: false
+
+Style/Documentation:
+  Enabled: false
+
+Style/DocumentationMethod:
+  Enabled: false
 
 Style/DoubleCopDisableDirective:
-  Enabled: true
+  Enabled: false
 
 Style/DoubleNegation:
-  Enabled: true
+  Enabled: false
 
 Style/EachForSimpleLoop:
-  Enabled: true
+  Enabled: false
 
 Style/EachWithObject:
-  Enabled: true
+  Enabled: false
 
 Style/EmptyBlockParameter:
-  Enabled: true
+  Enabled: false
 
 Style/EmptyCaseCondition:
-  Enabled: true
+  Enabled: false
 
 Style/EmptyElse:
-  Enabled: true
+  Enabled: false
 
 Style/EmptyLambdaParameter:
-  Enabled: true
+  Enabled: false
 
 Style/EmptyLiteral:
-  Enabled: true
+  Enabled: false
 
 Style/EmptyMethod:
-  Enabled: true
+  Enabled: false
 
 Style/Encoding:
-  Enabled: true
+  Enabled: false
 
 Style/EndBlock:
   Enabled: true
 
+Style/EndlessMethod:
+  Enabled: false
+
+Style/EnvHome:
+  Enabled: false
+
 Style/EvalWithLocation:
-  Enabled: true
+  Enabled: false
 
 Style/EvenOdd:
-  Enabled: true
+  Enabled: false
 
 Style/ExpandPathArguments:
-  Enabled: true
+  Enabled: false
 
 Style/ExplicitBlockArgument:
-  Enabled: true
+  Enabled: false
 
 Style/ExponentialNotation:
-  Enabled: true
+  Enabled: false
+
+Style/FetchEnvVar:
+  Enabled: false
+
+Style/FileRead:
+  Enabled: false
+
+Style/FileWrite:
+  Enabled: false
 
 Style/FloatDivision:
-  Enabled: true
+  Enabled: false
 
 Style/For:
   Enabled: true
 
 Style/FormatString:
-  Enabled: true
+  Enabled: false
 
 Style/FormatStringToken:
-  Enabled: true
+  Enabled: false
 
 Style/FrozenStringLiteralComment:
   Enabled: true
 
 Style/GlobalStdStream:
-  Enabled: true
+  Enabled: false
 
 Style/GlobalVars:
-  Enabled: true
+  Enabled: false
 
 Style/HashAsLastArrayItem:
-  Enabled: true
+  Enabled: false
+
+Style/HashConversion:
+  Enabled: false
 
 Style/HashEachMethods:
-  Enabled: true
+  Enabled: false
+
+Style/HashExcept:
+  Enabled: false
 
 Style/HashLikeCase:
-  Enabled: true
+  Enabled: false
 
 Style/HashSyntax:
   Enabled: true
+  EnforcedStyle: ruby19_no_mixed_keys
 
 Style/HashTransformKeys:
-  Enabled: true
+  Enabled: false
 
 Style/HashTransformValues:
-  Enabled: true
+  Enabled: false
 
 Style/IdenticalConditionalBranches:
-  Enabled: true
+  Enabled: false
 
 Style/IfInsideElse:
-  Enabled: true
+  Enabled: false
 
 Style/IfUnlessModifier:
-  Enabled: true
+  Enabled: false
 
 Style/IfUnlessModifierOfIfUnless:
-  Enabled: true
+  Enabled: false
+
+Style/IfWithBooleanLiteralBranches:
+  Enabled: false
 
 Style/IfWithSemicolon:
-  Enabled: true
+  Enabled: false
+
+Style/ImplicitRuntimeError:
+  Enabled: false
+
+Style/InPatternThen:
+  Enabled: false
 
 Style/InfiniteLoop:
-  Enabled: true
+  Enabled: false
+
+Style/InlineComment:
+  Enabled: false
 
 Style/InverseMethods:
-  Enabled: true
+  Enabled: false
+
+Style/IpAddresses:
+  Enabled: false
 
 Style/KeywordParametersOrder:
-  Enabled: true
+  Enabled: false
 
 Style/Lambda:
-  Enabled: true
+  Enabled: false
 
 Style/LambdaCall:
   Enabled: true
 
 Style/LineEndConcatenation:
-  Enabled: true
+  Enabled: false
+
+Style/MapCompactWithConditionalBlock:
+  Enabled: false
+
+Style/MapToHash:
+  Enabled: false
+
+Style/MethodCallWithArgsParentheses:
+  Enabled: false
 
 Style/MethodCallWithoutArgsParentheses:
   Enabled: true
 
+Style/MethodCalledOnDoEndBlock:
+  Enabled: false
+
 Style/MethodDefParentheses:
   Enabled: true
 
 Style/MinMax:
-  Enabled: true
+  Enabled: false
+
+Style/MissingElse:
+  Enabled: false
 
 Style/MissingRespondToMissing:
-  Enabled: true
+  Enabled: false
 
 Style/MixinGrouping:
-  Enabled: true
+  Enabled: false
 
 Style/MixinUsage:
-  Enabled: true
+  Enabled: false
 
 Style/ModuleFunction:
-  Enabled: true
+  Enabled: false
 
 Style/MultilineBlockChain:
-  Enabled: true
+  Enabled: false
 
 Style/MultilineIfModifier:
-  Enabled: true
+  Enabled: false
 
 Style/MultilineIfThen:
   Enabled: true
 
+Style/MultilineInPatternThen:
+  Enabled: false
+
 Style/MultilineMemoization:
-  Enabled: true
+  Enabled: false
+
+Style/MultilineMethodSignature:
+  Enabled: false
 
 Style/MultilineTernaryOperator:
-  Enabled: true
+  Enabled: false
 
 Style/MultilineWhenThen:
-  Enabled: true
+  Enabled: false
 
 Style/MultipleComparison:
-  Enabled: true
+  Enabled: false
 
 Style/MutableConstant:
-  Enabled: true
+  Enabled: false
 
 Style/NegatedIf:
-  Enabled: true
+  Enabled: false
+
+Style/NegatedIfElseCondition:
+  Enabled: false
 
 Style/NegatedUnless:
-  Enabled: true
+  Enabled: false
 
 Style/NegatedWhile:
-  Enabled: true
+  Enabled: false
+
+Style/NestedFileDirname:
+  Enabled: false
 
 Style/NestedModifier:
-  Enabled: true
+  Enabled: false
 
 Style/NestedParenthesizedCalls:
-  Enabled: true
+  Enabled: false
 
 Style/NestedTernaryOperator:
-  Enabled: true
+  Enabled: false
 
 Style/NilComparison:
   Enabled: true
 
+Style/NilLambda:
+  Enabled: false
+
 Style/NonNilCheck:
-  Enabled: true
+  Enabled: false
 
 Style/Not:
   Enabled: true
 
+Style/NumberedParameters:
+  Enabled: false
+
+Style/NumberedParametersLimit:
+  Enabled: false
+
 Style/NumericLiteralPrefix:
-  Enabled: true
+  Enabled: false
 
 Style/NumericLiterals:
-  Enabled: true
+  Enabled: false
 
 Style/NumericPredicate:
-  Enabled: true
+  Enabled: false
+
+Style/ObjectThen:
+  Enabled: false
 
 Style/OneLineConditional:
   Enabled: true
 
+Style/OpenStructUse:
+  Enabled: false
+
+Style/OptionHash:
+  Enabled: false
+
 Style/OptionalArguments:
-  Enabled: true
+  Enabled: false
 
 Style/OptionalBooleanParameter:
-  Enabled: true
+  Enabled: false
 
 Style/OrAssignment:
-  Enabled: true
+  Enabled: false
 
 Style/ParallelAssignment:
-  Enabled: true
+  Enabled: false
 
 Style/ParenthesesAroundCondition:
-  Enabled: true
+  Enabled: false
 
 Style/PercentLiteralDelimiters:
-  Enabled: true
+  Enabled: false
 
 Style/PercentQLiterals:
-  Enabled: true
+  Enabled: false
 
 Style/PerlBackrefs:
-  Enabled: true
+  Enabled: false
 
 Style/PreferredHashMethods:
-  Enabled: true
+  Enabled: false
 
 Style/Proc:
-  Enabled: true
+  Enabled: false
+
+Style/QuotedSymbols:
+  Enabled: false
 
 Style/RaiseArgs:
-  Enabled: true
+  Enabled: false
 
 Style/RandomWithOffset:
-  Enabled: true
+  Enabled: false
+
+Style/RedundantArgument:
+  Enabled: false
 
 Style/RedundantAssignment:
-  Enabled: true
+  Enabled: false
 
 Style/RedundantBegin:
-  Enabled: true
+  Enabled: false
 
 Style/RedundantCapitalW:
-  Enabled: true
+  Enabled: false
 
 Style/RedundantCondition:
-  Enabled: true
+  Enabled: false
 
 Style/RedundantConditional:
-  Enabled: true
+  Enabled: false
 
 Style/RedundantException:
-  Enabled: true
+  Enabled: false
 
 Style/RedundantFetchBlock:
-  Enabled: true
+  Enabled: false
 
 Style/RedundantFileExtensionInRequire:
-  Enabled: true
+  Enabled: false
 
 Style/RedundantFreeze:
-  Enabled: true
+  Enabled: false
+
+Style/RedundantInitialize:
+  Enabled: false
 
 Style/RedundantInterpolation:
-  Enabled: true
+  Enabled: false
 
 Style/RedundantParentheses:
-  Enabled: true
+  Enabled: false
 
 Style/RedundantPercentQ:
-  Enabled: true
+  Enabled: false
 
 Style/RedundantRegexpCharacterClass:
-  Enabled: true
+  Enabled: false
 
 Style/RedundantRegexpEscape:
-  Enabled: true
+  Enabled: false
 
 Style/RedundantReturn:
-  Enabled: true
+  Enabled: false
 
 Style/RedundantSelf:
-  Enabled: true
+  Enabled: false
 
 Style/RedundantSelfAssignment:
-  Enabled: true
+  Enabled: false
+
+Style/RedundantSelfAssignmentBranch:
+  Enabled: false
 
 Style/RedundantSort:
-  Enabled: true
+  Enabled: false
 
 Style/RedundantSortBy:
   Enabled: true
 
 Style/RegexpLiteral:
-  Enabled: true
+  Enabled: false
 
 Style/RescueModifier:
-  Enabled: true
+  Enabled: false
 
 Style/RescueStandardError:
-  Enabled: true
+  Enabled: false
+
+Style/ReturnNil:
+  Enabled: false
 
 Style/SafeNavigation:
-  Enabled: true
+  Enabled: false
 
 Style/Sample:
   Enabled: true
 
+Style/SelectByRegexp:
+  Enabled: false
+
 Style/SelfAssignment:
-  Enabled: true
+  Enabled: false
 
 Style/Semicolon:
-  Enabled: true
+  Enabled: false
+
+Style/Send:
+  Enabled: false
 
 Style/SignalException:
-  Enabled: true
+  Enabled: false
 
 Style/SingleArgumentDig:
-  Enabled: true
+  Enabled: false
+
+Style/SingleLineBlockParams:
+  Enabled: false
 
 Style/SingleLineMethods:
-  Enabled: true
+  Enabled: false
 
 Style/SlicingWithRange:
-  Enabled: true
+  Enabled: false
 
 Style/SpecialGlobalVars:
-  Enabled: true
+  Enabled: false
 
 Style/StabbyLambdaParentheses:
   Enabled: true
 
+Style/StaticClass:
+  Enabled: false
+
 Style/StderrPuts:
-  Enabled: true
+  Enabled: false
+
+Style/StringChars:
+  Enabled: false
 
 Style/StringConcatenation:
-  Enabled: true
+  Enabled: false
+
+Style/StringHashKeys:
+  Enabled: false
 
 Style/StringLiterals:
   Enabled: true
+  EnforcedStyle: double_quotes
 
 Style/StringLiteralsInInterpolation:
-  Enabled: true
+  Enabled: false
+
+Style/StringMethods:
+  Enabled: false
 
 Style/Strip:
   Enabled: true
 
 Style/StructInheritance:
-  Enabled: true
+  Enabled: false
+
+Style/SwapValues:
+  Enabled: false
 
 Style/SymbolArray:
-  Enabled: true
+  Enabled: false
 
 Style/SymbolLiteral:
-  Enabled: true
+  Enabled: false
 
 Style/SymbolProc:
-  Enabled: true
+  Enabled: false
 
 Style/TernaryParentheses:
-  Enabled: true
+  Enabled: false
+
+Style/TopLevelMethodDefinition:
+  Enabled: false
 
 Style/TrailingBodyOnClass:
-  Enabled: true
+  Enabled: false
 
 Style/TrailingBodyOnMethodDefinition:
-  Enabled: true
+  Enabled: false
 
 Style/TrailingBodyOnModule:
-  Enabled: true
+  Enabled: false
 
 Style/TrailingCommaInArguments:
-  Enabled: true
+  Enabled: false
 
 Style/TrailingCommaInArrayLiteral:
-  Enabled: true
+  Enabled: false
+
+Style/TrailingCommaInBlockArgs:
+  Enabled: false
 
 Style/TrailingCommaInHashLiteral:
-  Enabled: true
+  Enabled: false
 
 Style/TrailingMethodEndStatement:
-  Enabled: true
+  Enabled: false
 
 Style/TrailingUnderscoreVariable:
-  Enabled: true
+  Enabled: false
 
 Style/TrivialAccessors:
-  Enabled: true
+  Enabled: false
 
 Style/UnlessElse:
-  Enabled: true
+  Enabled: false
+
+Style/UnlessLogicalOperators:
+  Enabled: false
 
 Style/UnpackFirst:
-  Enabled: true
+  Enabled: false
 
 Style/VariableInterpolation:
-  Enabled: true
+  Enabled: false
 
 Style/WhenThen:
-  Enabled: true
+  Enabled: false
 
 Style/WhileUntilDo:
-  Enabled: true
+  Enabled: false
 
 Style/WhileUntilModifier:
-  Enabled: true
+  Enabled: false
 
 Style/WordArray:
-  Enabled: true
+  Enabled: false
 
 Style/YodaCondition:
-  Enabled: true
+  Enabled: false
 
 Style/ZeroLengthPredicate:
-  Enabled: true
+  Enabled: false

From baa90b2f99958a0bb4d27a375a584d05cd4dd5b8 Mon Sep 17 00:00:00 2001
From: Issy Long <issyl0@github.com>
Date: Wed, 12 Oct 2022 10:16:28 +0000
Subject: [PATCH 38/47] config/default: Fix `Layout/IndentationStyle`
 configuration

- The alphabetization script didn't cope very well with all the extra options for some reason.
---
 config/default.yml | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/config/default.yml b/config/default.yml
index c34453de..96c2cd34 100644
--- a/config/default.yml
+++ b/config/default.yml
@@ -177,13 +177,13 @@ Layout/HeredocIndentation:
   Enabled: false
 
 Layout/IndentationConsistency:
+  Enabled: false
+
+Layout/IndentationStyle:
   Enabled: true
   EnforcedStyle: spaces
   IndentationWidth: 2
 
-Layout/IndentationStyle:
-  Enabled: false
-
 Layout/IndentationWidth:
   Enabled: true
   Width: 2

From 5a1ede7b4931b877586ac3e03829661c03ddd734 Mon Sep 17 00:00:00 2001
From: Issy Long <issyl0@github.com>
Date: Wed, 12 Oct 2022 10:25:52 +0000
Subject: [PATCH 39/47] .rubocop.yml: Move `Enabled: false` cops into
 `config/default.yml`

- We've now changed tactic such that we're not enabling any new cops for
  downstream consumers, so let's move the "locally" disabled cops for
  this codebase back into `config/default.yml` so that we don't enable
  them for downstream consumers by accident. Something like
  `Lint/AssignmentInCondition` that doesn't have an autocorrect would be
  particularly annoying to receive violations for when you're just
  trying to upgrade your project's version of this gem.
---
 .rubocop.yml       | 27 ---------------------------
 config/default.yml | 21 +++++++++++++++++++++
 2 files changed, 21 insertions(+), 27 deletions(-)

diff --git a/.rubocop.yml b/.rubocop.yml
index 593983b7..802a6e67 100644
--- a/.rubocop.yml
+++ b/.rubocop.yml
@@ -1,33 +1,6 @@
 inherit_from: ./config/default.yml
 
-AllCops:
-  SuggestExtensions: false
-
-Gemspec/RequiredRubyVersion:
-  Enabled: false
-
-Lint/AssignmentInCondition:
-  Enabled: false
-
-Lint/EmptyConditionalBody:
-  Enabled: false
-
-Lint/UselessAssignment:
-  Enabled: false
-
 Naming/FileName:
   Enabled: true
   Exclude:
     - "rubocop-github.gemspec"
-
-Style/Documentation:
-  Enabled: false
-
-Style/GuardClause:
-  Enabled: false
-
-Style/Next:
-  Enabled: false
-
-Style/SoleNestedConditional:
-  Enabled: false
diff --git a/config/default.yml b/config/default.yml
index 96c2cd34..37467f1e 100644
--- a/config/default.yml
+++ b/config/default.yml
@@ -35,6 +35,9 @@ Gemspec/OrderedDependencies:
 Gemspec/RequireMFA:
   Enabled: false
 
+Gemspec/RequiredRubyVersion:
+  Enabled: false
+
 Gemspec/RubyVersionGlobalsUsage:
   Enabled: false
 
@@ -357,6 +360,9 @@ Lint/AmbiguousRange:
 Lint/AmbiguousRegexpLiteral:
   Enabled: false
 
+Lint/AssignmentInCondition:
+  Enabled: false
+
 Lint/BigDecimalNew:
   Enabled: false
 
@@ -423,6 +429,9 @@ Lint/EachWithObjectArgument:
 Lint/ElseLayout:
   Enabled: true
 
+Lint/EmptyConditionalBody:
+  Enabled: false
+
 Lint/EmptyEnsure:
   Enabled: true
 
@@ -678,6 +687,9 @@ Lint/UriRegexp:
 Lint/UselessAccessModifier:
   Enabled: false
 
+Lint/UselessAssignment:
+  Enabled: false
+
 Lint/UselessElseWithoutRescue:
   Enabled: false
 
@@ -1162,6 +1174,9 @@ Style/GlobalStdStream:
 Style/GlobalVars:
   Enabled: false
 
+Style/GuardClause:
+  Enabled: false
+
 Style/HashAsLastArrayItem:
   Enabled: false
 
@@ -1325,6 +1340,9 @@ Style/NestedParenthesizedCalls:
 Style/NestedTernaryOperator:
   Enabled: false
 
+Style/Next:
+  Enabled: false
+
 Style/NilComparison:
   Enabled: true
 
@@ -1514,6 +1532,9 @@ Style/SingleLineMethods:
 Style/SlicingWithRange:
   Enabled: false
 
+Style/SoleNestedConditional:
+  Enabled: false
+
 Style/SpecialGlobalVars:
   Enabled: false
 

From 60a3a0431a533914f1fb2bc5db78a20f97327a31 Mon Sep 17 00:00:00 2001
From: Issy Long <issyl0@github.com>
Date: Wed, 12 Oct 2022 10:34:50 +0000
Subject: [PATCH 40/47] config/default: It's impossible to disable
 `Lint/Syntax`

- Somehow this snuck in, but RuboCop errors:

```
Error: configuration for Syntax cop found in config/default.yml.
It's not possible to disable this cop.
```
---
 config/default.yml | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/config/default.yml b/config/default.yml
index 37467f1e..dd878514 100644
--- a/config/default.yml
+++ b/config/default.yml
@@ -636,9 +636,6 @@ Lint/SuppressedException:
 Lint/SymbolConversion:
   Enabled: false
 
-Lint/Syntax:
-  Enabled: false
-
 Lint/ToEnumArguments:
   Enabled: false
 

From 55b4ece5e7d251fea1044551c26b337fddb5f9eb Mon Sep 17 00:00:00 2001
From: Issy Long <issyl0@github.com>
Date: Wed, 12 Oct 2022 10:38:51 +0000
Subject: [PATCH 41/47] Revert "Run `bundle exec rubocop -a` (or `-A`) on all
 the code in this repo"

This reverts commit 53a0a37784c3d95c05edbc3f57023072b00ef607.

This is because we've now disabled all the rules that would have been
`DisabledByDefault`. This is so that downstream consumers don't get any
nasty surprises. As a result, there should be no RuboCop linting
violations in the code in this repo, so we can back out the changes to
slim the diff: they're now redundant.

Of course, it would be a good idea to go and make these changes at a later
date, but we can do that when we enable the correct rules having matched
each one up with its rationale in our styleguide.
---
 Rakefile                                      |  2 +-
 .../cop/github/insecure_hash_algorithm.rb     | 31 ++++++++++++-------
 .../cop/github/rails_application_record.rb    |  6 ++--
 .../rails_controller_render_action_symbol.rb  |  2 +-
 .../github/rails_controller_render_literal.rb | 14 ++++++---
 .../rails_controller_render_paths_exist.rb    | 14 ++++++---
 .../rails_controller_render_shorthand.rb      |  4 +--
 lib/rubocop/cop/github/rails_render_inline.rb |  4 ++-
 .../github/rails_render_object_collection.rb  |  4 ++-
 .../cop/github/rails_view_render_literal.rb   | 10 ++++--
 .../github/rails_view_render_paths_exist.rb   | 10 ++++--
 .../cop/github/render_literal_helpers.rb      |  2 +-
 test/test_insecure_hash_algorithm.rb          |  2 +-
 test/test_rails_controller_render_literal.rb  |  1 +
 14 files changed, 69 insertions(+), 37 deletions(-)

diff --git a/Rakefile b/Rakefile
index 66dceb34..25e3326b 100644
--- a/Rakefile
+++ b/Rakefile
@@ -4,7 +4,7 @@ require "bundler/gem_tasks"
 require "rake/testtask"
 require "rubocop/rake_task"
 
-task default: %i[test rubocop]
+task default: [:test, :rubocop]
 
 Rake::TestTask.new
 RuboCop::RakeTask.new
diff --git a/lib/rubocop/cop/github/insecure_hash_algorithm.rb b/lib/rubocop/cop/github/insecure_hash_algorithm.rb
index e9fb3309..ab73ca1b 100644
--- a/lib/rubocop/cop/github/insecure_hash_algorithm.rb
+++ b/lib/rubocop/cop/github/insecure_hash_algorithm.rb
@@ -64,7 +64,6 @@ class InsecureHashAlgorithm < Base
 
         def insecure_algorithm?(val)
           return false if val == :Digest # Don't match "Digest::Digest".
-
           case alg_name(val)
           when *allowed_hash_functions
             false
@@ -81,7 +80,7 @@ def not_just_encoding?(val)
         end
 
         def just_encoding?(val)
-          %i[hexencode bubblebabble].include?(val)
+          val == :hexencode || val == :bubblebabble
         end
 
         # Built-in hash functions are listed in these docs:
@@ -100,7 +99,6 @@ def allowed_hash_functions
         def alg_name(val)
           return :nil if val.nil?
           return val.to_s.downcase unless val.is_a?(RuboCop::AST::Node)
-
           case val.type
           when :sym, :str
             val.children.first.to_s.downcase
@@ -110,19 +108,28 @@ def alg_name(val)
         end
 
         def on_const(const_node)
-          add_offense(const_node, message: MSG) if insecure_const?(const_node) && !digest_uuid?(const_node)
+          if insecure_const?(const_node) && !digest_uuid?(const_node)
+            add_offense(const_node, message: MSG)
+          end
         end
 
         def on_send(send_node)
-          if uuid_v3?(send_node)
-            add_offense(send_node, message: UUID_V3_MSG) unless allowed_hash_functions.include?("md5")
-          elsif uuid_v5?(send_node)
-            add_offense(send_node, message: UUID_V5_MSG) unless allowed_hash_functions.include?("sha1")
-          elsif openssl_hmac_new?(send_node)
-            add_offense(send_node, message: MSG) if openssl_hmac_new_insecure?(send_node)
-          elsif insecure_digest?(send_node)
+          case
+          when uuid_v3?(send_node)
+            unless allowed_hash_functions.include?("md5")
+              add_offense(send_node, message: UUID_V3_MSG)
+            end
+          when uuid_v5?(send_node)
+            unless allowed_hash_functions.include?("sha1")
+              add_offense(send_node, message: UUID_V5_MSG)
+            end
+          when openssl_hmac_new?(send_node)
+            if openssl_hmac_new_insecure?(send_node)
+              add_offense(send_node, message: MSG)
+            end
+          when insecure_digest?(send_node)
             add_offense(send_node, message: MSG)
-          elsif insecure_hash_lookup?(send_node)
+          when insecure_hash_lookup?(send_node)
             add_offense(send_node, message: MSG)
           end
         end
diff --git a/lib/rubocop/cop/github/rails_application_record.rb b/lib/rubocop/cop/github/rails_application_record.rb
index cfb19743..1ec30cf9 100644
--- a/lib/rubocop/cop/github/rails_application_record.rb
+++ b/lib/rubocop/cop/github/rails_application_record.rb
@@ -17,9 +17,11 @@ class RailsApplicationRecord < Base
         PATTERN
 
         def on_class(node)
-          klass, superclass, = *node
+          klass, superclass, _ = *node
 
-          add_offense(superclass) if active_record_base_const?(superclass) && !application_record_const?(klass)
+          if active_record_base_const?(superclass) && !(application_record_const?(klass))
+            add_offense(superclass)
+          end
         end
       end
     end
diff --git a/lib/rubocop/cop/github/rails_controller_render_action_symbol.rb b/lib/rubocop/cop/github/rails_controller_render_action_symbol.rb
index 86618331..e3d6eca7 100644
--- a/lib/rubocop/cop/github/rails_controller_render_action_symbol.rb
+++ b/lib/rubocop/cop/github/rails_controller_render_action_symbol.rb
@@ -24,7 +24,7 @@ class RailsControllerRenderActionSymbol < Base
 
         def on_send(node)
           if sym_node = render_sym?(node)
-            add_offense(sym_node) do |_corrector|
+            add_offense(sym_node) do |corrector|
               register_offense(sym_node, node)
             end
           elsif option_pairs = render_with_options?(node)
diff --git a/lib/rubocop/cop/github/rails_controller_render_literal.rb b/lib/rubocop/cop/github/rails_controller_render_literal.rb
index edda84d6..0f2efd39 100644
--- a/lib/rubocop/cop/github/rails_controller_render_literal.rb
+++ b/lib/rubocop/cop/github/rails_controller_render_literal.rb
@@ -60,10 +60,12 @@ def on_send(node)
           elsif option_pairs = render_with_options?(node)
             option_pairs = option_pairs.reject { |pair| options_key?(pair) }
 
-            return if option_pairs.any? { |pair| ignore_key?(pair) }
+            if option_pairs.any? { |pair| ignore_key?(pair) }
+              return
+            end
 
             if template_node = option_pairs.map { |pair| template_key?(pair) }.compact.first
-              unless literal?(template_node)
+              if !literal?(template_node)
                 add_offense(node)
                 return
               end
@@ -73,7 +75,7 @@ def on_send(node)
             end
 
             if layout_node = option_pairs.map { |pair| layout_key?(pair) }.compact.first
-              unless literal?(layout_node)
+              if !literal?(layout_node)
                 add_offense(node)
                 return
               end
@@ -89,14 +91,16 @@ def on_send(node)
               add_offense(node)
               return
             end
-            option_pairs = option_hash&.pairs
+            option_pairs = option_hash && option_hash.pairs
           else
             option_pairs = node.arguments[0].pairs
           end
 
           if option_pairs
             locals = option_pairs.map { |pair| locals_key?(pair) }.compact.first
-            add_offense(node) if locals && (!locals.hash_type? || !hash_with_literal_keys?(locals))
+            if locals && (!locals.hash_type? || !hash_with_literal_keys?(locals))
+              add_offense(node)
+            end
           end
         end
       end
diff --git a/lib/rubocop/cop/github/rails_controller_render_paths_exist.rb b/lib/rubocop/cop/github/rails_controller_render_paths_exist.rb
index 3f84ce2f..126738a0 100644
--- a/lib/rubocop/cop/github/rails_controller_render_paths_exist.rb
+++ b/lib/rubocop/cop/github/rails_controller_render_paths_exist.rb
@@ -27,16 +27,22 @@ def on_send(node)
 
           if args = render_str?(node)
             node, path = args
-            add_offense(node, message: "Template could not be found") unless resolve_template(path.to_s)
+            unless resolve_template(path.to_s)
+              add_offense(node, message: "Template could not be found")
+            end
           elsif pairs = render_options?(node)
             if pair = pairs.detect { |p| render_key?(p) }
               key, node, path = render_key?(pair)
 
               case key
               when :action, :template
-                add_offense(node, message: "Template could not be found") unless resolve_template(path.to_s)
+                unless resolve_template(path.to_s)
+                  add_offense(node, message: "Template could not be found")
+                end
               when :partial
-                add_offense(node, message: "Partial template could not be found") unless resolve_partial(path.to_s)
+                unless resolve_partial(path.to_s)
+                  add_offense(node, message: "Partial template could not be found")
+                end
               end
             end
           end
@@ -44,7 +50,7 @@ def on_send(node)
 
         def resolve_template(path)
           cop_config["ViewPath"].each do |view_path|
-            if m = Dir["#{File.join(config.path_relative_to_config(view_path), path)}*"].first
+            if m = Dir[File.join(config.path_relative_to_config(view_path), path) + "*"].first
               return m
             end
           end
diff --git a/lib/rubocop/cop/github/rails_controller_render_shorthand.rb b/lib/rubocop/cop/github/rails_controller_render_shorthand.rb
index ae62f71b..58069e10 100644
--- a/lib/rubocop/cop/github/rails_controller_render_shorthand.rb
+++ b/lib/rubocop/cop/github/rails_controller_render_shorthand.rb
@@ -28,8 +28,8 @@ def on_send(node)
               if value_node = action_key?(pair)
                 comma = option_pairs.length > 1 ? ", " : ""
                 corrected_source = node.source
-                                       .sub(/#{pair.source}(,\s*)?/, "")
-                                       .sub("render ", "render \"#{str(value_node)}\"#{comma}")
+                  .sub(/#{pair.source}(,\s*)?/, "")
+                  .sub("render ", "render \"#{str(value_node)}\"#{comma}")
 
                 add_offense(node, message: "Use `#{corrected_source}` instead") do |corrector|
                   corrector.replace(node.source_range, corrected_source)
diff --git a/lib/rubocop/cop/github/rails_render_inline.rb b/lib/rubocop/cop/github/rails_render_inline.rb
index 65c8fb5e..8f76fb2f 100644
--- a/lib/rubocop/cop/github/rails_render_inline.rb
+++ b/lib/rubocop/cop/github/rails_render_inline.rb
@@ -18,7 +18,9 @@ class RailsRenderInline < Base
 
         def on_send(node)
           if option_pairs = render_with_options?(node)
-            add_offense(node) if option_pairs.detect { |pair| inline_key?(pair) }
+            if option_pairs.detect { |pair| inline_key?(pair) }
+              add_offense(node)
+            end
           end
         end
       end
diff --git a/lib/rubocop/cop/github/rails_render_object_collection.rb b/lib/rubocop/cop/github/rails_render_object_collection.rb
index b5a13b53..38a27fa5 100644
--- a/lib/rubocop/cop/github/rails_render_object_collection.rb
+++ b/lib/rubocop/cop/github/rails_render_object_collection.rb
@@ -31,7 +31,9 @@ def on_send(node)
 
               case object_sym
               when :object
-                suggestion = ", instead `render partial: #{partial_name.source}, locals: { #{File.basename(partial_name.children[0], '.html.erb')}: #{object_node.source} }`" if partial_name.children[0].is_a?(String)
+                if partial_name.children[0].is_a?(String)
+                  suggestion = ", instead `render partial: #{partial_name.source}, locals: { #{File.basename(partial_name.children[0], '.html.erb')}: #{object_node.source} }`"
+                end
                 add_offense(node, message: "Avoid `render object:`#{suggestion}")
               when :collection, :spacer_template
                 add_offense(node, message: "Avoid `render collection:`")
diff --git a/lib/rubocop/cop/github/rails_view_render_literal.rb b/lib/rubocop/cop/github/rails_view_render_literal.rb
index d3070d39..c8563868 100644
--- a/lib/rubocop/cop/github/rails_view_render_literal.rb
+++ b/lib/rubocop/cop/github/rails_view_render_literal.rb
@@ -34,10 +34,12 @@ def on_send(node)
 
           if render_literal?(node)
           elsif option_pairs = render_with_options?(node)
-            return if option_pairs.any? { |pair| ignore_key?(pair) }
+            if option_pairs.any? { |pair| ignore_key?(pair) }
+              return
+            end
 
             if partial_node = option_pairs.map { |pair| partial_key?(pair) }.compact.first
-              unless literal?(partial_node)
+              if !literal?(partial_node)
                 add_offense(node)
                 return
               end
@@ -58,7 +60,9 @@ def on_send(node)
 
           if locals
             if locals.hash_type?
-              add_offense(node) unless hash_with_literal_keys?(locals)
+              if !hash_with_literal_keys?(locals)
+                add_offense(node)
+              end
             else
               add_offense(node)
             end
diff --git a/lib/rubocop/cop/github/rails_view_render_paths_exist.rb b/lib/rubocop/cop/github/rails_view_render_paths_exist.rb
index 64234167..49a40f2c 100644
--- a/lib/rubocop/cop/github/rails_view_render_paths_exist.rb
+++ b/lib/rubocop/cop/github/rails_view_render_paths_exist.rb
@@ -27,12 +27,16 @@ def on_send(node)
 
           if args = render_str?(node)
             node, path = args
-            add_offense(node, message: "Partial template could not be found") unless resolve_partial(path.to_s)
+            unless resolve_partial(path.to_s)
+              add_offense(node, message: "Partial template could not be found")
+            end
           elsif pairs = render_options?(node)
             if pair = pairs.detect { |p| partial_key?(p) }
               node, path = partial_key?(pair)
 
-              add_offense(node, message: "Partial template could not be found") unless resolve_partial(path.to_s)
+              unless resolve_partial(path.to_s)
+                add_offense(node, message: "Partial template could not be found")
+              end
             end
           end
         end
@@ -43,7 +47,7 @@ def resolve_partial(path)
           path = parts.join(File::SEPARATOR)
 
           cop_config["ViewPath"].each do |view_path|
-            if m = Dir["#{File.join(config.path_relative_to_config(view_path), path)}*"].first
+            if m = Dir[File.join(config.path_relative_to_config(view_path), path) + "*"].first
               return m
             end
           end
diff --git a/lib/rubocop/cop/github/render_literal_helpers.rb b/lib/rubocop/cop/github/render_literal_helpers.rb
index 6994fb79..67417a54 100644
--- a/lib/rubocop/cop/github/render_literal_helpers.rb
+++ b/lib/rubocop/cop/github/render_literal_helpers.rb
@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-
+#
 require "rubocop"
 
 module RuboCop
diff --git a/test/test_insecure_hash_algorithm.rb b/test/test_insecure_hash_algorithm.rb
index 3e48aa90..597450b8 100644
--- a/test/test_insecure_hash_algorithm.rb
+++ b/test/test_insecure_hash_algorithm.rb
@@ -10,7 +10,7 @@ def cop_class
   end
 
   def make_cop(allowed:)
-    config = RuboCop::Config.new({ "GitHub/InsecureHashAlgorithm" => { "Allowed" => allowed } })
+    config = RuboCop::Config.new({"GitHub/InsecureHashAlgorithm" => {"Allowed" => allowed}})
     cop_class.new(config)
   end
 
diff --git a/test/test_rails_controller_render_literal.rb b/test/test_rails_controller_render_literal.rb
index bd52c7f1..9da2f16c 100644
--- a/test/test_rails_controller_render_literal.rb
+++ b/test/test_rails_controller_render_literal.rb
@@ -442,6 +442,7 @@ def index
     assert_equal 1, offenses.count
   end
 
+
   def test_render_literal_dynamic_local_key_offense
     offenses = investigate cop, <<-RUBY, "app/controllers/products_controller.rb"
       class ProductsController < ActionController::Base

From d95509e71fa988c61d1e02a432a63d1c019d6988 Mon Sep 17 00:00:00 2001
From: Issy Long <issyl0@github.com>
Date: Wed, 12 Oct 2022 10:41:16 +0000
Subject: [PATCH 42/47] Revert "Fix `Naming/MemoizedInstanceVariableName`
 offenses"

This reverts commit e36d683f6b85e7394775a02d9f6321f2cf34b4b5.

 This is because we've now disabled all the rules that would have been
`DisabledByDefault`. This is so that downstream consumers don't get any
nasty surprises. As a result, there should be no RuboCop linting
violations in the code in this repo, so we can back out the changes to
slim the diff: they're now redundant.

Of course, it would be a good idea to go and make these changes at a later
date, but we can do that when we enable the correct rules having matched
each one up with its rationale in our styleguide.
---
 lib/rubocop/cop/github/insecure_hash_algorithm.rb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/rubocop/cop/github/insecure_hash_algorithm.rb b/lib/rubocop/cop/github/insecure_hash_algorithm.rb
index ab73ca1b..de1b321d 100644
--- a/lib/rubocop/cop/github/insecure_hash_algorithm.rb
+++ b/lib/rubocop/cop/github/insecure_hash_algorithm.rb
@@ -93,7 +93,7 @@ def just_encoding?(val)
         ].freeze
 
         def allowed_hash_functions
-          @allowed_hash_functions ||= cop_config.fetch("Allowed", DEFAULT_ALLOWED).map(&:downcase)
+          @allowed_algorithms ||= cop_config.fetch("Allowed", DEFAULT_ALLOWED).map(&:downcase)
         end
 
         def alg_name(val)

From 70dc91b33d08103529870e11d675ab441759b7fb Mon Sep 17 00:00:00 2001
From: Issy Long <issyl0@github.com>
Date: Wed, 12 Oct 2022 10:43:52 +0000
Subject: [PATCH 43/47] config/default: Set `Enabled: false` for new RuboCop
 rules

- The following message appeared when I ran `bundle exec rubocop` on this
  project. Since we're setting everything to `Enabled: false` to mimic
  `DisabledByDefault` for now, let's make this message go away. We almost
  certainly also don't want to blanket enable all new cops, so I've not
  added that configuration.

```
The following cops were added to RuboCop, but are not configured. Please set Enabled to either `true` or `false` in your `.rubocop.yml` file.

Please also note that you can opt-in to new cops by default by adding this to your config:
  AllCops:
    NewCops: enable

Lint/EmptyBlock: # new in 1.1
  Enabled: true
Lint/EmptyClass: # new in 1.3
  Enabled: true
Lint/EmptyInPattern: # new in 1.16
  Enabled: true
For more information: https://docs.rubocop.org/rubocop/versioning.html
```
---
 config/default.yml | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/config/default.yml b/config/default.yml
index dd878514..6dcd009d 100644
--- a/config/default.yml
+++ b/config/default.yml
@@ -429,6 +429,15 @@ Lint/EachWithObjectArgument:
 Lint/ElseLayout:
   Enabled: true
 
+Lint/EmptyBlock:
+  Enabled: false
+
+Lint/EmptyClass:
+  Enabled: false
+
+Lint/EmptyInPattern:
+  Enabled: false
+
 Lint/EmptyConditionalBody:
   Enabled: false
 

From 42740863a57463c67a50cdc071f484f32e3be56f Mon Sep 17 00:00:00 2001
From: Issy Long <issyl0@github.com>
Date: Thu, 13 Oct 2022 11:48:13 +0000
Subject: [PATCH 44/47] CHANGELOG: Note that no new rules are enabled in this
 release

---
 CHANGELOG.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index c42df4d3..2dbdfa85 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -2,4 +2,4 @@
 
 ## Unreleased
 
-- Unset `DisabledByDefault: true` in `config/default.yml`. This will use RuboCop's choice of default cops to enable, plus our existing augmentations in `config/default.yml`. Prevents confusing behaviour where downstream consumers didn't realise that RuboCop's default cops weren't being applied. (https://github.com/github/rubocop-github/pull/119)
+- Unset `DisabledByDefault: true` in `config/default.yml`. Prevents confusing behaviour where users of the gem didn't realise that RuboCop's default cops weren't being applied (including potentially custom cops in their projects). We've explicitly set `Enabled: false` for all the cops that were previously default disabled. This has the effect that consumers of this gem won't be surprised by new linting violations when they use this new version in their projects. (https://github.com/github/rubocop-github/pull/119)

From c49a2efce17e2500cc1a6af6f377bc7c7433047a Mon Sep 17 00:00:00 2001
From: Ben Sheldon <bensheldon@gmail.com>
Date: Tue, 11 Oct 2022 20:00:16 -0700
Subject: [PATCH 45/47] Separate Ruby (`rubocop-github`) from Rails
 (`rubocop-github-rails`) cops and rules to disambiguate rule inheritance from
 custom cops

---
 .rubocop.yml                 |  5 ++-
 Gemfile.lock                 |  3 ++
 README.md                    | 42 ++++++++++++++----------
 config/default.yml           |  2 +-
 config/default_cops.yml      |  3 ++
 config/rails.yml             | 34 +-------------------
 config/rails_cops.yml        | 62 ++++++++++++++++++++++++++++++++++++
 lib/rubocop-github-rails.rb  | 18 +++++++++++
 lib/rubocop-github.rb        |  9 ++++++
 lib/rubocop/cop/github.rb    | 13 ++------
 lib/rubocop/github.rb        |  9 ++++++
 lib/rubocop/github/inject.rb | 27 ++++++++++++++++
 12 files changed, 165 insertions(+), 62 deletions(-)
 create mode 100644 config/default_cops.yml
 create mode 100644 config/rails_cops.yml
 create mode 100644 lib/rubocop-github-rails.rb
 create mode 100644 lib/rubocop-github.rb
 create mode 100644 lib/rubocop/github.rb
 create mode 100644 lib/rubocop/github/inject.rb

diff --git a/.rubocop.yml b/.rubocop.yml
index 802a6e67..9c49771d 100644
--- a/.rubocop.yml
+++ b/.rubocop.yml
@@ -1,6 +1,9 @@
-inherit_from: ./config/default.yml
+inherit_from:
+  - ./config/default.yml
 
 Naming/FileName:
   Enabled: true
   Exclude:
     - "rubocop-github.gemspec"
+    - "lib/rubocop-github.rb"
+    - "lib/rubocop-github-rails.rb"
diff --git a/Gemfile.lock b/Gemfile.lock
index 41c4de23..e0932d27 100644
--- a/Gemfile.lock
+++ b/Gemfile.lock
@@ -31,6 +31,8 @@ GEM
       crass (~> 1.0.2)
       nokogiri (>= 1.5.9)
     minitest (5.16.1)
+    nokogiri (1.13.6-arm64-darwin)
+      racc (~> 1.4)
     nokogiri (1.13.6-x86_64-darwin)
       racc (~> 1.4)
     parallel (1.22.1)
@@ -71,6 +73,7 @@ GEM
     unicode-display_width (2.2.0)
 
 PLATFORMS
+  arm64-darwin-21
   x86_64-darwin-19
   x86_64-darwin-20
 
diff --git a/README.md b/README.md
index da686741..541fbe37 100644
--- a/README.md
+++ b/README.md
@@ -4,22 +4,32 @@ This repository provides recommended RuboCop configuration and additional Cops f
 
 ## Usage
 
-**Gemfile**
-
-``` ruby
-gem "rubocop-github"
-gem "rubocop-performance", require: false
-gem "rubocop-rails", require: false
-```
-
-**.rubocop.yml**
-
-``` yaml
-inherit_gem:
-  rubocop-github:
-    - config/default.yml
-    - config/rails.yml
-```
+Add `rubocop-github` to your Gemfile, along with its dependencies:
+
+  ```ruby
+  gem "rubocop-github", require: false
+  gem "rubocop-performance", require: false
+  gem "rubocop-rails", require: false
+  ```
+
+Inherit all of the stylistic rules and cops through an inheritance declaration in your `.rubocop.yml`:
+
+  ```yaml
+  # .rubocop.yml
+  inherit_from:
+    rubocop-github:
+      - config/default.yml # generic Ruby rules and cops
+      - config/rails.yml # Rails-specific rules and cops
+  ```
+
+Alternatively, only require the additional custom cops in your `.rubocop.yml` without inheriting/enabling the other stylistic rules:
+
+  ```yaml
+  # .rubocop.yml
+  require:
+    - rubocop-github  # generic Ruby cops only
+    - rubocop-github-rails # Rails-specific cops only
+  ```
 
 💭 Looking for `config/accessibility.yml` and the `GitHub/Accessibility` configs? They have been moved to [a new gem](https://github.com/github/rubocop-rails-accessibility).
 
diff --git a/config/default.yml b/config/default.yml
index 67af72a5..d5952dce 100644
--- a/config/default.yml
+++ b/config/default.yml
@@ -1,5 +1,5 @@
 require:
-  - rubocop/cop/github
+  - rubocop-github
   - rubocop-performance
 
 AllCops:
diff --git a/config/default_cops.yml b/config/default_cops.yml
new file mode 100644
index 00000000..00b5ea04
--- /dev/null
+++ b/config/default_cops.yml
@@ -0,0 +1,3 @@
+GitHub/InsecureHashAlgorithm:
+  Description: 'Encourage usage of secure hash algorithms'
+  Enabled: pending
diff --git a/config/rails.yml b/config/rails.yml
index ab16d61e..2782574f 100644
--- a/config/rails.yml
+++ b/config/rails.yml
@@ -1,4 +1,5 @@
 require:
+  - rubocop-github-rails
   - rubocop-rails
 
 Rails/OutputSafety:
@@ -22,63 +23,30 @@ GitHub/RailsApplicationRecord:
 
 GitHub/RailsControllerRenderActionSymbol:
   Enabled: true
-  Include:
-    - 'app/controllers/**/*.rb'
 
 GitHub/RailsControllerRenderLiteral:
   Enabled: true
-  StyleGuide: https://github.com/github/rubocop-github/blob/master/guides/rails-render-literal.md
-  Include:
-    - 'app/controllers/**/*.rb'
 
 GitHub/RailsControllerRenderPathsExist:
   Enabled: true
-  ViewPath:
-    - 'app/views'
-  Include:
-    - 'app/controllers/**/*.rb'
 
 GitHub/RailsControllerRenderShorthand:
   Enabled: true
-  StyleGuide: https://github.com/github/rubocop-github/blob/master/guides/rails-controller-render-shorthand.md
-  Include:
-    - 'app/controllers/**/*.rb'
 
 GitHub/RailsRenderInline:
   Enabled: true
-  StyleGuide: https://github.com/github/rubocop-github/blob/master/guides/rails-controller-render-inline.md
-  Include:
-    - 'app/controllers/**/*.rb'
-    - 'app/helpers/**/*.rb'
-    - 'app/view_models/**/*.rb'
-    - 'app/views/**/*.erb'
 
 GitHub/RailsRenderObjectCollection:
   Enabled: false
 
 GitHub/RailsViewRenderLiteral:
   Enabled: true
-  StyleGuide: https://github.com/github/rubocop-github/blob/master/guides/rails-render-literal.md
-  Include:
-    - 'app/helpers/**/*.rb'
-    - 'app/view_models/**/*.rb'
-    - 'app/views/**/*.erb'
 
 GitHub/RailsViewRenderPathsExist:
   Enabled: true
-  ViewPath:
-    - 'app/views'
-  Include:
-    - 'app/helpers/**/*.rb'
-    - 'app/view_models/**/*.rb'
-    - 'app/views/**/*.erb'
 
 GitHub/RailsViewRenderShorthand:
   Enabled: true
-  Include:
-    - 'app/helpers/**/*.rb'
-    - 'app/view_models/**/*.rb'
-    - 'app/views/**/*.erb'
 
 # Exclude Rails ERB files from incompatible cops
 
diff --git a/config/rails_cops.yml b/config/rails_cops.yml
new file mode 100644
index 00000000..ef3d9a4f
--- /dev/null
+++ b/config/rails_cops.yml
@@ -0,0 +1,62 @@
+GitHub/RailsApplicationRecord:
+  Enabled: pending
+
+GitHub/RailsControllerRenderActionSymbol:
+  Enabled: pending
+  Include:
+    - 'app/controllers/**/*.rb'
+
+GitHub/RailsControllerRenderLiteral:
+  Enabled: pending
+  StyleGuide: https://github.com/github/rubocop-github/blob/master/guides/rails-render-literal.md
+  Include:
+    - 'app/controllers/**/*.rb'
+
+GitHub/RailsControllerRenderPathsExist:
+  Enabled: pending
+  ViewPath:
+    - 'app/views'
+  Include:
+    - 'app/controllers/**/*.rb'
+
+GitHub/RailsControllerRenderShorthand:
+  Enabled: pending
+  StyleGuide: https://github.com/github/rubocop-github/blob/master/guides/rails-controller-render-shorthand.md
+  Include:
+    - 'app/controllers/**/*.rb'
+
+GitHub/RailsRenderInline:
+  Enabled: pending
+  StyleGuide: https://github.com/github/rubocop-github/blob/master/guides/rails-controller-render-inline.md
+  Include:
+    - 'app/controllers/**/*.rb'
+    - 'app/helpers/**/*.rb'
+    - 'app/view_models/**/*.rb'
+    - 'app/views/**/*.erb'
+
+GitHub/RailsRenderObjectCollection:
+  Enabled: pending
+
+GitHub/RailsViewRenderLiteral:
+  Enabled: pending
+  StyleGuide: https://github.com/github/rubocop-github/blob/master/guides/rails-render-literal.md
+  Include:
+    - 'app/helpers/**/*.rb'
+    - 'app/view_models/**/*.rb'
+    - 'app/views/**/*.erb'
+
+GitHub/RailsViewRenderPathsExist:
+  Enabled: pending
+  ViewPath:
+    - 'app/views'
+  Include:
+    - 'app/helpers/**/*.rb'
+    - 'app/view_models/**/*.rb'
+    - 'app/views/**/*.erb'
+
+GitHub/RailsViewRenderShorthand:
+  Enabled: pending
+  Include:
+    - 'app/helpers/**/*.rb'
+    - 'app/view_models/**/*.rb'
+    - 'app/views/**/*.erb'
diff --git a/lib/rubocop-github-rails.rb b/lib/rubocop-github-rails.rb
new file mode 100644
index 00000000..02aa6adc
--- /dev/null
+++ b/lib/rubocop-github-rails.rb
@@ -0,0 +1,18 @@
+# frozen_string_literal: true
+
+require "rubocop"
+require "rubocop/github"
+require "rubocop/github/inject"
+
+RuboCop::GitHub::Inject.rails_defaults!
+
+require "rubocop/cop/github/rails_application_record"
+require "rubocop/cop/github/rails_controller_render_action_symbol"
+require "rubocop/cop/github/rails_controller_render_literal"
+require "rubocop/cop/github/rails_controller_render_paths_exist"
+require "rubocop/cop/github/rails_controller_render_shorthand"
+require "rubocop/cop/github/rails_render_inline"
+require "rubocop/cop/github/rails_render_object_collection"
+require "rubocop/cop/github/rails_view_render_literal"
+require "rubocop/cop/github/rails_view_render_paths_exist"
+require "rubocop/cop/github/rails_view_render_shorthand"
diff --git a/lib/rubocop-github.rb b/lib/rubocop-github.rb
new file mode 100644
index 00000000..17c07e77
--- /dev/null
+++ b/lib/rubocop-github.rb
@@ -0,0 +1,9 @@
+# frozen_string_literal: true
+
+require "rubocop"
+require "rubocop/github"
+require "rubocop/github/inject"
+
+RuboCop::GitHub::Inject.default_defaults!
+
+require "rubocop/cop/github/insecure_hash_algorithm"
diff --git a/lib/rubocop/cop/github.rb b/lib/rubocop/cop/github.rb
index e978c2b9..fa55c2d2 100644
--- a/lib/rubocop/cop/github.rb
+++ b/lib/rubocop/cop/github.rb
@@ -1,13 +1,4 @@
 # frozen_string_literal: true
 
-require "rubocop/cop/github/insecure_hash_algorithm"
-require "rubocop/cop/github/rails_application_record"
-require "rubocop/cop/github/rails_controller_render_action_symbol"
-require "rubocop/cop/github/rails_controller_render_literal"
-require "rubocop/cop/github/rails_controller_render_paths_exist"
-require "rubocop/cop/github/rails_controller_render_shorthand"
-require "rubocop/cop/github/rails_render_inline"
-require "rubocop/cop/github/rails_render_object_collection"
-require "rubocop/cop/github/rails_view_render_literal"
-require "rubocop/cop/github/rails_view_render_paths_exist"
-require "rubocop/cop/github/rails_view_render_shorthand"
+require "rubocop-github"
+require "rubocop-rails"
diff --git a/lib/rubocop/github.rb b/lib/rubocop/github.rb
new file mode 100644
index 00000000..d367f815
--- /dev/null
+++ b/lib/rubocop/github.rb
@@ -0,0 +1,9 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module GitHub
+    PROJECT_ROOT   = Pathname.new(__dir__).parent.parent.expand_path.freeze
+    CONFIG_DEFAULT = PROJECT_ROOT.join("config", "default_cops.yml").freeze
+    CONFIG_RAILS = PROJECT_ROOT.join("config", "rails_cops.yml").freeze
+  end
+end
diff --git a/lib/rubocop/github/inject.rb b/lib/rubocop/github/inject.rb
new file mode 100644
index 00000000..697a5809
--- /dev/null
+++ b/lib/rubocop/github/inject.rb
@@ -0,0 +1,27 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module GitHub
+    # Because RuboCop doesn't yet support plugins, we have to monkey patch in a
+    # bit of our configuration. Borrowed from:
+    # https://github.com/rubocop/rubocop-rails/blob/f36121946359615a26c9a941763abd1470693e8d/lib/rubocop/rails/inject.rb
+    module Inject
+      def self.default_defaults!
+        _load_config(CONFIG_DEFAULT)
+      end
+
+      def self.rails_defaults!
+        _load_config(CONFIG_RAILS)
+      end
+
+      def self._load_config(path)
+        path = path.to_s
+        hash = ConfigLoader.send(:load_yaml_configuration, path)
+        config = Config.new(hash, path).tap(&:make_excludes_absolute)
+        puts "configuration from #{path}" if ConfigLoader.debug?
+        config = ConfigLoader.merge_with_default(config, path, unset_nil: false)
+        ConfigLoader.instance_variable_set(:@default_configuration, config)
+      end
+    end
+  end
+end

From 6bbad25c67a56fc07e9d5ef3498e0861fcf34a33 Mon Sep 17 00:00:00 2001
From: Ben Sheldon <bensheldon@gmail.com>
Date: Thu, 13 Oct 2022 08:22:12 -0700
Subject: [PATCH 46/47] Disable all of the DisabledByDefault Rails cops too

---
 config/rails.yml | 401 ++++++++++++++++++++++++++++++++++++++++++-----
 1 file changed, 360 insertions(+), 41 deletions(-)

diff --git a/config/rails.yml b/config/rails.yml
index 2782574f..e414a00a 100644
--- a/config/rails.yml
+++ b/config/rails.yml
@@ -2,22 +2,6 @@ require:
   - rubocop-github-rails
   - rubocop-rails
 
-Rails/OutputSafety:
-  Enabled: true
-
-Rails/PluralizationGrammar:
-  Enabled: true
-
-Rails/RequestReferer:
-  Enabled: true
-  EnforcedStyle: referrer
-
-Rails/ScopeArgs:
-  Enabled: true
-
-Rails/UniqBeforePluck:
-  Enabled: true
-
 GitHub/RailsApplicationRecord:
   Enabled: true
 
@@ -48,48 +32,383 @@ GitHub/RailsViewRenderPathsExist:
 GitHub/RailsViewRenderShorthand:
   Enabled: true
 
-# Exclude Rails ERB files from incompatible cops
-
 Layout/BlockAlignment:
   Exclude:
-    - 'app/views/**/*.erb'
+    - app/views/**/*.erb
 
-Style/For:
-  Exclude:
-    - 'app/views/**/*.erb'
-
-Style/OneLineConditional:
+Layout/IndentationWidth:
   Exclude:
-    - 'app/views/**/*.erb'
+    - app/views/**/*.erb
 
-Style/Semicolon:
+Layout/InitialIndentation:
   Exclude:
-    - 'app/views/**/*.erb'
+    - app/views/**/*.erb
 
 Layout/SpaceInsideParens:
   Exclude:
-    - 'app/views/**/*.erb'
-
-Style/StringLiterals:
-  Exclude:
-    - 'app/views/**/*.erb'
+    - app/views/**/*.erb
 
 Layout/TrailingEmptyLines:
   Exclude:
-    - 'app/views/**/*.erb'
+    - app/views/**/*.erb
 
 Layout/TrailingWhitespace:
   Exclude:
-    - 'app/views/**/*.erb'
+    - app/views/**/*.erb
 
-Layout/IndentationWidth:
+Lint/UselessAccessModifier:
+  ContextCreatingMethods:
+    - concerning
+
+Rails/ActionControllerTestCase:
+  Enabled: false
+
+Rails/ActionFilter:
+  Enabled: false
+
+Rails/ActiveRecordAliases:
+  Enabled: false
+
+Rails/ActiveRecordCallbacksOrder:
+  Enabled: false
+
+Rails/ActiveRecordOverride:
+  Enabled: false
+
+Rails/ActiveSupportAliases:
+  Enabled: false
+
+Rails/AddColumnIndex:
+  Enabled: false
+
+Rails/AfterCommitOverride:
+  Enabled: false
+
+Rails/ApplicationController:
+  Enabled: false
+
+Rails/ApplicationJob:
+  Enabled: false
+
+Rails/ApplicationMailer:
+  Enabled: false
+
+Rails/ApplicationRecord:
+  Enabled: false
+
+Rails/ArelStar:
+  Enabled: false
+
+Rails/AssertNot:
+  Enabled: false
+
+Rails/AttributeDefaultBlockValue:
+  Enabled: false
+
+Rails/BelongsTo:
+  Enabled: false
+
+Rails/Blank:
+  Enabled: false
+
+Rails/BulkChangeTable:
+  Enabled: false
+
+Rails/CompactBlank:
+  Enabled: false
+
+Rails/ContentTag:
+  Enabled: false
+
+Rails/CreateTableWithTimestamps:
+  Enabled: false
+
+Rails/Date:
+  Enabled: false
+
+Rails/DefaultScope:
+  Enabled: false
+
+Rails/Delegate:
+  Enabled: false
+
+Rails/DelegateAllowBlank:
+  Enabled: false
+
+Rails/DeprecatedActiveModelErrorsMethods:
+  Enabled: false
+
+Rails/DotSeparatedKeys:
+  Enabled: false
+
+Rails/DuplicateAssociation:
+  Enabled: false
+
+Rails/DuplicateScope:
+  Enabled: false
+
+Rails/DurationArithmetic:
+  Enabled: false
+
+Rails/DynamicFindBy:
+  Enabled: false
+
+Rails/EagerEvaluationLogMessage:
+  Enabled: false
+
+Rails/EnumHash:
+  Enabled: false
+
+Rails/EnumUniqueness:
+  Enabled: false
+
+Rails/EnvironmentComparison:
+  Enabled: false
+
+Rails/EnvironmentVariableAccess:
+  Enabled: false
+
+Rails/Exit:
+  Enabled: false
+
+Rails/ExpandedDateRange:
+  Enabled: false
+
+Rails/FilePath:
+  Enabled: false
+
+Rails/FindBy:
+  Enabled: false
+
+Rails/FindById:
+  Enabled: false
+
+Rails/FindEach:
+  Enabled: false
+
+Rails/HasAndBelongsToMany:
+  Enabled: false
+
+Rails/HasManyOrHasOneDependent:
+  Enabled: false
+
+Rails/HelperInstanceVariable:
+  Enabled: false
+
+Rails/HttpPositionalArguments:
+  Enabled: false
+
+Rails/HttpStatus:
+  Enabled: false
+
+Rails/I18nLazyLookup:
+  Enabled: false
+
+Rails/I18nLocaleAssignment:
+  Enabled: false
+
+Rails/I18nLocaleTexts:
+  Enabled: false
+
+Rails/IgnoredSkipActionFilterOption:
+  Enabled: false
+
+Rails/IndexBy:
+  Enabled: false
+
+Rails/IndexWith:
+  Enabled: false
+
+Rails/Inquiry:
+  Enabled: false
+
+Rails/InverseOf:
+  Enabled: false
+
+Rails/LexicallyScopedActionFilter:
+  Enabled: false
+
+Rails/LinkToBlank:
+  Enabled: false
+
+Rails/MailerName:
+  Enabled: false
+
+Rails/MatchRoute:
+  Enabled: false
+
+Rails/MigrationClassName:
+  Enabled: false
+
+Rails/NegateInclude:
+  Enabled: false
+
+Rails/NotNullColumn:
+  Enabled: false
+
+Rails/OrderById:
+  Enabled: false
+
+Rails/Output:
+  Enabled: false
+
+Rails/OutputSafety:
+  Enabled: true
+
+Rails/Pick:
+  Enabled: false
+
+Rails/Pluck:
+  Enabled: false
+
+Rails/PluckId:
+  Enabled: false
+
+Rails/PluckInWhere:
+  Enabled: false
+
+Rails/PluralizationGrammar:
+  Enabled: true
+
+Rails/Presence:
+  Enabled: false
+
+Rails/Present:
+  Enabled: false
+
+Rails/RakeEnvironment:
+  Enabled: false
+
+Rails/ReadWriteAttribute:
+  Enabled: false
+
+Rails/RedundantAllowNil:
+  Enabled: false
+
+Rails/RedundantForeignKey:
+  Enabled: false
+
+Rails/RedundantPresenceValidationOnBelongsTo:
+  Enabled: false
+
+Rails/RedundantReceiverInWithOptions:
+  Enabled: false
+
+Rails/RedundantTravelBack:
+  Enabled: false
+
+Rails/ReflectionClassName:
+  Enabled: false
+
+Rails/RefuteMethods:
+  Enabled: false
+
+Rails/RelativeDateConstant:
+  Enabled: false
+
+Rails/RenderInline:
+  Enabled: false
+
+Rails/RenderPlainText:
+  Enabled: false
+
+Rails/RequestReferer:
+  Enabled: true
+  EnforcedStyle: referrer
+
+Rails/RequireDependency:
+  Enabled: false
+
+Rails/ReversibleMigration:
+  Enabled: false
+
+Rails/ReversibleMigrationMethodDefinition:
+  Enabled: false
+
+Rails/RootJoinChain:
+  Enabled: false
+
+Rails/RootPublicPath:
+  Enabled: false
+
+Rails/SafeNavigation:
+  Enabled: false
+
+Rails/SafeNavigationWithBlank:
+  Enabled: false
+
+Rails/SaveBang:
+  Enabled: false
+
+Rails/SchemaComment:
+  Enabled: false
+
+Rails/ScopeArgs:
+  Enabled: true
+
+Rails/ShortI18n:
+  Enabled: false
+
+Rails/SkipsModelValidations:
+  Enabled: false
+
+Rails/SquishedSQLHeredocs:
+  Enabled: false
+
+Rails/StripHeredoc:
+  Enabled: false
+
+Rails/TableNameAssignment:
+  Enabled: false
+
+Rails/TimeZone:
+  Enabled: false
+
+Rails/TimeZoneAssignment:
+  Enabled: false
+
+Rails/ToFormattedS:
+  Enabled: false
+
+Rails/TransactionExitStatement:
+  Enabled: false
+
+Rails/UniqBeforePluck:
+  Enabled: true
+
+Rails/UniqueValidationWithoutIndex:
+  Enabled: false
+
+Rails/UnknownEnv:
+  Enabled: false
+
+Rails/UnusedIgnoredColumns:
+  Enabled: false
+
+Rails/Validation:
+  Enabled: false
+
+Rails/WhereEquals:
+  Enabled: false
+
+Rails/WhereExists:
+  Enabled: false
+
+Rails/WhereNot:
+  Enabled: false
+
+Style/For:
   Exclude:
-    - 'app/views/**/*.erb'
+    - app/views/**/*.erb
 
-Layout/InitialIndentation:
+Style/OneLineConditional:
   Exclude:
-    - 'app/views/**/*.erb'
+    - app/views/**/*.erb
 
-Lint/UselessAccessModifier:
-  ContextCreatingMethods:
-    - concerning
+Style/Semicolon:
+  Exclude:
+    - app/views/**/*.erb
+
+Style/StringLiterals:
+  Exclude:
+    - app/views/**/*.erb

From 40349f514428fa56efdc36dfe94cb3ed81a9a510 Mon Sep 17 00:00:00 2001
From: Ben Sheldon <bensheldon@gmail.com>
Date: Thu, 13 Oct 2022 08:33:13 -0700
Subject: [PATCH 47/47] Release v0.19.0

---
 CHANGELOG.md           | 2 ++
 Gemfile.lock           | 2 +-
 rubocop-github.gemspec | 2 +-
 3 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 2dbdfa85..7b4ce534 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -2,4 +2,6 @@
 
 ## Unreleased
 
+## v0.19.0
+
 - Unset `DisabledByDefault: true` in `config/default.yml`. Prevents confusing behaviour where users of the gem didn't realise that RuboCop's default cops weren't being applied (including potentially custom cops in their projects). We've explicitly set `Enabled: false` for all the cops that were previously default disabled. This has the effect that consumers of this gem won't be surprised by new linting violations when they use this new version in their projects. (https://github.com/github/rubocop-github/pull/119)
diff --git a/Gemfile.lock b/Gemfile.lock
index e0932d27..e597b511 100644
--- a/Gemfile.lock
+++ b/Gemfile.lock
@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    rubocop-github (0.18.0)
+    rubocop-github (0.19.0)
       rubocop (>= 1.0.0)
       rubocop-performance
       rubocop-rails
diff --git a/rubocop-github.gemspec b/rubocop-github.gemspec
index d18c7205..7b243dd4 100644
--- a/rubocop-github.gemspec
+++ b/rubocop-github.gemspec
@@ -2,7 +2,7 @@
 
 Gem::Specification.new do |s|
   s.name = "rubocop-github"
-  s.version = "0.18.0"
+  s.version = "0.19.0"
   s.summary = "RuboCop GitHub"
   s.description = "Code style checking for GitHub Ruby repositories "
   s.homepage = "https://github.com/github/rubocop-github"

<!DOCTYPE html PUBLIC '-//W3C//DTD XHTML 1.0 Transitional//EN' 'http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd'>
<html xmlns='http://www.w3.org/1999/xhtml'>
<head>
<title>pFad - Phonifier reborn</title>
<meta http-equiv='Content-Type' content='text/html; charset=utf-8' />
</head>
<body>
<h1>Pfad - The Proxy pFad of &#169; 2024 Garber Painting. All rights reserved.</h1>


<!-- Disclaimer -->
<p>Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.</p>
<br>
<p>Alternative Proxies:</p><p><a href="http://rainy.clevelandohioweatherforecast.com/php-proxy/index.php?q=https://github.com/github/rubocop-github/compare/v0.18.0...v0.19.0.patch" target="_blank">Alternative Proxy</a></p><p><a href="http://rainy.clevelandohioweatherforecast.com/pFad/index.php?u=https://github.com/github/rubocop-github/compare/v0.18.0...v0.19.0.patch" target="_blank">pFad Proxy</a></p><p><a href="http://rainy.clevelandohioweatherforecast.com/pFad/v3index.php?u=https://github.com/github/rubocop-github/compare/v0.18.0...v0.19.0.patch" target="_blank">pFad v3 Proxy</a></p><p><a href="http://rainy.clevelandohioweatherforecast.com/pFad/v4index.php?u=https://github.com/github/rubocop-github/compare/v0.18.0...v0.19.0.patch" target="_blank">pFad v4 Proxy</a></p></body>
</html>