From fb79321412edd95913cf2a55be900c0978c0b98a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Adri=C3=A1n=20Bolonio?= <bolonio@github.com>
Date: Thu, 28 Jul 2022 14:54:39 +0000
Subject: [PATCH 1/3] Add new a11y rubocop rule: LinkHref

---
 lib/rubocop/cop/github/rails_link_href.rb | 25 ++++++++++++++++++++
 test/test_rails_link_href.rb              | 28 +++++++++++++++++++++++
 2 files changed, 53 insertions(+)
 create mode 100644 lib/rubocop/cop/github/rails_link_href.rb
 create mode 100644 test/test_rails_link_href.rb

diff --git a/lib/rubocop/cop/github/rails_link_href.rb b/lib/rubocop/cop/github/rails_link_href.rb
new file mode 100644
index 00000000..f2165f7b
--- /dev/null
+++ b/lib/rubocop/cop/github/rails_link_href.rb
@@ -0,0 +1,25 @@
+# frozen_string_literal: true
+
+require "rubocop"
+
+module RuboCop
+  module Cop
+    module GitHub
+      module Accessibility
+        class LinkHref < Base
+          MSG = "Links should go somewhere, you probably want to use a `<button>` instead.".freeze
+
+          def on_send(node)
+            receiver, method_name, *args = *node
+
+            if receiver.nil? && method_name == :link_to
+              if args.first.type == :str && args.first.children.first == "#"
+                add_offense(node.loc.selector)
+              end
+            end
+          end
+        end
+      end
+    end
+  end
+end
diff --git a/test/test_rails_link_href.rb b/test/test_rails_link_href.rb
new file mode 100644
index 00000000..cc961c8f
--- /dev/null
+++ b/test/test_rails_link_href.rb
@@ -0,0 +1,28 @@
+# frozen_string_literal: true
+
+require_relative "./cop_test"
+require "minitest/autorun"
+require "rubocop/cop/github/rails_link_href"
+
+class LinkHref < CopTest
+  def cop_class
+    RuboCop::Cop::GitHub::Accessibility::LinkHref
+  end
+
+  def test_link_href_offense
+    offenses = erb_investigate cop, <<-ERB, "app/views/products/index.html.erb"
+      <%= link_to 'Go to GitHub' %>
+    ERB
+
+    assert_equal 1, offenses.count
+    assert_equal "Links should go somewhere, you probably want to use a `<button>` instead.", offenses[0].message
+  end
+
+  def test_link_href_no_offense
+    offenses = erb_investigate cop, <<-ERB, "app/views/products/index.html.erb"
+      <%= link_to 'Go to GitHub', 'https://github.com/' %>
+    ERB
+    
+    assert_equal 0, offenses.count
+  end
+end

From b6645c249a3050ce450fdd95bd73d65bec0a7ced Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Adri=C3=A1n=20Bolonio?= <bolonio@github.com>
Date: Mon, 1 Aug 2022 09:35:22 +0000
Subject: [PATCH 2/3] Add documentation, Move to accessibility folder, Add
 config

---
 config/accessibility.yml                      |  5 +++-
 guides/link-has-href.md                       | 27 +++++++++++++++++++
 .../link_has_href.rb}                         |  4 +--
 ...ils_link_href.rb => test_link_has_href.rb} | 19 ++++++++-----
 4 files changed, 46 insertions(+), 9 deletions(-)
 create mode 100644 guides/link-has-href.md
 rename lib/rubocop/cop/github/{rails_link_href.rb => accessibility/link_has_href.rb} (77%)
 rename test/{test_rails_link_href.rb => test_link_has_href.rb} (54%)

diff --git a/config/accessibility.yml b/config/accessibility.yml
index 00f871c6..44839317 100644
--- a/config/accessibility.yml
+++ b/config/accessibility.yml
@@ -3,4 +3,7 @@ require:
 
 GitHub/Accessibility/ImageHasAlt:
   Enabled: true
-  StyleGuide: https://github.com/github/rubocop-github/blob/master/guides/image-has-alt.md
\ No newline at end of file
+  StyleGuide: https://github.com/github/rubocop-github/blob/master/guides/image-has-alt.md
+GitHub/Accessibility/LinkHasHref:
+  Enabled: true
+  StyleGuide: https://github.com/github/rubocop-github/blob/master/guides/link-has-href.md
\ No newline at end of file
diff --git a/guides/link-has-href.md b/guides/link-has-href.md
new file mode 100644
index 00000000..7a8d4efa
--- /dev/null
+++ b/guides/link-has-href.md
@@ -0,0 +1,27 @@
+# GitHub/Accessibility/LinkHasHref
+
+## Rule Details
+
+Links should go somewhere, you probably want to use a `<button>` instead.
+
+## Resources
+
+- TBD
+
+## Examples
+### **Incorrect** code for this rule 👎
+
+```erb
+<%= link_to 'Go to GitHub' %>
+```
+
+```erb
+<%= link_to 'Go to GitHub', '#' %>
+```
+
+### **Correct** code for this rule  👍
+
+```erb
+<!-- good -->
+<%= link_to 'Go to GitHub', 'https://github.com/' %>
+```
diff --git a/lib/rubocop/cop/github/rails_link_href.rb b/lib/rubocop/cop/github/accessibility/link_has_href.rb
similarity index 77%
rename from lib/rubocop/cop/github/rails_link_href.rb
rename to lib/rubocop/cop/github/accessibility/link_has_href.rb
index f2165f7b..751c564c 100644
--- a/lib/rubocop/cop/github/rails_link_href.rb
+++ b/lib/rubocop/cop/github/accessibility/link_has_href.rb
@@ -6,14 +6,14 @@ module RuboCop
   module Cop
     module GitHub
       module Accessibility
-        class LinkHref < Base
+        class LinkHasHref < Base
           MSG = "Links should go somewhere, you probably want to use a `<button>` instead.".freeze
 
           def on_send(node)
             receiver, method_name, *args = *node
 
             if receiver.nil? && method_name == :link_to
-              if args.first.type == :str && args.first.children.first == "#"
+              if args.length == 1 || (args.length > 1 && args[1].type == :str && args[1].children.first == "#")
                 add_offense(node.loc.selector)
               end
             end
diff --git a/test/test_rails_link_href.rb b/test/test_link_has_href.rb
similarity index 54%
rename from test/test_rails_link_href.rb
rename to test/test_link_has_href.rb
index cc961c8f..b68dc92e 100644
--- a/test/test_rails_link_href.rb
+++ b/test/test_link_has_href.rb
@@ -2,27 +2,34 @@
 
 require_relative "./cop_test"
 require "minitest/autorun"
-require "rubocop/cop/github/rails_link_href"
+require "rubocop/cop/github/accessibility/link_has_href"
 
-class LinkHref < CopTest
+class LinkHasHref < CopTest
   def cop_class
-    RuboCop::Cop::GitHub::Accessibility::LinkHref
+    RuboCop::Cop::GitHub::Accessibility::LinkHasHref
   end
 
-  def test_link_href_offense
+  def test_link_has_href_offense
     offenses = erb_investigate cop, <<-ERB, "app/views/products/index.html.erb"
       <%= link_to 'Go to GitHub' %>
     ERB
 
     assert_equal 1, offenses.count
     assert_equal "Links should go somewhere, you probably want to use a `<button>` instead.", offenses[0].message
+
+    offenses = erb_investigate cop, <<-ERB, "app/views/products/index.html.erb"
+      <%= link_to 'Go to GitHub', '#' %>
+    ERB
+
+    assert_equal 1, offenses.count
+    assert_equal "Links should go somewhere, you probably want to use a `<button>` instead.", offenses[0].message
   end
 
-  def test_link_href_no_offense
+  def test_link_has_href_no_offense
     offenses = erb_investigate cop, <<-ERB, "app/views/products/index.html.erb"
       <%= link_to 'Go to GitHub', 'https://github.com/' %>
     ERB
-    
+
     assert_equal 0, offenses.count
   end
 end

From 295968ef0fa211f8deb7269b347b2e64714703e3 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Adri=C3=A1n=20Bolonio?= <bolonio@github.com>
Date: Mon, 1 Aug 2022 12:10:02 +0000
Subject: [PATCH 3/3] Update docs

---
 guides/link-has-href.md | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/guides/link-has-href.md b/guides/link-has-href.md
index 7a8d4efa..8a574c94 100644
--- a/guides/link-has-href.md
+++ b/guides/link-has-href.md
@@ -6,7 +6,9 @@ Links should go somewhere, you probably want to use a `<button>` instead.
 
 ## Resources
 
-- TBD
+- [`<a>`: The Anchor element](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/a)
+- [Primer: Links](https://primer.style/design/accessibility/links)
+- [HTML Spec: The a element](https://html.spec.whatwg.org/multipage/text-level-semantics.html#the-a-element)
 
 ## Examples
 ### **Incorrect** code for this rule 👎

<!DOCTYPE html PUBLIC '-//W3C//DTD XHTML 1.0 Transitional//EN' 'http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd'>
<html xmlns='http://www.w3.org/1999/xhtml'>
<head>
<title>pFad - Phonifier reborn</title>
<meta http-equiv='Content-Type' content='text/html; charset=utf-8' />
</head>
<body>
<h1>Pfad - The Proxy pFad of &#169; 2024 Garber Painting. All rights reserved.</h1>


<!-- Disclaimer -->
<p>Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.</p>
<br>
<p>Alternative Proxies:</p><p><a href="http://rainy.clevelandohioweatherforecast.com/php-proxy/index.php?q=https://patch-diff.githubusercontent.com/raw/github/rubocop-github/pull/108.patch" target="_blank">Alternative Proxy</a></p><p><a href="http://rainy.clevelandohioweatherforecast.com/pFad/index.php?u=https://patch-diff.githubusercontent.com/raw/github/rubocop-github/pull/108.patch" target="_blank">pFad Proxy</a></p><p><a href="http://rainy.clevelandohioweatherforecast.com/pFad/v3index.php?u=https://patch-diff.githubusercontent.com/raw/github/rubocop-github/pull/108.patch" target="_blank">pFad v3 Proxy</a></p><p><a href="http://rainy.clevelandohioweatherforecast.com/pFad/v4index.php?u=https://patch-diff.githubusercontent.com/raw/github/rubocop-github/pull/108.patch" target="_blank">pFad v4 Proxy</a></p></body>
</html>