From 42c405a2d9b2e0809c4c45b9bfd9782e471f4365 Mon Sep 17 00:00:00 2001 From: GrantBirki Date: Mon, 24 Feb 2025 13:55:40 -0800 Subject: [PATCH 01/12] run `bundle update` to bump all the gems --- Gemfile.lock | 28 ++++++++++++++-------------- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/Gemfile.lock b/Gemfile.lock index 9b458cd9..59dc2267 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -9,25 +9,25 @@ PATH GEM remote: https://rubygems.org/ specs: - actionview (7.1.5.1) - activesupport (= 7.1.5.1) + actionview (8.0.1) + activesupport (= 8.0.1) builder (~> 3.1) erubi (~> 1.11) rails-dom-testing (~> 2.2) rails-html-sanitizer (~> 1.6) - activesupport (7.1.5.1) + activesupport (8.0.1) base64 benchmark (>= 0.3) bigdecimal - concurrent-ruby (~> 1.0, >= 1.0.2) + concurrent-ruby (~> 1.0, >= 1.3.1) connection_pool (>= 2.2.5) drb i18n (>= 1.6, < 2) logger (>= 1.4.2) minitest (>= 5.1) - mutex_m securerandom (>= 0.3) - tzinfo (~> 2.0) + tzinfo (~> 2.0, >= 2.0.5) + uri (>= 0.13.1) ast (2.4.2) base64 (0.2.0) benchmark (0.4.0) @@ -37,27 +37,26 @@ GEM connection_pool (2.5.0) crass (1.0.6) drb (2.2.1) - erubi (1.13.0) + erubi (1.13.1) i18n (1.14.7) concurrent-ruby (~> 1.0) json (2.10.1) language_server-protocol (3.17.0.4) lint_roller (1.1.0) logger (1.6.6) - loofah (2.23.1) + loofah (2.24.0) crass (~> 1.0.2) nokogiri (>= 1.12.0) mini_portile2 (2.8.8) minitest (5.25.4) - mutex_m (0.3.0) - nokogiri (1.17.2) + nokogiri (1.18.3) mini_portile2 (~> 2.8.2) racc (~> 1.4) - nokogiri (1.17.2-arm64-darwin) + nokogiri (1.18.3-arm64-darwin) racc (~> 1.4) - nokogiri (1.17.2-x86_64-darwin) + nokogiri (1.18.3-x86_64-darwin) racc (~> 1.4) - nokogiri (1.17.2-x86_64-linux) + nokogiri (1.18.3-x86_64-linux-gnu) racc (~> 1.4) parallel (1.26.3) parser (3.3.7.1) @@ -99,12 +98,13 @@ GEM rubocop (>= 1.72.1, < 2.0) rubocop-ast (>= 1.38.0, < 2.0) ruby-progressbar (1.13.0) - securerandom (0.3.2) + securerandom (0.4.1) tzinfo (2.0.6) concurrent-ruby (~> 1.0) unicode-display_width (3.1.4) unicode-emoji (~> 4.0, >= 4.0.4) unicode-emoji (4.0.4) + uri (1.0.2) PLATFORMS arm64-darwin-21 From a590c16465afee82fbbde4adc539363261804e03 Mon Sep 17 00:00:00 2001 From: GrantBirki Date: Mon, 24 Feb 2025 13:57:09 -0800 Subject: [PATCH 02/12] change order so ruby_version is on top --- rubocop-github.gemspec | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/rubocop-github.gemspec b/rubocop-github.gemspec index a7f53d19..fad23002 100644 --- a/rubocop-github.gemspec +++ b/rubocop-github.gemspec @@ -18,6 +18,8 @@ Gem::Specification.new do |s| s.files = Dir["README.md", "STYLEGUIDE.md", "LICENSE", "config/*.yml", "lib/**/*.rb", "guides/*.md"] + s.required_ruby_version = ">= 3.0.0" + s.add_dependency "rubocop", ">= 1.37" s.add_dependency "rubocop-performance", ">= 1.15" s.add_dependency "rubocop-rails", ">= 2.17" @@ -26,8 +28,6 @@ Gem::Specification.new do |s| s.add_development_dependency "minitest" s.add_development_dependency "rake" - s.required_ruby_version = ">= 3.0.0" - s.email = "engineering@github.com" s.authors = "GitHub" end From e5574be60c8fdb4b542e3d0d6e86e75eed15f222 Mon Sep 17 00:00:00 2001 From: GrantBirki Date: Mon, 24 Feb 2025 14:06:50 -0800 Subject: [PATCH 03/12] change gem requirements so tests pass for Ruby 3.0 and 3.1 versions --- Gemfile.lock | 19 ++++++++++--------- rubocop-github.gemspec | 3 ++- 2 files changed, 12 insertions(+), 10 deletions(-) diff --git a/Gemfile.lock b/Gemfile.lock index 59dc2267..ad5601d2 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -9,25 +9,25 @@ PATH GEM remote: https://rubygems.org/ specs: - actionview (8.0.1) - activesupport (= 8.0.1) + actionview (7.1.5.1) + activesupport (= 7.1.5.1) builder (~> 3.1) erubi (~> 1.11) rails-dom-testing (~> 2.2) rails-html-sanitizer (~> 1.6) - activesupport (8.0.1) + activesupport (7.1.5.1) base64 benchmark (>= 0.3) bigdecimal - concurrent-ruby (~> 1.0, >= 1.3.1) + concurrent-ruby (~> 1.0, >= 1.0.2) connection_pool (>= 2.2.5) drb i18n (>= 1.6, < 2) logger (>= 1.4.2) minitest (>= 5.1) + mutex_m securerandom (>= 0.3) - tzinfo (~> 2.0, >= 2.0.5) - uri (>= 0.13.1) + tzinfo (~> 2.0) ast (2.4.2) base64 (0.2.0) benchmark (0.4.0) @@ -49,6 +49,7 @@ GEM nokogiri (>= 1.12.0) mini_portile2 (2.8.8) minitest (5.25.4) + mutex_m (0.3.0) nokogiri (1.18.3) mini_portile2 (~> 2.8.2) racc (~> 1.4) @@ -98,13 +99,12 @@ GEM rubocop (>= 1.72.1, < 2.0) rubocop-ast (>= 1.38.0, < 2.0) ruby-progressbar (1.13.0) - securerandom (0.4.1) + securerandom (0.3.2) tzinfo (2.0.6) concurrent-ruby (~> 1.0) unicode-display_width (3.1.4) unicode-emoji (~> 4.0, >= 4.0.4) unicode-emoji (4.0.4) - uri (1.0.2) PLATFORMS arm64-darwin-21 @@ -114,10 +114,11 @@ PLATFORMS x86_64-linux DEPENDENCIES - actionview + actionview (~> 7.1.5.1) minitest rake rubocop-github! + securerandom (~> 0.3.2) BUNDLED WITH 2.4.9 diff --git a/rubocop-github.gemspec b/rubocop-github.gemspec index fad23002..85c7a97a 100644 --- a/rubocop-github.gemspec +++ b/rubocop-github.gemspec @@ -24,9 +24,10 @@ Gem::Specification.new do |s| s.add_dependency "rubocop-performance", ">= 1.15" s.add_dependency "rubocop-rails", ">= 2.17" - s.add_development_dependency "actionview" + s.add_development_dependency "actionview", "~> 7.1.5.1" s.add_development_dependency "minitest" s.add_development_dependency "rake" + s.add_development_dependency "securerandom", "~> 0.3.2" s.email = "engineering@github.com" s.authors = "GitHub" From 59e951fe3c4874cc33103d227babb841d5a0013c Mon Sep 17 00:00:00 2001 From: GrantBirki Date: Mon, 24 Feb 2025 14:10:00 -0800 Subject: [PATCH 04/12] remove pin --- Gemfile.lock | 1 - rubocop-github.gemspec | 1 - 2 files changed, 2 deletions(-) diff --git a/Gemfile.lock b/Gemfile.lock index ad5601d2..0605411d 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -118,7 +118,6 @@ DEPENDENCIES minitest rake rubocop-github! - securerandom (~> 0.3.2) BUNDLED WITH 2.4.9 diff --git a/rubocop-github.gemspec b/rubocop-github.gemspec index 85c7a97a..8f0f0ef4 100644 --- a/rubocop-github.gemspec +++ b/rubocop-github.gemspec @@ -27,7 +27,6 @@ Gem::Specification.new do |s| s.add_development_dependency "actionview", "~> 7.1.5.1" s.add_development_dependency "minitest" s.add_development_dependency "rake" - s.add_development_dependency "securerandom", "~> 0.3.2" s.email = "engineering@github.com" s.authors = "GitHub" From 277e4add03c9b3f7fe473cf58b357844865004a7 Mon Sep 17 00:00:00 2001 From: GrantBirki Date: Mon, 24 Feb 2025 14:10:42 -0800 Subject: [PATCH 05/12] remove ruby 3.0 from test suite --- .github/workflows/test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 7a95733d..f9d43d38 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -15,7 +15,7 @@ jobs: strategy: fail-fast: false matrix: - ruby_version: ["3.0", "3.1", "3.2", "3.3"] + ruby_version: ["3.1", "3.2", "3.3"] steps: - uses: actions/checkout@v4 From 0bcb35056de17f859fa9fbfd67b36ff76c52197a Mon Sep 17 00:00:00 2001 From: GrantBirki Date: Mon, 24 Feb 2025 14:12:42 -0800 Subject: [PATCH 06/12] add Ruby 3.4 to the test suite --- .github/workflows/test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index f9d43d38..aebd3962 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -15,7 +15,7 @@ jobs: strategy: fail-fast: false matrix: - ruby_version: ["3.1", "3.2", "3.3"] + ruby_version: ["3.1", "3.2", "3.3", "3.4"] steps: - uses: actions/checkout@v4 From fe4e0d132751ec7460f506bbd527917836e9cf64 Mon Sep 17 00:00:00 2001 From: GrantBirki Date: Mon, 24 Feb 2025 14:17:40 -0800 Subject: [PATCH 07/12] bump securerandom --- Gemfile.lock | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Gemfile.lock b/Gemfile.lock index 0605411d..e86d00ce 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -99,7 +99,7 @@ GEM rubocop (>= 1.72.1, < 2.0) rubocop-ast (>= 1.38.0, < 2.0) ruby-progressbar (1.13.0) - securerandom (0.3.2) + securerandom (0.4.1) tzinfo (2.0.6) concurrent-ruby (~> 1.0) unicode-display_width (3.1.4) From 74ffb61574a244453cc7ec30379b055dd1e96e71 Mon Sep 17 00:00:00 2001 From: GrantBirki Date: Mon, 24 Feb 2025 14:18:56 -0800 Subject: [PATCH 08/12] use the latest available version of ruby --- .ruby-version | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.ruby-version b/.ruby-version index e4604e3a..4d9d11cf 100644 --- a/.ruby-version +++ b/.ruby-version @@ -1 +1 @@ -3.2.1 +3.4.2 From d38437326a77bb00a0f586c398229ed82cde6522 Mon Sep 17 00:00:00 2001 From: GrantBirki Date: Mon, 24 Feb 2025 14:20:13 -0800 Subject: [PATCH 09/12] use the latest available version of bundler (`2.6.5`) --- Gemfile.lock | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Gemfile.lock b/Gemfile.lock index e86d00ce..d4bfa04e 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -120,4 +120,4 @@ DEPENDENCIES rubocop-github! BUNDLED WITH - 2.4.9 + 2.6.5 From c971bc5c76bd68337aa0774ec5997b627bca8b67 Mon Sep 17 00:00:00 2001 From: GrantBirki Date: Mon, 24 Feb 2025 14:26:17 -0800 Subject: [PATCH 10/12] bump version to v0.23.0 --- CHANGELOG.md | 4 ++++ Gemfile.lock | 2 +- lib/version.rb | 2 +- 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index bf2db2f4..2496c68f 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,9 @@ # rubocop-github +## v0.23.0 + +- Read the automatic release notes on [the /releases page for this gem](https://github.com/github/rubocop-github/releases). + ## v0.22.0 - Read the automatic release notes on [the /releases page for this gem](https://github.com/github/rubocop-github/releases). diff --git a/Gemfile.lock b/Gemfile.lock index d4bfa04e..61b040cc 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -1,7 +1,7 @@ PATH remote: . specs: - rubocop-github (0.22.0) + rubocop-github (0.23.0) rubocop (>= 1.37) rubocop-performance (>= 1.15) rubocop-rails (>= 2.17) diff --git a/lib/version.rb b/lib/version.rb index 3ed48bc6..fd3043d4 100644 --- a/lib/version.rb +++ b/lib/version.rb @@ -1,3 +1,3 @@ # frozen_string_literal: true -VERSION = "0.22.0" +VERSION = "0.23.0" From c760634e686a9c51e25110055b3bd92878b87a07 Mon Sep 17 00:00:00 2001 From: GrantBirki Date: Tue, 25 Feb 2025 09:12:01 -0800 Subject: [PATCH 11/12] remove version bump --- Gemfile.lock | 2 +- lib/version.rb | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Gemfile.lock b/Gemfile.lock index 61b040cc..d4bfa04e 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -1,7 +1,7 @@ PATH remote: . specs: - rubocop-github (0.23.0) + rubocop-github (0.22.0) rubocop (>= 1.37) rubocop-performance (>= 1.15) rubocop-rails (>= 2.17) diff --git a/lib/version.rb b/lib/version.rb index fd3043d4..3ed48bc6 100644 --- a/lib/version.rb +++ b/lib/version.rb @@ -1,3 +1,3 @@ # frozen_string_literal: true -VERSION = "0.23.0" +VERSION = "0.22.0" From 2ae67258663e15bc53f8f05fdf54dc457ba43dc7 Mon Sep 17 00:00:00 2001 From: GrantBirki Date: Tue, 25 Feb 2025 09:12:58 -0800 Subject: [PATCH 12/12] remove changelog changes --- CHANGELOG.md | 4 ---- 1 file changed, 4 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 2496c68f..bf2db2f4 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,9 +1,5 @@ # rubocop-github -## v0.23.0 - -- Read the automatic release notes on [the /releases page for this gem](https://github.com/github/rubocop-github/releases). - ## v0.22.0 - Read the automatic release notes on [the /releases page for this gem](https://github.com/github/rubocop-github/releases). pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy