Merge pull request #224 from Shopify/compile-stats

maximecb · web-flow · commit 44faa18c5f5e · 2021-09-15T13:01:13.000-07:00
Add counters for tracking invalidations
diff --git a/yjit.rb b/yjit.rb
@@ -177,6 +177,9 @@ def _print_stats
       yjit_ratio_pct = 100.0 * retired_in_yjit.to_f / total_insns_count
 
       $stderr.puts "compiled_iseq_count:   " + ("%10d" % stats[:compiled_iseq_count])
+      $stderr.puts "compiled_block_count:  " + ("%10d" % stats[:compiled_block_count])
+      $stderr.puts "invalidation_count:    " + ("%10d" % stats[:invalidation_count])
+      $stderr.puts "constant_state_bumps:  " + ("%10d" % stats[:constant_state_bumps])
       $stderr.puts "inline_code_size:      " + ("%10d" % stats[:inline_code_size])
       $stderr.puts "outlined_code_size:    " + ("%10d" % stats[:outlined_code_size])
 
diff --git a/yjit_core.c b/yjit_core.c
@@ -558,6 +558,10 @@ add_block_version(blockid_t blockid, block_t* block)
             RB_OBJ_WRITTEN(iseq, Qundef, object);
         }
     }
+
+#if YJIT_STATS
+    yjit_runtime_counters.compiled_block_count++;
+#endif
 }
 
 // Create a new outgoing branch entry for a block
@@ -1145,6 +1149,10 @@ invalidate_block_version(block_t *block)
 
     yjit_free_block(block);
 
+#if YJIT_STATS
+    yjit_runtime_counters.invalidation_count++;
+#endif
+
     // fprintf(stderr, "invalidation done\n");
 }
 
diff --git a/yjit_iface.c b/yjit_iface.c
@@ -591,6 +591,9 @@ rb_yjit_constant_state_changed(void)
 {
     if (blocks_assuming_stable_global_constant_state) {
         st_foreach(blocks_assuming_stable_global_constant_state, block_invalidation_iterator, 0);
+#if YJIT_STATS
+        yjit_runtime_counters.constant_state_bumps++;
+#endif
     }
 }
 
diff --git a/yjit_iface.h b/yjit_iface.h
@@ -87,6 +87,9 @@ YJIT_DECLARE_COUNTERS(
 
     vm_insns_count,
     compiled_iseq_count,
+    compiled_block_count,
+    invalidation_count,
+    constant_state_bumps,
 
     expandarray_splat,
     expandarray_postarg,

Original file line number	Diff line number	Diff line change
`@@ -558,6 +558,10 @@ add_block_version(blockid_t blockid, block_t* block)`
`558`	`558`	`RB_OBJ_WRITTEN(iseq, Qundef, object);`
`559`	`559`	`}`
`560`	`560`	`}`
	`561`	`+`
	`562`	`+#if YJIT_STATS`
	`563`	`+ yjit_runtime_counters.compiled_block_count++;`
	`564`	`+#endif`
`561`	`565`	`}`
`562`	`566`
`563`	`567`	`// Create a new outgoing branch entry for a block`
`@@ -1145,6 +1149,10 @@ invalidate_block_version(block_t *block)`
`1145`	`1149`
`1146`	`1150`	`yjit_free_block(block);`
`1147`	`1151`
	`1152`	`+#if YJIT_STATS`
	`1153`	`+ yjit_runtime_counters.invalidation_count++;`
	`1154`	`+#endif`
	`1155`	`+`
`1148`	`1156`	`// fprintf(stderr, "invalidation done\n");`
`1149`	`1157`	`}`
`1150`	`1158`
Original file line number	Diff line number	Diff line change
`@@ -591,6 +591,9 @@ rb_yjit_constant_state_changed(void)`
`591`	`591`	`{`
`592`	`592`	`if (blocks_assuming_stable_global_constant_state) {`
`593`	`593`	`st_foreach(blocks_assuming_stable_global_constant_state, block_invalidation_iterator, 0);`
	`594`	`+#if YJIT_STATS`
	`595`	`+ yjit_runtime_counters.constant_state_bumps++;`
	`596`	`+#endif`
`594`	`597`	`}`
`595`	`598`	`}`
`596`	`599`