Add waitFor for failing tests

tuan-nguen · tuan-nguen · commit 21dd9a1f0c76 · 2025-03-28T12:20:03.000Z
diff --git a/extensions/ql-vscode/src/view/model-editor/__tests__/MethodRow.spec.tsx b/extensions/ql-vscode/src/view/model-editor/__tests__/MethodRow.spec.tsx
@@ -2,6 +2,7 @@ import {
   getAllByRole,
   render as reactRender,
   screen,
+  waitFor,
 } from "@testing-library/react";
 import { createMethod } from "../../../../test/factories/model-editor/method-factories";
 import type { MethodRowProps } from "../MethodRow";
@@ -245,7 +246,9 @@ describe(MethodRow.name, () => {
 
     const addButton = await screen.findByLabelText("Add new model");
     expect(addButton).toBeInTheDocument();
-    expect(addButton).toBeDisabled();
+    await waitFor(() => {
+      expect(addButton).toBeDisabled();
+    });
 
     expect(screen.queryByLabelText("Remove model")).not.toBeInTheDocument();
   });
@@ -257,7 +260,9 @@ describe(MethodRow.name, () => {
 
     const addButton = await screen.findByLabelText("Add new model");
     expect(addButton).toBeInTheDocument();
-    expect(addButton).toBeDisabled();
+    await waitFor(() => {
+      expect(addButton).toBeDisabled();
+    });
 
     expect(screen.queryByLabelText("Remove model")).not.toBeInTheDocument();
   });
diff --git a/extensions/ql-vscode/src/view/model-editor/__tests__/ModelEvaluation.spec.tsx b/extensions/ql-vscode/src/view/model-editor/__tests__/ModelEvaluation.spec.tsx
@@ -1,4 +1,4 @@
-import { render as reactRender, screen } from "@testing-library/react";
+import { render as reactRender, screen, waitFor } from "@testing-library/react";
 import type { Props } from "../ModelEvaluation";
 import { ModelEvaluation } from "../ModelEvaluation";
 import { createMockModelEditorViewState } from "../../../../test/factories/model-editor/view-state";
@@ -58,7 +58,9 @@ describe(ModelEvaluation.name, () => {
 
       const evaluateButton = await screen.findByText("Evaluate");
       expect(evaluateButton).toBeInTheDocument();
-      expect(evaluateButton).toBeDisabled();
+      await waitFor(() => {
+        expect(evaluateButton).toBeDisabled();
+      });
 
       expect(screen.queryByText("Stop evaluation")).not.toBeInTheDocument();
 
@@ -72,7 +74,9 @@ describe(ModelEvaluation.name, () => {
 
       const evaluateButton = await screen.findByText("Evaluate");
       expect(evaluateButton).toBeInTheDocument();
-      expect(evaluateButton).toBeDisabled();
+      await waitFor(() => {
+        expect(evaluateButton).toBeDisabled();
+      });
 
       expect(screen.queryByText("Stop evaluation")).not.toBeInTheDocument();
 
