Fix tests for VariantAnalysis

tuan-nguen · tuan-nguen · commit a4b3d5364103 · 2025-03-28T10:36:10.000Z
diff --git a/extensions/ql-vscode/src/view/method-modeling/__tests__/MultipleModeledMethodsPanel.spec.tsx b/extensions/ql-vscode/src/view/method-modeling/__tests__/MultipleModeledMethodsPanel.spec.tsx
@@ -521,12 +521,11 @@ describe(MultipleModeledMethodsPanel.name, () => {
 
     const render = createRender(modeledMethods);
 
-    it("can add modeling", () => {
+    it("can add modeling", async () => {
       render();
 
-      expect(
-        screen.getByLabelText("Add modeling").getElementsByTagName("input")[0],
-      ).toBeEnabled();
+      const addButton = await screen.findByLabelText("Add modeling");
+      expect(addButton).toBeEnabled();
     });
 
     it("can delete first modeling", async () => {
diff --git a/extensions/ql-vscode/src/view/variant-analysis/__tests__/VariantAnalysis.spec.tsx b/extensions/ql-vscode/src/view/variant-analysis/__tests__/VariantAnalysis.spec.tsx
@@ -1,4 +1,4 @@
-import { render as reactRender, screen, waitFor } from "@testing-library/react";
+import { render as reactRender, screen } from "@testing-library/react";
 import {
   VariantAnalysisFailureReason,
   VariantAnalysisStatus,
@@ -57,9 +57,6 @@ describe(VariantAnalysis.name, () => {
     const variantAnalysis = createMockVariantAnalysis({});
     render({ variantAnalysis });
 
-    await waitFor(() => screen.getByDisplayValue("All"));
-    await waitFor(() => screen.getByDisplayValue("Number of results"));
-
     await postMessage<ToVariantAnalysisMessage>({
       t: "setFilterSortState",
       filterSortState: {
@@ -69,8 +66,11 @@ describe(VariantAnalysis.name, () => {
       },
     });
 
-    expect(screen.getByDisplayValue("With results")).toBeInTheDocument();
-    expect(screen.getByDisplayValue("Alphabetically")).toBeInTheDocument();
+    const withResults = await screen.findByText("With results");
+    expect(withResults).toBeInTheDocument();
+
+    const alphabetically = await screen.findByText("Alphabetically");
+    expect(alphabetically).toBeInTheDocument();
 
     expect(screen.queryByDisplayValue("All")).not.toBeInTheDocument();
     expect(
