Skip to content

Some PRs logged for the wrong releases #617

@hunner

Description

@hunner

1f68ef8 causes many PRs to be logged in the changelog incorrectly.

One problem caused by this this is because the merged_at date (on github's PR api) can be 1+ seconds later than the merge commit date because the PR is closed after the merge commit is pushed. This matters because if the merge commit of a PR is the tagged SHA then that PR is considered part of the next release (it's merged_at time is later than the date of the tagged SHA).

Another issue I haven't found the root cause yet is that some commits that are rebased may be mentioned as being in a later release, such as #274 and #275 ; #274 went out in 1.8.4 and #275 in 1.8.5, and all 1.15.x tags currently incorrectly place this in 1.8.5.

This should be fixed before 1.15.0 goes out. Otherwise changelogs generated with 1.14.x or earlier will be incorrectly reorganized.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      pFad - Phonifier reborn

      Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

      Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


      Alternative Proxies:

      Alternative Proxy

      pFad Proxy

      pFad v3 Proxy

      pFad v4 Proxy