From 464aadfba9b635b50a9233f1c3007750a2f5f2b6 Mon Sep 17 00:00:00 2001 From: Olle Jonsson Date: Tue, 1 Oct 2019 20:38:32 +0100 Subject: [PATCH 1/7] CI: Use the shorter image names for less maint (#716) --- .circleci/config.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 86c9b9748..f5b7051e2 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -27,19 +27,19 @@ jobs: "ruby-23": <<: *shared docker: - - image: circleci/ruby:2.3.8-node-browsers + - image: circleci/ruby:2.3-node-browsers "ruby-24": <<: *shared docker: - - image: circleci/ruby:2.4.5-node-browsers + - image: circleci/ruby:2.4-node-browsers "ruby-25": <<: *shared docker: - - image: circleci/ruby:2.5.3-node-browsers + - image: circleci/ruby:2.5-node-browsers "ruby-26": <<: *shared docker: - - image: circleci/ruby:2.6.1-node-browsers + - image: circleci/ruby:2.6-node-browsers "jruby-91": <<: *shared docker: From 00560f7ce360bafa7b87b449ff0d6bed47ee9f9e Mon Sep 17 00:00:00 2001 From: Marco Ferrari Date: Sat, 5 Oct 2019 09:35:19 +0200 Subject: [PATCH 2/7] Fix Performance/Count in entry_spec --- spec/unit/generator/entry_spec.rb | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/spec/unit/generator/entry_spec.rb b/spec/unit/generator/entry_spec.rb index 5da720766..8626189d7 100644 --- a/spec/unit/generator/entry_spec.rb +++ b/spec/unit/generator/entry_spec.rb @@ -544,7 +544,7 @@ def default_sections end it "returns default sections" do - default_sections.each { |default_section| expect(entry_sections.select { |section| section.name == default_section }.size).to eq 1 } + default_sections.each { |default_section| expect(entry_sections.count { |section| section.name == default_section }).to eq 1 } end it "assigns issues to the correct sections" do @@ -607,8 +607,8 @@ def default_sections end it "returns only configured sections" do - expect(entry_sections.select { |section| section.name == "foo" }.size).to eq 1 - expect(entry_sections.select { |section| section.name == "bar" }.size).to eq 1 + expect(entry_sections.count { |section| section.name == "foo" }).to eq 1 + expect(entry_sections.count { |section| section.name == "bar" }).to eq 1 end it "assigns issues to the correct sections" do @@ -665,8 +665,8 @@ def default_sections end it "returns only configured sections" do - expect(entry_sections.select { |section| section.name == "foo" }.size).to eq 1 - expect(entry_sections.select { |section| section.name == "bar" }.size).to eq 1 + expect(entry_sections.count { |section| section.name == "foo" }).to eq 1 + expect(entry_sections.count { |section| section.name == "bar" }).to eq 1 end it "assigns issues to the correct sections" do @@ -729,11 +729,11 @@ def default_sections end it "returns default sections" do - default_sections.each { |default_section| expect(entry_sections.select { |section| section.name == default_section }.size).to eq 1 } + default_sections.each { |default_section| expect(entry_sections.count { |section| section.name == default_section }).to eq 1 } end it "returns added section" do - expect(entry_sections.select { |section| section.name == "foo" }.size).to eq 1 + expect(entry_sections.count { |section| section.name == "foo" }).to eq 1 end it "assigns issues to the correct sections" do From 08459b850312f640ae08b4728e33fc4d9cd84279 Mon Sep 17 00:00:00 2001 From: Marco Ferrari Date: Sat, 5 Oct 2019 09:43:27 +0200 Subject: [PATCH 3/7] Update changelog before 1.15.0 --- CHANGELOG.md | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index e4bbea010..82f8959a3 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,6 +1,6 @@ # Change Log -## [1.15.0](https://github.com/github-changelog-generator/github-changelog-generator/tree/1.15.0) (2019-08-06) +## [1.15.0](https://github.com/github-changelog-generator/github-changelog-generator/tree/1.15.0) (2019-10-05) [Full Changelog](https://github.com/github-changelog-generator/github-changelog-generator/compare/v1.15.0.pre.rc...1.15.0) @@ -8,6 +8,7 @@ - CircleCI: Add a build matrix [\#685](https://github.com/github-changelog-generator/github-changelog-generator/issues/685) - A way to add release summaries [\#582](https://github.com/github-changelog-generator/github-changelog-generator/issues/582) +- CI: Use the shorter image names for less maint [\#716](https://github.com/github-changelog-generator/github-changelog-generator/pull/716) ([olleolleolle](https://github.com/olleolleolle)) - Build matrix for different ruby & jruby versions [\#686](https://github.com/github-changelog-generator/github-changelog-generator/pull/686) ([szemek](https://github.com/szemek)) - CircleCI 2.0 configuration [\#684](https://github.com/github-changelog-generator/github-changelog-generator/pull/684) ([szemek](https://github.com/szemek)) - 588 : Added new line after credits [\#627](https://github.com/github-changelog-generator/github-changelog-generator/pull/627) ([qwerty2323](https://github.com/qwerty2323)) @@ -26,6 +27,7 @@ **Closed issues:** +- Gitea integration [\#735](https://github.com/github-changelog-generator/github-changelog-generator/issues/735) - Could we publish the latest version to gem? [\#722](https://github.com/github-changelog-generator/github-changelog-generator/issues/722) - docker container waits for a long time, then crashes [\#717](https://github.com/github-changelog-generator/github-changelog-generator/issues/717) - N/A [\#713](https://github.com/github-changelog-generator/github-changelog-generator/issues/713) @@ -45,6 +47,7 @@ - Can we exclude closed Requests [\#632](https://github.com/github-changelog-generator/github-changelog-generator/issues/632) - Version in master branch hangs on MacOS [\#629](https://github.com/github-changelog-generator/github-changelog-generator/issues/629) - Some PRs logged for the wrong releases [\#617](https://github.com/github-changelog-generator/github-changelog-generator/issues/617) +- Is there way to list referenced but not closed issues? [\#609](https://github.com/github-changelog-generator/github-changelog-generator/issues/609) - since\_tag with unreleased tag unexpected behavior [\#604](https://github.com/github-changelog-generator/github-changelog-generator/issues/604) - Generator doesn't work when I run the command presented in the docs [\#599](https://github.com/github-changelog-generator/github-changelog-generator/issues/599) - Move repo to organisation [\#595](https://github.com/github-changelog-generator/github-changelog-generator/issues/595) @@ -1046,4 +1049,4 @@ -\* *This Change Log was automatically generated by [github_changelog_generator](https://github.com/skywinder/Github-Changelog-Generator)* +\* *This Change Log was automatically generated by [github_changelog_generator](https://github.com/skywinder/Github-Changelog-Generator)* \ No newline at end of file From 31c9482969a77da18e8056d91b2ee4a110c6366d Mon Sep 17 00:00:00 2001 From: Marco Ferrari Date: Sat, 5 Oct 2019 10:06:03 +0200 Subject: [PATCH 4/7] v1.15.0 --- lib/github_changelog_generator/version.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/github_changelog_generator/version.rb b/lib/github_changelog_generator/version.rb index 8a98a4f52..507620a23 100644 --- a/lib/github_changelog_generator/version.rb +++ b/lib/github_changelog_generator/version.rb @@ -1,5 +1,5 @@ # frozen_string_literal: true module GitHubChangelogGenerator - VERSION = "1.15.0-rc" + VERSION = "1.15.0" end From 2116ff9b11e329e7de13adab6775e2dc77c693d9 Mon Sep 17 00:00:00 2001 From: Marco Ferrari Date: Sat, 5 Oct 2019 10:11:54 +0200 Subject: [PATCH 5/7] Add release instructions to CONTRIBUTING --- CONTRIBUTING.md | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 5251a760a..51906b8b0 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -58,3 +58,15 @@ Use the [ronn] gem to generate `.1` and `.html` artifacts like this: `cd man; ro [github-changelog-generator on Rubydoc.info]: http://www.rubydoc.info/gems/github_changelog_generator [ronn]: https://github.com/rtomayko/ronn [github-changelog-generator on Inch CI]: https://inch-ci.org/github/github-changelog-generator/github-changelog-generator + +## Releasing a new version + +1. Clone the repository +1. Install the dependencies (look at the CI configuration for the most updated procedure) +1. Update the changelog (and commit it afterwards): `github_changelog_generator -t --future-release ` +1. Push the changes and wait for the latest CI build to complete +1. Bump the version, create a Git tag and commit the changes: `bundle exec bump pre --tag` +1. Push the version bump commit: `git push` +1. Push the Git tag: `git push --tags` +1. Build the new gem +1. Push the new gem From 4883a8be97b81d4ebd66965b427c1712cde66476 Mon Sep 17 00:00:00 2001 From: Marco Ferrari Date: Mon, 28 Oct 2019 17:17:53 +0100 Subject: [PATCH 6/7] Update the gem release procedure --- CONTRIBUTING.md | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 51906b8b0..4ce1d490d 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -64,9 +64,16 @@ Use the [ronn] gem to generate `.1` and `.html` artifacts like this: `cd man; ro 1. Clone the repository 1. Install the dependencies (look at the CI configuration for the most updated procedure) 1. Update the changelog (and commit it afterwards): `github_changelog_generator -t --future-release ` +1. Update the certification authority: `bundle exec rake update_ssl_ca_file` 1. Push the changes and wait for the latest CI build to complete 1. Bump the version, create a Git tag and commit the changes: `bundle exec bump pre --tag` 1. Push the version bump commit: `git push` 1. Push the Git tag: `git push --tags` -1. Build the new gem -1. Push the new gem +1. Build the new gem: `bundle exec rake build` +1. Push the new gem: `bundle exec rake release` + +If you get the `Your rubygems.org credentials aren't set` error, set your RubyGems.org credentials: + +```shell +curl -u your-rubygems-username https://rubygems.org/api/v1/api_key.yaml > $HOME/.gem/credentials +``` From 58b262dc1bcf05a2e0332a435b173bd6134d9f88 Mon Sep 17 00:00:00 2001 From: RafaAudibert - Deepin Date: Mon, 30 Sep 2019 21:32:39 -0300 Subject: [PATCH 7/7] Handling case insensitive exclude labels Added tests for case_insensitive exclude_labels --- .../generator/generator_processor.rb | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/github_changelog_generator/generator/generator_processor.rb b/lib/github_changelog_generator/generator/generator_processor.rb index 09d7bab7c..f23d99415 100644 --- a/lib/github_changelog_generator/generator/generator_processor.rb +++ b/lib/github_changelog_generator/generator/generator_processor.rb @@ -8,9 +8,10 @@ class Generator def exclude_issues_by_labels(issues) return issues if !options[:exclude_labels] || options[:exclude_labels].empty? + exclude_labels = options[:exclude_labels].map(&:downcase) issues.reject do |issue| - labels = issue["labels"].map { |l| l["name"] } - (labels & options[:exclude_labels]).any? + issue_labels = issue["labels"].map { |label| label["name"].downcase } + (issue_labels & exclude_labels).any? end end pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy