diff --git a/.rubocop.yml b/.rubocop.yml index 733e76a06..e4ace89b9 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -9,7 +9,7 @@ AllCops: - 'vendor/**/*' - 'gemfiles/**/*' -Metrics/LineLength: +Layout/LineLength: Enabled: false Performance/RegexpMatch: diff --git a/lib/github_changelog_generator/generator/section.rb b/lib/github_changelog_generator/generator/section.rb index b66972e2c..8fdded5d6 100644 --- a/lib/github_changelog_generator/generator/section.rb +++ b/lib/github_changelog_generator/generator/section.rb @@ -112,7 +112,10 @@ def encapsulate_string(string) string = string.gsub('\\', '\\\\') ENCAPSULATED_CHARACTERS.each do |char| - string = string.gsub(char, "\\#{char}") + # Only replace char with escaped version if it isn't inside backticks (markdown inline code). + # This relies on each opening '`' being closed (ie an even number in total). + # A char is *outside* backticks if there is an even number of backticks following it. + string = string.gsub(%r{#{Regexp.escape(char)}(?=([^`]*`[^`]*`)*[^`]*$)}, "\\#{char}") end string diff --git a/spec/unit/generator/section_spec.rb b/spec/unit/generator/section_spec.rb new file mode 100644 index 000000000..369d5304c --- /dev/null +++ b/spec/unit/generator/section_spec.rb @@ -0,0 +1,34 @@ +# frozen_string_literal: true + +module GitHubChangelogGenerator + RSpec.describe Section do + let(:options) { {} } + subject(:section) { described_class.new(options) } + + describe "#encapsulate_string" do + let(:string) { "" } + + context "with the empty string" do + it "returns the string" do + expect(section.send(:encapsulate_string, string)).to eq string + end + end + + context "with a string with an escape-needing character in it" do + let(:string) { " and outside" } + + it "returns the string escaped" do + expect(section.send(:encapsulate_string, string)).to eq '\\ and outside' + end + end + + context "with a backticked string with an escape-needing character in it" do + let(:string) { 'back `\` slash' } + + it "returns the string" do + expect(section.send(:encapsulate_string, string)).to eq 'back `\` slash' + end + end + end + end +end pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy