Fix browser markdown (#548)

j-rewerts · clayreimann · commit 09384e3981de · 2019-04-16T20:54:09.000-05:00
Got the code from PR #505. Fixes #451.
diff --git a/lib/Markdown.js b/lib/Markdown.js
@@ -32,7 +32,7 @@ class Markdown extends Requestable {
     * @return {Promise} - the promise for the http request
     */
    render(options, cb) {
-      return this._request('POST', '/markdown', options, cb);
+      return this._request('POST', '/markdown', options, cb, true);
    }
 }
 
diff --git a/test/dist.spec/index.html b/test/dist.spec/index.html
@@ -12,7 +12,7 @@
   <script>mocha.setup('bdd')</script>
   <script>
      describe('the dist file', function() {
-        it('should work', function(done) {
+        it('should load a Gist', function(done) {
            var github = new GitHub();
            var gist = github.getGist('e265df71e7532f3a4bdd');
            gist.read()
@@ -21,6 +21,24 @@
                  done();
               });
         });
+
+        it('should render markdown', function(done) {
+           var shouldBe = '<p>Hello world github/linguist#1 <strong>cool</strong>, and #1!</p>\n';
+           var github = new GitHub();
+           var markdown = github.getMarkdown();
+           const options = {
+              text: 'Hello world github/linguist#1 **cool**, and #1!',
+           };
+
+           markdown.render(options)
+              .then(function({data: html}) {
+                 console.log(html);
+                 if (html !== shouldBe) {
+                    throw new Error(html + ' should be ' + shouldBe)
+                 }
+                 done();
+              }).catch(done);
+        });
      });
   </script>
   <script>

Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,7 @@ class Markdown extends Requestable {`
`32`	`32`	`* @return {Promise} - the promise for the http request`
`33`	`33`	`*/`
`34`	`34`	`render(options, cb) {`
`35`		`- return this._request('POST', '/markdown', options, cb);`
	`35`	`+ return this._request('POST', '/markdown', options, cb, true);`
`36`	`36`	`}`
`37`	`37`	`}`
`38`	`38`