Skip to content

Commit 7e231a4

Browse files
committed
Merge branch 'patch-1' of https://github.com/boppreh/GitPython into boppreh-patch-1
Adjusted patch to only run git command in shell mode on windows. Conflicts: git/cmd.py
2 parents a40d848 + 3f277ba commit 7e231a4

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

git/cmd.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@ def dashify(string):
2929

3030

3131
class Git(LazyMixin):
32-
3332
"""
3433
The Git class manages communication with the Git binary.
3534
@@ -348,6 +347,9 @@ def execute(self, command,
348347
stdin=istream,
349348
stderr=PIPE,
350349
stdout=PIPE,
350+
# Prevent cmd prompt popups on windows by using a shell ... .
351+
# See https://github.com/gitpython-developers/GitPython/pull/126
352+
shell=sys.platform == 'win32',
351353
close_fds=(os.name == 'posix'), # unsupported on linux
352354
**subprocess_kwargs
353355
)

0 commit comments

Comments
 (0)
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy