Merge pull request gitpython-developers#150 from derenio/0.3

Byron · Byron · commit 9c5b87bcdd70 · 2014-11-14T15:23:53.000+01:00
Merged fd leaks fix from the master to the 0.3 version
diff --git a/git/cmd.py b/git/cmd.py
@@ -74,6 +74,9 @@ def __init__(self, proc, args ):
             self.args = args
             
         def __del__(self):
+            self.proc.stdout.close()
+            self.proc.stderr.close()
+
             # did the process finish already so we have a return code ?
             if self.proc.poll() is not None:
                 return
@@ -85,6 +88,8 @@ def __del__(self):
             # try to kill it
             try:
                 os.kill(self.proc.pid, 2)   # interrupt signal
+            except OSError:
+                pass # ignore error when process already died
             except AttributeError:
                 # try windows 
                 # for some reason, providing None for stdout/stderr still prints something. This is why 
@@ -101,6 +106,8 @@ def wait(self):
             
             :raise GitCommandError: if the return status is not 0"""
             status = self.proc.wait()
+            self.proc.stdout.close()
+            self.proc.stderr.close()
             if status != 0:
                 raise GitCommandError(self.args, status, self.proc.stderr.read())
             # END status handling 
