client: reuse group instead of diy'ing it

schmichael · schmichael · commit 0efa2d24e43a · 2018-11-26T12:52:31.000-08:00
diff --git a/client/client.go b/client/client.go
@@ -575,15 +575,11 @@ func (c *Client) Shutdown() error {
 		}
 	} else {
 		// In normal mode call shutdown
-		wg := sync.WaitGroup{}
+		arGroup := group{}
 		for _, ar := range c.getAllocRunners() {
-			wg.Add(1)
-			go func(ar AllocRunner) {
-				ar.Shutdown()
-				wg.Done()
-			}(ar)
+			arGroup.Go(ar.Shutdown)
 		}
-		wg.Wait()
+		arGroup.Wait()
 	}
 
 	c.shutdown = true

Original file line number	Diff line number	Diff line change
`@@ -575,15 +575,11 @@ func (c *Client) Shutdown() error {`
`575`	`575`	`}`
`576`	`576`	`} else {`
`577`	`577`	`// In normal mode call shutdown`
`578`		`- wg := sync.WaitGroup{}`
	`578`	`+ arGroup := group{}`
`579`	`579`	`for _, ar := range c.getAllocRunners() {`
`580`		`- wg.Add(1)`
`581`		`- go func(ar AllocRunner) {`
`582`		`- ar.Shutdown()`
`583`		`- wg.Done()`
`584`		`- }(ar)`
	`580`	`+ arGroup.Go(ar.Shutdown)`
`585`	`581`	`}`
`586`		`- wg.Wait()`
	`582`	`+ arGroup.Wait()`
`587`	`583`	`}`
`588`	`584`
`589`	`585`	`c.shutdown = true`