bug symfony#5000 Fixed case where service definition is actually an alias (Xavier Coureau)

weaverryan · weaverryan · commit f9901d5eb1e9 · 2015-03-02T11:44:42.000-05:00
This PR was merged into the 2.3 branch. Discussion ---------- Fixed case where service definition is actually an alias If `acme_mailer.transport_chain` service would be an alias, the `hasDefinition` method would return `false` and would fake the expected result. Same for the further call on `getDefinition` method. Commits ------- c9caef6 Fixed case where definition service is an alias
diff --git a/components/dependency_injection/tags.rst b/components/dependency_injection/tags.rst
@@ -133,11 +133,11 @@ custom tag::
     {
         public function process(ContainerBuilder $container)
         {
-            if (!$container->hasDefinition('acme_mailer.transport_chain')) {
+            if (!$container->has('acme_mailer.transport_chain')) {
                 return;
             }
 
-            $definition = $container->getDefinition(
+            $definition = $container->findDefinition(
                 'acme_mailer.transport_chain'
             );
 

Original file line number	Diff line number	Diff line change
`@@ -133,11 +133,11 @@ custom tag::`
`133`	`133`	`{`
`134`	`134`	`public function process(ContainerBuilder $container)`
`135`	`135`	`{`
`136`		`- if (!$container->hasDefinition('acme_mailer.transport_chain')) {`
	`136`	`+ if (!$container->has('acme_mailer.transport_chain')) {`
`137`	`137`	`return;`
`138`	`138`	`}`
`139`	`139`
`140`		`- $definition = $container->getDefinition(`
	`140`	`+ $definition = $container->findDefinition(`
`141`	`141`	`'acme_mailer.transport_chain'`
`142`	`142`	`);`
`143`	`143`