Deprecate Diffable.rename for .renamed_file

Byron · Byron · commit 4bcc4d55baef · 2016-05-19T12:43:19.000+02:00
Fixes #426
diff --git a/git/diff.py b/git/diff.py
@@ -333,7 +333,16 @@ def __str__(self):
 
     @property
     def renamed(self):
-        """:returns: True if the blob of our diff has been renamed"""
+        """:returns: True if the blob of our diff has been renamed
+        :note: This property is deprecated, please use ``renamed_file`` instead.
+        """
+        return self.renamed_file
+        
+    @property
+    def renamed_file(self):
+        """:returns: True if the blob of our diff has been renamed
+        :note: This property is deprecated, please use ``renamed_file`` instead.
+        """
         return self.rename_from != self.rename_to
 
     @classmethod
diff --git a/git/test/test_diff.py b/git/test/test_diff.py
@@ -86,6 +86,7 @@ def test_diff_with_rename(self):
         assert_equal(1, len(diffs))
 
         diff = diffs[0]
+        assert_true(diff.renamed_file)
         assert_true(diff.renamed)
         assert_equal(diff.rename_from, u'Jérôme')
         assert_equal(diff.rename_to, u'müller')
@@ -95,6 +96,7 @@ def test_diff_with_rename(self):
         diffs = Diff._index_from_raw_format(self.rorepo, output.stdout)
         assert len(diffs) == 1
         diff = diffs[0]
+        assert diff.renamed_file
         assert diff.renamed
         assert diff.rename_from == 'this'
         assert diff.rename_to == 'that'
