Let close_fds be True on all platforms

EliahKagan · EliahKagan · commit 78d63d9ecf4c · 2023-12-01T02:53:51.000-05:00
Since Python 3.7, subprocess.Popen supports close_fds=True on all platforms, including Windows, and it is the default, including when arguments for standard streams have non-None values passed. 3.7 is the lowest version of Python that GitPython supports. So this omits the close_fds=True argument from the calls where it was present. This has the same effect (in 3.7 and higher) as passing close_fds=True. When the the close_fd argument was added to the Popen call in git.cmd.Git.execute in 1ee2afb, Python 2 was still supported. In Python 2, close_fds defaulted to False. This appears to be the reason it had been passed explicitly. It was conditioned on being on a Unix-like system because having it True on Windows would prevent stdin, stdout, or stderr redirection.
diff --git a/git/cmd.py b/git/cmd.py
@@ -1001,7 +1001,6 @@ def execute(
                     stderr=PIPE,
                     stdout=stdout_sink,
                     shell=shell,
-                    close_fds=(os.name == "posix"),  # Unsupported on Windows.
                     universal_newlines=universal_newlines,
                     creationflags=PROC_CREATIONFLAGS,
                     **subprocess_kwargs,
diff --git a/git/index/fun.py b/git/index/fun.py
@@ -102,7 +102,6 @@ def run_commit_hook(name: str, index: "IndexFile", *args: str) -> None:
             stdout=subprocess.PIPE,
             stderr=subprocess.PIPE,
             cwd=index.repo.working_dir,
-            close_fds=(os.name == "posix"),
             creationflags=PROC_CREATIONFLAGS,
         )
     except Exception as ex:

Original file line number	Diff line number	Diff line change
`@@ -102,7 +102,6 @@ def run_commit_hook(name: str, index: "IndexFile", *args: str) -> None:`
`102`	`102`	`stdout=subprocess.PIPE,`
`103`	`103`	`stderr=subprocess.PIPE,`
`104`	`104`	`cwd=index.repo.working_dir,`
`105`		`- close_fds=(os.name == "posix"),`
`106`	`105`	`creationflags=PROC_CREATIONFLAGS,`
`107`	`106`	`)`
`108`	`107`	`except Exception as ex:`