Remove flake8 linting in favor of black formatting

Byron · Byron · commit a7c5d887e943 · 2022-05-18T07:52:20.000+08:00
`flake8` seems to dislike the formatting of black.
diff --git a/.flake8 b/.flake8
diff --git a/.github/workflows/pythonpackage.yml b/.github/workflows/pythonpackage.yml
@@ -44,10 +44,10 @@ jobs:
         # and cause subsequent tests to fail
         cat test/fixtures/.gitconfig >> ~/.gitconfig
 
-    - name: Lint with flake8
+    - name: Lint with Black
       run: |
         set -x
-        flake8
+        black --check .
 
     - name: Check types with mypy
       # With new versions of pypi new issues might arise. This is a problem if there is nobody able to fix them,
diff --git a/README.md b/README.md
@@ -107,16 +107,14 @@ with MINGW's.
 Ensure testing libraries are installed.
 In the root directory, run: `pip install -r test-requirements.txt`
 
-To lint, run: `flake8`
-
 To typecheck, run: `mypy -p git`
 
 To test, run: `pytest`
 
-Configuration for flake8 is in the ./.flake8 file.
-
 Configurations for mypy, pytest and coverage.py are in ./pyproject.toml.
 
+Run `black` for formatting.
+
 The same linting and testing will also be performed against different supported python versions
 upon submitting a pull request (or on each push if you have a fork with a "main" branch and actions enabled).
 
diff --git a/git/__init__.py b/git/__init__.py
@@ -3,7 +3,6 @@
 #
 # This module is part of GitPython and is released under
 # the BSD License: http://www.opensource.org/licenses/bsd-license.php
-# flake8: noqa
 # @PydevCodeAnalysisIgnore
 from git.exc import *  # @NoMove @IgnorePep8
 import inspect
diff --git a/git/cmd.py b/git/cmd.py
@@ -947,7 +947,7 @@ def execute(
                 )
         else:
             cmd_not_found_exception = (
-                FileNotFoundError  # NOQA # exists, flake8 unknown @UndefinedVariable
+                FileNotFoundError 
             )
         # end handle
 
diff --git a/git/compat.py b/git/compat.py
@@ -5,7 +5,6 @@
 # This module is part of GitPython and is released under
 # the BSD License: http://www.opensource.org/licenses/bsd-license.php
 """utilities to help provide compatibility with python 3"""
-# flake8: noqa
 
 import locale
 import os
diff --git a/git/index/__init__.py b/git/index/__init__.py
@@ -1,4 +1,3 @@
 """Initialize the index package"""
-# flake8: noqa
 from .base import *
 from .typ import *
diff --git a/git/objects/__init__.py b/git/objects/__init__.py
@@ -1,7 +1,6 @@
 """
 Import all submodules main classes into the package space
 """
-# flake8: noqa
 import inspect
 
 from .base import *
diff --git a/git/refs/__init__.py b/git/refs/__init__.py
@@ -1,4 +1,3 @@
-# flake8: noqa
 # import all modules in order, fix the names they require
 from .symbolic import *
 from .reference import *
diff --git a/git/repo/__init__.py b/git/repo/__init__.py
@@ -1,3 +1,2 @@
 """Initialize the Repo package"""
-# flake8: noqa
 from .base import Repo as Repo
diff --git a/requirements-dev.txt b/requirements-dev.txt
@@ -3,13 +3,6 @@
 
 # libraries for additional local testing/linting - to be added to test-requirements.txt when all pass
 
-flake8-type-checking;python_version>="3.8"      # checks for TYPE_CHECKING only imports
-# flake8-annotations                          # checks for presence of type annotations
-# flake8-rst-docstrings                       # checks docstrings are valid RST
-# flake8-builtins                             # warns about shadowing builtin names
-# flake8-pytest-style
-
-# pytest-flake8
 pytest-icdiff
 # pytest-profiling
 
diff --git a/test-requirements.txt b/test-requirements.txt
@@ -1,10 +1,7 @@
 ddt>=1.1.1, !=1.4.3
 mypy
 
-flake8
-flake8-bugbear
-flake8-comprehensions
-flake8-typing-imports
+black
 
 virtualenv
 

Original file line number	Diff line number	Diff line change
`@@ -3,7 +3,6 @@`
`3`	`3`	`#`
`4`	`4`	`# This module is part of GitPython and is released under`
`5`	`5`	`# the BSD License: http://www.opensource.org/licenses/bsd-license.php`
`6`		`-# flake8: noqa`
`7`	`6`	`# @PydevCodeAnalysisIgnore`
`8`	`7`	`from git.exc import * # @NoMove @IgnorePep8`
`9`	`8`	`import inspect`
Original file line number	Diff line number	Diff line change
`@@ -947,7 +947,7 @@ def execute(`
`947`	`947`	`)`
`948`	`948`	`else:`
`949`	`949`	`cmd_not_found_exception = (`
`950`		`- FileNotFoundError # NOQA # exists, flake8 unknown @UndefinedVariable`
	`950`	`+ FileNotFoundError`
`951`	`951`	`)`
`952`	`952`	`# end handle`
`953`	`953`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,3 @@`
`1`		`-# flake8: noqa`
`2`	`1`	`# import all modules in order, fix the names they require`
`3`	`2`	`from .symbolic import *`
`4`	`3`	`from .reference import *`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,2 @@`
`1`	`1`	`"""Initialize the Repo package"""`
`2`		`-# flake8: noqa`
`3`	`2`	`from .base import Repo as Repo`