Skip to content

Commit b2c46f7

Browse files
authored
Merge pull request #1788 from EliahKagan/void-finalizer
In handle_process_output don't forward finalizer result
2 parents 597e1a6 + 7057b9b commit b2c46f7

File tree

1 file changed

+1
-4
lines changed

1 file changed

+1
-4
lines changed

git/cmd.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,6 @@ def handle_process_output(
111111
112112
This function returns once the finalizer returns.
113113
114-
:return: Result of finalizer
115114
:param process: :class:`subprocess.Popen` instance
116115
:param stdout_handler: f(stdout_line_string), or None
117116
:param stderr_handler: f(stderr_line_string), or None
@@ -205,9 +204,7 @@ def pump_stream(
205204
stderr_handler(error_str) # type: ignore
206205

207206
if finalizer:
208-
return finalizer(process)
209-
else:
210-
return None
207+
finalizer(process)
211208

212209

213210
def dashify(string: str) -> str:

0 commit comments

Comments
 (0)
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy