In Submodule.iter_items, don't attach second empty iterator

EliahKagan · EliahKagan · commit c3c008c4971f · 2023-12-22T04:58:54.000-05:00
This fixes the minor bug where a separate empty iterator was bound to the StopIteration exception raised as a result of returning from the generator function (#1779). This change does not cause what exceptions are raised from GitPython code in any situations, nor how many items any iterators yield.
diff --git a/git/objects/submodule/base.py b/git/objects/submodule/base.py
@@ -1401,7 +1401,7 @@ def iter_items(
             pc = repo.commit(parent_commit)  # Parent commit instance
             parser = cls._config_parser(repo, pc, read_only=True)
         except (IOError, BadName):
-            return iter([])
+            return
         # END handle empty iterator
 
         for sms in parser.sections():
