Log args in the order they are passed to Popen

EliahKagan · EliahKagan · commit c3fde7fb8dcd · 2023-10-03T10:16:10.000-04:00
This is still not including all or even most of the arguments, nor
are all the logged arguments literal (nor should either of those
things likely be changed). It is just to facilitate easier
comparison of what is logged to the Popen call in the code.
diff --git a/git/cmd.py b/git/cmd.py
@@ -979,12 +979,12 @@ def execute(
         if shell is None:
             shell = self.USE_SHELL
         log.debug(
-            "Popen(%s, cwd=%s, universal_newlines=%s, shell=%s, stdin=%s)",
+            "Popen(%s, cwd=%s, stdin=%s, shell=%s, universal_newlines=%s)",
             redacted_command,
             cwd,
-            universal_newlines,
-            shell,
             istream_ok,
+            shell,
+            universal_newlines,
         )
         try:
             with maybe_patch_caller_env:
