fix(refs): handle quoted branch names

Byron · Byron · commit f21630bcf83c · 2016-12-08T16:01:35.000+01:00
Fixes #550
diff --git a/git/refs/head.py b/git/refs/head.py
@@ -8,6 +8,12 @@
 __all__ = ["HEAD", "Head"]
 
 
+def strip_quotes(string):
+    if string.startswith('"') and string.endswith('"'):
+        return string[1:-1]
+    return string
+    
+
 class HEAD(SymbolicReference):
 
     """Special case of a Symbolic Reference as it represents the repository's
@@ -152,7 +158,7 @@ def tracking_branch(self):
         from .remote import RemoteReference
         reader = self.config_reader()
         if reader.has_option(self.k_config_remote) and reader.has_option(self.k_config_remote_ref):
-            ref = Head(self.repo, Head.to_full_path(reader.get_value(self.k_config_remote_ref)))
+            ref = Head(self.repo, Head.to_full_path(strip_quotes(reader.get_value(self.k_config_remote_ref))))
             remote_refpath = RemoteReference.to_full_path(join_path(reader.get_value(self.k_config_remote), ref.name))
             return RemoteReference(self.repo, remote_refpath)
         # END handle have tracking branch
diff --git a/git/test/test_refs.py b/git/test/test_refs.py
@@ -119,6 +119,18 @@ def test_heads(self, rwrepo):
             assert head.tracking_branch() == remote_ref
             head.set_tracking_branch(None)
             assert head.tracking_branch() is None
+            
+            
+            special_name = 'feature#123'
+            special_name_remote_ref = SymbolicReference.create(rwrepo, 'refs/remotes/origin/%s' % special_name)
+            gp_tracking_branch = rwrepo.create_head('gp_tracking#123')
+            special_name_remote_ref = rwrepo.remotes[0].refs[special_name]  # get correct type
+            gp_tracking_branch.set_tracking_branch(special_name_remote_ref)
+            assert gp_tracking_branch.tracking_branch().path == special_name_remote_ref.path
+            
+            git_tracking_branch = rwrepo.create_head('git_tracking#123')
+            rwrepo.git.branch('-u', special_name_remote_ref.name, git_tracking_branch.name)
+            assert git_tracking_branch.tracking_branch().name == special_name_remote_ref.name
         # END for each head
 
         # verify REFLOG gets altered
