Put all regex patterns in r-strings

EliahKagan · EliahKagan · commit ffcbf07e7c87 · 2023-10-21T23:49:39.000-04:00
This improves consistency, because most were already. For a few it
allows backslashes to removed, improving readability. Even for the
others, some editors will highlight them as regular expressions now
that they are raw string literals.
diff --git a/git/cmd.py b/git/cmd.py
@@ -264,7 +264,7 @@ class Git(LazyMixin):
 
     _excluded_ = ("cat_file_all", "cat_file_header", "_version_info")
 
-    re_unsafe_protocol = re.compile("(.+)::.+")
+    re_unsafe_protocol = re.compile(r"(.+)::.+")
 
     def __getstate__(self) -> Dict[str, Any]:
         return slots_to_dict(self, exclude=self._excluded_)
diff --git a/git/diff.py b/git/diff.py
@@ -53,7 +53,7 @@
 # Special object to compare against the empty tree in diffs
 NULL_TREE = object()
 
-_octal_byte_re = re.compile(b"\\\\([0-9]{3})")
+_octal_byte_re = re.compile(rb"\\([0-9]{3})")
 
 
 def _octal_repl(matchobj: Match) -> bytes:
diff --git a/git/refs/log.py b/git/refs/log.py
@@ -41,7 +41,7 @@ class RefLogEntry(Tuple[str, str, Actor, Tuple[int, int], str]):
 
     """Named tuple allowing easy access to the revlog data fields"""
 
-    _re_hexsha_only = re.compile("^[0-9A-Fa-f]{40}$")
+    _re_hexsha_only = re.compile(r"^[0-9A-Fa-f]{40}$")
     __slots__ = ()
 
     def __repr__(self) -> str:
diff --git a/git/repo/base.py b/git/repo/base.py
@@ -131,8 +131,8 @@ class Repo(object):
 
     # precompiled regex
     re_whitespace = re.compile(r"\s+")
-    re_hexsha_only = re.compile("^[0-9A-Fa-f]{40}$")
-    re_hexsha_shortened = re.compile("^[0-9A-Fa-f]{4,40}$")
+    re_hexsha_only = re.compile(r"^[0-9A-Fa-f]{40}$")
+    re_hexsha_shortened = re.compile(r"^[0-9A-Fa-f]{4,40}$")
     re_envvars = re.compile(r"(\$(\{\s?)?[a-zA-Z_]\w*(\}\s?)?|%\s?[a-zA-Z_]\w*\s?%)")
     re_author_committer_start = re.compile(r"^(author|committer)")
     re_tab_full_line = re.compile(r"^\t(.*)$")
diff --git a/test/test_exc.py b/test/test_exc.py
@@ -102,7 +102,7 @@ def test_CommandError_unicode(self, case):
 
             if subs is not None:
                 # Substrings (must) already contain opening `'`.
-                subs = "(?<!')%s(?!')" % re.escape(subs)
+                subs = r"(?<!')%s(?!')" % re.escape(subs)
                 self.assertRegex(s, subs)
 
         if not stream:
