Skip to content

Configparser does not respect order of config files with includes #627

@DanielSiepmann

Description

@DanielSiepmann

When you have an include statement in the user .gitconfig there content will take precedence over the local .git/config of the repository.

E.g. the following code:
entry = repo.config_reader().get_value('gitlab', 'url')

With the following config setup:

~/.gitconfig:

[include]
    path = ~/.gitconfig-local
[gitlab]
    url = url1

~/.gitconfig-local:

[gitlab]
    url = url2

.git/config:

[gitlab]
    url = url3

Will return url2 I would expect to receive url3 instead as local config should take precedence as the include was in a more global config.

Looks like the issue resides inside the read function e.g.

files_to_read.append(include_path)
will just add the includes to the list, which is just wrong, as they should be read instantly to overwrite just the already known configs.

As the function is just to big, I'm not able to provide a fix.

Versions in use:

>>> import git; git.__version__
'2.1.3'
python --version
Python 2.7.13

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      pFad - Phonifier reborn

      Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

      Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


      Alternative Proxies:

      Alternative Proxy

      pFad Proxy

      pFad v3 Proxy

      pFad v4 Proxy