plumbing: format/gitattributes, close file in ReadAttributesFile

prskr · prskr · commit 798d9942c362 · 2024-02-05T10:28:25.000+01:00
Fixes #1017
diff --git a/plumbing/format/gitattributes/attributes.go b/plumbing/format/gitattributes/attributes.go
@@ -1,6 +1,7 @@
 package gitattributes
 
 import (
+	"bufio"
 	"errors"
 	"io"
 	"strings"
@@ -88,13 +89,10 @@ func (a attribute) String() string {
 
 // ReadAttributes reads patterns and attributes from the gitattributes format.
 func ReadAttributes(r io.Reader, domain []string, allowMacro bool) (attributes []MatchAttribute, err error) {
-	data, err := io.ReadAll(r)
-	if err != nil {
-		return nil, err
-	}
+	scanner := bufio.NewScanner(r)
 
-	for _, line := range strings.Split(string(data), eol) {
-		attribute, err := ParseAttributesLine(line, domain, allowMacro)
+	for scanner.Scan() {
+		attribute, err := ParseAttributesLine(scanner.Text(), domain, allowMacro)
 		if err != nil {
 			return attributes, err
 		}
@@ -105,6 +103,10 @@ func ReadAttributes(r io.Reader, domain []string, allowMacro bool) (attributes [
 		attributes = append(attributes, attribute)
 	}
 
+	if err := scanner.Err(); err != nil {
+		return attributes, err
+	}
+
 	return attributes, nil
 }
 
diff --git a/plumbing/format/gitattributes/dir.go b/plumbing/format/gitattributes/dir.go
@@ -4,6 +4,7 @@ import (
 	"os"
 
 	"github.com/go-git/go-billy/v5"
+
 	"github.com/go-git/go-git/v5/plumbing/format/config"
 	gioutil "github.com/go-git/go-git/v5/utils/ioutil"
 )
@@ -26,6 +27,8 @@ func ReadAttributesFile(fs billy.Filesystem, path []string, attributesFile strin
 		return nil, err
 	}
 
+	defer gioutil.CheckClose(f, &err)
+
 	return ReadAttributes(f, path, allowMacro)
 }
 

Original file line number	Diff line number	Diff line change
`@@ -4,6 +4,7 @@ import (`
`4`	`4`	`"os"`
`5`	`5`
`6`	`6`	`"github.com/go-git/go-billy/v5"`
	`7`	`+`
`7`	`8`	`"github.com/go-git/go-git/v5/plumbing/format/config"`
`8`	`9`	`gioutil "github.com/go-git/go-git/v5/utils/ioutil"`
`9`	`10`	`)`
`@@ -26,6 +27,8 @@ func ReadAttributesFile(fs billy.Filesystem, path []string, attributesFile strin`
`26`	`27`	`return nil, err`
`27`	`28`	`}`
`28`	`29`
	`30`	`+ defer gioutil.CheckClose(f, &err)`
	`31`	`+`
`29`	`32`	`return ReadAttributes(f, path, allowMacro)`
`30`	`33`	`}`
`31`	`34`