Dump py.Objects with __str__ if possible

ncw · ncw · commit aa058f1e8f73 · 2014-11-18T10:56:29.000Z
diff --git a/ast/dump.go b/ast/dump.go
@@ -51,6 +51,8 @@ func Dump(ast Ast) string {
 			case Pos:
 			case Ast:
 				args = append(args, fmt.Sprintf("%s=%s", fname, Dump(x)))
+			case py.I__str__:
+				args = append(args, fmt.Sprintf("%s=%s", fname, x.M__str__()))
 			default:
 				args = append(args, fmt.Sprintf("%s=%v", fname, x))
 			}
diff --git a/ast/dump_test.go b/ast/dump_test.go
@@ -20,6 +20,7 @@ func TestDump(t *testing.T) {
 		{&Module{}, `Module(body=[])`},
 		{&Module{Body: []Stmt{&Pass{}}}, `Module(body=[Pass()])`},
 		{&Module{Body: []Stmt{&ExprStmt{Value: &Tuple{}}}}, `Module(body=[Expr(value=Tuple(elts=[], ctx=UnknownExprContext(0)))])`},
+		{&NameConstant{Value: py.True}, `NameConstant(value=True)`},
 	} {
 		out := Dump(test.in)
 		if out != test.out {

Original file line number	Diff line number	Diff line change
`@@ -51,6 +51,8 @@ func Dump(ast Ast) string {`
`51`	`51`	`case Pos:`
`52`	`52`	`case Ast:`
`53`	`53`	`args = append(args, fmt.Sprintf("%s=%s", fname, Dump(x)))`
	`54`	`+ case py.I__str__:`
	`55`	`+ args = append(args, fmt.Sprintf("%s=%s", fname, x.M__str__()))`
`54`	`56`	`default:`
`55`	`57`	`args = append(args, fmt.Sprintf("%s=%v", fname, x))`
`56`	`58`	`}`