feat: add untypedconst linter

leonklingele · leonklingele · commit e20c62e42076 · 2023-02-01T00:10:41.000+01:00
Implements #3478.
diff --git a/go.mod b/go.mod
@@ -49,6 +49,7 @@ require (
 	github.com/hashicorp/go-version v1.6.0
 	github.com/hexops/gotextdiff v1.0.3
 	github.com/jgautheron/goconst v1.5.1
+	github.com/jiftechnify/untypedconst v0.0.0-20211230012903-7f805b5dad89
 	github.com/jingyugao/rowserrcheck v1.1.1
 	github.com/jirfag/go-printf-func-name v0.0.0-20200119135958-7558a9eaa5af
 	github.com/julz/importas v0.1.0
diff --git a/go.sum b/go.sum
diff --git a/pkg/golinters/untypedconst.go b/pkg/golinters/untypedconst.go
@@ -0,0 +1,19 @@
+package golinters
+
+import (
+	"github.com/jiftechnify/untypedconst"
+	"golang.org/x/tools/go/analysis"
+
+	"github.com/golangci/golangci-lint/pkg/golinters/goanalysis"
+)
+
+func NewUntypedConst() *goanalysis.Linter {
+	a := untypedconst.Analyzer
+
+	return goanalysis.NewLinter(
+		a.Name,
+		a.Doc,
+		[]*analysis.Analyzer{a},
+		nil,
+	).WithLoadMode(goanalysis.LoadModeTypesInfo)
+}
diff --git a/pkg/lint/lintersdb/manager.go b/pkg/lint/lintersdb/manager.go
@@ -821,6 +821,11 @@ func (m Manager) GetAllSupportedLinterConfigs() []*linter.Config {
 			WithLoadForGoAnalysis().
 			WithURL("https://github.com/mvdan/unparam"),
 
+		linter.NewConfig(golinters.NewUntypedConst()).
+			WithSince("v1.51.0").
+			WithPresets(linter.PresetBugs).
+			WithURL("https://github.com/jiftechnify/untypedconst"),
+
 		linter.NewConfig(golinters.NewUnused(unusedCfg)).
 			WithSince("v1.20.0").
 			WithLoadForGoAnalysis().
diff --git a/test/testdata/untypedconst.go b/test/testdata/untypedconst.go
@@ -0,0 +1,62 @@
+//golangcitest:args -Euntypedconst
+package testdata
+
+type ExString string
+
+func retExString() ExString {
+	if true {
+		return ExString("hoge")
+	} else {
+		return "hoge" // want `returning untyped constant as defined type "command-line-arguments.ExString"`
+	}
+}
+
+type ExInt int
+
+func retExInt() ExInt {
+	if true {
+		return ExInt(1)
+	} else {
+		return 1 // want `returning untyped constant as defined type "command-line-arguments.ExInt"`
+	}
+}
+
+type ExFloat float64
+
+func retExFloat() ExFloat {
+	if true {
+		return ExFloat(0.5)
+	} else {
+		return 0.5 // want `returning untyped constant as defined type "command-line-arguments.ExFloat"`
+	}
+}
+
+type ExComplex complex128
+
+func retExComplex() ExComplex {
+	if true {
+		return ExComplex(1.0 + 0.5i)
+	} else {
+		return 1.0 + 0.5i // want `returning untyped constant as defined type "command-line-arguments.ExComplex"`
+	}
+}
+
+type ExRune rune
+
+func retExRune() ExRune {
+	if true {
+		return ExRune('a')
+	} else {
+		return 'a' // want `returning untyped constant as defined type "command-line-arguments.ExRune"`
+	}
+}
+
+type ExBool bool
+
+func retExBool() ExBool {
+	if true {
+		return ExBool(true)
+	} else {
+		return true // want `returning untyped constant as defined type "command-line-arguments.ExBool"`
+	}
+}
