From 789b8ca53b2e3478139a01ae1837a810b145968c Mon Sep 17 00:00:00 2001
From: Patrick Strawderman <pstrawderman@netflix.com>
Date: Fri, 10 Nov 2023 11:50:39 -0800
Subject: [PATCH 1/2] Lazily initialize Executor in ScheduledDataLoaderRegistry
 builder

Calling ScheduledDataLoaderRegistry.newScheduledRegistry would create a new
ScheduledExecutorService on every call, regardless of whether a custom one
was supplied. Move creation of the default ScheduledExecutorService from the
builder field to the build method to avoid the issue.
---
 .../dataloader/registries/ScheduledDataLoaderRegistry.java   | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/src/main/java/org/dataloader/registries/ScheduledDataLoaderRegistry.java b/src/main/java/org/dataloader/registries/ScheduledDataLoaderRegistry.java
index fada66d..28b13e0 100644
--- a/src/main/java/org/dataloader/registries/ScheduledDataLoaderRegistry.java
+++ b/src/main/java/org/dataloader/registries/ScheduledDataLoaderRegistry.java
@@ -257,7 +257,7 @@ public static class Builder {
         private final Map<String, DataLoader<?, ?>> dataLoaders = new LinkedHashMap<>();
         private final Map<DataLoader<?, ?>, DispatchPredicate> dataLoaderPredicates = new LinkedHashMap<>();
         private DispatchPredicate dispatchPredicate = DispatchPredicate.DISPATCH_ALWAYS;
-        private ScheduledExecutorService scheduledExecutorService = Executors.newSingleThreadScheduledExecutor();
+        private ScheduledExecutorService scheduledExecutorService;
         private Duration schedule = Duration.ofMillis(10);
         private boolean tickerMode = false;
 
@@ -348,6 +348,9 @@ public Builder tickerMode(boolean tickerMode) {
          * @return the newly built {@link ScheduledDataLoaderRegistry}
          */
         public ScheduledDataLoaderRegistry build() {
+            if (scheduledExecutorService == null) {
+                scheduledExecutorService = Executors.newSingleThreadScheduledExecutor();
+            }
             return new ScheduledDataLoaderRegistry(this);
         }
     }

From 6b20182f4d2eb4e52b82949604a7a03cd48e60d4 Mon Sep 17 00:00:00 2001
From: Patrick Strawderman <pstrawderman@netflix.com>
Date: Fri, 10 Nov 2023 12:11:57 -0800
Subject: [PATCH 2/2] Avoid allocations in DataLoaderHelper.dispatch when
 there's no work

Bail out early in DataLoaderHelper.dispatch when loaderQueue is empty to avoid
unnecessary allocations; additionally, when there is work, size the allocated
Lists precisely based on the loaderQueue size.
---
 .../java/org/dataloader/DataLoaderHelper.java | 30 ++++++++++++++-----
 1 file changed, 23 insertions(+), 7 deletions(-)

diff --git a/src/main/java/org/dataloader/DataLoaderHelper.java b/src/main/java/org/dataloader/DataLoaderHelper.java
index 67db4e2..066214c 100644
--- a/src/main/java/org/dataloader/DataLoaderHelper.java
+++ b/src/main/java/org/dataloader/DataLoaderHelper.java
@@ -162,12 +162,21 @@ Object getCacheKeyWithContext(K key, Object context) {
 
     DispatchResult<V> dispatch() {
         boolean batchingEnabled = loaderOptions.batchingEnabled();
-        //
-        // we copy the pre-loaded set of futures ready for dispatch
-        final List<K> keys = new ArrayList<>();
-        final List<Object> callContexts = new ArrayList<>();
-        final List<CompletableFuture<V>> queuedFutures = new ArrayList<>();
+        final List<K> keys;
+        final List<Object> callContexts;
+        final List<CompletableFuture<V>> queuedFutures;
         synchronized (dataLoader) {
+            int queueSize = loaderQueue.size();
+            if (queueSize == 0) {
+                lastDispatchTime.set(now());
+                return emptyDispatchResult();
+            }
+
+            // we copy the pre-loaded set of futures ready for dispatch
+            keys = new ArrayList<>(queueSize);
+            callContexts = new ArrayList<>(queueSize);
+            queuedFutures = new ArrayList<>(queueSize);
+
             loaderQueue.forEach(entry -> {
                 keys.add(entry.getKey());
                 queuedFutures.add(entry.getValue());
@@ -176,8 +185,8 @@ DispatchResult<V> dispatch() {
             loaderQueue.clear();
             lastDispatchTime.set(now());
         }
-        if (!batchingEnabled || keys.isEmpty()) {
-            return new DispatchResult<>(completedFuture(emptyList()), 0);
+        if (!batchingEnabled) {
+            return emptyDispatchResult();
         }
         final int totalEntriesHandled = keys.size();
         //
@@ -524,4 +533,11 @@ private CompletableFuture<List<V>> setToValueCache(List<V> assembledValues, List
         }
         return CompletableFuture.completedFuture(assembledValues);
     }
+
+    private static final DispatchResult<?> EMPTY_DISPATCH_RESULT = new DispatchResult<>(completedFuture(emptyList()), 0);
+
+    @SuppressWarnings("unchecked") // Casting to any type is safe since the underlying list is empty
+    private static <T> DispatchResult<T> emptyDispatchResult() {
+        return (DispatchResult<T>) EMPTY_DISPATCH_RESULT;
+    }
 }

<!DOCTYPE html PUBLIC '-//W3C//DTD XHTML 1.0 Transitional//EN' 'http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd'>
<html xmlns='http://www.w3.org/1999/xhtml'>
<head>
<title>pFad - Phonifier reborn</title>
<meta http-equiv='Content-Type' content='text/html; charset=utf-8' />
</head>
<body>
<h1>Pfad - The Proxy pFad of &#169; 2024 Garber Painting. All rights reserved.</h1>


<!-- Disclaimer -->
<p>Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.</p>
<br>
<p>Alternative Proxies:</p><p><a href="http://rainy.clevelandohioweatherforecast.com/php-proxy/index.php?q=https://github.com/graphql-java/java-dataloader/compare/v3.2.1...v3.2.2.patch" target="_blank">Alternative Proxy</a></p><p><a href="http://rainy.clevelandohioweatherforecast.com/pFad/index.php?u=https://github.com/graphql-java/java-dataloader/compare/v3.2.1...v3.2.2.patch" target="_blank">pFad Proxy</a></p><p><a href="http://rainy.clevelandohioweatherforecast.com/pFad/v3index.php?u=https://github.com/graphql-java/java-dataloader/compare/v3.2.1...v3.2.2.patch" target="_blank">pFad v3 Proxy</a></p><p><a href="http://rainy.clevelandohioweatherforecast.com/pFad/v4index.php?u=https://github.com/graphql-java/java-dataloader/compare/v3.2.1...v3.2.2.patch" target="_blank">pFad v4 Proxy</a></p></body>
</html>