-
-
Notifications
You must be signed in to change notification settings - Fork 43
added in fourth item in feature box and adjusted mobile responsiveness #41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Copy is duplicated between this and the first item. You can revert the copy for the first item to what it used to be to rectify that. |
Ah. Just noticed now. Re: first item's old copy Looking at the overall picture now, I can see why the 'Easy to Learn' feature item may have been omitted. Let me know if this is still a worthwhile effort. Otherwise, I can pick up on an official 'help wanted' issue. |
@chanonroy Yep, that copy. Title too. I think they're different enough to have both. |
@@ -66,6 +66,7 @@ body { | |||
} | |||
.subheading + .paragraph { | |||
margin-top: 10px; | |||
padding: 0 30px 0 30px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(optional) - makes padding for text copy look similar to the mockup
@chanonroy It seems like the latest changes updated the existing copy to the old stuff, but didn't add the new section to replace the lost copy? |
@contra - it didn't carry over from the first Pull Request commit? On my fork the new section with lost copy is still there. Did it have to do with the way that the last commit updated the Pull Request? |
Hmm. It should not look like that. Checking now. |
@contra - is this using the updated main.css? I copied the old stylesheet in and it looks funky like yours. The updated stylesheet from the commits achieve a look similar to the first photo I posted. |
@chanonroy I merged your whole PR so all the changes in here were deployed. |
Worse comes to worse, we can always revert it to the original with 3 feature boxes. This might be a lot of effort for very minimal changes. |
@chanonroy Reverted it while you work it out - send a new PR when ready. |
Looking to contribute more, holla if you need more help