Skip to content

Commit eb860c0

Browse files
committed
fix weird error in integration tests
somehow the variable "$i" gets overwritten in integration-testing/multi-nodejs-test/test.sh:20, which is why we now rename it to a more meaningful variable
1 parent b6d3de7 commit eb860c0

File tree

1 file changed

+8
-6
lines changed
  • integration-testing/multi-nodejs-test

1 file changed

+8
-6
lines changed

integration-testing/multi-nodejs-test/test.sh

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -12,18 +12,20 @@ cd "$( dirname "$( readlink -f "$0" )" )" || exit 1
1212
# However, the built distribution should work with older NodeJS versions as well.
1313
# This test is simple by design. It merely ensures, that calling Handlebars does not fail with old versions.
1414
# It does (almost) not test for correctness, because that is already done in the mocha-tests.
15-
# And it does not use any NodeJS based testing framwork to make this part independent of the Node version.
15+
# And it does not use any NodeJS based testing framework to make this part independent of the Node version.
1616

1717
unset npm_config_prefix
1818

1919
echo "Handlebars should be able to run in various versions of NodeJS"
20-
for i in 0.10 0.12 4 5 6 7 8 9 10 11 12 13 ; do
20+
for node_version_to_test in 0.10 0.12 4 5 6 7 8 9 10 11 12 13 14 15; do
21+
2122
rm target node_modules package-lock.json -rf
2223
mkdir target
23-
nvm install "$i"
24-
nvm exec "$i" npm install
25-
nvm exec "$i" npm run test
26-
nvm exec "$i" npm run test-precompile
24+
25+
nvm install "$node_version_to_test"
26+
nvm exec "$node_version_to_test" npm install
27+
nvm exec "$node_version_to_test" npm run test
28+
nvm exec "$node_version_to_test" npm run test-precompile
2729

2830
echo Success
2931
done

0 commit comments

Comments
 (0)
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy