Resurrect samples/Issues/ShowRepoIssues

andreasabel · andreasabel · commit 445c8de7300b · 2023-06-23T14:53:58.000+02:00
This example wasn't ported to the new API.

Now it is, with some ugly `show`s still.
diff --git a/.github/workflows/haskell-ci.yml b/.github/workflows/haskell-ci.yml
@@ -203,7 +203,7 @@ jobs:
         run: |
           touch cabal.project
           echo "packages: $GITHUB_WORKSPACE/source/." >> cabal.project
-          if [ $((HCNUMVER >= 71000)) -ne 0 ] ; then echo "packages: $GITHUB_WORKSPACE/source/samples" >> cabal.project ; fi
+          if [ $((HCNUMVER >= 80400)) -ne 0 ] ; then echo "packages: $GITHUB_WORKSPACE/source/samples" >> cabal.project ; fi
           cat cabal.project
       - name: sdist
         run: |
@@ -223,11 +223,11 @@ jobs:
           touch cabal.project
           touch cabal.project.local
           echo "packages: ${PKGDIR_github}" >> cabal.project
-          if [ $((HCNUMVER >= 71000)) -ne 0 ] ; then echo "packages: ${PKGDIR_github_samples}" >> cabal.project ; fi
+          if [ $((HCNUMVER >= 80400)) -ne 0 ] ; then echo "packages: ${PKGDIR_github_samples}" >> cabal.project ; fi
           if [ $((HCNUMVER >= 80200)) -ne 0 ] ; then echo "package github" >> cabal.project ; fi
           if [ $((HCNUMVER >= 80200)) -ne 0 ] ; then echo "    ghc-options: -Werror=missing-methods" >> cabal.project ; fi
-          if [ $((HCNUMVER >= 80200)) -ne 0 ] ; then echo "package github-samples" >> cabal.project ; fi
-          if [ $((HCNUMVER >= 80200)) -ne 0 ] ; then echo "    ghc-options: -Werror=missing-methods" >> cabal.project ; fi
+          if [ $((HCNUMVER >= 80400)) -ne 0 ] ; then echo "package github-samples" >> cabal.project ; fi
+          if [ $((HCNUMVER >= 80400)) -ne 0 ] ; then echo "    ghc-options: -Werror=missing-methods" >> cabal.project ; fi
           cat >> cabal.project <<EOF
           constraints:  github +openssl
           constraints:  github-samples +openssl
@@ -264,8 +264,8 @@ jobs:
         run: |
           cd ${PKGDIR_github} || false
           ${CABAL} -vnormal check
-          if [ $((HCNUMVER >= 71000)) -ne 0 ] ; then cd ${PKGDIR_github_samples} || false ; fi
-          if [ $((HCNUMVER >= 71000)) -ne 0 ] ; then ${CABAL} -vnormal check ; fi
+          if [ $((HCNUMVER >= 80400)) -ne 0 ] ; then cd ${PKGDIR_github_samples} || false ; fi
+          if [ $((HCNUMVER >= 80400)) -ne 0 ] ; then ${CABAL} -vnormal check ; fi
       - name: haddock
         run: |
           if [ $((HCNUMVER >= 80600)) -ne 0 ] ; then $CABAL v2-haddock --disable-documentation --haddock-all $ARG_COMPILER --with-haddock $HADDOCK $ARG_TESTS $ARG_BENCH all ; fi
diff --git a/samples/Issues/ShowRepoIssues.hs b/samples/Issues/ShowRepoIssues.hs
@@ -1,21 +1,31 @@
-module ShowRepoIssue where
+{-# LANGUAGE OverloadedStrings #-}
 
-import qualified Github.Issues as Github
+import qualified GitHub as Github
 import Data.List (intercalate)
+import Data.Foldable (toList)
 
+main :: IO ()
 main = do
-  let limitations = [Github.OnlyClosed, Github.Mentions "mike-burns", Github.AssignedTo "jyurek"]
-  possibleIssues <- Github.issuesForRepo "thoughtbot" "paperclip" limitations
+  let filt = Github.stateClosed <> Github.optionsMentioned "mike-burns" <> Github.optionsAssignee "jyurek"
+  possibleIssues <- Github.github' $ Github.issuesForRepoR "thoughtbot" "paperclip" filt Github.FetchAll
   case possibleIssues of
-       (Left error) -> putStrLn $ "Error: " ++ show error
-       (Right issues) ->
-         putStrLn $ intercalate "\n\n" $ map formatIssue issues
+       Left err -> putStrLn $ "Error: " ++ show err
+       Right issues ->
+         putStrLn $ intercalate "\n\n" $ map formatIssue $ toList issues
 
-formatIssue issue =
-  (Github.githubOwnerLogin $ Github.issueUser issue) ++
-    " opened this issue " ++
-    (show $ Github.fromDate $ Github.issueCreatedAt issue) ++ "\n" ++
-    (Github.issueState issue) ++ " with " ++
-    (show $ Github.issueComments issue) ++ " comments" ++ "\n\n" ++
-    (Github.issueTitle issue)
+formatIssue :: Github.Issue -> String
+formatIssue issue = concat
 
+  [ show $ Github.simpleUserLogin $ Github.issueUser issue
+  , " opened this issue "
+  , show $ Github.issueCreatedAt issue
+  , ".\n"
+
+  , "It is currently "
+  , show $ Github.issueState issue
+  , " with "
+  , show $ Github.issueComments issue
+  , " comments.\n\n"
+
+  , show $ Github.issueTitle issue
+  ]
diff --git a/samples/github-samples.cabal b/samples/github-samples.cabal
@@ -18,15 +18,13 @@ tested-with:
   GHC == 8.8.4
   GHC == 8.6.5
   GHC == 8.4.4
-  GHC == 8.2.2
-  GHC == 8.0.2
-  GHC == 7.10.3
 
 library
   hs-source-dirs:   src
   ghc-options:      -Wall
   build-depends:
-    , base                   >=4.7 && <5
+    , base                   >=4.11 && <5
+        -- require base-4.11 because then (<>) is in Prelude
     , base-compat-batteries
     , github
     , text
@@ -149,6 +147,11 @@ executable github-list-team-current
 --   main-is:        ShowDeployKey.hs
 --   hs-source-dirs: Repos/DeployKeys
 
+executable github-show-repo-issues
+  import:         deps
+  main-is:        ShowRepoIssues.hs
+  hs-source-dirs: Issues
+
 executable github-show-user
   import:         deps
   main-is:        ShowUser.hs
