remove get_quadrant, bump to v0.2.0

astynax · astynax · commit 04a3445cfdc9 · 2019-07-25T12:57:19.000+03:00
diff --git a/README.md b/README.md
@@ -10,8 +10,6 @@ A SICP'ish Points implemented in Python using hexlet-pairs.
     >>> p = points.make(100, 200)
     >>> print(points.to_string(p))
     (100, 200)
-    >>> points.get_quadrant(p)
-    1
     >>> points.get_x(p)
     100
     >>> points.get_y(p)
diff --git a/pyproject.toml b/pyproject.toml
@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "hexlet-points"
-version = "0.1.0"
+version = "0.2.0"
 description = "A SICP'ish Points implemented in Python using hexlet-pairs"
 authors = ["Hexlet Team <info@hexlet.io>"]
 license = "ISC"
diff --git a/src/hexlet/points/__init__.py b/src/hexlet/points/__init__.py
@@ -4,10 +4,10 @@
 
 from hexlet import pairs
 
-__all__ = (  # noqa: WPS317
+__all__ = (   # noqa: WPS317
     'make',
     'get_x', 'get_y',
-    'to_string', 'get_quadrant',
+    'to_string',
 )
 
 
@@ -29,16 +29,3 @@ def get_y(point: pairs.Pair) -> int:
 def to_string(point: pairs.Pair) -> str:
     """Return a string representation of the point."""
     return repr((get_x(point), get_y(point)))
-
-
-def get_quadrant(point: pairs.Pair) -> int:
-    """Return a quadrant number for the point."""
-    return {
-        (True, True): 1,
-        (False, True): 2,
-        (False, False): 3,
-        (True, False): 4,
-    }[(
-        get_x(point) > 0,
-        get_y(point) > 0,
-    )]
diff --git a/test/test_points.py b/test/test_points.py
@@ -18,15 +18,3 @@ def test_to_string():
     assert points.to_string(p) == '(100, 200)', (
         'Should return a proper representation.'
     )
-
-
-def test_get_quadrant():
-    """Test to_string conversion."""
-    p1 = points.make(1, 1)
-    p2 = points.make(-1, 1)
-    p3 = points.make(-1, -1)
-    p4 = points.make(1, -1)
-    assert points.get_quadrant(p1) == 1, 'Should detect a quadrant #1.'
-    assert points.get_quadrant(p2) == 2, 'Should detect a quadrant #2.'
-    assert points.get_quadrant(p3) == 3, 'Should detect a quadrant #3.'
-    assert points.get_quadrant(p4) == 4, 'Should detect a quadrant #4.'

Original file line number	Diff line number	Diff line change
`@@ -10,8 +10,6 @@ A SICP'ish Points implemented in Python using hexlet-pairs.`
`10`	`10`	`>>> p = points.make(100, 200)`
`11`	`11`	`>>> print(points.to_string(p))`
`12`	`12`	`(100, 200)`
`13`		`- >>> points.get_quadrant(p)`
`14`		`- 1`
`15`	`13`	`>>> points.get_x(p)`
`16`	`14`	`100`
`17`	`15`	`>>> points.get_y(p)`