Unlock GIL for Consumer_close's rd_kafka_destroy()

edenhill · edenhill · commit 6cf1fa465415 · 2017-01-31T15:00:37.000+01:00
diff --git a/confluent_kafka/src/Consumer.c b/confluent_kafka/src/Consumer.c
@@ -472,19 +472,16 @@ static PyObject *Consumer_poll (Handle *self, PyObject *args,
 
 static PyObject *Consumer_close (Handle *self, PyObject *ignore) {
 	CallState cs;
-	int raise = 0;
 
 	CallState_begin(self, &cs);
 
 	rd_kafka_consumer_close(self->rk);
 
-	raise = !CallState_end(self, &cs);
-
 	rd_kafka_destroy(self->rk);
 	self->rk = NULL;
 
-	if (raise)
-		return NULL;
+        if (!CallState_end(self, &cs))
+                return NULL;
 
 	Py_RETURN_NONE;
 }
