Fix test case exception handling

hrchu · Ryan P · commit c5eb7bf43b3d · 2019-07-26T07:30:11.000-04:00
Let tests fail if the expected exception not thrown.
diff --git a/tests/test_Consumer.py b/tests/test_Consumer.py
@@ -10,10 +10,9 @@ def test_basic_api():
     """ Basic API tests, these wont really do anything since there is no
         broker configured. """
 
-    try:
+    with pytest.raises(TypeError) as ex:
         kc = Consumer()
-    except TypeError as e:
-        assert str(e) == "expected configuration dict"
+    assert ex.match('expected configuration dict')
 
     def dummy_commit_cb(err, partitions):
         pass
diff --git a/tests/test_Producer.py b/tests/test_Producer.py
@@ -14,10 +14,9 @@ def test_basic_api():
     """ Basic API tests, these wont really do anything since there is no
         broker configured. """
 
-    try:
+    with pytest.raises(TypeError) as ex:
         p = Producer()
-    except TypeError as e:
-        assert str(e) == "expected configuration dict"
+    assert ex.match('expected configuration dict')
 
     p = Producer({'socket.timeout.ms': 10,
                   'error_cb': error_cb,
@@ -136,10 +135,8 @@ def produce_hi(self):
     assert type(sp) == SubProducer
 
     # Invalid config should fail
-    try:
+    with pytest.raises(KafkaException):
         sp = SubProducer({'should.fail': False}, 'mytopic')
-    except KafkaException:
-        pass
 
     sp = SubProducer({'log.thread.name': True}, 'mytopic')
     sp.produce('someother', value='not hello')
