All joinString operation test cases pass

iKnowJavaScript · iKnowJavaScript · commit 2dbb7d7962ad · 2019-04-10T11:45:40.000+01:00
diff --git a/operations/arithmethics/operations.js b/operations/arithmethics/operations.js
@@ -1,10 +1,10 @@
 //Addition Operation
 const twoSum = function(a, b) {
   return arguments.length < 2 || arguments.length > 3
-  ? "Input only two Numbers"
-  : typeof a === "number" && typeof b === "number"
-    ? a + b
-    : "Inputs Must be Numbers";
+    ? "Input only two Numbers"
+    : typeof a === "number" && typeof b === "number"
+      ? a + b
+      : "Inputs Must be Numbers";
 };
 
 //Adding Infinite sum of numbers
@@ -25,10 +25,10 @@ const addAll = function() {
 //Subraction Operation
 const subtract = function(a, b) {
   return arguments.length < 2 || arguments.length > 3
-  ? "Input only two Numbers"
-  : typeof a === "number" && typeof b === "number" 
-    ? a - b 
-    : "Inputs Must be Numbers";
+    ? "Input only two Numbers"
+    : typeof a === "number" && typeof b === "number" 
+      ? a - b 
+      : "Inputs Must be Numbers";
 };
 
 //Multiplication Operation
@@ -49,15 +49,19 @@ const multiply = function() {
 //Division Operation
 const divide = function(a, b) {
   return arguments.length < 2 || arguments.length > 3
-  ? "Input only two Numbers"
-  : typeof a === "number" && typeof b === "number" 
-    ? a / b 
-    : "Inputs Must be Numbers";
+    ? "Input only two Numbers"
+    : typeof a === "number" && typeof b === "number" 
+      ? a / b 
+      : "Inputs Must be Numbers";
 };
 
 //String Concatenation Operation
 const joinString = function(a, b) {
-  return typeof a === "string" && typeof b === "string" ? a.concat(b) : false;
+  return arguments.length < 2 || arguments.length > 3
+    ? "Input only two String"
+    : typeof a === "string" && typeof b === "string" 
+      ? a.concat(b) 
+      : "Inputs Must be String";
 };
 
 module.exports = { twoSum, addAll, subtract, multiply, divide, joinString };
diff --git a/operations/arithmethics/operations.test.js b/operations/arithmethics/operations.test.js
@@ -111,6 +111,12 @@ describe("Testing String Concatenation implementation", () => {
     expect(joinString("Good", "Job")).toBe("GoodJob");
   });
   it("Parameter should only be String", () => {
-    expect(joinString("Well", 4)).toBeFalsy();
+    expect(joinString("Well", 4)).toMatch(/Must be String/);
+  });
+  it("Parameter should at least be two", () => {
+    expect(joinString("Well")).toMatch(/only two String/);
+  });
+  it("Parameter should not be more than two", () => {
+    expect(joinString("Good", "Job", "Well", "Done")).toMatch(/only two String/);
   });
 });
