Skip to content

[Composer] Bumped Symfony version to 5.3.* #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

mnocon
Copy link
Contributor

@mnocon mnocon commented Jun 15, 2021

Question Answer
JIRA issue n/a
Type n/a
Target Ibexa version v3.3 and 4.0
BC breaks no
Doc needed no

Bumped the Symfony version used to the recently released 5.3.

I had to add the symfony/runtime requirement (it's also present in https://github.com/symfony/website-skeleton/blob/5.3/composer.json#L30).

There are other differences between these two skeletons:

  1. sensio/framework-extra-bundle is using different major: https://github.com/symfony/website-skeleton/blob/5.3/composer.json#L30 (we have `"sensio/framework-extra-bundle": "^5.6.1")
  2. We still have "doctrine/doctrine-bundle": "~2.3.2" - added in IBX-460: Locked doctrine/doctrine-bundle to 2.3.x to avoid issues #3 , not sure if it's still needed.

Currently this PR fails to install with:

!!  In CheckExceptionOnInvalidReferenceBehaviorPass.php line 86:
!!
!!    The service "ezpublish_rest.security.authentication.listener.session.ezpubl
!!    ish_front" has a dependency on a non-existent service "session.storage". Di
!!    d you mean this: "session.storage.factory.native"?

which seems related to symfony/symfony#40048

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Checked that target branch is set correctly.
  • Asked for a review (ping @ibexa/engineering).

@mnocon mnocon force-pushed the bump-symfony-version branch from 6768643 to 7e7acad Compare June 15, 2021 11:55
@mnocon
Copy link
Contributor Author

mnocon commented Jun 29, 2021

Replaced by #5

@mnocon mnocon closed this Jun 29, 2021
@adamwojs adamwojs deleted the bump-symfony-version branch December 28, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy