Creating a database multiple times is a no-op

wwentland · wwentland · commit 4e06277b203c · 2016-06-13T16:44:36.000+02:00
Creating a database multiple times does no longer throw an error and
passing 'IF NOT EXISTS' to CREATE DATABASE does nothing at the moment
and will be deprecated in 1.0.
diff --git a/influxdb/client.py b/influxdb/client.py
@@ -465,16 +465,13 @@ def get_list_database(self):
         """
         return list(self.query("SHOW DATABASES").get_points())
 
-    def create_database(self, dbname, if_not_exists=False):
+    def create_database(self, dbname):
         """Create a new database in InfluxDB.
 
         :param dbname: the name of the database to create
         :type dbname: str
         """
-        if if_not_exists:
-            self.query("CREATE DATABASE IF NOT EXISTS \"%s\"" % dbname)
-        else:
-            self.query("CREATE DATABASE \"%s\"" % dbname)
+        self.query("CREATE DATABASE \"%s\"" % dbname)
 
     def drop_database(self, dbname):
         """Drop a database from InfluxDB.
diff --git a/influxdb/tests/client_test.py b/influxdb/tests/client_test.py
@@ -418,19 +418,6 @@ def test_create_database(self):
                 'create database "new_db"'
             )
 
-    def test_create_database_with_exist_check(self):
-        with requests_mock.Mocker() as m:
-            m.register_uri(
-                requests_mock.GET,
-                "http://localhost:8086/query",
-                text='{"results":[{}]}'
-            )
-            self.cli.create_database('new_db', if_not_exists=True)
-            self.assertEqual(
-                m.last_request.qs['q'][0],
-                'create database if not exists "new_db"'
-            )
-
     def test_create_numeric_named_database(self):
         with requests_mock.Mocker() as m:
             m.register_uri(
diff --git a/influxdb/tests/server_tests/client_test_with_server.py b/influxdb/tests/server_tests/client_test_with_server.py
@@ -133,18 +133,6 @@ def test_create_database(self):
             [{'name': 'new_db_1'}, {'name': 'new_db_2'}]
         )
 
-    def test_create_database_twice_if_not_exist(self):
-        self.assertIsNone(self.cli.create_database('new_db'))
-        self.assertIsNone(
-            self.cli.create_database('new_db', if_not_exists=True))
-
-    def test_create_database_twice_fails(self):
-        self.assertIsNone(self.cli.create_database('new_db'))
-        with self.assertRaises(InfluxDBClientError) as ctx:
-            self.cli.create_database('new_db')
-        self.assertEqual('database already exists',
-                         ctx.exception.content)
-
     def test_get_list_series_empty(self):
         rsp = self.cli.get_list_series()
         self.assertEqual([], rsp)
