Skip to content

Commit 3ebd927

Browse files
authored
runfiles: Drop outdated comments about vendoring (bazel-contrib#986)
The runfiles library now canonically lives in rules_python and has been updated multiple times since its original import from bazel_tools.
1 parent 1487a0c commit 3ebd927

File tree

2 files changed

+0
-23
lines changed

2 files changed

+0
-23
lines changed

python/runfiles/BUILD.bazel

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -12,23 +12,6 @@
1212
# See the License for the specific language governing permissions and
1313
# limitations under the License.
1414

15-
# We'd like to alias the runfiles target @bazel_tools//tools/python/runfiles.
16-
# However, we need its source file to exist in the runfiles tree under this
17-
# repo's name, so that it can be imported as
18-
#
19-
# from rules_python.python.runfiles import runfiles
20-
#
21-
# in user code. This requires either adding a symlink to runfiles or copying
22-
# the file with an action.
23-
#
24-
# Both solutions are made more difficult by the fact that runfiles.py is not
25-
# directly exported by its package. We could try to get a handle on its File
26-
# object by unpacking the runfiles target's providers, but this seems hacky
27-
# and is probably more effort than it's worth. Also, it's not trivial to copy
28-
# files in a cross-platform (i.e. Windows-friendly) way.
29-
#
30-
# So instead, we just vendor in runfiles.py here.
31-
3215
load("//python:defs.bzl", "py_library")
3316

3417
filegroup(

python/runfiles/runfiles.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -12,12 +12,6 @@
1212
# See the License for the specific language governing permissions and
1313
# limitations under the License.
1414

15-
###############################################################################
16-
# Vendored in from bazelbuild/bazel (tools/python/runfiles/runfiles.py) at #
17-
# commit 6c60a8ec049b6b8540c473969dd7bd1dad46acb9 (2019-07-19). See #
18-
# //python/runfiles:BUILD for details. #
19-
###############################################################################
20-
2115
"""Runfiles lookup library for Bazel-built Python binaries and tests.
2216
2317
USAGE:

0 commit comments

Comments
 (0)
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy