Refactor: Create misc routes for token based role invites (fossasia#5578)

abhinavk96 · web-flow · commit 0128dbca3e55 · 2019-02-03T07:54:59.000+08:00
diff --git a/app/__init__.py b/app/__init__.py
@@ -126,6 +126,7 @@ def create_app():
         from app.api.uploads import upload_routes
         from app.api.users import user_misc_routes
         from app.api.orders import order_misc_routes
+        from app.api.role_invites import role_invites_misc_routes
 
         app.register_blueprint(api_v1)
         app.register_blueprint(event_copy)
@@ -138,6 +139,7 @@ def create_app():
         app.register_blueprint(user_misc_routes)
         app.register_blueprint(attendee_misc_routes)
         app.register_blueprint(order_misc_routes)
+        app.register_blueprint(role_invites_misc_routes)
 
     sa.orm.configure_mappers()
 
diff --git a/app/api/role_invites.py b/app/api/role_invites.py
@@ -17,6 +17,12 @@
 from app.models.user import User
 from app.models.users_events_role import UsersEventsRoles
 from app.settings import get_settings
+from flask import jsonify, request, Blueprint
+from app.api.helpers.errors import NotFoundError
+from sqlalchemy.orm.exc import NoResultFound
+
+
+role_invites_misc_routes = Blueprint('role_invites_misc', __name__, url_prefix='/v1')
 
 
 class RoleInviteListPost(ResourceList):
@@ -45,19 +51,10 @@ def after_create_object(self, role_invite, data, view_kwargs):
         :return:
         """
         user = User.query.filter_by(email=role_invite.email).first()
-        if 'status' in data and data['status'] == 'accepted':
-            role = Role.query.filter_by(name=role_invite.role_name).first()
-            event = Event.query.filter_by(id=role_invite.event_id).first()
-            uer = UsersEventsRoles.query.filter_by(user=user).filter_by(
-                event=event).filter_by(role=role).first()
-            if not uer:
-                uer = UsersEventsRoles(user, event, role)
-                save_to_db(uer, 'Role Invite accepted')
-
         event = Event.query.filter_by(id=role_invite.event_id).first()
         frontend_url = get_settings()['frontend_url']
-        link = "{}/events/{}/role-invites/{}" \
-            .format(frontend_url, event.id, role_invite.hash)
+        link = "{}/e/{}/role-invites?token={}" \
+            .format(frontend_url, event.identifier, role_invite.hash)
 
         send_email_role_invite(role_invite.email, role_invite.role_name, event.name, link)
         if user:
@@ -90,7 +87,7 @@ def query(self, view_kwargs):
 
     view_kwargs = True
     methods = ['GET']
-    decorators = (api.has_permission('is_organizer', fetch='event_id', fetch_as="event_id"),)
+    decorators = (api.has_permission('is_coorganizer', fetch='event_id', fetch_as="event_id"),)
     schema = RoleInviteSchema
     data_layer = {'session': db.session,
                   'model': RoleInvite,
@@ -122,23 +119,12 @@ def before_update_object(self, role_invite, data, view_kwargs):
                                                                               'status' not in data):
             raise UnprocessableEntity({'source': ''}, "You can only change your status")
 
-    def after_update_object(self, role_invite, data, view_kwargs):
-        user = User.query.filter_by(email=role_invite.email).first()
-        if 'status' in data and data['status'] == 'accepted':
-            role = Role.query.filter_by(name=role_invite.role_name).first()
-            event = Event.query.filter_by(id=role_invite.event_id).first()
-            uer = UsersEventsRoles.query.filter_by(user=user).filter_by(
-                event=event).filter_by(role=role).first()
-            if not uer:
-                uer = UsersEventsRoles(user, event, role)
-                save_to_db(uer, 'Role Invite accepted')
     decorators = (api.has_permission('is_organizer', methods="DELETE", fetch="event_id", fetch_as="event_id",
                                      model=RoleInvite),)
     schema = RoleInviteSchema
     data_layer = {'session': db.session,
                   'model': RoleInvite,
-                  'methods': {'before_update_object': before_update_object,
-                              'after_update_object': after_update_object}}
+                  'methods': {'before_update_object': before_update_object}}
 
 
 class RoleInviteRelationship(ResourceRelationship):
@@ -149,3 +135,51 @@ class RoleInviteRelationship(ResourceRelationship):
     schema = RoleInviteSchema
     data_layer = {'session': db.session,
                   'model': RoleInvite}
+
+
+@role_invites_misc_routes.route('/role_invites/accept-invite', methods=['POST'])
+def accept_invite():
+    token = request.json['data']['token']
+    try:
+        role_invite = RoleInvite.query.filter_by(hash=token).one()
+    except NoResultFound:
+        return NotFoundError({'source': ''}, 'Role Invite Not Found').respond()
+    else:
+        try:
+            user = User.query.filter_by(email=role_invite.email).first()
+        except NoResultFound:
+            return NotFoundError({'source': ''}, 'User corresponding to role invite not Found').respond()
+        try:
+            role = Role.query.filter_by(name=role_invite.role_name).first()
+        except NoResultFound:
+            return NotFoundError({'source': ''}, 'Role corresponding to role invite not Found').respond()
+        event = Event.query.filter_by(id=role_invite.event_id).first()
+        uer = UsersEventsRoles.query.filter_by(user=user).filter_by(
+            event=event).filter_by(role=role).first()
+        if not uer:
+            role_invite.status = "accepted"
+            save_to_db(role_invite, 'Role Invite Accepted')
+            uer = UsersEventsRoles(user, event, role)
+            save_to_db(uer, 'User Event Role Created')
+            if not user.is_verified:
+                user.is_verified = True
+                save_to_db(user, 'User verified')
+
+    return jsonify({
+        "email": user.email,
+        "event": role_invite.event_id,
+        "name": user.fullname if user.fullname else None
+    })
+
+
+@role_invites_misc_routes.route('/role_invites/user', methods=['POST'])
+def fetch_user():
+    token = request.json['data']['token']
+    try:
+        role_invite = RoleInvite.query.filter_by(hash=token).one()
+    except NoResultFound:
+        return NotFoundError({'source': ''}, 'Role Invite Not Found').respond()
+    else:
+        return jsonify({
+            "email": role_invite.email
+        })
