feat: Implementing is_active and timeframe checks for discount code (fossasia#5612)

uds5501 · iamareebjamal · commit a04dbc3992c9 · 2019-02-17T22:28:12.000+05:30
* Implementing is_active and timeframe checks 

- Implementing is_active and time-frame checks for discount code application
- Using `405` error code
- Using `tz-aware` datetime elements for time frame checks

* Modifying the tests to ensure code application

* Remove print stub

Co-Authored-By: uds5501 &lt;singhuddeshyaofficial@gmail.com&gt;
diff --git a/app/api/discount_codes.py b/app/api/discount_codes.py
@@ -3,7 +3,7 @@
 from sqlalchemy.orm.exc import NoResultFound
 
 from app.api.helpers.db import safe_query
-from app.api.helpers.exceptions import ConflictException, ForbiddenException, UnprocessableEntity
+from app.api.helpers.exceptions import ConflictException, ForbiddenException, UnprocessableEntity, MethodNotAllowed
 from app.api.helpers.permission_manager import has_access
 from app.api.helpers.permissions import jwt_required, current_identity
 from app.api.helpers.utilities import require_relationship
@@ -15,6 +15,8 @@
 from app.models.ticket import Ticket
 from app.models.user import User
 
+from datetime import datetime
+
 class DiscountCodeListPost(ResourceList):
     """
     Create Event and Ticket Discount code and Get Event Discount Codes
@@ -208,6 +210,13 @@ def before_get(self, args, kwargs):
             discount = db.session.query(DiscountCode).filter_by(code=kwargs.get('code'), deleted_at=None).first()
             if discount:
                 kwargs['id'] = discount.id
+                discount_tz = discount.valid_from.tzinfo
+                current_time = datetime.now().replace(tzinfo=discount_tz)
+                if not discount.is_active:
+                    raise MethodNotAllowed({'parameter': '{code}'}, "Discount Code is not active")
+                elif current_time < discount.valid_from or current_time > discount.valid_till:
+                    raise MethodNotAllowed({'parameter': '{code}'},
+                                           "Discount Code is not active in current time frame")
             else:
                 raise ObjectNotFound({'parameter': '{code}'}, "DiscountCode: not found")
 
diff --git a/app/factories/common.py b/app/factories/common.py
@@ -8,7 +8,7 @@
 url_ = 'http://example.com'
 imageUrl_ = 'https://www.w3schools.com/html/pic_mountain.jpg'
 date_ = '2016-12-13T23:59:59.123456+00:00'
-dateEnd_ = '2016-12-14T23:59:59.123456+00:00'
+dateEnd_ = '2020-12-14T23:59:59.123456+00:00'
 country_ = 'US'
 currency_ = 'USD'
 int_ = '1'
