chore: change target framework monikers from netcoreapp to net
#433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasperk81
reviewed
Dec 5, 2022
| @@ -1,7 +1,7 @@ | |||
| <Project Sdk="Microsoft.NET.Sdk"> | |||
|
|
|||
| <PropertyGroup> | |||
| <TargetFrameworks>netcoreapp3.1;netcoreapp5.0;netcoreapp6.0</TargetFrameworks> | |||
| <TargetFrameworks>netcoreapp3.1;net5.0;net6.0</TargetFrameworks> | |||
There was a problem hiding this comment.
net5.0 is not supported and netcoreapp3.1's last date is next tuesday: https://dotnet.microsoft.com/en-us/platform/support/policy/dotnet-core
maybe net6.0 and net7.0 support is enough
There was a problem hiding this comment.
We don't want to remove support for old versions yet.
There was a problem hiding this comment.
ok. i think net7.0 could be supported at the same time now that it's been released.
There was a problem hiding this comment.
You are right... I've updated the sources
vlastahajek
approved these changes
Dec 5, 2022
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #427
Proposed Changes
TargetFrameworksfromnetcoreapptonetX.Y.Checklist
dotnet testcompletes successfully