batch: convert optional maxBatchSize parameter to overload to preserve binary compatibility and set default value to 5000

cypressious · cypressious · commit db0cadf4953d · 2018-05-08T11:59:33.000+02:00
diff --git a/src/InfluxDB.Collector/Configuration/CollectorBatchConfiguration.cs b/src/InfluxDB.Collector/Configuration/CollectorBatchConfiguration.cs
@@ -4,6 +4,8 @@ namespace InfluxDB.Collector.Configuration
 {
     public abstract class CollectorBatchConfiguration
     {
-        public abstract CollectorConfiguration AtInterval(TimeSpan interval, int? maxBatchSize = null);
+        public CollectorConfiguration AtInterval(TimeSpan interval) => AtInterval(interval, 5000);
+
+        public abstract CollectorConfiguration AtInterval(TimeSpan interval, int? maxBatchSize);
     }
-}
+}
diff --git a/src/InfluxDB.Collector/Configuration/PipelinedCollectorBatchConfiguration.cs b/src/InfluxDB.Collector/Configuration/PipelinedCollectorBatchConfiguration.cs
@@ -16,7 +16,7 @@ public PipelinedCollectorBatchConfiguration(CollectorConfiguration configuration
             _configuration = configuration;
         }
 
-        public override CollectorConfiguration AtInterval(TimeSpan interval, int? maxBatchSize = null)
+        public override CollectorConfiguration AtInterval(TimeSpan interval, int? maxBatchSize)
         {
             _interval = interval;
             _maxBatchSize = maxBatchSize;
@@ -36,4 +36,4 @@ public IPointEmitter CreateEmitter(IPointEmitter parent, out Action dispose)
             return batcher;
         }
     }
-}
+}

Original file line number	Diff line number	Diff line change
`@@ -4,6 +4,8 @@ namespace InfluxDB.Collector.Configuration`
`4`	`4`	`{`
`5`	`5`	`public abstract class CollectorBatchConfiguration`
`6`	`6`	`{`
`7`		`- public abstract CollectorConfiguration AtInterval(TimeSpan interval, int? maxBatchSize = null);`
	`7`	`+ public CollectorConfiguration AtInterval(TimeSpan interval) => AtInterval(interval, 5000);`
	`8`	`+`
	`9`	`+ public abstract CollectorConfiguration AtInterval(TimeSpan interval, int? maxBatchSize);`
`8`	`10`	`}`
`9`		`-}`
	`11`	`+}`
Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,7 @@ public PipelinedCollectorBatchConfiguration(CollectorConfiguration configuration`
`16`	`16`	`_configuration = configuration;`
`17`	`17`	`}`
`18`	`18`
`19`		`- public override CollectorConfiguration AtInterval(TimeSpan interval, int? maxBatchSize = null)`
	`19`	`+ public override CollectorConfiguration AtInterval(TimeSpan interval, int? maxBatchSize)`
`20`	`20`	`{`
`21`	`21`	`_interval = interval;`
`22`	`22`	`_maxBatchSize = maxBatchSize;`
`@@ -36,4 +36,4 @@ public IPointEmitter CreateEmitter(IPointEmitter parent, out Action dispose)`
`36`	`36`	`return batcher;`
`37`	`37`	`}`
`38`	`38`	`}`
`39`		`-}`
	`39`	`+}`