This repository was archived by the owner on Oct 29, 2024. It is now read-only.
This repository was archived by the owner on Oct 29, 2024. It is now read-only.
InfluxDBClient.request discards error details when raising exception #533
Description
The InfluxDBClient.request method contains code to make a request to the influxdb server that looks like this:
while retry:
try:
response = self._session.request(...)
break
except requests.exceptions.ConnectionError as e:
_try += 1
if self._retries != 0:
retry = _try < self._retries
else:
raise requests.exceptions.ConnectionErrorThe problem is that if we fail to connect, the ConnectionError that is raised does not have any of the information about what actually failed, making it really hard to debug from the exception message.
A possibly alternative might be something like this:
while retry:
try:
response = self._session.request(...)
break
except requests.exceptions.ConnectionError as e:
_try += 1
if self._retries != 0:
retry = _try < self._retries
if not retry:
raiseThis will re-raise the exception that caused the failure, with the contextual information about what actually happened.