on_commit(): removed consumer arg

edenhill · edenhill · commit 99b774b9bcec · 2016-05-09T19:36:29.000+02:00
diff --git a/confluent_kafka/cimpl/Consumer.c b/confluent_kafka/cimpl/Consumer.c
@@ -552,7 +552,7 @@ PyTypeObject ConsumerType = {
 	"request has succeeded or failed.\n"
 	"\n"
 	"\n"
-	".. py:function:: on_commit(consumer, err, partitions)\n"
+	".. py:function:: on_commit(err, partitions)\n"
 	"\n"
 	"  :param Consumer consumer: Consumer instance.\n"
 	"  :param KafkaError err: Commit error object, or None on success.\n"
@@ -656,7 +656,7 @@ static void Consumer_offset_commit_cb (rd_kafka_t *rk, rd_kafka_resp_err_t err,
 	/* Construct list of TopicPartition based on 'c_parts' */
 	parts = c_parts_to_py(c_parts);
 
-	args = Py_BuildValue("(OOO)", self, k_err, parts);
+	args = Py_BuildValue("(OO)", k_err, parts);
 
 	Py_DECREF(k_err);
 	Py_DECREF(parts);
diff --git a/confluent_kafka/kafkatest/kafkatest_verifiable_consumer.py b/confluent_kafka/kafkatest/kafkatest_verifiable_consumer.py
@@ -105,7 +105,7 @@ def on_revoke (self, consumer, partitions):
         self.do_commit(immediate=True)
 
 
-    def on_commit (self, consumer, err, partitions):
+    def on_commit (self, err, partitions):
         """ Offsets Committed callback """
         if err is not None and err.code() == KafkaError._NO_OFFSET:
             self.dbg('on_commit(): no offsets to commit')
diff --git a/examples/integration_test.py b/examples/integration_test.py
@@ -191,7 +191,7 @@ def verify_producer_performance(with_dr_cb=True):
           (t_delivery_spent - t_produce_spent))
 
 
-def print_commit_result (consumer, err, partitions):
+def print_commit_result (err, partitions):
     if err is not None:
         print('# Failed to commit offsets: %s: %s' % (err, partitions))
     else:
diff --git a/tests/test_Consumer.py b/tests/test_Consumer.py
@@ -12,7 +12,7 @@ def test_basic_api():
     except TypeError as e:
         assert str(e) == "expected configuration dict"
 
-    def dummy_commit_cb (consumer, err, partitions):
+    def dummy_commit_cb (err, partitions):
         pass
 
     kc = Consumer({'group.id':'test', 'socket.timeout.ms':'100',
