Merge pull request SHA2017-badge#197 from SHA2017-badge/basvs-with-open-file

raboof · web-flow · commit 86d5d4994a9e · 2017-08-05T15:20:24.000-07:00
fix max open file descriptors in woezel
diff --git a/esp32/modules/woezel.py b/esp32/modules/woezel.py
@@ -193,19 +193,18 @@ def install_pkg(pkg_spec, install_path, force_reinstall):
     verf = "%s%s/version" % (install_path, pkg_spec)
     if already_installed:
         try:
-            fver = open(verf, "r")
+            with open(verf, "r") as fver:
+                old_ver = fver.read()
         except:
             print("No version file found")
         else:
-            old_ver = fver.read();
             if old_ver == latest_ver:
                 if not force_reinstall:
                     raise LatestInstalledError("Latest version installed")
             else:
                 print("Removing previous rev. %s" % old_ver)
                 for rm_file in os.listdir("%s%s" % (install_path, pkg_spec)):
                     os.remove("%s%s/%s" % (install_path, pkg_spec, rm_file))
-            fver.close()
     packages = data["releases"][latest_ver]
     del data
     gc.collect()
@@ -222,9 +221,8 @@ def install_pkg(pkg_spec, install_path, force_reinstall):
         f1.close()
     del f3
     del f2
-    fver = open(verf, "w")
-    fver.write(latest_ver)
-    fver.close()
+    with open(verf, "w") as fver:
+        fver.write(latest_ver)
     del fver
     gc.collect()
     return meta
