Skip to content

Commit d0ed482

Browse files
jpadillatomchristie
authored andcommitted
Skip HiddenField from Schema fields (encode#4429)
1 parent d540f02 commit d0ed482

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

rest_framework/schemas.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -296,8 +296,9 @@ def get_serializer_fields(self, path, method, callback, view):
296296

297297
fields = []
298298
for field in serializer.fields.values():
299-
if field.read_only:
299+
if field.read_only or isinstance(field, serializers.HiddenField):
300300
continue
301+
301302
required = field.required and method != 'PATCH'
302303
description = force_text(field.help_text) if field.help_text else ''
303304
field = coreapi.Field(

tests/test_schemas.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,8 @@ class ExamplePagination(pagination.PageNumberPagination):
2626
class ExampleSerializer(serializers.Serializer):
2727
a = serializers.CharField(required=True, help_text='A field description')
2828
b = serializers.CharField(required=False)
29+
read_only = serializers.CharField(read_only=True)
30+
hidden = serializers.HiddenField(default='hello')
2931

3032

3133
class AnotherSerializer(serializers.Serializer):

0 commit comments

Comments
 (0)
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy