On Discord we hit an API throttling

Not the same as #153 

An error occurs in production:

> Client error: `GET https://discordapp.com/api/v6/guilds/***/members?limit=200&after=***` resulted in a `429 Too Many Requests` response.

I thing that when we fetch the members of the guild we should be less agressive in the for loop.

https://github.com/jolicode/secret-santa/blob/8e2f74bd1446e95534bac11d6292ad3df615924e/src/Discord/UserExtractor.php#L42-L57

Adding a "sleep" maybe?

There is also a lot of headers to help us mitigate this issue: https://discord.com/developers/docs/topics/rate-limits


	do {
	if ((time() - $startTime) > 19) {
	throw new UserExtractionFailedException(DiscordApplication::APPLICATION_CODE, 'Took too much time to retrieve all the users on your team.');
	}

	$lastMember = $lastMembers ? end($lastMembers) : null;

	try {
	/** @var GuildMember[] $members */
	$lastMembers = $this->apiHelper->getMembersInGuild($guildId, $lastMember ? $lastMember->user->id : null);
	} catch (\Throwable $t) {
	throw new UserExtractionFailedException(DiscordApplication::APPLICATION_CODE, 'Could not fetch members in guild.', $t);
	}

	$members = array_merge($members, $lastMembers);
	} while (!empty($lastMembers));

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

On Discord we hit an API throttling #167

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

On Discord we hit an API throttling #167

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.